Commit Graph
32590 Commits
Author SHA1 Message Date
Jesse Glick f343595b43 Make sure new APIs are marked with @since. 2014-09-24 08:38:19 -04:00
Jesse Glick 42b2f22c25 Utility class, no constructor. 2014-09-24 08:36:20 -04:00
Jesse Glick c1116a765e CallableDecorator is newly added, so belongs in the package for new classes. 2014-09-24 08:14:43 -04:00
Nicolas De Loof 9b3f48853d [FIXED JENKINS-24825] define hudson.model.AbstractItem#movedTo 2014-09-24 14:03:41 +02:00
Jesse Glick e640fd4dbc BYPASS_LOG is meant to _replace_ all logging, and log what _would have been_ violations.
(It supersedes other bypass properties.)
2014-09-24 07:51:31 -04:00
Jesse Glick 9a5e8e975d BYPASS_LOG is only needed for testing, not regular operation, so it need not be settable at runtime. 2014-09-24 07:48:30 -04:00
Harald Albers 7e09c4f8ad Merge pull request #1405 from ebourg/update-jetty-documentation-url
Update the link to the Jetty documentation in realm.properties
2014-09-24 12:26:24 +02:00
Kohsuke Kawaguchi 91c516200f Reimplemented the checker as RoleChecker 2014-09-23 19:12:43 -07:00
Kohsuke Kawaguchi ffb5b65093 Switched from annotation based scheme to a function based scheme. 2014-09-23 19:12:43 -07:00
Kohsuke Kawaguchi 59456c734a Defined three remoting roles in Jenkins.
(This requires 82211d10bfc7d066121ba80c8a6755d1dae97bf2 in remoting)
2014-09-23 19:03:49 -07:00
Kohsuke Kawaguchi 1295aa9180 I prefer strongly typed named variable for controlling feature flags.
It's faster, it's typed, and failing to use the correct name results in an error, so you know when the flag gets removed.
Making it more friendly for Groovy script.
2014-09-23 14:54:50 -07:00
Kohsuke Kawaguchi 140d929516 Fixed the computation of effective FilePathFilter.
If a @SlaveToMaster Callable gets sent to the master, and if inside its call() method the code directly/indirectly performs file system access (for example on files and directories that it didn't receive as parameters), that is not meant to be the subject of the filter check.

Rather, the check is meant for FilePath that the other side sends to us, when it points to a local file.

So it makes more sense to compute the effective FilePathFilter during the deserialization, as opposed to doing so when the actual operation is attempted.

Various FileCallable impls in FilePath fits this pattern, as it drags outer FilePath instance with itself. In addition, this change addresses other situations correctly, where FilePath is used as arguments and return values of other Callables, such as the following:

FilePath f = channel.call(new SlaveWillDoSomeComputationAndGiveMeTheResultAsFile());
f.copyTo(build.getRootDir().child("data.xml"))

"f.copyTo" happens in the context of Channel.current()==null, but we need to check that 'f' is legit and not something like
new FilePath(new File("/etc/shadow"))
2014-09-23 14:53:31 -07:00
Kohsuke Kawaguchi c0260056e5 in pre-cursor for the next change, make all remoting call go through FileCallable 2014-09-23 14:53:31 -07:00
Jesse Glick 2fe5b96f55 For testing purposes, adding dry-run system properties allowing potential violations to be written to log files. 2014-09-23 16:26:27 -04:00
Kohsuke Kawaguchi d000cd65a7 [FIXED JENKINS-24453]
The actual fix is made in 040b7d4047
through winp.
2014-09-23 13:14:34 -07:00
Jesse Glick 14d33d4ba4 Demonstrating that local FilePath operations within a slave callable are unaffected by FilePathFilter.
This is because we are not installing a filter on the reverse channel.
2014-09-23 16:05:10 -04:00
Jesse Glick 47f61e55da Better toString(). 2014-09-23 15:56:45 -04:00
Jesse Glick cf36145eed Merge branch 'security' into SECURITY-144 2014-09-23 10:17:23 -04:00
Jesse Glick 23f3e0bbe6 Merge branch 'security' into security-rc
Conflicts:
	test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
	test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy
	test/src/test/groovy/hudson/model/UpdateCenter2Test.groovy
	test/src/test/java/hudson/model/UpdateSiteTest.java
	test/src/test/java/hudson/tasks/FingerprinterTest.java
	test/src/test/java/hudson/tasks/junit/JUnitResultArchiverTest.java
2014-09-23 10:16:54 -04:00
Jesse Glick 1d29041372 [JENKINS-21984] Disabling cert check on updateDirectlyWithJson since the certificate is now expired, and it is no good to have a test which is known to start failing at a particular time in the future!
(cherry picked from commit 334ce1be69)
2014-09-23 09:59:01 -04:00
Jesse Glick 1e8076d569 The jenkins_main_trunk job has been retired, so for now just skip these tests when running on any Jenkins server.
(cherry picked from commit b7d4c6a414)

Conflicts:
	test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
2014-09-23 09:56:19 -04:00
Emmanuel Bourg 14b8997cbb Updated the link to the Jetty documentation in realm.properties 2014-09-23 13:09:01 +02:00
Stephen Connolly bfa9c503d6 Expose the remote cause details 2014-09-23 10:31:39 +01:00
Kohsuke Kawaguchi 040b7d4047 [ZD-20503] Incorporated a newer version of winp.
This version checks the critical flag of the process, as killing such a
process results in BSoD.
2014-09-22 18:09:26 -07:00
Kohsuke Kawaguchi bcf34e00f3 Merged new trilead that has logging improvements 2014-09-22 12:58:28 -07:00
CloudBees DEV@Cloud df89897896 Merge commit 'be76d0938401be581c66fbb2f274e95660883904' builds/254 2014-09-22 17:04:36 +00:00
Jesse Glick be76d09384 If during hudson-dev:run we have updated a bundled plugin, honor that pin at next start. changes/254 2014-09-22 13:03:31 -04:00
Jesse Glick 735ba83148 Installing a default FilePathFilter that rejects everything. 2014-09-22 12:54:05 -04:00
Jesse Glick 53958b8a33 Merge branch 'rc' into security-rc 2014-09-22 11:56:08 -04:00
Oliver Gondža c121ee41d0 Merge pull request #1403 from amaurymedeiros/patch-1
Update package name reference.
2014-09-22 17:31:27 +02:00
Jesse Glick 755f55cbdf installTo/uninstallFrom methods ought to be final. 2014-09-22 10:58:48 -04:00
Kohsuke Kawaguchi 9d4d0a0bce the trunk is toward 1.583-SNAPSHOT 2014-09-22 07:52:50 -07:00
Kohsuke Kawaguchi eb191593cf creating an RC branch 2014-09-22 07:52:41 -07:00
Kohsuke Kawaguchi c2986d9db2 merged back the RC branch 2014-09-22 07:50:18 -07:00
Kohsuke Kawaguchi 4a3286af14 updated changelog as a part of the release 2014-09-22 07:50:12 -07:00
Amaury cb9d218bf1 Update package name reference.
Update package name reference from Hudson to Jenkins.
2014-09-22 11:24:39 -03:00
Jesse Glick 1869eac536 No real reason to mention node name in exception. 2014-09-22 10:00:05 -04:00
Jesse Glick 308cf24227 Adding logging to CallableDirectionChecker.
Also clarified that this is impl, not API.
2014-09-22 09:25:07 -04:00
Kohsuke Kawaguchi 9ac4e0f69a updated changelog for release 2014-09-21 21:03:57 -07:00
Kohsuke Kawaguchi a909e32a67 [maven-release-plugin] prepare for next development iteration 2014-09-21 20:57:40 -07:00
Kohsuke Kawaguchi 0a9dd730e7 [maven-release-plugin] prepare release jenkins-1.581 jenkins-1.581 2014-09-21 20:57:39 -07:00
Ryan Campbell 8bece68d33 Incorporate feedback from @jglick 2014-09-20 16:11:19 -05:00
Jesse Glick 4fabe92368 One-letter typo caused massive test failures, obscuring any real problems. 2014-09-20 15:44:12 -04:00
Ryan Campbell 43c4a86a3d Improve naming of test 2014-09-20 13:13:34 -05:00
Ryan Campbell 2e446fd936 Cleanup test file 2014-09-20 13:13:27 -05:00
Ryan Campbell 423b51a43a [JENKINS-24763] Prevent thread starvation in OldDataMonitor by reducing scope of synchronization 2014-09-20 12:13:59 -05:00
Jesse Glick ad200c3888 Merge branch 'security' into SECURITY-144 2014-09-19 16:46:14 -04:00
Jesse Glick 041f9b9fec Merge branch 'security' into security-rc
Conflicts:
	test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
	test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
	test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
2014-09-19 16:45:46 -04:00
Jesse Glick 6e1defe58a Skip a test if starting Jenkins was interrupted.
For reasons TBD, sometimes CI tests fail with (1.565.x):
java.lang.InterruptedException: null
	at java.lang.Object.wait(Native Method)
	at java.lang.Object.wait(Object.java:503)
	at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:267)
	at jenkins.InitReactorRunner.run(InitReactorRunner.java:44)
	at jenkins.model.Jenkins.executeReactor(Jenkins.java:915)
	at jenkins.model.Jenkins.<init>(Jenkins.java:814)
	at hudson.model.Hudson.<init>(Hudson.java:82)
	at org.jvnet.hudson.test.JenkinsRule.newHudson(JenkinsRule.java:539)
	at org.jvnet.hudson.test.JenkinsRule.before(JenkinsRule.java:331)
	at org.jvnet.hudson.test.JenkinsRule$2.evaluate(JenkinsRule.java:479)
(cherry picked from commit 7bbf36b7f0)
2014-09-19 16:36:03 -04:00
Jesse Glick 201065ffef Trying to make SocketTimeoutException’s (as originally noted in 3ec7e56) not turn into test errors. (Works only in JenkinsRule, not HudsonTestCase.) Still have no clue as to cause.
(cherry picked from commit 6fd76ea2e8)

Conflicts:
	test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
2014-09-19 16:35:52 -04:00