Commit Graph
32590 Commits
Author SHA1 Message Date
Dominique 78d4b85a8d Incorrect link to master node on label page 2014-09-04 21:36:34 -04:00
Kohsuke Kawaguchi b119f865c2 [FIXED SECURITY-122]
Added "X-Content-Type-Options: nosniff" for serving user-generated
contents to improve security a little bit
2014-09-02 16:43:16 -07:00
Kohsuke Kawaguchi c93635b9e9 [SECURITY-128]
Plugins that depend on LTS shouldn't be using this API.
2014-09-02 16:15:22 -07:00
Kohsuke Kawaguchi 54d44502bd [FIXED SECURITY-127]
CONFIGURE permission shouldn't allow the type of the job to be changed.
That's more of CREATE+DELETE.

In any case, the code doesn't correctly handling submitting config.xml
for a different type.
2014-09-02 16:12:47 -07:00
Kohsuke Kawaguchi 31df138d69 [SECURITY-87]
After talking to Jesse, he's OK with me bringing it back to public so
long as we don't allow other programmatic dependencies to it.

The intention of leaving them mutable is to allow admins to play with
this in the groovy script during the initialization and at runtime.

Groovy currently ignores the private access modifier anyway, but that is
considered as a bug in the upstream
(https://jira.codehaus.org/browse/GROOVY-3010)
2014-09-02 14:16:53 -07:00
Kohsuke Kawaguchi db757116f1 [FIXED SECURITY-128]
It may be that the 'newName' exists and just not visible to the user trying to do a rename
2014-09-02 14:05:42 -07:00
Nicolas De loof 314bd64604 set @since on DecoratedLauncher 2014-09-02 12:04:12 +02:00
Jesse Glick 1a6e943d04 Improved Javadoc for ExecutorListener. builds/248 changes/248 2014-09-01 21:41:33 -04:00
Kohsuke Kawaguchi 1a4aef1172 the trunk is toward 1.580-SNAPSHOT 2014-09-01 08:21:17 -07:00
Kohsuke Kawaguchi 39e18511b5 creating an RC branch 2014-09-01 08:21:14 -07:00
Kohsuke Kawaguchi 1983d93da7 merged back the RC branch 2014-08-31 21:47:25 -07:00
Kohsuke Kawaguchi e9235776b1 updated changelog as a part of the release 2014-08-31 21:47:23 -07:00
Kohsuke Kawaguchi a4cf59cb41 updated changelog for release 2014-08-31 19:50:05 -07:00
Kohsuke Kawaguchi 803fd365e2 [maven-release-plugin] prepare for next development iteration 2014-08-31 19:43:31 -07:00
Kohsuke Kawaguchi 6a9b4bc686 [maven-release-plugin] prepare release jenkins-1.578 jenkins-1.578 2014-08-31 19:43:30 -07:00
Jesse Glick 67f23793fc [SECURITY-120] Do not print a warning with stack trace just because we are using a 2.x servlet container. 2014-08-31 17:44:29 -04:00
Jesse Glick c7cf218076 Merge branch 'security' into security-rc 2014-08-31 11:45:07 -04:00
Jesse Glick 9dec86501b Merge branch 'rc' into security-rc 2014-08-31 11:45:05 -04:00
Jesse Glick 8b23452c5c [SECURITY-87] No apparent reason for CONNECTION_TIMEOUT to be public. 2014-08-31 11:20:08 -04:00
CloudBees DEV@Cloud a197999c6c Merge commit '52c28ae38d29773e2a47db3f9dfaa57291e0ee87' builds/247 2014-08-31 15:07:55 +00:00
Kohsuke Kawaguchi c07463ddad Integrated the latest version with a better error diagnostics 2014-08-30 15:17:56 -07:00
Kohsuke Kawaguchi 79c905e6d0 [FIXED SECURITY-120]
If Jenkins URL is set to https, force the secure flag. Also force the
cookie to be HTTP only, which mitigates the damage that XSS can cause.

See https://www.owasp.org/index.php/SecureFlag
2014-08-29 18:41:44 -07:00
Kohsuke Kawaguchi b1803a9539 [FIXED SECURITY-110]
Don't let UsernameNotFoundException vs BadCredentialsException
difference to be seen by the caller, for that tells whether the user
exists or not.

But to assist trouble-shooting, do report that error to the server. UUID
helps the user finds the information in the log file
2014-08-29 18:02:02 -07:00
Kohsuke Kawaguchi cf5a9b7c20 [FIXED JENKINS-24514]
Ubuntu (at least as of 12.04) has the default umask 022, which made some
users nervous. Quoting its /etc/login.defs below, which explains its
historical origin:

  UMASK is the default umask value for pam_umask and is used by
  useradd and newusers to set the mode of the new home directories.
  022 is the "historical" value in Debian for UMASK
  027, or even 077, could be considered better for privacy
  There is no One True Answer here : each sysadmin must make up his/her
  mind.

It does seem to me that a bit more restrictive default is sensible,
so this change introduces /etc/default/jenkins parameter that sets the
default umask to 027 to prevent "others" from seeing files.

Not that keys and other sensitive files are protected anyway, so it is
not the case that the privacy of Jenkins data files have been vulnerable
prior to this change.
2014-08-29 17:37:59 -07:00
Kohsuke Kawaguchi 880e101b1a [FIXED SECURITY-87]
Don't wait for a connection forever, which can cause the thread to hang forever if the upload link never arrives
2014-08-29 17:13:30 -07:00
Kohsuke Kawaguchi 9db1a1d106 [FIXED SECURITY-149]
ZeroClipboard 1.3.5 is rather incompatible with 1.1.7, and various API changes were needed.

 - setText() call doesn't work until the DOM is populated, which is at some unknown time AFAICT.
   installing it via the datarequested event avoids this problem.
 - constructor now demands the element to attach to, and it's unclear if relative positioning is working or not.
 - "display: inline-block" is needed for ZeroClipboard to correctly compute the height of the element
2014-08-29 17:01:38 -07:00
Jesse Glick 52c28ae38d NPE diagnosis from ProjectTest.testCheckout.
java.lang.NullPointerException: null
	at hudson.model.AbstractBuild.setWorkspace(AbstractBuild.java:296)
	at hudson.model.ProjectTest.testCheckout(ProjectTest.java:423)
builds/246 changes/246 changes/247
2014-08-29 20:01:13 -04:00
Jesse Glick cb6e568815 [FIXED JENKINS-23522] Defend against stack overflows when a listener (unnecessarily) called super from a deprecated method.
Fixes #1295 a little differently.
builds/245 changes/245
2014-08-29 18:16:19 -04:00
Kohsuke Kawaguchi a6a7bec04b [FIXED SECURITY-138]
Protect default password value from users who are triggering builds.
2014-08-29 09:24:00 -07:00
Kohsuke Kawaguchi 0f63c678ee [FIXED SECURITY-143]
Coerce the parameter value to one of a legal value
2014-08-29 09:12:47 -07:00
Jesse Glick d33a63225b Another attempt to diagnose a random test failure. (Cf. #1370.) builds/244 changes/244 2014-08-28 17:02:27 -04:00
Jesse Glick bdc91654f6 [JENKINS-24317] Amending 80f78d5732.
If we are running on a case-insensitive FS, the test makes no sense because migration would never even be attempted to begin with.
builds/243 changes/243
2014-08-28 15:45:47 -04:00
Daniel Beck 0b72b85b21 Noting change to logging in Stapler 2014-08-28 21:10:26 +02:00
Henrik Ygge f6ec318cc2 [FIXED JENKINS-23724]
For some reason IE10 craches when document.getElementsByName is called and there is an element with a name attribute but no value. In this case a button had a name attribute set with an empty string as the value.
2014-08-27 22:42:17 +01:00
tfennelly 80f78d5732 Fixing dir listing in test to not be case sensitive (related to JENKINS-24317) 2014-08-27 22:08:16 +01:00
Jesse Glick a1cf988bfc Simplified constructor. 2014-08-27 15:22:26 -04:00
Jesse Glick a046c6c212 A couple of methods that should no longer be @Deprecated. 2014-08-27 15:19:31 -04:00
Jesse Glick a73ba0ac91 Integer.toString here too. 2014-08-27 15:18:00 -04:00
Jesse Glick 87e5f27ed5 Minimizing diff to master. 2014-08-27 15:17:18 -04:00
Jesse Glick d568087347 Obsolete logic to delete build number symlinks. 2014-08-27 15:15:21 -04:00
Jesse Glick 348924b4d5 Need to synchronize access to LEGACY_ID_FORMATTER. 2014-08-27 15:15:02 -04:00
Jesse Glick 268d20c341 Be consistent and use Integer.toString rather than String.valueOf. 2014-08-27 15:13:51 -04:00
Jesse Glick 843d238723 Added RunIdMigrator. 2014-08-27 15:04:45 -04:00
Jesse Glick 25075826b5 Making various changes to ALLRM incompatible to subclasses, so be explicit that this is distinct from RunMap only for purposes of clarity and testing. 2014-08-27 11:16:52 -04:00
Jesse Glick 1ede3e9833 Defend against out-of-order builds even if nextBuildNumber is wrong. 2014-08-27 11:00:39 -04:00
Jesse Glick 2ca95503eb Implemented @daniel-beck’s suggestion for defense against build number duplication. 2014-08-27 10:46:10 -04:00
Jesse Glick c0d48fc116 Fixed compatibility with MatrixRun.
The Run constructors taking a timestamp must not be deprecated.
And the root directory must be created in RunMap.put, not the constructor,
in case the number (and hence directory name) is changed after the constructor completes.
2014-08-27 10:22:10 -04:00
Jesse Glick 80724c8eca Merge remote-tracking branch 'origin/master' into build-number-is-id-JENKINS-24380 2014-08-27 10:04:23 -04:00
Jesse Glick f39c435f8c [FIXED JENKINS-21977] Skip HsErrPidList when running functional tests. builds/242 changes/242 2014-08-27 09:49:12 -04:00
Daniel Beck 1d3568835d Noting #1348, #1373 2014-08-27 11:22:21 +02:00