Commit Graph
32590 Commits
Author SHA1 Message Date
nlabrot c726667162 [FIXED JENKINS-20086] Allow disabling use of default exclude patterns (.git, .svn, etc.) 2014-06-19 22:42:33 +02:00
Stephen Connolly 0ae4c2cff6 Somebody did not read the javadoc for the goTo method (urls not supposed to start with a /) 2014-06-19 14:38:52 +01:00
Stephen Connolly 454e510d8f Since the javadoc for the method says that the relative path should start without a leading '/' strip any leading '/' characters
- I had been tempted to throw IllegalArgumentException but that would break a lot of tests
2014-06-19 14:38:17 +01:00
Stephen Connolly 333b05e356 [FIXED JENKINS-23294] Interpret X-Forwarded-Port
- Also fixed handling of X-Forwarded-Proto and added support for X-Forwarded-Host

- Additional complexity is that there can be multiple headers with the same name (which was handled by default by accident) and
  that a header value may contain a comma separated list if there were multiple forwarding hops.
2014-06-19 14:10:56 +01:00
Jesse Glick cffe9df017 [FIXED JENKINS-23294] Deal with X-Forwarded-Port.
If this is set, use it instead of ServletRequest.getServerPort() for purposes of getRootUrlFromRequest().
Also treat the default port as scheme-specific in that method (which presumes that we in fact got the reported port right).
And enhance the reverse proxy setup monitor to validate that the Referer header (/manage)
actually matches what we have computed from getRootUrlFromRequest;
if it does not, something is messed up, though it may require some digging to find what.
(Would be better to let the monitor specify the exact problem it determined,
though this is not always actually possible;
for example if you are missing AllowEncodedSlashes NoDecode in Apache,
you just get a 404 from Apache without even getting to Jenkins.)
2014-06-19 14:05:28 +01:00
Stephen Connolly 5bad446dd5 [FIXED JENKINS-23294] Interpret X-Forwarded-Port
- Also fixed handling of X-Forwarded-Proto and added support for X-Forwarded-Host

- Additional complexity is that there can be multiple headers with the same name (which was handled by default by accident) and
  that a header value may contain a comma separated list if there were multiple forwarding hops.
2014-06-19 13:58:33 +01:00
tfennelly 1aec030e08 [FIXED JENKINS-23492] UI improvements / refreshing 2014-06-18 18:52:27 +01:00
Kevin Burke b1c9c485ba Update menu dropdown styles
- Replaces thick shadow with a fuzzy shadow.

- adds more padding

- adds a pointer cursor to indicate the items are clickable.
2014-06-18 14:44:09 +01:00
Kevin Burke c37191bbfe Fix inputs bleeding behind help text
Previously the inputs would bleed behind the help text. They were still
clickable but this is not a desirable visual effect.
2014-06-18 14:39:37 +01:00
Oliver Gondža 83f6d97836 Noting #1288 2014-06-17 22:11:52 +02:00
Oliver Gondža 425fdaa027 Merge pull request #1288 from daniel-beck/JENKINS-23434
[FIXED JENKINS-23434] Sort NullSCM first
2014-06-17 22:03:17 +02:00
Daniel Beck c84d3484dd [FIXED JENKINS-23434] Sort NullSCM first 2014-06-17 21:09:48 +02:00
Jesse Glick 9404759d0d [JENKINS-14264] Factor out console-link.jelly for ease of reuse from other run types with logs. builds/171 changes/171 2014-06-17 09:31:38 -04:00
Jesse Glick 87e2d32faa [FIXED JENKINS-14264] For logs >200Kb, just show two <t:task>s without nesting, for proper interoperability with the context menu. 2014-06-17 09:26:49 -04:00
Kohsuke Kawaguchi c3a2dae751 Bumped up to a new version 2014-06-16 19:03:21 -07:00
Kevin Burke d78f26e4e6 Friendlier form styles
- Swap out black borders for gray ones

- Add rounded corners to form areas
2014-06-16 18:56:31 +01:00
Kevin Burke 83b54a9cac Update Jenkins button styles. 2014-06-16 18:21:25 +01:00
CloudBees DEV@Cloud 0021967b38 Merge REMERGE_HEAD into HEAD 2014-06-16 17:12:55 +00:00
Nicolas De Loof fac1cd2643 log full display name to disambiguate jobs when used with folders 2014-06-16 18:39:49 +02:00
Jesse Glick d660d60ea7 [FIXED JENKINS-23191] f:radio is not databinding-aware and does not correctly handle multiple configuration sections unless you make it. builds/170 changes/170 2014-06-16 12:28:54 -04:00
Jesse Glick e1e7f1b93b [JENKINS-23191] Cannot reproduce problem in HtmlUnit test, but can at least guard against other regressions. 2014-06-16 12:22:12 -04:00
Oliver Gondža 7667abba00 Since 2014-06-16 13:11:52 +02:00
Oliver Gondža 21fd44d017 Noting #1281 2014-06-16 13:10:00 +02:00
Oliver Gondža d743dd6cbe Merge pull request #1281 from daniel-beck/JENKINS-23094
[FIXED JENKINS-23094] Use POST to start slave agent
2014-06-16 13:04:33 +02:00
Oliver Gondža 2fa74ce947 Noting #1269 2014-06-16 13:00:34 +02:00
Oliver Gondža 6f02cd74ff Merge pull request #1269 from olivergondza/view-cli
[FIXED JENKINS-23361] Add CLI commands to add jobs to and remove jobs from views
2014-06-16 12:54:30 +02:00
Kohsuke Kawaguchi 8fe2f520d0 the trunk is toward 1.570-SNAPSHOT 2014-06-15 22:01:49 -07:00
Kohsuke Kawaguchi af4c736f3e creating an RC branch 2014-06-15 22:01:44 -07:00
Kohsuke Kawaguchi 547e9c7265 merged back the RC branch 2014-06-15 22:01:23 -07:00
Kohsuke Kawaguchi 8a1b01d082 updated changelog as a part of the release 2014-06-15 22:01:20 -07:00
Kohsuke Kawaguchi d70e78ffab updated changelog for release 2014-06-15 16:39:44 -07:00
Kohsuke Kawaguchi 6c917802dc [maven-release-plugin] prepare for next development iteration 2014-06-15 16:30:50 -07:00
Kohsuke Kawaguchi 99b3ccb907 [maven-release-plugin] prepare release jenkins-1.568 jenkins-1.568 2014-06-15 16:30:49 -07:00
Daniel Beck 97c90ace15 [FIXED SECURITY-134] Restrict access to admin monitor info page
This could contain sensitive information in the list of solutions
provided. It also shows the path to JENKINS_HOME, exposing OS and
configuration information.
2014-06-15 20:32:53 +02:00
Daniel Beck d4f6532d5a [FIXED SECURITY-133] Restrict access to SCMTrigger status page
The page shows the names and URLs of all jobs currently busy with
polling. This includes jobs users might not regularly be able to
access and might therefore reveal otherwise hidden information.
2014-06-15 20:31:54 +02:00
Daniel Beck 90337f0608 [FIXED JENKINS-23094] Use POST to start slave agent 2014-06-15 17:05:23 +02:00
Matt Moore b00aeddf4b Null check the 'properties' element of the json message before attempting to 'rebuild' the 'DescribableList' 2014-06-14 16:36:59 -07:00
tfennelly aa8f5955cd [JENKINS-22373] Submit on Enter key bug on IE9 2014-06-13 18:28:29 +01:00
Jesse Glick 6dd071eaa8 [FIXED JENKINS-23417] Noting merge of #1277. builds/169 changes/169 2014-06-12 17:40:49 -04:00
Surya Gaddipati 65b7d8a71c Remove NoExternalUse Restrictions on SecurityListener methods.
Plugins like github-oauth-plugin implementing SecurityRealm need to call
these methods in security lifecycle events.
2014-06-12 15:56:50 -05:00
Jesse Glick 2b89f9d09e [FIXED JENKINS-21631] Noting #1275. 2014-06-12 10:43:41 -04:00
Jesse Glick 74680ca221 Merge branch 'JENKINS-21631' of github.com:synopsys-arc-oss/jenkins 2014-06-12 10:42:03 -04:00
Oleg Nenashev 5df3f74b4e [JENKINS-21631] - Don't fail with NPE if the PeepholePermalink cache contains the non-numeric value.
Actually, the change just prevents symptoms. There should be an error somewhere else.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2014-06-12 11:13:08 +04:00
Kohsuke Kawaguchi fad3f7db48 [FIXED JENKINS-23410]
Integrated the fix made in winp 1.20.
2014-06-11 22:30:35 -07:00
Jesse Glick 845a2770fa Merge pull request #1274 from kevinburke/building-link
Link to 'Building Jenkins' page from text file
2014-06-11 18:49:13 -04:00
Kevin Burke 4a3c2d1115 Link to 'Building Jenkins' page from text file 2014-06-11 15:05:20 -07:00
CloudBees DEV@Cloud 677fdc0ac5 Merge commit '78dcd063da55ed725c99165686b14b180d03108f' builds/168 2014-06-11 20:48:36 +00:00
Jesse Glick 78dcd063da MockFolderTest.moving pointed out a refinement to 1197e0c: list folders, if included, before their contents. changes/168 2014-06-11 16:47:01 -04:00
Jesse Glick 5396f51546 1197e0c required mocking Item.getName(). 2014-06-11 16:46:19 -04:00
Daniel Beck 956ac72bd9 Noting JENKINS-18654 in 1.524 2014-06-11 22:36:16 +02:00