Commit Graph
32590 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 9cddeba7b2 [JENKINS-13995]
Made the 'v' icon bigger to increase the hit test area, and improved the alignment
logic so that the text and the 'v' icon gets vertically aligned.
2013-04-16 16:43:27 -07:00
Kohsuke Kawaguchi 11bc7ce933 [JENKINS-13995]
Now that the context menu is open only when clicking 'v', the tooltip on model link should
be displayed as soon as the mouse hovers over it.
2013-04-16 16:00:46 -07:00
Kohsuke Kawaguchi 5aa4af75c2 we want to prefer *.jpi over *.hpi, but the code was other way around 2013-04-16 13:38:54 -07:00
Kohsuke Kawaguchi 38eec41601 Simplification without changing the semantics 2013-04-16 12:56:37 -07:00
Kohsuke Kawaguchi ff7f272a4b Fixing StringIndexOutOfBoundsException
I'm not really sure what this code is doing or what ID is supposed to look like. So this is just a minimum-intrusion change to avoid an exception.

java.lang.StringIndexOutOfBoundsException: String index out of range: -1
        at java.lang.String.substring(String.java:1875)
        at hudson.tasks.junit.PackageResult.findCorrespondingResult(PackageResult.java:86)
        at hudson.tasks.junit.TestResult.findCorrespondingResult(TestResult.java:295)
        at hudson.tasks.test.AbstractTestResultAction.findCorrespondingResult(AbstractTestResultAction.java:183)
        at hudson.tasks.test.TestResult.getResultInBuild(TestResult.java:162)
        at hudson.tasks.junit.History.getList(History.java:82)
        at hudson.tasks.junit.History$1.createDataSet(History.java:105)
        at hudson.tasks.junit.History$GraphImpl.createGraph(History.java:169)
        at hudson.util.Graph.render(Graph.java:87)
        at hudson.util.Graph.doPng(Graph.java:98)
2013-04-16 12:56:37 -07:00
Jesse Glick 5ee9ab5451 Merge pull request #760 from mpapo/JENKINS-17416
JENKINS-17416 - Improve Wipe Out Workspace label
2013-04-16 12:48:32 -07:00
Kohsuke Kawaguchi 72fbcbfcea the trunk is toward 1.513-SNAPSHOT 2013-04-16 12:44:28 -07:00
Kohsuke Kawaguchi 1c35f3638f creating an RC branch 2013-04-16 12:44:26 -07:00
Kohsuke Kawaguchi 084da443e1 [JENKINS-13995]
Added logging more liberally, and fixed the problem.
The root cause was that when the mouse enters a hot spot, I wasn't cancelling the previous delayed hide timer.

This fix eliminates the need for the hack in the hide method where I was testing if the mouse was still over the hotspot.
2013-04-16 12:04:34 -07:00
Kohsuke Kawaguchi 6fb7a50d07 [JENKINS-13995]
Fixed a bug where the context menu anchor 'v' disappears even when the mouse is still over a model link.
2013-04-16 12:03:47 -07:00
Kohsuke Kawaguchi d9ec2ce7f3 matching the size with font size since the context menu is most likely aligned with text 2013-04-16 12:03:47 -07:00
Kohsuke Kawaguchi 7547681a24 need to prefer linked files over archives.
This regression appeared to be introduced in 32d5c23.
2013-04-16 12:03:47 -07:00
Michael Pailloncy 15cc52276e JENKINS-17416 - Improve Wipe Out Workspace label 2013-04-16 19:59:32 +02:00
Jesse Glick 293403f3d1 [JENKINS-17637] Noting. 2013-04-16 12:04:53 -04:00
Jesse Glick f8ce8c6e5a Removed junk from cdee827d55. 2013-04-16 11:55:58 -04:00
Nicolas De loof cdee827d55 restore backward compatibility
d3096819f6 changed constructor signature. Add a backward-compatible one
2013-04-16 13:52:23 +02:00
redlab d4459d9d0f As this is my first look inside Jenkins codebase I not sure it's correct
but perhaps artifacts for modulebuilds should be deleted just as logs
are deleted. see https://issues.jenkins-ci.org/browse/JENKINS-17508
I did not fully test it yet, all unit tests ran fine, but didn't succeed
to run jobs inside Jenkins, due to classloader issues while running
Jenkins in Jetty, to verify deletion
2013-04-15 20:59:06 +02:00
Kohsuke Kawaguchi a9edf6a421 merged back the RC branch 2013-04-14 19:04:41 -07:00
Kohsuke Kawaguchi 5ea3d54067 updated changelog as a part of the release 2013-04-14 19:04:38 -07:00
Kohsuke Kawaguchi 796a4e9da6 updated changelog for release 2013-04-14 18:36:58 -07:00
Kohsuke Kawaguchi d1a9c950fc [maven-release-plugin] prepare for next development iteration 2013-04-14 18:26:00 -07:00
Kohsuke Kawaguchi 759ce9edde [maven-release-plugin] prepare release jenkins-1.511 jenkins-1.511 2013-04-14 18:25:59 -07:00
ssogabe 3a855b876d updated Japanese localization 2013-04-13 19:40:42 +09:00
ssogabe ac562d821a check view name with ajax 2013-04-13 09:53:51 +09:00
Seiji Sogabe 477e8979eb rawEncode should be used instead of encode 2013-04-13 04:48:07 +09:00
Jesse Glick 299af75293 Touch-ups related to PR #757. 2013-04-12 14:09:12 -04:00
Jesse Glick eb49ae16dd Merge pull request #757 from Vlatombe/views_include_jobs_folder
ListView can match now items belonging to nested ItemGroups
2013-04-12 11:02:47 -07:00
Vincent Latombe bcd9456933 Merge branch 'master' into views_include_jobs_folder 2013-04-12 15:56:11 +02:00
lvotypko 095ef2d7ee Keep consistence in pendings when exception is thrown during method pop() 2013-04-12 07:53:53 +02:00
Jesse Glick 2d3fa398c3 testWipeWorkspace was failing after changes to link confirmation.
Tricky to emulate the actual web interaction including JavaScript window.confirm;
suffices to just call the web method directly.
2013-04-11 18:52:05 -04:00
Jesse Glick 7d31e7c5d6 Using l:confirmationLink instead of AbstractItem/delete.jelly and AbstractProject/wipeOutWorkspace.jelly. 2013-04-11 17:45:40 -04:00
Seiji Sogabe 3f164c9570 updated changelog for c86b6d7055 2013-04-12 00:41:24 +09:00
Jesse Glick 704d870a13 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-04-11 11:36:30 -04:00
Jesse Glick 1205e9f6c4 [FIXED JENKINS-17575] Redirecting properly after deleting jobs in folders.
Expanded MockFolder to be a ViewGroup so that it is possible to test views inside folders,
and generally fixed it to service Stapler hierarchies properly so that WebClient-based tests can work.
2013-04-11 11:34:56 -04:00
Seiji Sogabe c86b6d7055 Merge pull request #657 from ssogabe/JENKINS-5408
[FIXED JENKINS-5408] Quoting Issue with JDK Installer with Windows Slave
2013-04-11 08:21:27 -07:00
Jesse Glick e3346be374 Better toString. 2013-04-11 11:07:51 -04:00
Jesse Glick dcff6e4130 [JENKINS-17575] Baseline testing of behavior without folders. 2013-04-11 09:50:57 -04:00
Jesse Glick f8f9462b6c [JENKINS-14827] Noting. 2013-04-11 09:46:19 -04:00
Jesse Glick f44ed3d3e1 Failure to define a crumb was causing testDeleteHudsonComputer to be testing the wrong thing. 2013-04-11 09:33:08 -04:00
Vincent Latombe c4847d1b95 Deprecated jobBaseUrl from projectView.jelly.
The reason is that we always determine the job url using
Functions#getRelativeLinkTo, which keeps the view navigation info if it
exists, and can produce an absolute url if required by the context. So
it is no longer needed for the caller to worry about jobBaseUrl.

By default, names are interpreted in relatively to the current item
group, so Label and Computer views no longer need to set useFullName to
true to have correct behaviour.
2013-04-11 09:19:10 +02:00
Seiji Sogabe d33e22d392 [FIXED JENKINS-17317] ”My Views" links leads to 404 Not Found. 2013-04-11 06:31:21 +09:00
Jesse Glick e1f070bbef [JENKINS-15340] Do not try to click on links with onclick attributes as these require confirmation. 2013-04-10 13:17:30 -04:00
Jesse Glick fefb2d0b5c Diagnosis of unreproducible test failure.
https://ci.jenkins-ci.org/job/jenkins_main_trunk/2449/testReport/hudson.console/ConsoleAnnotatorTest/testCompletedStatelessLogAnnotation/
junit.framework.AssertionFailedError: expected:<3> but was:<4>
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.Assert.failNotEquals(Assert.java:329)
	at junit.framework.Assert.assertEquals(Assert.java:78)
	at junit.framework.Assert.assertEquals(Assert.java:234)
	at junit.framework.Assert.assertEquals(Assert.java:241)
	at junit.framework.TestCase.assertEquals(TestCase.java:409)
	at hudson.console.ConsoleAnnotatorTest.testCompletedStatelessLogAnnotation(ConsoleAnnotatorTest.java:69)
2013-04-10 13:10:50 -04:00
Vincent Latombe 719975595d Merge branch 'master' into views_include_jobs_folder
Conflicts:
	changelog.html
2013-04-10 19:00:04 +02:00
Jesse Glick 9eb69772a5 [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk, as it may be expensive.
First of all, /reload should require POST (also prevents XSS DoS attacks).
Adding <l:confirmationLink> to encapsulate a link that requires confirmation upon clicking.
Allowing a ManagementLink to request confirmation (also implying POST); could be used also for e.g. /quietDown.
Enhancing <l:task> to support confirmation as well, and honoring this in context menu items.
2013-04-10 11:29:18 -04:00
Vincent Latombe 609487a06f Merge branch 'master' into views_include_jobs_folder
Conflicts:
	changelog.html
2013-04-10 14:30:27 +02:00
Vincent Latombe 0c0959ec10 Call non-ambiguous method 2013-04-10 11:47:15 +02:00
Vincent Latombe d54105c296 Crafting the job parent url by removing the job short url to the
complete relative url, in order to take into account the current view.
2013-04-10 11:27:59 +02:00
Vincent Latombe f6cc507217 Functions#getRelativeLinkTo now normalize the output url.
Added some unit tests
2013-04-10 11:27:10 +02:00
Vincent Latombe a1adf8aeab Removing allJobNames.
The view content needs to be determined by getItems as the content can
change even without view definition modification.
2013-04-10 09:47:10 +02:00