Commit Graph
32590 Commits
Author SHA1 Message Date
lvotypko 02d34ebc85 Method getComputers() does not return computers for label expressions. 2013-03-21 05:47:46 +01:00
Jesse Glick c49d6b5b3b Use TemporaryFolder to good effect.
Prevents us from leaving behind a temp dir with cyclic symlinks, which breaks JGit’s clean function.
That in turn can cause test builds to break:
https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/783/console
Cleaning workspace
FATAL: Could not delete file …/workspace/core/jenkins_main_trunk/core/target/hudson5309354136960541268tmp/c/symlink/c/symlink/c/symlink/…/c/foo.xml
org.eclipse.jgit.api.errors.JGitInternalException: Could not delete file …/workspace/core/jenkins_main_trunk/core/target/hudson5309354136960541268tmp/c/symlink/c/symlink/c/symlink/…/c/foo.xml
	at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:137)
	at org.jenkinsci.plugins.gitclient.JGitAPIImpl.clean(JGitAPIImpl.java:305)
	at hudson.plugins.git.GitAPI.clean(GitAPI.java:248)
	at hudson.plugins.git.GitSCM$4.invoke(GitSCM.java:1213)
	at hudson.plugins.git.GitSCM$4.invoke(GitSCM.java:1196)
	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2236)
	at hudson.remoting.UserRequest.perform(UserRequest.java:118)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:326)
	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:722)
Caused by: java.io.IOException: Could not delete file …/workspace/core/jenkins_main_trunk/core/target/hudson5309354136960541268tmp/c/symlink/c/symlink/c/symlink/…/c/foo.xml
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:142)
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	…
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	at org.eclipse.jgit.util.FileUtils.delete(FileUtils.java:126)
	at org.eclipse.jgit.api.CleanCommand.call(CleanCommand.java:132)
	... 14 more
2013-03-20 11:23:01 -04:00
Jesse Glick 90f3ad5df0 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-03-20 08:19:51 -04:00
Jesse Glick f77cd8a891 'mvn -Dtest=hudson.maven.MavenProjectTest#testDeleteSetBuildDeletesModuleBuilds test' fails on empty local repo.
~/.m2/repository/org/jvnet/hudson/main/test/multimod/moduleA/1.0-SNAPSHOT/moduleA-1.0-SNAPSHOT.jar was missing; need install goal.
Better to set a local repo so we do not pollute the real repo, and to avoid interaction between tests.
2013-03-20 08:19:25 -04:00
Jesse Glick b7f0e57a7d Updated comment in POM. 2013-03-20 07:48:56 -04:00
Stephen Connolly a16c59bfb8 This code was borked as SlaveComputer is not serializable and we are passing an implicit ref to the outer class.
- I suspect that nobody has ever used this method given the lack of conversion to static inner class required to make it work
2013-03-20 11:12:35 +00:00
Jesse Glick 845bf37a44 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-03-19 18:40:01 -04:00
Jesse Glick 3370e6edf5 [FIXED JENKINS-3265] Hotfix for regression in matrix project loading from 25084f5. 2013-03-19 18:39:40 -04:00
Harald Albers 377e3136b3 updated comment 2013-03-19 19:23:47 +01:00
Pei-Tang Huang 59b4637480 Aligned Traditional Chinese translation with
f43cde68a8.
2013-03-19 23:32:05 +08:00
Jesse Glick 78b263421f [FIXED JENKINS-17271] Util.deleteFile should give a concrete reason for failure. 2013-03-19 11:05:21 -04:00
Jesse Glick 606a9e1de9 File.setWritable should be the first, and if possible only, thing we try for makeWritable. 2013-03-19 10:13:19 -04:00
Jesse Glick 4d8843c991 There is no ‘title’ format key. 2013-03-18 18:28:58 -04:00
Jesse Glick f2508b36ed [FIXED JENKINS-17263] Correctly display current Jenkins.mode. 2013-03-18 18:28:08 -04:00
Jesse Glick 98869558a3 [JENKINS-10502] This was an RFE, not a bug. 2013-03-18 18:26:46 -04:00
Jesse Glick 2166e4af42 Skipping this test did work. 2013-03-18 15:03:16 -04:00
Jesse Glick b36b0d60da ${rootURL} should be used to locate env-vars.html, since otherwise the link will be broken when the builder is configured from a job inside a folder. 2013-03-18 14:58:28 -04:00
Jesse Glick c6f988a120 Normalized help file locations. 2013-03-18 14:41:24 -04:00
Jesse Glick c5f5b80b38 Merge branch 'master' into ArtifactManager-JENKINS-17236 2013-03-18 14:23:36 -04:00
Jesse Glick 2857f3cf42 Due to SUREFIRE-974 using excludedGroups does not seem like an option. 2013-03-18 14:23:05 -04:00
Jesse Glick e96d835a29 Merge branch 'master' into ArtifactManager-JENKINS-17236 2013-03-18 12:46:28 -04:00
Jesse Glick 919bab822f Cannot pass -DexcludedGroups to the entire Jenkins build, since it will fail in other modules. 2013-03-18 12:45:36 -04:00
Jesse Glick a4f16799e2 Merge branch 'master' into ArtifactManager-JENKINS-17236
Conflicts:
	core/src/main/java/hudson/tasks/ArtifactArchiver.java
2013-03-18 12:25:32 -04:00
Jesse Glick 2454c06d04 FailsOnCloud 2013-03-18 12:11:23 -04:00
Jesse Glick 7c20f84737 createTmpDir → TemporaryFolder 2013-03-18 12:03:40 -04:00
Jesse Glick 085646355f JUnit 4. 2013-03-18 12:02:25 -04:00
Jesse Glick aba642e089 Suppressing RedeployPublisherTest.testBug2593 on jenkins.ci.cloudbees.com. 2013-03-18 11:34:47 -04:00
Jesse Glick e88932956f [JENKINS-10502] Noting. 2013-03-18 11:22:14 -04:00
Jesse Glick 780506f6b8 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-03-18 11:21:20 -04:00
Jesse Glick aeb887c12d Merge pull request #732 from pjrt/JENKINS-10502
[FIXED JENKINS-10502] Option to make the build not fail if there is nothing to archive
2013-03-18 08:21:01 -07:00
Jesse Glick 5069a2bb1b JUnit 4. 2013-03-18 11:12:07 -04:00
Jesse Glick fe099a1a0a Distinguishing getArtifactManager and pickArtifactManager.
These do different things that should not be conflated.
2013-03-18 10:52:59 -04:00
Jesse Glick 7372f93a4f Revert "Stronger and shorter type signature"
This reverts commit 36049b6528.

3f0fff9 failed to make Run.java compilable; and this commit introduced a rawtypes warning in ArtifactManager.
Provisionally switching back to originally type signatures which at least were accepted by the compiler, if not optimal.
2013-03-18 10:41:45 -04:00
Jesse Glick a49d8f8a96 Revert "type error fix"
This reverts commit 3f0fff9867.
2013-03-18 10:41:38 -04:00
Kohsuke Kawaguchi 77e011a3da the trunk is toward 1.508-SNAPSHOT 2013-03-17 16:22:54 -07:00
Kohsuke Kawaguchi b74f69df6b creating an RC branch 2013-03-17 16:22:49 -07:00
Kohsuke Kawaguchi 4ff2e2020a merged back the RC branch 2013-03-17 12:49:32 -07:00
Kohsuke Kawaguchi 2c44a36427 updated changelog as a part of the release 2013-03-17 12:49:29 -07:00
Kohsuke Kawaguchi 6e4eaef762 updated changelog for release 2013-03-17 12:10:12 -07:00
Kohsuke Kawaguchi 92f9877fd4 [maven-release-plugin] prepare for next development iteration 2013-03-17 11:53:58 -07:00
Kohsuke Kawaguchi 260649c155 [maven-release-plugin] prepare release jenkins-1.506 jenkins-1.506 2013-03-17 11:53:55 -07:00
imod 320eea930e [FIXED JENKINS-17177] wrong build result in post build steps after failed pre build step in maven project 2013-03-16 10:53:45 +01:00
Pedro Rodriguez f43cde68a8 Added help-allowEmptyArchive.html. Did some cleanup in ArtifactArchiver and config.jelly 2013-03-15 23:41:37 -04:00
Kohsuke Kawaguchi 3f0fff9867 type error fix 2013-03-15 19:09:00 -07:00
Kohsuke Kawaguchi 36049b6528 Stronger and shorter type signature 2013-03-15 18:54:50 -07:00
Kohsuke Kawaguchi ae816df41e Allowing the object returned from ArtifactManager to be bound under the URL space of build.
DirectoryBrowserSupport is a bit of weirdo, in that its a very intelligent HttpResponse object that creates a whole hierarchy. But most of the time, complex structures are created by a series of POJOs referencing each other. Defining a signature to return HttpResponse prevents this common design pattern.

In contrast, as I wrote in the revised javadoc, one can force a certain HttpResponse during the object traversal by throwing an HttpResponse.

So this new signature can accommodate both cases, so I recommend this over the original signature
2013-03-15 18:53:33 -07:00
Kohsuke Kawaguchi 7a2833e09e documenting the restrictions about when they can be invoked. 2013-03-15 18:41:20 -07:00
Jesse Glick da47873031 appliesTo should default to true. 2013-03-15 19:06:48 -04:00
Jesse Glick 834f10a531 Passing in the workspace explicitly means the standard manager can work on any Run. 2013-03-15 18:57:30 -04:00
Jesse Glick 42922b9a70 Added some more methods to ArtifactManager that look to be needed based on grepping plugin sources for usages of now-deprecated getArtifactsDir.
Most such plugins just need to store or load individual artifacts, and could easily be made to accept an InputStream, and this is easy to support in various implementations, so do that.
A few really expect to get a java.io.File directory that they can play with, but these are the exceptions.
Such plugins will just not work when used on builds with nondefault storage, unless they are rewritten.
2013-03-15 18:38:49 -04:00