Commit Graph
32590 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi e95de82644 adding a constructor that's friendly to subtyping 2011-08-29 11:25:24 -07:00
Kohsuke Kawaguchi f322503d3a Reverting 4de81f1eb3.
Max Spring discovered a stack overflow in http://jenkins.361315.n4.nabble.com/channel-example-and-plugin-classes-gives-ClassNotFoundException-td3756092.html that pointed this call into thread context classloader (TCL) as the culprit. Independently, Paul Sandoz discovered the same issue in our products. If TCL is another classloader that delegates to UberClassLoader (UCL), this code causes infinite recursion.

And moreover, given the goal of UCL, it seems wrong that this class is changing behaviour based on contextual information like TCL.

 In looking at 4de81f1eb3, the change was introduced to make sure XStream unmarshalling invoked from Plugin.start() would see the classes in that plugin. This was an issue back then when plugins are prepared and loaded one by one, as UCL didn't have visibility into plugins being prepared. But in the current Jenkins, classloaders for all the plugins are prepared, before any plugin gets started, so by the time Plugin.start() runs, UCL is fully functioning.

 Therefore, there's no need to consult TCL for the purpose of resolving its own classes. I could have also removed the code that sets TCL, but because some libraries often depend on TCL and doesn't properly look at caller class, I'm leaving it in, even though it's generally a bad practice to rely on TCL in multi-classloader apps like Jenkins
2011-08-29 10:56:55 -07:00
Kohsuke Kawaguchi 91fafb4e9e merged back the RC branch 2011-08-29 10:31:17 -07:00
Kohsuke Kawaguchi 758b06ef24 updated changelog as a part of the release 2011-08-29 10:31:15 -07:00
Kohsuke Kawaguchi efe76e9eb0 toward the next release 2011-08-29 09:32:10 -07:00
Kohsuke Kawaguchi c3453e21f8 releasing a new plugin parent POM 2011-08-29 09:32:03 -07:00
Kohsuke Kawaguchi 9360b8c423 updated changelog for release 2011-08-29 09:32:02 -07:00
Kohsuke Kawaguchi c354a01efd [maven-release-plugin] prepare for next development iteration 2011-08-29 09:19:10 -07:00
Kohsuke Kawaguchi a3d5d3ce6e [maven-release-plugin] prepare release jenkins-1.428 jenkins-1.428 2011-08-29 09:19:10 -07:00
Ryan Campbell f3815178be Add a WorkspaceListener extension point 2011-08-29 17:21:54 +02:00
Kohsuke Kawaguchi 851a999c87 not exposing the setBuiltOnStr to arbitrary external methods. It's really only for internal consumption. 2011-08-28 11:30:54 -07:00
Richard Mortimer f8e92df4d5 Add changelog entry for JENKINS-10831 2011-08-28 11:30:53 -07:00
Richard Mortimer 67262e455f JENKINS-10831 maven submodule build fails doing mkdir on master.
Remove the shadow copy of buildOn from MavenBuild.java and move the setter to
AbstractBuild to allow MavenModuleSetBuild.java to continue to set the
build node.
2011-08-28 11:20:11 -07:00
Kohsuke Kawaguchi 452d638fac following up tweaks to the previous commit, and explaining what we don't do so that future versions don't inadvertently mess up them 2011-08-28 11:17:32 -07:00
Tim Pizey 253fee3726 Do not keep changing permissions on install directory. 2011-08-28 11:15:08 -07:00
Mark Field edda7fb465 Add displayName and description as further optional tags that can be submitted as part of an External run 2011-08-28 11:05:35 -07:00
Stefan Wolf 46e8ed3f3c Moved groovy compilation phase from core to parent
Use stock gmaven plugin to achieve this
2011-08-28 10:58:25 -07:00
Christoph Kutzinski b9ce1520cd make FindBugs happy 2011-08-27 21:57:37 +02:00
Kohsuke Kawaguchi 3df6408c12 Jenkins 2011-08-27 09:01:38 -07:00
Kohsuke Kawaguchi 32956d2616 also compress the PNG file 2011-08-27 09:00:07 -07:00
Kohsuke Kawaguchi 59c04d8e9a added svg2png script 2011-08-27 08:55:48 -07:00
olivier lamy c8c10b2f2e issue not fixed 2011-08-27 14:48:20 +02:00
Christoph Kutzinski 6d99ffb637 fixed serving of JARs if running with hudson-dev:run which was broken since https://github.com/jenkinsci/jenkins/commit/a376eb5832a75d4fb840a9088b37a988582b0965 2011-08-27 11:56:15 +02:00
Olivier Lamy 76791e0f8d changelog entry for JENKINS-10831 2011-08-27 21:06:54 +03:00
Olivier Lamy 50a82775e1 Merge pull request #219 from oldelvet/jenkins-10831-npe
Ignore null reporters field in MavenBuild$RunnerImpl.post2 and avoid a NPE.
Thanks !
2011-08-26 23:51:53 -07:00
Richard Mortimer 2fa40188b9 Ignore null reporters field and avoid a NPE.
The NPE can occur if a build fails during checkout and hence the run phase
never gets called. See JENKINS-10831 for an example of this happening.
2011-08-27 00:22:40 +01:00
dty 8dfa5e19ea [FIX JENKINS-10330] Update project names in fingerprints when projects are renamed.
- Added a RenameListener to Fingerprint. When the listener is invoked for
  renamed projects, it will iterate over all the builds of the project looking
  for fingerprint actions. If the build was the originator of the fingerprint,
  the buildPtr is updated; (had to make the name non-final to allow for this).
  If the build is the consumer of a fingerprint, the usages are updated.

   core/src/main/java/hudson/model/Fingerprint.java

- Expose the fingerprint data inline with the build data in the remote API.
  The renaming code also uses this method as a convenient way to get the
  fingerprints for a build.

   core/src/main/java/hudson/model/AbstractBuild.java

- Test.

   test/src/test/java/hudson/tasks/FingerprinterTest.java
2011-08-26 15:51:34 -07:00
Nicolas De Loof 532ab9448d [JENKINS-10819] replace wagon-http-lightweight with wagon-http (httpclient) 2011-08-26 13:02:38 +02:00
Kohsuke Kawaguchi 9dca500e22 [FIXED JENKINS-10799] very early on during the boot sequence, NPE can
happen.

This happens because the version number isn't computed yet, but we try
to put that into HTTP header.

Fixing this by making <st:header/> tolerate null in value or name.
2011-08-25 17:29:57 -07:00
Kohsuke Kawaguchi 3f4d01ec15 [JENKINS-8856] evacuate stdout at OS level to avoid interference with
JVM.
2011-08-25 17:26:15 -07:00
Kohsuke Kawaguchi 9c9379e965 [FIXED JENKINS-10810] integrated the version that works with IBM JDK 2011-08-24 14:52:44 -07:00
Kohsuke Kawaguchi 552741c980 [FIXED JENKINS-10805] preserve the timestampa as well as permissions 2011-08-24 12:02:14 -07:00
Kohsuke Kawaguchi 4f3a285ab4 [FIXED JENKINS-8837] set a dummy mojo object in Maven3, and documented
that this feature is now deprecated.
2011-08-24 11:50:39 -07:00
Kohsuke Kawaguchi 9144caad2a Merged my local changes. 2011-08-24 09:38:52 -07:00
Kohsuke Kawaguchi df3192a44b merged additional changes 2011-08-24 09:32:03 -07:00
Kohsuke Kawaguchi bcdff8c55b if launcher fails to connect silently, report an error 2011-08-24 09:24:28 -07:00
Nicolas De Loof f36368bf82 use BatchMode transfert listener to avoid unformatted transfert progress in log 2011-08-24 10:17:18 +02:00
Kohsuke Kawaguchi 9522cecfe3 FindBugs bug cleanup 2011-08-23 23:16:53 -07:00
Kohsuke Kawaguchi b6d700e5a4 integrated 3.0 site plugin to be able to run FindBugs, which is implemented as a reporting plugin 2011-08-23 21:34:05 -07:00
Kevin Sawicki 2e9292f8dc Fix typos in SCM class comments.
Non-functional change.
2011-08-23 17:30:00 -07:00
Kohsuke Kawaguchi 3bbbe2db22 final was missing 2011-08-23 15:53:45 -07:00
Kohsuke Kawaguchi 872dfe8aaf CLI clients should be able to see plugin classes 2011-08-23 14:12:09 -07:00
Kohsuke Kawaguchi 13d8a744be Ryan reported a dead lock caused by getView(String), so removing synchronized and requiring the list be concurrently iterable. 2011-08-23 14:12:09 -07:00
Kohsuke Kawaguchi f4f41872e5 added a script to compress PNG 2011-08-23 14:12:09 -07:00
Kohsuke Kawaguchi 5ac08becfc improving error diagnostics 2011-08-23 14:12:09 -07:00
Kohsuke Kawaguchi 4c34e4cdc4 adding more default implementations 2011-08-23 14:12:09 -07:00
Kohsuke Kawaguchi d6c3e702a1 doc improvement 2011-08-23 14:12:09 -07:00
Kohsuke Kawaguchi 29aa83e99a bug fix 2011-08-23 14:12:09 -07:00
Kohsuke Kawaguchi 72152be42d Detecting why this exception happens:
mavenExecutionResult exceptions not empty
message : Internal error: java.lang.NullPointerException
cause : null
Stack trace :
org.apache.maven.InternalErrorException: Internal error: java.lang.NullPointerException
	at org.apache.maven.lifecycle.internal.BuilderCommon.handleBuildError(BuilderCommon.java:128)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:95)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
	at org.jvnet.hudson.maven3.launcher.Maven3Launcher.main(Maven3Launcher.java:79)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchStandard(Launcher.java:329)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:239)
	at org.jvnet.hudson.maven3.agent.Maven3Main.launch(Maven3Main.java:158)
	at hudson.maven.Maven3Builder.call(Maven3Builder.java:121)
	at hudson.maven.Maven3Builder.call(Maven3Builder.java:73)
	at hudson.remoting.UserRequest.perform(UserRequest.java:118)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:287)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.NullPointerException
	at hudson.maven.MojoInfo.intercept(MojoInfo.java:208)
	at hudson.maven.reporters.MavenArtifactArchiver.preExecute(MavenArtifactArchiver.java:74)
	at hudson.maven.Maven3Builder$MavenExecutionListener.recordMojoStarted(Maven3Builder.java:535)
	at hudson.maven.Maven3Builder$MavenExecutionListener.forkStarted(Maven3Builder.java:671)
	at org.apache.maven.lifecycle.internal.DefaultExecutionEventCatapult.fire(DefaultExecutionEventCatapult.java:94)
	at org.apache.maven.lifecycle.internal.DefaultExecutionEventCatapult.fire(DefaultExecutionEventCatapult.java:42)
	at org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:328)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:199)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
	... 24 more
channel stopped
FATAL: null
java.lang.NullPointerException
	at hudson.maven.MavenModuleSetBuild$RunnerImpl.doRun(MavenModuleSetBuild.java:833)
	at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:448)
	at hudson.model.Run.run(Run.java:1376)
	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:479)
	at hudson.model.ResourceController.execute(ResourceController.java:88)
	at hudson.model.Executor.run(Executor.java:230)
2011-08-23 14:12:09 -07:00
imod 68117973f5 fix some wrong error messages about wrong configured config files 2011-08-22 19:47:34 +02:00