Agent implementers use onOnline to perform actions after an agent
put online. The API specifies that execeptions thrown by this
method will not put an agent offline. However, the default
implementation does exactly that.
This change clarifies the API to say all exceptions will be logged
and hardens setChannel against exceptions during onOnline.
NOTE: Errors will still cause an agent to go offline as they are
generally fatal conditions.
Also added tests to verify the behavior.
* [FIX JENKINS-41696] Fix recording fingerprints
1. Fix bug which records fingerprints while
ignoring the excludes when archiving artifacts.
* [JENKINS-41696] Fix recording fingerprints
1. Fix bug which records fingerprints while
ignoring the excludes when archiving artifacts.
2. Fingerprinter now supports excluding patterns for targets,
caseSensitivity and defaultExcludes.
* [FIX JENKINS-41696] Fix recording fingerprints
1. Fix bug which records fingerprints while
ignoring the excludes when archiving artifacts.
2. Fingerprinter now supports excludes,
defaultExcludes and caseSensitivity.
Signed-off-by: Mit Naria <mit4dev@gmail.com>
* [FIX JENKINS-41696] Fix recording fingerprints
1. Fix bug which records fingerprints while
ignoring the excludes when archiving artifacts.
2. Fingerprinter now supports excludes,
defaultExcludes and caseSensitivity.
* removing unused annotation and triggering a build.
* Apply suggestions from code review by jvz
Co-Authored-By: foxtrot9 <mit4dev@gmail.com>
* [JENKINS-41696] Fix deserialization bug using readResolve.
Signed-off-by: Mit Naria <mit4dev@gmail.com>
* Update Fingerprinter.java
1. Getters and setters for defaultExcludes and caseSensitive use boolean instead of Boolean.
* Minor bug fixs.
Signed-off-by: Mit Naria <mit4dev@gmail.com>
* Fix stupid mistake in last commit
Signed-off-by: Mit Naria <mit4dev@gmail.com>
This was an experiment that was not adopted.
Retaining just creates confusion.
For reference, these are the commits related to the file:
o 68d4d22fcf kk [JENKINS-8446] it's better to let those directories setting be a part of JENKINS_HOME rather than being independent configuration properties, since they aren't orthogonal.
:\
: o 8291720005 kk making it more type-safe
: |
: o 8c7c1c62b1 kk this file is now auto-generated
:/
o 61768cc0f8 kk not specifying the file extension so that different pieces can be implemented by different view technologies
|
o 12ad3b0272 kk replaced i18n by '_' since it shows up a lot.
:
o 00bc32985f kk experimental re-write of the "manage Jenkins" view by Groovy
|
~
* [JENKINS-57244] FilePath (de)serialization via XStream is unsupported but should not be fatal.
* Factoring out a _getChannelForSerialization with a friendlier message and a redirect.
* JENKINS-11888 Add stop-job CLI command
* JENKINS-11888 Add license headers
* JENKINS-11888 Review fix
* JENKINS-11888 Fix review
* JENKINS-11888 Remove moved files from cli package
* JENKINS-11888 Fix logging
* JENKINS-11888 Collect jobs list before stopping any builds
* JENKINS-11888 Refactor isBuilding check
* JENKINS-11888 Add Restricted annotation for StopBuildsCommand
* JENKINS-11888 Make cli output more responsive
* JENKINS-11888 Remove single quote for job name
* JENKINS-11888 Add semicolon
* JENKINS-11888 Handle exception for executor.doStop
* JENKINS-11888 Rework test to use JenkinsRule
* JENKINS-11888 Remove semicolons from CLI output
* JENKINS-11888 Fix tests for windows platform
* JENKINS-11888 Write message about exception in one line
* JENKINS-11888 Fix output on not founded job
* JENKINS-11888 Improve tests
* JENKINS-11888 Use fullDisplayName for job name
* JENKINS-11888 Use single quotes for build and job names
* JENKINS-11888 Cleanup exceptions throwing
* JENKINS-11888 Add test checking second job will be stopped if first stop failed
* Update ApiTokenStats.java
remove the synchronized on method updateUsageForId if token usage stats diabled
* Update ApiTokenPropertyConfiguration.java
change the default value for api token usage stats to false
* Update ApiTokenPropertyConfiguration.java
change default value to true
* [JENKINS-56477] New "isCompatible" method avoiding all plugins w/ warns
Previous version was only checking "isCompatibleWithInstalledVersion", but there were several other cases that had to be checked
* [JENKINS-56477] Added issue annotation to isPluginUpdateCompatible test
* [JENKINS-56477] Factored out getUpdateSite, init method used by 2 tests
Also removed the "sites" list from the init, since it seemed it was not being used, only using the specific site created from the external json
* [JENKINS-56477] Added a new option for plugin selection: "compatible"
Now users can select "All", "Compatible" or "None"
* [JENKINS-56477] checkPluginsWithoutWarnings also unchecks now
Useful if the user first clicks "Select All" and now wants to "Select Compatible" only.
* [JENKINS-56477] Added unit test for "UpdateSite.Plugin.isCompatible"
The UpdateSite class and its internal classes (e.g. Plugin) are a bit tricky to unit-test. Using some stubs to set the necessary context for the test to run
* [JENKINS-56477] "mock-maker-inline" incompatible w/ other tests
Had to remove the unit test checking "pluginUpdateNotCompatible. It needed "mock-maker-inline" config to mock/spy the Plugin class (which is final), but that mockito config caused conflicts with pre-existing tests.
* [JENKINS-56477] Simplifying condition to check the candidate checkbox
* [JENKINS-56477] Method overload with param should not be exported
* [JENKINS-56477] Javadoc for isCompatible(). Overloaded ver. restricted
Also switched the call in table.jelly to the overloaded version of isCompatible, since a "cache" var was available in the context (and was being already used by calls to the internal methods to show the warnings)
* Removed empty line.
Trivial change to force re-execution of pipeline.
* [JENKINS-56477] "isCompatible" set to @Restricted for now
This method is currently only being used by the Jenkins UI, so we are not being exposing it to plugins nor exporting it. If in the future that need emerges, this can be changed
* Created new getter method in AbstractCIBase and marked it as
`Restricted`
* Added suggested changes
* Added changes
* Suggested Changes Added
* Added new getter method with appropriate changes.
Oleg Nenashev