Matt Sicker
f71bf07993
Refactor FileLocker into JUnit rule
...
Also fixes a bug where locked files are not cleaned up in the cleanup.
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-18 10:46:09 -06:00
Matt Sicker
41fbaeeb8e
Break up testForceRemoveRecursive_LockedFiles into logical tests
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-17 16:06:54 -06:00
Matt Sicker
cc809df4c2
Use Files.isSymbolicLink on non-Windows platforms
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-17 15:47:18 -06:00
Matt Sicker
1b23a9e119
Fix symlink check logic to support junctions again
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-17 15:18:17 -06:00
Matt Sicker
592af986dc
Clarify what this test is for
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-17 15:17:48 -06:00
Matt Sicker
c05829c780
Add explicit test timeout
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-17 11:57:04 -06:00
Matt Sicker
27949aab5a
Merge branch 'master' into flaky-util-test
2018-12-17 10:22:55 -06:00
Matt Sicker
685fb49c4f
Ensure test thread is killed eventually
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-17 09:53:11 -06:00
Kohsuke Kawaguchi
bcc4e4fe9c
[maven-release-plugin] prepare for next development iteration
2018-12-16 21:07:20 -08:00
Kohsuke Kawaguchi
0f477dc3be
[maven-release-plugin] prepare release jenkins-2.156
jenkins-2.156
2018-12-16 21:07:07 -08:00
suren
fbf0254662
Restore mis-remove localization files
2018-12-16 22:53:33 +08:00
Matt Sicker
b42d0fcb7d
Fix typo in method name
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-14 14:30:15 -06:00
Matt Sicker
c020186130
Revert behavior of making writable
...
Instead of attempting to make every file or directory writable before deleting, this reverts behavior back to trying to delete before setting writable file options and retrying.
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-14 14:25:44 -06:00
Matt Sicker
e892a0bb6e
Add convenience constructor
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-14 14:24:47 -06:00
Matt Sicker
97f539d003
Fix off by one error in error message
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-14 14:05:44 -06:00
Jesse Glick
13db805dee
[JENKINS-26677] Avoid using ServletException from SlaveComputer since it can break calls to SlaveComputer.getChannelToMaster. ( #3778 )
...
java.lang.NoClassDefFoundError: javax/servlet/ServletException
at hudson.util.ProcessTree.get(ProcessTree.java:399)
2018-12-14 18:59:04 +01:00
Oleg Nenashev
bd06d4f10e
Merge pull request #3776 from olivergondza/bump-ath-in-essentials
...
Bump ATH version to one that support Selenium 3
2018-12-14 18:55:38 +01:00
Nicolae Pascu
b4a884e5bd
[JENKINS-54933] Replace ZeroClipboard (Flash) with native JavaScript implementation ( #3780 )
...
* [CORE-626] remove ZeroClipboard and replace with pure js replacement
* remove css rule used for testing
* Poke the build
2018-12-14 18:34:44 +01:00
Matt Sicker
e67d24c2ef
Fix off by one math logic
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-14 11:21:04 -06:00
Matt Sicker
da96361c9b
Merge branch 'master' into flaky-util-test
2018-12-14 11:06:51 -06:00
Matt Sicker
2e8197a2c7
Complete refactoring of Util.delete methods
...
This removes duplicated tests from UtilTest that were added in PathRemoverTest. This also ports the sleep/gc strategy for use by default to preserve backward compatibility.
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-14 10:33:18 -06:00
Oleg Nenashev
b13d2b3210
Merge pull request #3730 from robert-shade/aix_processtree
...
[JENKINS-16867] - Provide ProcessTree Implementation for AIX
(cherry picked from commit 3107ee4239 )
2018-12-14 14:39:11 +01:00
Oleg Nenashev
f0dadba464
Merge pull request #3791 from jsoref/patch-3
...
Miscellaneous minor fixes
2018-12-14 10:08:56 +01:00
Oleg Nenashev
6dd871ab20
Merge pull request #3801 from daniel-beck/update-triggerRemotely-documentation
...
Update triggerRemotely documentation
2018-12-14 10:08:32 +01:00
Wadeck Follonier
0c6a314297
[JENKINS-55197] Correction of the InstallUncaught NPE ( #3806 )
...
[JENKINS-55197] Correction of the InstallUncaught exception
2018-12-14 10:02:56 +01:00
Matt Sicker
3ee6a38484
Add PathRemover refactoring of Util
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-13 17:16:58 -06:00
Jesse Glick
b826edb23d
Merge pull request #3804 from jglick/timeout-diagnosis
...
Fixing tests which attempted to restart the Surefire booter JVM
2018-12-13 11:39:16 -05:00
Jeff Thompson
2853de4c0c
Merge pull request #3800 from jeffret-b/remoting/3.28
...
Upgrade to 3.28 version of Remoting.
2018-12-13 08:00:05 -07:00
Matt Sicker
aa0d346700
Simplify assume expressions
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-12 14:31:34 -06:00
Matt Sicker
c58164a25d
Use ExpectedException in test
...
Signed-off-by: Matt Sicker <boards@gmail.com >
2018-12-12 14:29:26 -06:00
Jesse Glick
08d273f3c6
Fixing a SIOOBE encountered during Windows-jdk11 tests (but not reproducible locally).
...
Amends code added in https://github.com/jenkinsci/jenkins/pull/2082 .
java.lang.RuntimeException: Unexpected issues encountered during cleanUp: offset 0, count -1, length 5
at jenkins.model.Jenkins.cleanUp(Jenkins.java:3319)
at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:495)
at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:565)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.StringIndexOutOfBoundsException: offset 0, count -1, length 5
at java.base/java.lang.String.checkBoundsOffCount(String.java:3304)
at java.base/java.lang.String.<init>(String.java:465)
at hudson.TcpSlaveAgentListener$PingAgentProtocol.connect(TcpSlaveAgentListener.java:416)
at hudson.TcpSlaveAgentListener.shutdown(TcpSlaveAgentListener.java:196)
at jenkins.model.Jenkins._cleanUpShutdownTcpSlaveAgent(Jenkins.java:3548)
at jenkins.model.Jenkins.cleanUp(Jenkins.java:3294)
... 6 more
2018-12-12 14:47:48 -05:00
Jesse Glick
208b42a3ca
Blocking Lifecycle.restart from within JenkinsRule.
2018-12-12 11:36:04 -05:00
Jesse Glick
55ce7a6924
Let us again try all matrix variants.
2018-12-12 10:41:04 -05:00
Jesse Glick
a701c1af98
Merge branch 'master' into timeout-diagnosis
2018-12-12 10:38:14 -05:00
Jesse Glick
486b1566ee
Merge pull request #3809 from jglick/QueueTest.testBlockBuildWhenUpstreamBuildingLock
...
Suppressing a flaky test
2018-12-12 10:37:51 -05:00
Jesse Glick
e3b1f32a42
JenkinsBuildsAndWorkspacesDirectoriesTest also has a restart issue, it seems.
2018-12-12 10:36:58 -05:00
Jesse Glick
f966a89170
Noticed a Surefire error.
...
https://ci.jenkins.io/job/Core/job/jenkins/job/master/1179/execution/node/38/log/?consoleFull
[WARNING] Corrupted stdin stream in forked JVM 2. See the dump file /home/jenkins/workspace/Core_jenkins_master-CZB5BLBJFXZE2BKR63DSXQKXRZJAOWBX73QP55GU5KMX7AHAF6CQ/test/target/surefire-reports/2018-12-12T10-57-04_077-jvmRun2.dumpstream
2018-12-12 09:04:59 -05:00
Jesse Glick
65a121c1bb
Suppressing a flaky test.
...
https://ci.jenkins.io//job/Core/job/jenkins/job/master/1179//testReport/junit/hudson.model/QueueTest/Windows_jdk8___Windows_Publishing___testBlockBuildWhenUpstreamBuildingLock/
2018-12-12 08:56:10 -05:00
Baptiste Mathus
97bb8af88a
Merge pull request #3807 from batmat/fix-compilation-issue
...
Remove duplicate @Ignore failing the compilation
2018-12-12 11:48:40 +01:00
Baptiste Mathus
563945f11d
Remove duplicate @Ignore failing the compilation
2018-12-12 11:31:57 +01:00
Baptiste Mathus
404ca8d0c7
Merge pull request #3721 from jvz/simple-footer-decorators
...
[JENKINS-54325] Add support for multiple footers in SimplePageDecorator
2018-12-12 09:38:30 +01:00
Jesse Glick
d121e08b5b
Seeing if this helps.
2018-12-11 22:27:36 -05:00
Josh Soref
064daa7f6f
Scope upgrade text to upgrade case
...
blurb.3 and blurb.4 are specifically talking about a table "below", but without this change,
the table is actually above. With this change, the blurbs only appear when they are applicable.
2018-12-11 16:03:51 -05:00
Matt Sicker and daniel-beck
c8b34f3472
Use mdash
...
Co-Authored-By: daniel-beck <daniel-beck@users.noreply.github.com >
2018-12-11 21:23:25 +01:00
Josh Soref
67c19e8990
Rewriting old data monitor text
2018-12-11 15:17:14 -05:00
Jesse Glick
2656f7bf76
Merge pull request #3799 from jglick/failing-tests
...
Suppressing some tests which fail in CI
2018-12-11 10:29:08 -05:00
Jesse Glick
25823d91ce
Clarifying reason for suppression.
2018-12-11 09:30:32 -05:00
Wadeck Follonier
99835d6247
Revert the whitespace addition as well
2018-12-11 10:48:08 +01:00
Baptiste Mathus
0ee685eeec
Un-ignore test that was fixed
...
Fixed in https://github.com/jenkinsci/jenkins/pull/3795
2018-12-11 09:57:12 +01:00
Daniel Beck
fd19c9a693
Update triggerRemotely documentation
2018-12-11 00:49:20 +01:00