This reverts commit bb7c8fcedb.
Closes#2090, I'll redo this as a PR... though if that PR is subject to multiple rounds of review before being merged then I will take that of evidence of the exact problem that committing directly was supposed to resolve... namely exponentially multiplying the effort required to make actual improvements to the code base.
- It is never too late to do the right thing.
- The vast majority of usages of `Jenkins.getInstance()` in core currently assume that its return value is non-null
- This commit changes those that are written to correctly check for non-null values will call `Jenkins.getInstanceOrNull()`
- We deprecate the `Jenkins.getActiveInstance()` madness
- I checked with @kohsuke who said not to bother with a PR and just commit this strongly opinionated change direct to master as a PR will just degrade into a bikeshedding.
* origin/master: (91 commits)
Parsing can happen in the forked Maven process. Support remoting.
Fixed the test failures.
Strip whitespace on maven installation.
updated ja.
Use relative path to validate new view name (in order to allow ViewGroups like NestedView to override)
Added i18n.
moved to the model package to colocate with the Result class, since I don't think this class is tied by itself to the notification.
doc improvements
enum to describe a result trend - i.e. change from the previous to the current result
Recording the previous change.
Do not include trailing periods in console links.
doc improvements
Added a hook to customize the XML parser behaviour.
- Renamed from 'linked' to 'base' - Fixed the bug where multi-level base setting wasn't working properly - Improved docs
Updated style
Added convenience method for getting configuration run
Initial commit
the trunk is toward 1.416-SNAPSHOT
creating an RC branch
updated changelog as a part of the release
...
Conflicts:
core/src/main/java/hudson/slaves/NodeProvisioner.java
maven-plugin/src/main/java/hudson/maven/MavenModule.java
maven-plugin/src/main/java/hudson/maven/RedeployPublisher.java
java.lang.NullPointerException
at hudson.ProxyConfiguration.open(ProxyConfiguration.java:112)
at hudson.FilePath.installIfNecessaryFrom(FilePath.java:532)
at hudson.plugins.hadoop.PluginImpl.createHadoopVM(PluginImpl.java:109)
at hudson.plugins.hadoop.SlaveStartTask.call(SlaveStartTask.java:58)
at hudson.plugins.hadoop.SlaveStartTask.call(SlaveStartTask.java:41)
at hudson.remoting.UserRequest.perform(UserRequest.java:104)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:270)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26276 71c3de6d-444a-0410-be80-ed276b4c234a
This allows us to define more setter methods on configuration values, which in turn improves the ability to make programatic changes to the configuration, which in turn improves testability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@11515 71c3de6d-444a-0410-be80-ed276b4c234a
Stephen Connolly