Commit Graph
3763 Commits
Author SHA1 Message Date
kohsuke 2390f683b4 don't let the local variable hide the field.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19739 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 21:20:00 +00:00
kohsuke ab3a78c5ad modernized.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19722 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 03:14:34 +00:00
kohsuke 9936fa4fa0 [HUDSON-3984] Added logging.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19721 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 02:14:40 +00:00
kohsuke d866685e86 [HUDSON-3984] Added logging.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19720 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 02:12:19 +00:00
kohsuke f94b155f29 [HUDSON-3984] Added logging.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19719 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 02:09:23 +00:00
kohsuke 3520698791 [FIXED HUDSON-4032] Fixed in 1.316.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19718 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 02:02:24 +00:00
kohsuke 9808c4c55f improved error diagnostics
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19708 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 00:41:37 +00:00
kohsuke 1eb5418742 doc fix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19707 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 00:03:37 +00:00
kohsuke eea5a3d14e fixed possible NPE
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19706 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-15 00:03:13 +00:00
kohsuke 37aa48b0ee cherry picking from rev.19592.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19701 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-14 21:33:15 +00:00
kohsuke 4a533e530e Fixed a possible NPEs with the slavestatus plugin.
(<a href="http://www.nabble.com/Hudson-throws-NPE-after-upgrade-to-1.1315-td24476619.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19696 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-14 18:48:03 +00:00
kohsuke de68fa2568 Tentatively added additional extension points to control queue behaviors.
(<a href="http://www.nabble.com/Queue-handling-contribution-td24322512.html">patch</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19695 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-14 17:38:17 +00:00
kohsuke 27042bbc4a [FIXED HUDSON-1920] Applied a patch. In 1.316.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19683 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-14 03:55:43 +00:00
kohsuke 550e2d8c57 added a reference to a typical way of creating a Launcher
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19668 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-13 19:20:49 +00:00
kohsuke 104ea7654d The default view is now configurable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19667 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-13 18:51:29 +00:00
kohsuke 3b7eb05e43 merged the RC branch back. This time I saw a lot of strange merge failures. Is svnmerge interfering with Subversion 1.6 somehow?
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19665 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-13 17:48:59 +00:00
kohsuke 39df5b0dd8 eliminated redundant boolean flag that can result in NPEs like described in http://www.nabble.com/SVN-repo-access-problem.-td24450388.html
The line in question is as follows:

            if(Hudson.getInstance().isUseCrumbs() && !Hudson.getInstance().getCrumbIssuer().validateCrumb(req, parser)) {


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19663 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-13 17:14:59 +00:00
kohsuke 3a115dfb8b Plugins can now hide classes in the core so that they can ship their own versions.
(<a href="http://www.nabble.com/jaxen-JDOM-classloading-issues.-td24459951.html">report</a>)



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19658 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-13 17:00:02 +00:00
jglick f3f9796222 [FIXED HUDSON-3647] Enclose URLs in build emails in angle brackets to ensure they are hyperlinked.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19652 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-13 16:12:30 +00:00
sogabe f0ce8118bf I18N again
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19595 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-10 22:19:09 +00:00
sogabe 1943d19031 I18N & Japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19594 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-10 22:17:23 +00:00
kohsuke 029f6715f4 [FIXED HUDSON-3087] Purging workspace in Matrix job should purge all configuration workspaces, too. In 1.316.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19589 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-10 17:37:06 +00:00
kohsuke 6d3ed4c1f4 [FIXED HUDSON-840] in 1.316.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19582 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-10 16:58:51 +00:00
kohsuke ccd0e9f1ac [FIXED HUDSON-2373] in 1.316.
Fixed "incomplete LifecycleExecutor" warning with Maven 2.2
    (<a href="https://hudson.dev.java.net/issues/show_bug.cgi?id=2373">issue 2373</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19573 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-10 00:02:11 +00:00
kohsuke 5534f633dd [FIXED HUDSON-2997] NPE fix. This will be in 1.316.
The fix includes a new getPreviousCompletedBuild(), which only makes sense when we allow multiple concurrent builds per a project, which is currently being developed in a branch. Parameterized build accidentally already incorporates this behavior, so I'm making this fix in the trunk.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19570 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-09 21:23:19 +00:00
kohsuke 3b93eefdf0 [FIXED HUDSON-3972] Incorporated the change in 1.316.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19568 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-09 19:01:34 +00:00
kohsuke 285bf38bd8 removed the usage of deprecated methods
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19558 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-09 16:34:59 +00:00
kohsuke 9e7e52e0c7 Fixed a possible NPE in installing Windows service.
(<a href="http://d.hatena.ne.jp/ushiday/20090708">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19556 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-09 01:28:01 +00:00
kohsuke 58e1367ba1 Fixed a possible NPE in <tt>CrumbFilter.getCrumbIssuer</tt>.
(<a href="http://www.nabble.com/problem-on-tomcat-td24353243.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19555 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-09 01:03:45 +00:00
kohsuke 7b7574210e allowed this to be configured via a system property. Interim solution until we really fix the e-mail notification.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19554 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-09 00:55:53 +00:00
kohsuke df1e55186b Rolling back r19373-19376 as discussed in http://www.nabble.com/attention-all-subversion-users-td24335693.html to proceed with the 1.315 release
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19544 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-08 23:42:31 +00:00
kohsuke 439a6b94f0 while working on a hang problem in JavaFX deployment of Hudson, I noticed that slave is eagerly loading a lot of classes that it shouldn't load, which appears to be caused by the fact that SLAVE_LOG_HANDLER is in SlaveComputer class, which triggers classloading of such classes like hudson.model.Hudson.
I'm hoping that this fixes the hang issue, but at least this makes the start up a bit faster.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19542 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-08 23:20:54 +00:00
jglick b7c25bdf45 [FIXED HUDSON-3989] Installation of JDK 1.4.x did not work due to to "j2sdk" dir name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19476 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 19:44:20 +00:00
kohsuke a31176489c Using AntClassLoader with Closeable so that we can predictably release jar files opened by URLClassLoader
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19472 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 18:35:32 +00:00
jglick 2dd667265b File.toURL() is deprecated.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19471 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 18:31:24 +00:00
kohsuke f6e9363491 a small code simplification
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19451 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-07 16:56:09 +00:00
kohsuke 1bdbdbb398 added the simplest kill method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19440 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 22:16:56 +00:00
kohsuke d1a4bb7bf7 [FIXED HUDSON-3981] Increased the timeout to 3secs as suggested. Added caching so that successive look-ups go faster. This fix will be in 1.315.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19436 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:46:01 +00:00
kohsuke a86fe5e9c7 reformatted import statements
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19435 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:32:11 +00:00
kohsuke af1d6538f4 generalized ProcessTreeKiller to expose more system information, so that the plugins and core can do more interesting things.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19434 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:31:29 +00:00
mindless 8aa65078c9 [HUDSON-3590] load user when create flag is false if user has a config file
(this should not be considered "creating" the user), so login works even if
User.getAll has not yet been called.  fixes regression from r19411


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19412 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-05 23:58:44 +00:00
mindless c9db91664d [FIXED HUDSON-3590] don't create new in-memory user when someone attempts
login with invalid username


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19411 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-05 20:17:39 +00:00
mindless aedca55e74 [FIXED HUDSON-3505] fix getUpUrl when parent is MatrixConfiguration.
(this makes a valid link for "Back to Project" in this case, though sidepanel
navigation between MatrixProject/Configuration/Build/Run could still be improved)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19409 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-05 19:28:14 +00:00
kohsuke 8487501176 Hudson failed to notice a build result status change if aborted builds
were in the middle.
    (<a href="http://www.nabble.com/Losing-build-state-after-aborts--td24335949.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19401 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-04 18:53:31 +00:00
kohsuke d6677bcb1c added an option to close OutputStream at the end
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19392 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-04 01:49:18 +00:00
mindless 12689f0c30 [FIXED HUDSON-3674] Don't allow rename of view to same name as another view
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19389 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-03 22:04:18 +00:00
kohsuke ca0b6e830d I discovered that when Apache sits in front of Hudson as a reverse proxy, it blocks the traffic in such a way that breaks tunneling of the remoting.
The issue is that the CLI initiates the upload side of the connection and sends some small chunk, yet Apache never forwads that to Hudson, presumably because it's trying to buffer more contents from CLI, which never arrives.

A similar problem seems to exist for the download side, although various reports (like http://mail-archives.apache.org/mod_mbox/httpd-users/200509.mbox/%3C20050927152742.GA8726@redhat.com%3E) suggests that this is fixed in a relatively recent version of Apache.

Other pages, like http://httpd.apache.org/docs/2.2/mod/mod_proxy.html , seems to suggest that Apache can be configured not to do this buffering, but my attempt to configure them failed, both on Ubuntu and OpenSolaris. It could be my mistake, but the lesson for me is that even if Apache can be configured not to interfere, it's still rather error prone.

On top of that, it's not hard to imagine that other forward/reverse proxy have similar problems --- IIRC, Dean Yu reported a similar problem.

So I decided to let CLI talk to Hudson via a conventional TCP/IP connection, if possible. An extra bonus is that this is more resource efficient on the server side (which was tying 2 request handling for pushing and pulling before this change.)

The downside of this change is that if the client is behind the proxy, or if the server is behind a reverse proxy, this needs an extra set up. I thought this is a lesser evil, as Hudson tends to run inside a corporate network, and this issue is already better understood since JNLP slaves have the same issue.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19378 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-03 00:12:46 +00:00
kaxelson 4448beb285 [FIXED HUDSON-3966] added option to clean workspace before each build as part of advanced project configuration
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19373 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-02 22:37:17 +00:00
kohsuke 46d1e006ae fixed the archiving code by de-composing it to a smaller orthogonal pieces
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19364 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-02 18:20:13 +00:00
kohsuke dd808e1f1e Merged revisions 19167-19168,19178,19183-19187,19190,19193-19194,19207,19209,19223,19236,19248,19254,19257,19338 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r19167 | kohsuke | 2009-06-23 16:08:06 -0700 (Tue, 23 Jun 2009) | 1 line
  
  merged back the changes in the RC branch
........
  r19168 | kohsuke | 2009-06-23 16:12:46 -0700 (Tue, 23 Jun 2009) | 1 line
  
  fixed the bug
........
  r19178 | swiest | 2009-06-24 02:43:21 -0700 (Wed, 24 Jun 2009) | 1 line
  
  Updated German localization of core module.
........
  r19183 | kohsuke | 2009-06-24 08:57:07 -0700 (Wed, 24 Jun 2009) | 1 line
  
  forgot to update this
........
  r19184 | kohsuke | 2009-06-24 09:06:59 -0700 (Wed, 24 Jun 2009) | 1 line
  
  fixed and improved the retry logic
........
  r19185 | kohsuke | 2009-06-24 09:07:49 -0700 (Wed, 24 Jun 2009) | 1 line
  
  I think this is better
........
  r19186 | kohsuke | 2009-06-24 09:08:02 -0700 (Wed, 24 Jun 2009) | 1 line
  
  fixed import statements
........
  r19187 | kohsuke | 2009-06-24 09:57:52 -0700 (Wed, 24 Jun 2009) | 3 lines
  
  WebDAV deployment from Maven was failing with VerifyError.
  
  A test case requires a webdav server, I tried Milton but couldn't make it work without the source code.
........
  r19190 | swiest | 2009-06-24 12:07:50 -0700 (Wed, 24 Jun 2009) | 1 line
  
  Deprecated Util.combine(long,String) method and rewrote its callers to use localizable resources.
........
  r19193 | sogabe | 2009-06-24 14:53:02 -0700 (Wed, 24 Jun 2009) | 2 lines
  
  Updated Japanese localization.
........
  r19194 | kohsuke | 2009-06-24 15:20:15 -0700 (Wed, 24 Jun 2009) | 1 line
  
  added default value support
........
  r19207 | kohsuke | 2009-06-24 19:50:48 -0700 (Wed, 24 Jun 2009) | 1 line
  
  recording HUDSON-2909 for 1.313
........
  r19209 | kohsuke | 2009-06-24 19:52:21 -0700 (Wed, 24 Jun 2009) | 1 line
  
  creating a new RC branch
........
  r19223 | kohsuke | 2009-06-25 10:43:06 -0700 (Thu, 25 Jun 2009) | 7 lines
  
  Replaced the icon with the one that came from the same icon set, plus hyperlinking the icon
  to Hudson Wiki so that we can be more informative.
  
  Tooltip on the icon doesn't work very well because the TD itself sets a tooltip, and
  we end up seeing the overlapped 2 tooltips (at least on my Firefox 3.0 on Ubuntu)
........
  r19236 | kohsuke | 2009-06-25 18:06:50 -0700 (Thu, 25 Jun 2009) | 1 line
  
  applied a patch from Jeremy (or id:endolf). See http://www.nabble.com/Build-publisher-patch-svn-access-td24164282.html
........
  r19248 | kohsuke | 2009-06-26 14:42:40 -0700 (Fri, 26 Jun 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_313
........
  r19254 | kohsuke | 2009-06-26 17:28:12 -0700 (Fri, 26 Jun 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r19257 | kohsuke | 2009-06-26 18:20:24 -0700 (Fri, 26 Jun 2009) | 1 line
  
  updated changelog as a part of the release
........
  r19338 | kohsuke | 2009-06-30 18:48:25 -0700 (Tue, 30 Jun 2009) | 1 line
  
  added maven-versions-plugin to pick up ones that got out of sync
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19354 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-02 04:17:46 +00:00