* Revert "[JENKINS-48447] Fixed HTTP 404 error when clicking on newView sidebar link from an other view. (#3178)"
This reverts commit 6df06fc19a.
* Revert "[JENKINS-46911] createProjectFromXML not recognizing unsafe character… (#3057)"
This reverts commit ac2a1aaf89.
* [JENKINS-46911] createProjectFromXML not recognizing unsafe character '/'
* Better place for testCreateProjectCheckGoodName()
* Fix failed test
* Make changes suggested on PR review.
* Remove Failure exception, instead throw IOException. Add javadoc
* [JENKINS-46911] - Add TODO according to the comment from @jtnord.
Pulls in fixes for: JENKINS-48133, JENKINS-48055, JENKINS-37566, JENKINS-48309, JENKINS-47965, JENKINS-48130, JENKINS-37670, JENKINS-37566, JENKINS-46724
This change also adds some missing null/closing channel checks in the core.
In some cases the change prevents spawning threads if the channel is in the invalid state.
* Ensure all Jelly view have escape-by-default.
- all those views escape the content theirself, so no vulnerability corrected here (for TextParameterDefinition, it's done by textarea.jelly)
* - just a line break at end
* - just a line break at end (part 2)
* - change from st:out to j:out because their content is expected to be html tags
* - st => j for all finally
* [JENKINS-22474] API Token does not require CSRF token
- in order to ease the use of the api, we are not requiring the request to have a crumb
- in terms of security it's not a problem normally since the CSRF attacks use the cookies and in case of API Token, it's session-less / cookie-less
* - adjust the license header
* - add test for basic authentication
- add test for login process
* - add test for form submission using ui (htmlunit), not just login form
* - modification requested by Jesse
* - pom.xml update to use the last version of jenkins-test-harness (with the token helper methods)
- beginning of the simplification of tests
* - using the try-with-resource approach to ease readability
* - using closure method now
* - add missing login transformation
* - add unit test
* - use withToken
- remove useless crumb for GET method
- add fail (otherwise the assert in catch is not as useful as it could be)
* another bunch of test cases
* - for HudsonTestCase, some additional modifications are required: changing the view / different type of management for the variable inside the views
* - small other tests
* - last batch for the login method
* - crumb is not more required since we are using API Token
* - converting auth to ApiToken to avoid crumb method
* - converting auth to ApiToken to avoid crumb method (second)
* - remove usage of closure aware methods
* - update the pom using the snapshot as adviced by Jesse
- modifications on other class to adapt to the last modifications in JTH
* - modifications requested during code review
* - also put back my changes to the conflicted file
* - correction of the merge :)
* [JENKINS-27026] Notify the SecurityListener in case of Token based authentication success
- due the current version of the method, the UserDetails required for the event was not accessible. In order to stay with the same API in SecurityListener, two "protected" methods were created to split the job and let the UserDetails accessible
* - add test to ensure the SecurityListener is called for REST Token but also for regular basic auth
* - remove the comment about the split, will be put in GitHub comment instead
* - add check for anonymous call instead of just putting a comment
- remove the constructor in the dummy
- add link to PR from Daniel to simplify a call
* - separate the before/after to save one clear and be more explicit
- put more meaning in the assertLastEventIs method by explicitly say we will remove the last event
* - add comment about why we do not fire the "failedToAuthenticated" in the case of an invalid token (tips: it's because it could be a valid password)
* - also add the authenticated trigger on legacy filter as pointed by Ivan
* - add support of event on CLI remoting authentication
- adjust tests by moving the helper class used to spy on events
* - as mentioned Yvan, the code had some problems with null checking, so the approach is changed in order to encapsulate all that internal mechanism
* - add javadoc
- open the getUserDetailsForImpersonation from the User (will let the SSHD module to retrieve UserDetails from that)
* - remove single quote in log messages
* - basic corrections requested by Jesse
* - just another typo
* - adjust the javadoc for SecurityListener events
* - add the link to Jenkins#Anonymous
* - add link (not using see)
* - update comment on the isAnonymous as we (me + Oleg) do not find a best place at the moment
* - put the new method isAnonymous in ACL instead of Functions
* - little typo
- add requirement about the SecurityContext authentication
Oleg Nenashev