Commit Graph
182 Commits
Author SHA1 Message Date
d70bc2e623 [JENKINS-75350] Displays plugin health score in Plugin Manager (#10351)
Co-authored-by: Markus Winter <m.winter@sap.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2025-04-30 21:15:23 +01:00
7006cded64 [JENKINS-73278] Migrate core from EE 8 to EE 9 (#9672)
Co-authored-by: Kevin Guerroudj <91883215+Kevin-CB@users.noreply.github.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2024-09-03 14:59:04 -07:00
Tim Jacomb 8a89117123 Add /manage to uninstall plugin redirect to preserve breadcrumb (#9120) 2024-04-04 18:35:05 +02:00
Bob Du 8197702484 Further reduce usages of StringUtils (#9044)
* Remove usages of StringUtils#containsIgnoreCase

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#removeStart StringUtils#removeEnd

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#defaultString

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#defaultIfBlank

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#isAlphanumeric

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils.EMPTY

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#split

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#startsWithIgnoreCase

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#countMatches

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#endsWithAny

Signed-off-by: Bob Du <i@bobdu.cc>

* fix spotbugs warning

Signed-off-by: Bob Du <i@bobdu.cc>

* Use Objects.toString

Signed-off-by: Bob Du <i@bobdu.cc>

* revert unrelated change

Signed-off-by: Bob Du <i@bobdu.cc>

---------

Signed-off-by: Bob Du <i@bobdu.cc>
2024-03-27 06:38:23 -06:00
Basil Crow 9ce1ff4e7c Remove AntClassLoader (#7846) 2023-04-25 09:39:41 +02:00
EBIBO 58e457f6bd [JENKINS-68194] Delete .disabled file when uninstalling a plugin (#7042) 2022-11-26 07:02:58 -08:00
Basil Crow 6d179998e1 Use Java 11 methods where possible (#6700) 2022-06-30 09:31:36 -07:00
Basil CrowandTim Jacomb aa0513ee10 Revert JENKINS-20679 (support for plugin Java requirement metadata) (#6549)
Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
2022-05-11 08:59:33 -07:00
Basil Crow e27b310065 Enable whitespace-related Checkstyle checks (#6149) 2022-01-03 08:55:03 -08:00
Basil Crow 02eecd8a49 Consistent indentation with spaces rather than tabs (#6147) 2022-01-01 11:45:56 -08:00
Basil Crow b25b45bc90 Remove trailing whitespace (#6138) 2021-12-31 07:54:03 -08:00
Jesse Glick d963feec9b Include shortName in relevant PluginWrapper.dependencyErrors (#6077) 2021-12-21 15:07:59 -08:00
Daniel BeckandDaniel Beck 691ac8e6ae [JENKINS-65113] Add issue tracker metadata support (#5358)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2021-12-16 07:28:17 -08:00
Basil Crow 165d559469 Fix RV_RETURN_VALUE_IGNORED_BAD_PRACTICE SpotBugs violations (#6025) 2021-12-11 12:51:46 -08:00
Basil Crow 4b1f8949df Enable MissingDeprecated Checkstyle check (#5967) 2021-11-29 08:30:49 -08:00
Daniel BeckandDaniel Beck 1376b8bf6f Update at-since Javadoc up to 2.319 (#5936)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2021-11-21 08:58:17 +00:00
Basil Crow 632033d6ad Sort imports (#5732) 2021-09-18 09:39:42 +01:00
ca0508eaa9 [JENKINS-66563] add a supported API for a plugin to insert jars into its classpath (#5711)
* Revive support for `URLClassLoader`

* [JENKINS-66563] add a supported API for a plugin to insert jars into its classpath

Required for BouncyCastle plugin so it does not try and expose its
classes when running in a JVM in FIPS mode, but can be other use cases
as yet unknown.

* [JENKINS-66563] add test case for new functionality

* [JENKINS-66563] and @since javadoc

* [JENKINS-66563] correct indent for new test

* mark the API Beta and document do not do this

Feedback from Jesse was we should be clearer that you probably should
not be using this interface and that there are other approaches that
should be used first.
To that end add some extra Javadoc and mark the API as Beta

* [JENKINS-66563] fix javadoc errors

* Fix typo

Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>

Co-authored-by: Basil Crow <me@basilcrow.com>
Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
2021-09-16 08:09:46 +01:00
Basil Crow f12f400a5c Consistently use issues.jenkins.io for issue links (#5724) 2021-09-13 20:07:44 +01:00
Daniel Beck ef6b562161 Update at-since up to 2.308 2021-08-26 17:09:43 +02:00
Basil Crow bd7c823c27 Remove unnecessary parentheses (#5576) 2021-06-25 09:23:37 +01:00
Basil CrowandDaniel Beck b8c20c6428 Fix violations of a handful of Error Prone checks (#5519)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2021-06-14 16:45:34 +01:00
Tobias GruetzmacherandDaniel Beck 4fc0d5a085 Show implied plugin dependencies (#5472)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2021-05-25 20:57:19 +01:00
Basil Crow ccaabe5adc Reduce usages of com.google.common.collect in favor of native Java functionality (#5464)
* Reduce usages of `com.google.common.collect` in favor of native Java functionality

* Copy original list to preserve original behavior
2021-05-10 11:40:21 +02:00
Basil Crow f6378676b1 Add missing @Override annotations (#5430) 2021-04-28 17:28:25 +08:00
Basil Crow 44c5342c58 Declare modifiers in JLS order (#5339) 2021-03-08 07:58:59 +00:00
Oleg Nenashev b49610e29f Cleanup warnings for missing getPlugin() null checks (#5222) 2021-02-10 19:52:44 +00:00
Basil Crow 64dbdbc4f5 Remove unused imports 2020-12-19 13:10:38 -08:00
Basil Crow 81bbfea719 Remove redundant close() statements 2020-12-11 21:34:22 -08:00
Daniel BeckandDaniel Beck 3ea9dc6b3a Do not block rendering of Manage Jenkins while waiting for UC data (#4881)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:34:18 +01:00
Daniel BeckandDaniel Beck c632f42f07 Update at-since Javadoc (#4877)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:33:48 +01:00
StefanSpiekerandOleg Nenashev 463cd113ba Minor refactorings either for performance or readability (#4845)
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-07-17 15:14:46 +01:00
Daniel Beck f0ef947bf4 Make this a list to allow direct element access 2020-05-03 22:40:10 +02:00
Daniel Beck d213ef962c Add support for top-level 'deprecations' element in update site 2020-05-03 22:09:47 +02:00
Daniel Beck 0dc475a1df Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-05-03 18:29:48 +02:00
Daniel BeckandDaniel Beck e7efc567d2 Hide message re disabling implied dependencies when no dependents exist (#4597)
* Hide message re disabling implied dependencies when no dependents exist

* Rename CSS class to be clear about when it's added

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-04-07 09:40:15 +02:00
James Nord 1f946961b9 s/javax.annotation.CheckForNull/edu.umd.cs.findbugs.annotations.CheckForNull/g 2020-03-26 16:12:35 +00:00
James Nord 819f80b12f s/javax.annotation.Nonnull/edu.umd.cs.findbugs.annotations.NonNull/g 2020-03-26 11:14:41 +00:00
Antonio MunizandTim Jacomb b6678c2241 [JENKINS-61455] "About Jenkins" accessible with Jenkins.MANAGE (#4569)
* [JENKINS-61455] _About Jenkins_ accesible with Jenkins.MANAGE

_About Jenkins_ management link is now accessible to users with
Jenkins.MANAGE or Jenkins.SYSTEM_READ (as well as the usual
Jenkins.ADMINISTRATOR)

* [JENKINS-61455] Test updated to cover this use case

* [JENKINS-61455] Fix test

* [JENKINS-61455] Fix permissions on linked pages

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
2020-03-25 07:57:56 +00:00
Daniel Beck 665bc4deea Add inline security warnings to installed plugins list 2020-03-07 19:15:27 +01:00
Tim Jacomb 47a0be9eda JENKINS-61201 JEP-224 System read - about jenkins (#4520) 2020-02-27 07:47:54 +00:00
Joseph Petersen a05b37ea87 Hide deprecated plugins inside the available section on update center 2020-02-19 22:36:52 +01:00
Joseph Petersen ed9baefc56 Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-02-19 18:37:04 +01:00
Stefan Spieker 40206e023c removed some redundant constructs and replaced stringbuilder operations with too few arguments with string concatenation 2019-11-24 16:15:20 +01:00
Oleg Nenashev eedf2a4e2a Merge pull request #4262 from StefanSpieker/replace_getActiveInstance
Replaced deprecated getActiveInstance() with get()
2019-11-22 10:25:21 +01:00
Zbynek Konecny 40b68eaadb [JENKINS-59679] Use plugin URL from the update site rather than the manifest (#4273)
* Use plugin URL from the update site rather than the manifest

* Avoid Mockito when not needed

* Resolve plugin URL from multiple update sites
2019-11-10 11:24:28 +01:00
Oleg Nenashev 41a13dffc6 Merge pull request #4308 from basil/javadoc
Javadoc cleanup
2019-11-01 01:30:33 +03:00
Basil Crow 861855953b Replace <code>…</code> with {@code …} 2019-10-19 14:02:59 -07:00
Basil Crow a6e22982d4 Fix typos in Javadoc declarations 2019-10-19 14:02:59 -07:00
Daniel Beck fdb6faed00 Update at-since in Javadoc, make script work on Mac OS X 2019-10-16 12:22:03 +02:00