https://svn.dev.java.net/svn/hudson/branches/rc
........
r24110 | kohsuke | 2009-11-25 17:14:49 -0800 (Wed, 25 Nov 2009) | 22 lines
On my production server I started seeing a strange NPE
like this:
java.lang.NullPointerException
at hudson.model.Label.contains(Label.java:277)
at hudson.model.Queue$JobOffer.canTake(Queue.java:177)
at hudson.model.Queue$ApplicableJobOfferList.(Queue.java:767)
at hudson.model.Queue$ApplicableJobOfferList.(Queue.java:759)
at hudson.model.Queue.pop(Queue.java:684)
at hudson.model.Executor.grabJob(Executor.java:161)
at hudson.model.Executor.run(Executor.java:103)
The only possibility is that the getNodes() is returning null,
and that's only possible if Label.getNodes() returns null,
which in turn is only possible if the assignment to nodes
is overwritten by the reset method before it's used as a
return value.
This fix should eliminate the possibility that the getNodes()
method return null.
........
r24111 | kohsuke | 2009-11-25 17:15:45 -0800 (Wed, 25 Nov 2009) | 2 lines
Actually, getNodes() has another possibility of such a data race.
........
r24112 | kohsuke | 2009-11-25 17:24:27 -0800 (Wed, 25 Nov 2009) | 1 line
typo
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24127 71c3de6d-444a-0410-be80-ed276b4c234a
https://www.dev.java.net/svn/hudson/branches/managed-startup
........
r23666 | kohsuke | 2009-11-11 15:56:46 -0800 (Wed, 11 Nov 2009) | 1 line
Reworked the initialization logic
........
r23667 | kohsuke | 2009-11-11 16:01:56 -0800 (Wed, 11 Nov 2009) | 1 line
fixed a failing test
........
r23670 | kohsuke | 2009-11-11 16:42:32 -0800 (Wed, 11 Nov 2009) | 1 line
use a non-snapshot
........
r23711 | kohsuke | 2009-11-13 14:27:28 -0800 (Fri, 13 Nov 2009) | 1 line
Session -> Reactor
........
r23782 | kohsuke | 2009-11-17 10:35:14 -0800 (Tue, 17 Nov 2009) | 1 line
Poorman's clone of JDK6 ServiceLoader.
........
r23783 | kohsuke | 2009-11-17 10:56:25 -0800 (Tue, 17 Nov 2009) | 1 line
Integrated the fatal support so that all errors are sent to the listener.
........
r23784 | kohsuke | 2009-11-17 10:58:07 -0800 (Tue, 17 Nov 2009) | 1 line
with the new reactor initialization, things are getting too verbose
........
r23785 | kohsuke | 2009-11-17 11:18:45 -0800 (Tue, 17 Nov 2009) | 1 line
failing to load jobs are non-fatal, too
........
r23788 | kohsuke | 2009-11-17 13:18:59 -0800 (Tue, 17 Nov 2009) | 1 line
logging the exception properly
........
r23809 | kohsuke | 2009-11-17 18:45:47 -0800 (Tue, 17 Nov 2009) | 1 line
releasing 1.1 as milestone
........
r23810 | kohsuke | 2009-11-17 18:47:37 -0800 (Tue, 17 Nov 2009) | 2 lines
- use a better idiom for building a sequence
- use null display name to signify internal book-keeping tasks that's not worth displaying
........
r23817 | kohsuke | 2009-11-18 07:54:17 -0800 (Wed, 18 Nov 2009) | 1 line
removed accidental JDK6 dependency.
........
r23859 | kohsuke | 2009-11-19 11:03:28 -0800 (Thu, 19 Nov 2009) | 1 line
introducing the strategy pattern to hook into key decision making points during the start up
........
r23870 | kohsuke | 2009-11-19 14:33:07 -0800 (Thu, 19 Nov 2009) | 1 line
bug fix. These steps add additional tasks to the reactor, so they need to also prevent future milestones from getting attained.
........
r23879 | kohsuke | 2009-11-19 16:54:59 -0800 (Thu, 19 Nov 2009) | 1 line
moved the logic to the strategy.
........
r23899 | kohsuke | 2009-11-20 09:32:13 -0800 (Fri, 20 Nov 2009) | 1 line
handle duplicate plugins better
........
r23900 | kohsuke | 2009-11-20 10:06:42 -0800 (Fri, 20 Nov 2009) | 1 line
support pre-exploded plugin
........
r23901 | kohsuke | 2009-11-20 10:49:04 -0800 (Fri, 20 Nov 2009) | 1 line
making it a subtype
........
r23902 | kohsuke | 2009-11-20 10:54:42 -0800 (Fri, 20 Nov 2009) | 1 line
allow InitStrategy to skip some tasks
........
r23903 | kohsuke | 2009-11-20 11:03:38 -0800 (Fri, 20 Nov 2009) | 1 line
doc improvement.
........
r23904 | kohsuke | 2009-11-20 11:03:49 -0800 (Fri, 20 Nov 2009) | 1 line
no need to throw exceptions
........
r23906 | kohsuke | 2009-11-20 11:17:34 -0800 (Fri, 20 Nov 2009) | 1 line
debug switch to disable the automatic launch of slaves
........
r23907 | kohsuke | 2009-11-20 11:25:15 -0800 (Fri, 20 Nov 2009) | 1 line
added a magic object for cancelling all saves
........
r23909 | kohsuke | 2009-11-20 11:29:53 -0800 (Fri, 20 Nov 2009) | 1 line
moving initialization up
........
r23913 | kohsuke | 2009-11-20 13:32:08 -0800 (Fri, 20 Nov 2009) | 1 line
seeing heap space problem during tests
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23992 71c3de6d-444a-0410-be80-ed276b4c234a
link points to a non-existent file/dir (in this case File.exists() returns
false, so it was not removed before creating new symlink).
This change also avoids exec of "rm -rf" when simple File.delete() succeeds.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23972 71c3de6d-444a-0410-be80-ed276b4c234a
configure link.. admin permission was needed to actually configure.
Fixed this so configuration can be done, and also hide the configure link for
master node unless you also have admin permission.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23880 71c3de6d-444a-0410-be80-ed276b4c234a
- Removed "failed to launch" message from ComputerLauncher/main.jelly
This message was always shown, even if slave was offline for other reasons.
- Instead, added new OfflineCause.LaunchFailed which is set in SlaveComputer if channel
is not set after calling launcher. Now this shows the "failed to launch" message.
- Moved/copied existing translations for these strings to their new locations.
- Expanded message for in-demand strategy to say "will be relaunched when needed"
- Added text explanation and fixed display of exception for ChannelTermination cause
- Use class="warning" for default display of OfflineCause
- Added some @Override annotations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23876 71c3de6d-444a-0410-be80-ed276b4c234a
- Use isConnecting() instead of lastConnectActivity!=null in checking forceReconnect
param.. var never resets to null, so this prevented forceReconnect==false from ever
reconnecting (which broken in-demand strategy since 1.302 when it started using false)
- Only set ChannelTermination offline cause when the exception param is non-null.
On orderly shutdown this was replacing the real cause of going offline.
- In setNode try to delegate to RetentionStrategy rather than calling connect directly.
Reconfiguring a node was launching slave even if it wasn't needed per its strategy.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23875 71c3de6d-444a-0410-be80-ed276b4c234a
kohsuke