- Provides translations mostly for SetupWizard
- Makes title of error panel translatable
### Proposed changelog entries
### Submitter checklist
- [ ] JIRA issue is well described
- [ ] Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
- [ ] Appropriate autotests or explanation to why this change has no tests
- [ ] For dependency updates: links to external changelogs and, if possible, full diffs
### Desired reviewers
@batmat
Revert "[JENKINS-53462] Use a workaround to submit the form with a trusted event. No comments on the underlying insanity of hudson-behavior."
This reverts commit fa154b77d1.
The build name width did not take into account the width/offset of the build icon. This resulted in a scroll bar being added prematurely.
Screenshot of change: https://i.imgur.com/RmercIT.png
* [JENKINS-50447] New design and slim down of login page
The change will provide a new designed login page that is using no external deps to prevent any possible malvious javascript.
We still allow the user to use the legacy login page, which has not changed the behaviour.
[JENKINS-50447] Implement error case and use final svg jenkins logo
[JENKINS-50447] remove mock up logo
[JENKINS-50447] Fix feet back from jlong
[JENKINS-50447_squash] Use theme css which only contains values to be overriden. Drop ie js since with the theme css it is not needed anymore
* [JENKINS-50447_squash] Fix expression to evaluate when to show an error and when to simply redirect
* eslint - formating changes and fix offences
* [JENKINS-50447_squash] Use system property to controll whether or not to use the legacy login
* [JENKINS-50447_squash] prevent that the jsessionId appears in the url which should fix most tests
* [JENKINS-50447_squash] Fix cli test by adding pageDecorators magic from layout.jelly
* [JENKINS-50447_squash] remove pageDecorators because they assume existence of js that we do not have
* [JENKINS-50447] New design and slim down of login page
The change will provide a new designed login page that is using no external deps to prevent any possible malvious javascript.
We still allow the user to use the legacy login page, which has not changed the behaviour.
[JENKINS-50447] Implement error case and use final svg jenkins logo
[JENKINS-50447] remove mock up logo
[JENKINS-50447] Fix feet back from jlong
[JENKINS-50447_squash] Use theme css which only contains values to be overriden. Drop ie js since with the theme css it is not needed anymore
[JENKINS-50447_squash] Fix expression to evaluate when to show an error and when to simply redirect
eslint - formating changes and fix offences
[JENKINS-50447_squash] Use system property to controll whether or not to use the legacy login
[JENKINS-50447_squash] prevent that the jsessionId appears in the url which should fix most tests
[JENKINS-50447_squash] Fix cli test by adding pageDecorators magic from layout.jelly
[JENKINS-50447_squash] remove pageDecorators because they assume existence of js that we do not have
[JENKINS-50447_squash] make login page extensible with pagedecorators
[JENKINS-50447_squash] drop legacy support
* Make theme customisable by using a magic package for css and header. Limiting the implemetation of those to one.
* [JENKINS-50447_squash] Creating a specific decorator for login which only returns one instance
* [JENKINS-50447_squash] using rounded corner
* JENKINS-50447 remove legacy code
* [JENKINS-50447_squash] Fix comments from @amuniz about javadoc and uniqueness of css for login
* [JENKINS-50447_squash] Fix click on label span to toggle the select of the checkbox
* [JENKINS-50447_squash] fix comments from @daniel-beck
* [JENKINS-50447_squash] Fix license headers
* [JENKINS-50447_squash] Implement loading/restarting and signup with same design
* [JENKINS-50447_squash] Implement the loading/restarting view and signup with same design as the login page
* [JENKINS-50447_squash] Remove limitation that only one validation error can be shown at a time
* [JENKINS-50447_squash] implement password strength checker
* [JENKINS-50447_squash] Fix different comments from @daniel-beck regarding titles. Further enhanced spacing of label and input
* [JENKINS-50447_squash] Fix restart screen css. Fix comments regarding signup page.
* [JENKINS-50447_squash] fix tabindex flow
* harmonize design
- of checkboxes using jdl styles.
- distance of headers
* [JENKINS-50447] Fix comments from @daniel-beck
- fix some accessibility issues
-- html has now a lang tag
-- define main region
- fix missplaced }
- fix when server down for real that we still show the loading page
* [JENKINS-50447_squash] should never ended up here
* [JENKINS-31661] Add an administrative monitor to check the root url configuration
- add the monitor + test
* - corrections requested by Oleg in code review
* - add a field to fill during SetupWizard for the rootUrl (default value using javascript but editable)
- WIP : missing the translation
* - revert whitespace change
* - little refactoring of js methods
* - translation added
* - modification requested during PR by Jesse
* - renaming proposed by Keith
* - rework to have a new page in the SetupWizard for the root URL
* Correct relevant non-conflicting merge changes
* - in case of skip => also skip the instance configuration
- terminate => finish (+ uppercase)
- replace double single quotes
- add help message in the wizard to inform admins
- correct the installState serialization problem
- update working (admin monitor + wizard)
* address Daniel's comment
- skip all steps will show two messages instead of one (like before when clicking on skip twice)
- skip => not now
- remove margin and adjust padding for the wizard forms
- add the "if possible"
* address Arnaud's comment on the sauter vs passer
* address Liam's comment
* correct previous commit typo
* correct previous commit typo (2)
* add blank end line
* address James' comment
* address Daniel's comment
* address Devin's comment
- implement error management in the wizard
- provide different message in the monitor in case of null / invalid url
- add an helper to validate URL (even with _ in domain)
- add @Restricted
* - also update the monitor test to be consistent with its new behavior
* address Devin's comments
* correct header files
* include relevant classes for the url validation from commons-validator:1.6
* Move Apache classes in a more standard package
The current UC root CA will expire in 2021. Since this key certificate
is baked into jenkins.war, it needs a plenty of time to rotate. I think
two years window would be sufficient, but since I looked, we might as
well start now.
The new key is also now 4096 bits, upgraded from previous 2048 bits.
I've also used the opportunity to remove old hudson-community root CA,
which was used during the transition period from me leaving Sun and the
birth of Jenkins. It's been long since we stopped using this cert, so no
need to honor it anymore.
(cherry picked from commit bcab1f086f)
The current UC root CA will expire in 2021. Since this key certificate
is baked into jenkins.war, it needs a plenty of time to rotate. I think
two years window would be sufficient, but since I looked, we might as
well start now.
The new key is also now 4096 bits, upgraded from previous 2048 bits.
I've also used the opportunity to remove old hudson-community root CA,
which was used during the transition period from me leaving Sun and the
birth of Jenkins. It's been long since we stopped using this cert, so no
need to honor it anymore.
* Increase search results limit from 20 to 100
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
* Enlarge search box size
Increase the max number of results from 10 to 25.
Increase width of results from 25em to 35em
in order to suit longer job names.
This still fits even small 13" screens and improves
user experience.
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
* [JENKINS-45387] Improve setup wizard account creation in security realm
This commit adds an additional account creation method to the
security realm, that allows to create a new user account (as the system)
and is intended to be used by the setup wizard.
The main difference to the existing method is that the new method does
not force the Stapler to send a response, but instead throws an
exception if invalid data is submitted. This allows to call this from
the setup wizard, and send the response there. (This is necessary
because the setup wizard method has a response return type and
there is no way to access the response already send in the realm)
Further, it splits the private createAccount() method for
clarity as well as to allow code reuse from the new method.
* [JENKINS-45387] Fix SetupWizard sending responses twice on create admin
This commit fixes an issue where the SetupWizard class would send
two responses (indirectly) when invalid form data was provided for
creating the first admin account.
* [Fix JENKINS-45387] Setup wizard not displaying first account errors
This commit fixes the setup wizard not displaying HTML error
responses upon first account creation.
Previously, it just froze (buttons were not re-enabled) and didn't
display responses. (Probably caused by XSS policies on the iframe)
* [JENKINS-45387] Add some @Restricted annotations
As per
https://github.com/jenkinsci/jenkins/pull/3116#discussion_r172031063https://github.com/jenkinsci/jenkins/pull/3116#discussion_r172051979
* Improve sortable.js to work with BFA table
The Failure Cause Management table generated by the Build Failure
Analyzer
plugin (<https://wiki.jenkins.io/display/JENKINS/Build+Failure+Analyzer>)
doesn't render dates in a manner that sortable.js can recognize. This
commit improves the matching and sorting for date-like strings to
accommodate a broader variety of date/time strings, and uses the js Date
class to ensure accurate greater/equal/less than results.
* Remove commented patterns in sortable.js
Damian Szczepanik
