Commit Graph
307 Commits
Author SHA1 Message Date
Daniel Beck 2a03dda885 Reference redirectors and jenkins.io as much as possible (#2756)
* Reference redirectors and jenkins.io as much as possible

* Something went wrong, so this is a troubleshooting URL

* More specific redirect URLs
2017-02-25 19:56:01 +01:00
Jesse Glick 6386257578 @daniel-beck forgot to update since tags when merging #1485. 2017-02-14 14:51:06 -05:00
Josh Soref 496703d0fe Spelling fixes in changelogs, Javadoc, logs and UI (#2718)
* spelling: abstract

* spelling: about

* spelling: absolute

* spelling: across

* spelling: activity

* spelling: actually

* spelling: addition

* spelling: allocating

* spelling: ambiguous

* spelling: analyzes

* spelling: analysis

* spelling: another

* spelling: appear

* spelling: arbitrary

* spelling: artifact

* spelling: assignment

* spelling: associated

* spelling: augment

* spelling: authentication

* spelling: automatically

* spelling: available

* spelling: availability

* spelling: because

* spelling: background

* spelling: beginning

* spelling: boolean

* spelling: browsers

* spelling: building

* spelling: calculation

* spelling: channel

* spelling: column

* spelling: concatenation

* spelling: connect

* spelling: contribute

* spelling: convert

* spelling: copied

* spelling: couldn't

* spelling: scrambled

* spelling: creates-a

* spelling: curr-entry

* spelling: customize

* spelling: diagnostic

* spelling: contain

* spelling: default

* spelling: delimiter

* spelling: descriptor

* spelling: disambiguates

* spelling: different

* spelling: diligently

* spelling: disabled

* spelling: discovered

* spelling: display

* spelling: doesn't

* spelling: dollar

* spelling: downstream

* spelling: dynamically

* spelling: preemptively

* spelling: encrypt

* spelling: erroneous

* spelling: examine

* spelling: existence

* spelling: value

* spelling: february

* spelling: handling

* spelling: hostname

* spelling: convenient

* spelling: identify

* spelling: implementation

* spelling: incorrect

* spelling: individual

* spelling: initialization

* spelling: initialized

* spelling: inputstream

* spelling: instantiated

* spelling: instantiation

* spelling: intended

* spelling: interpreted

* spelling: interrupted

* spelling: invocations

* spelling: kern

* spelling: localization

* spelling: logger

* spelling: malfunctioning

* spelling: methods

* spelling: monitor

* spelling: mutator

* spelling: multiple

* spelling: object

* spelling: configured

* spelling: optionally

* spelling: option

* spelling: overridden

* spelling: parameterized

* spelling: parent

* spelling: permissions

* spelling: plugin

* spelling: potentially

* spelling: preferable

* spelling: problems like

* spelling: programmatically

* spelling: property

* spelling: reallocate

* spelling: recommended

* spelling: redirected

* spelling: registered

* spelling: reliable

* spelling: remember

* spelling: recurrence

* spelling: repeatable

* spelling: repeated

* spelling: resource

* spelling: retrieve

* spelling: returned

* spelling: revision

* spelling: sandwich

* spelling: separator

* spelling: serialization

* spelling: settings

* spelling: shadow

* spelling: should

* spelling: someone

* spelling: source

* spelling: specified

* spelling: style

* spelling: subversion

* spelling: sufficient

* spelling: supplementary

* spelling: suppressing

* spelling: synchronization

* spelling: synchronized

* spelling: this

* spelling: transitioning

* spelling: termination

* spelling: trying

* spelling: truncatable

* spelling: unknown

* spelling: undeployed

* spelling: unnecessary

* spelling: unparseable

* spelling: update

* spelling: upper

* spelling: verify

* spelling: visible

* spelling: warning

* spelling: we're

* spelling: whitespace

* spelling: wide

* spelling: with

* spelling: workspace

* spelling: yielding

* spelling: to

* spelling: by

* spelling: the

* spelling: hours
2017-02-12 13:38:30 +03:00
Jesse Glick 76aa0727f0 Functions.printStackTrace utility method. 2016-12-12 17:56:24 -05:00
Jesse Glick 7f4ce02e42 Handle circular references. 2016-12-12 16:14:48 -05:00
Jesse Glick 187731fd88 Check for printStackTrace overrides. 2016-12-12 16:06:57 -05:00
Jesse Glick da54171682 Handle suppressed exceptions. 2016-12-12 16:00:30 -05:00
Jesse Glick 2abddbdfcc Merge branch 'master' into printStackTrace-JDK-6507809 2016-12-12 14:25:12 -05:00
Jesse Glick c31392d140 [JENKINS-36476] Underprivileged users could not use the default value of a password parameter (#2454)
* [FIXED JENKINS-36476] Do not even send the default password in encrypted form; leave the text field blank, and apply the default upon submission.

* [JENKINS-36476] Use a special token, not the empty string, as the marker for the default value.
2016-07-16 22:14:48 +03:00
Stephen Connolly 53adb022e4 [FIXED JENKINS-36280] Enable DescriptorVisibilityFilter for Slave's ComputerLauncher, RetentionStrategy and NodeProperty 2016-06-28 17:07:00 +01:00
Oleg Nenashev ce8922bd74 Merge branch 'master' into JENKINS-34755
Conflicts:
	core/src/main/java/hudson/Util.java
	core/src/main/java/hudson/WebAppMain.java
	core/src/main/java/hudson/model/Item.java
	core/src/main/java/hudson/model/Queue.java
	core/src/main/java/hudson/model/UpdateCenter.java
	core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java
	core/src/main/java/hudson/slaves/NodeProvisioner.java
	core/src/main/java/jenkins/model/Jenkins.java
	core/src/main/java/jenkins/slaves/NioChannelSelector.java
	core/src/main/java/jenkins/util/xml/XMLUtils.java
2016-05-12 12:05:24 +02:00
Jesse Glick 6e815b1ff7 Merge branch 'security-stable-1.651' into security-master 2016-04-29 12:09:20 -04:00
Jesse Glick 4baafc0951 Merge branch 'security-stable-1.642' into security-stable-1.651 2016-04-29 12:09:09 -04:00
Jesse Glick 2992fdad76 Merge branch 'security-stable-1.625' into security-stable-1.642 2016-04-29 12:07:24 -04:00
Jesse Glick 416439ef2f Merge branch 'security-stable-1.609' into security-stable-1.625 2016-04-29 12:02:15 -04:00
Jesse Glick dc2aa07e58 [SECURITY-266] Protecting GetJobCommand. 2016-04-20 09:44:02 -04:00
Jesse Glick e8f6410793 [SECURITY-266] Conceal ciphertext from REST config.xml. 2016-04-20 09:14:42 -04:00
Jesse Glick 82b4235979 [SECURITY-266] Conceal ciphertext from the web UI for a user who has no Item.CONFIGURE permission. 2016-04-19 17:44:31 -04:00
Oliver Gondža ac566a91e4 Merge pull request #2146 from olivergondza/hide-management-link
[FIXED JENKINS-33683] - Fix Management link hiding
2016-04-13 21:37:19 +02:00
Daniel Beck b859206348 Merge branch 'master' into 2.0 2016-03-31 15:56:42 +02:00
Stephen Connolly 5ca718ac01 [FIXED JENKINS-33377] Add a check for termination to Functions.isExtensionsAvailable()
(cherry picked from commit 1ed395aa06)
2016-03-30 12:05:20 +02:00
bhenderson 6fe31014d8 Fix advertised JNLP Port
As far as I can figure, the /TcpSlaveAgentListener/ endpoint headers
tell the slaves what the JNLP port is. When I'm running jenkins behind a
proxy (marathon using the mesos plugin, which bridged networking), even
though I was setting the advertised port per a thread[1], it was not
accurately being returned in the header. This patch fixes that.

[1] https://groups.google.com/d/topic/jenkins-mesos/qUrXpDY07TQ/discussion
2016-03-29 08:30:20 -07:00
Oliver Gondža 8fdca29713 [JENKINS-33683] Annotate Function#getActionUrl() as well 2016-03-22 11:07:31 +01:00
Oliver Gondža eefafb2b38 [FIXED JENKINS-33683] Clarify Action methods can return null 2016-03-21 10:33:58 +01:00
Antonio Muñiz 7045be86e5 API use restricted and simplified logic in Functions 2016-03-20 23:17:40 +01:00
Antonio Muñiz 9e667865ad Merge branch 'JENKINS-14538' of github.com:daniel-beck/jenkins into JENKINS-14538 2016-03-18 18:10:46 +01:00
Daniel Beck 869f66cc07 Merge branch 'master' of github.com:jenkinsci/jenkins into 2.0
Conflicts:
	changelog.html
	cli/pom.xml
	core/pom.xml
	core/src/main/java/hudson/ProxyConfiguration.java
	core/src/main/java/jenkins/model/Jenkins.java
	core/src/main/java/jenkins/slaves/JnlpSlaveHandshake.java
	core/src/main/resources/hudson/model/Messages_da.properties
	pom.xml
	test/pom.xml
	war/pom.xml
2016-03-16 19:00:40 +01:00
Stephen Connolly 96150d3a46 Jenkins.getInstance() will be @Nonnull in Jenkins 2.0+
- Code that is running from a plugin and on the master's JVM is guaranteed to never get null from this method (any cases where you do get null are bugs in core)
- Code that is running from a plugin and on a remote JVM should never be allowed to load the Jenkins class in their classloader, so should never use Jenkins.getInstance()... we are annotating the method with @Nullable so that such code can have some evolution time
- Code that is running in core and on one of two special paths should use the Jenkins.getInstanceOrNull() method so that the UI can be presented to users before the singleton has been instantiated / after the singleton has been destroyed
- The remaining 95% of uses in core (and 100% of uses in plugins) can safely assume that the instance is never null
2016-03-08 21:15:43 +00:00
Stephen Connolly d1dfbd2baf Revert "Jenkins.getInstance() should be non-null"
This reverts commit bb7c8fcedb.

Closes #2090, I'll redo this as a PR... though if that PR is subject to multiple rounds of review before being merged then I will take that of evidence of the exact problem that committing directly was supposed to resolve... namely exponentially multiplying the effort required to make actual improvements to the code base.
2016-03-08 21:09:28 +00:00
Daniel Beck 03291cf891 Merge branch '2.0' of github.com:jenkinsci/jenkins into JENKINS-14538
Conflicts:
	core/src/main/resources/hudson/model/Computer/sidepanel.jelly
2016-03-08 19:08:09 +01:00
Stephen Connolly 1ed395aa06 [FIXED JENKINS-33377] Add a check for termination to Functions.isExtensionsAvailable() 2016-03-08 10:08:32 +00:00
Stephen Connolly bb7c8fcedb Jenkins.getInstance() should be non-null
- It is never too late to do the right thing.
- The vast majority of usages of `Jenkins.getInstance()` in core currently assume that its return value is non-null
- This commit changes those that are written to correctly check for non-null values will call `Jenkins.getInstanceOrNull()`
- We deprecate the `Jenkins.getActiveInstance()` madness
- I checked with @kohsuke who said not to bother with a PR and just commit this strongly opinionated change direct to master as a PR will just degrade into a bikeshedding.
2016-03-07 22:08:36 +00:00
Daniel Beck ea5b2a7ef6 [FIX JENKINS-14538] Move tool configuration to separate page 2016-02-03 18:21:03 +01:00
Antonio Muñiz 320e6c0702 Slave to Agent renaming - Javadocs and logs 2016-01-29 17:40:26 +01:00
Johannes Ernst 9303136c9d Incorporated pull request feedback:
* moved to jenkins.util.SystemProperties
* consistent naming getString/getInteger/getBoolean
* improved code formatting
Improved JavaDoc
2015-11-18 18:26:41 +00:00
Johannes Ernst 709fe5b9aa Allow setting of system properties from context.xml in addition to setting from command-line.
Accomplished by centralizing calls to System.getProperty(String) and related into new file SystemProperties.java.
There, we first check for existence of system property; if not, we look for property in context.xml
This is done for "application" properties (like hudson.DNSMultiCast.disabled) but not for java properties (like user.name)
2015-11-17 01:38:51 +00:00
Jesse Glick 1cbbb23923 Replaced Job.logRotator with BuildDiscarderProperty. 2015-10-27 16:51:15 -04:00
Vojtech Juranek 8f29260b17 [FIXED JENKINS-29507] Make JenkinsRule useable on systems without glibc 2015-09-17 19:56:51 +02:00
Veres Lajos d58903558e typofix - https://github.com/vlajos/misspell_fixer 2015-08-11 16:34:13 +01:00
Oleg Nenashev d5d8463e37 Merge pull request #1468 from synopsys-arc-oss/JENKINS-25734
[JENKINS-25734] - Prevent NPE in Executor/causeOfDeath page on "expected thread death"
2015-06-13 13:15:09 +03:00
Oleg Nenashev bf7f14b165 [JENKINS-25734] - Prevent NPE in Executor/causeOfDeath page if the field is null
The change does not fix the issue, but it suppresses NPE at least.
2015-06-07 16:05:35 +03:00
Jesse Glick 47cb028ac3 Added Javadoc. 2015-05-29 08:04:29 -04:00
Jesse Glick f73255968f Use system line separator. 2015-05-29 07:54:36 -04:00
Jesse Glick 532e9d24e8 Merge branch 'master' into printStackTrace-JDK-6507809 2015-05-29 07:31:06 -04:00
Oleg Nenashev fd42e33d61 Merge pull request #1661 from deadmoose/deprecated_annotations
Add @Deprecated annotations to things documented as @deprecated.
2015-04-22 16:21:45 -07:00
Kohsuke Kawaguchi 86bf6b7603 Allow the advertised TCP slave agent port number to be modified.
This allows TCP slave agent port to be reverse proxied.
2015-04-21 08:26:54 -07:00
David Hoover 1709ed3a2e Add @Deprecated annotations to things documented as @deprecated. 2015-04-19 14:50:12 -07:00
Stephen Connolly 1c253bb352 fix the @since tags 2015-03-26 15:22:33 +00:00
Stephen Connolly 9cd00e40dd added @since tag as requested by @jglick 2015-03-25 10:30:45 +00:00
Stephen Connolly 92147c3597 [FIXED JENKINS-27565] Refactor the Queue and Nodes to use a consistent locking strategy
The test system I set up to verify resolution of customer(s)' issues driving this change, required
additional changes in order to fully resolve the issues at hand. As a result I am bundling these
changes:

- Moves nodes to being store in separate config files outside of the main config file (improves performance) [FIXED JENKINS-27562]
- Makes the Jenkins is loading screen not block on the extensions loading lock [FIXED JENKINS-27563]
- Removes race condition rendering the list of executors [FIXED JENKINS-27564] [FIXED JENKINS-15355]
- Tidy up the locks that were causing deadlocks with the once retention strategy in durable tasks [FIXED JENKINS-27476]
- Remove any requirement from Jenkins Core to lock on the Queue when rendering the Jenkins UI [FIXED-JENKINS-27566]
2015-03-24 14:48:47 +00:00