OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-15 13:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
25,439 Commits 55 Branches 1,942 Tags
2c1876fa187ab38745e63cbe30112dde2c2388cf
Commit Graph
181 Commits
Author SHA1 Message Date
Jesse Glick 00956ff9da [JENKINS-39738, JENKINS-43668] - Pick up SSHD module including sshd-core 1.6.0 (#2853) 
* Pick up SSHD module including sshd-core 1.4.0.

* [FIXED JENKINS-39738] Picking up https://github.com/jenkinsci/sshd-module/commit/bb6963453086edef4e600abb2740182cd2f4ade0

* Picking up Apache SSHD 1.6.0 & Jenkins sshd module 2.0.
 2017-07-08 01:01:01 +02:00
Oliver Gondža 662df37426 Resolving the redirect is OK to fail 2017-06-19 13:22:25 +02:00
Oliver Gondža d9cb39f95f Use authorization to resolve redirect 2017-06-19 12:52:18 +02:00
Oliver Gondža 552d2835cc Address review comment 2017-06-19 09:34:44 +02:00
Oliver Gondža 741be05517 [FIXED JENKINS-44361] Follow HTTP redirects while initiating CLI connection 2017-05-23 15:16:04 +02:00
Stephen Connolly 3871d7778e [JENKINS-43531] Plugins may not be expecting InvalidPathException 
- Plugins should really be expecting it, but as historically they have not, may as well convert to IOE for them
 2017-04-19 14:04:33 +01:00
Jesse Glick 7c16d8dc46 Fix Javadoc generation on JDK 8. 2017-04-11 09:26:45 -04:00
Jesse Glick 729016989e [FIXED JENKINS-41745] Merged #2795: non-Remoting-based CLI. 2017-04-07 20:08:05 -04:00
Jesse Glick 0f87e10a69 @oleg-nenashev requested this be decoupled from https://github.com/jenkinsci/sshd-module/pull/10. 2017-04-07 11:29:21 -04:00
Jesse Glick f3da0e498f Minor review comments from @oleg-nenashev. 2017-04-07 10:22:06 -04:00
Jesse Glick 6ffc57ae79 Verifying that PlainCLIProtocol ignores unrecognized opcodes, so long as it has received well-formed frames. 2017-04-06 15:58:23 -04:00
Jesse Glick 9150d5b563 Suppress an idle timeout from Jetty which would otherwise interfere with interactive commands. 2017-04-06 15:30:53 -04:00
Jesse Glick c41c97b3a2 @stephenc requested documentation of the deprecated FullDuplexHttpStream constructor, and as it turns out it did not work. 2017-04-06 11:40:19 -04:00
Jesse Glick 724ebbcc50 Improved error message displayed when using -http against a pre-JENKINS-41745 server. 2017-04-05 18:42:33 -04:00
Jesse Glick da581599fd -http mode broke when the user omitted the mandatory final / in the Jenkins URL. 2017-04-05 18:28:37 -04:00
Jesse Glick 3939820c5f Using logger as suggested by @rsandell. 2017-04-05 09:53:14 -04:00
Jesse Glick 7bca0a1eef Refined implementation of -logger. 2017-04-05 09:48:56 -04:00
Jesse Glick 9fc59bf251 Finally figured out how to suppress the ReadPendingException from Jetty. 
Something¹ seems to interrupt the HTTP duplex service thread,
and Jetty apparently deals poorly with interruptions.
So introduce an extra sleep to soak up the interrupt.

¹Who? http://stackoverflow.com/questions/2126997/who-is-calling-the-java-thread-interrupt-method-if-im-not#comment40865453_2127397
 2017-04-04 19:15:03 -04:00
Jesse Glick 3b92399db8 Tested Jetty 9.4.3.v20170317 but ReadPendingException’s did not disappear. 2017-04-04 14:50:46 -04:00
Jesse Glick fb311c687f Suppress a meaningless ClosedChannelException thrown by Jetty when killing a client. 2017-04-04 14:01:57 -04:00
Jesse Glick 03aa2a1f17 Simpler to catch ReadPendingException in just one place. 2017-04-04 13:48:21 -04:00
Jesse Glick 4c1910a10b Silence an annoying message. 2017-04-04 13:24:20 -04:00
Jesse Glick c74999f00c Found a race condition which could explain random CI hangs of CLIActionTest.authenticate. 2017-04-04 11:26:57 -04:00
Jesse Glick 71d7562db6 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-04 11:03:59 -04:00
Jesse Glick 9812db70d3 Improved handling of stream closure. 
Making interrupt of `build -s` work in `-http` mode.
Does not solve `ReadPendingException`s.
 2017-04-03 18:52:59 -04:00
Jesse Glick f1689367c3 Test failure on Windows, perhaps specific to filesystem type of TemporaryFolder. 
java.nio.file.FileSystemException: …\.ssh\known_hosts: Incorrect function.
        at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
        at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:90)
        at sun.nio.fs.WindowsAclFileAttributeView.getFileSecurity(WindowsAclFileAttributeView.java:88)
        at sun.nio.fs.WindowsAclFileAttributeView.getOwner(WindowsAclFileAttributeView.java:121)
        at sun.nio.fs.FileOwnerAttributeViewImpl.getOwner(FileOwnerAttributeViewImpl.java:91)
        at java.nio.file.Files.getOwner(Files.java:2079)
        at org.apache.sshd.common.util.io.IoUtils.getFileOwner(IoUtils.java:272)
        at org.apache.sshd.common.util.io.ModifiableFileWatcher.validateStrictConfigFilePermissions(ModifiableFileWatcher.java:240)
        at org.apache.sshd.client.keyverifier.DefaultKnownHostsServerKeyVerifier.reloadKnownHosts(DefaultKnownHostsServerKeyVerifier.java:79)
        at org.apache.sshd.client.keyverifier.KnownHostsServerKeyVerifier.verifyServerKey(KnownHostsServerKeyVerifier.java:161)
        at …
Interactive testing of known_hosts on XP works as expected.
 2017-04-03 17:06:53 -04:00
Oleg Nenashev 33f458d358 Merge pull request #2519 from oleg-nenashev/findbugs/JENKINS-36720-medium-level-fb 
[JENKINS-36720] - Cleanup of SOME medium FindBugs issues
 2017-04-03 22:45:34 +02:00
Jesse Glick 466d74d15e Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-03 12:54:04 -04:00
Daniel Beck bde09f70af Merge pull request #2816 from stephenc/jenkins-42934 
[JENKINS-42934] Avoid using new FileInputStream / new FileOutputStream
 2017-03-30 12:46:10 +02:00
Jesse Glick 60632c0e98 Added -strictHostKey option to CLI in -ssh mode. 
[FIXED JENKINS-33595] Picks up https://github.com/jenkinsci/sshd-module/pull/11
to turn off SSHD by default, but expose it to tests which wish to enable it.
 2017-03-24 17:12:05 -04:00
Jesse Glick e69ba0f024 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-03-24 15:26:59 -04:00
Daniel Beck a00a6993ec Merge branch 'master' of github.com:jenkinsci/jenkins into update-german-translation 2017-03-24 01:58:19 +01:00
Stephen Connolly f0cd7ae8ff [JENKINS-42934] Avoid using new FileInputStream / new FileOutputStream 2017-03-20 12:50:46 +00:00
Tristan FAURE 3ff8ce4853 [JENKINS-42627] CLI is not translated to French (#2787) 
[JENKINS-42627] French translation for CLI
 2017-03-19 21:33:17 +01:00
Jesse Glick 289db88154 Using Logger consistently for all messages that are not expected to be stdout/stderr. 2017-03-17 11:20:44 -04:00
Jesse Glick 59d50136a4 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-03-17 10:39:13 -04:00
Oleg Nenashev 9536ad2182 Merge branch 'master' into findbugs/JENKINS-36720-medium-level-fb 2017-03-17 14:10:47 +01:00
Yoann Dubreuil 1b3121db24 [JENKINS-42191] Enhance CLI HTTP proxy support (#2711) 
* Enhance CLI HTTP proxy support

Fix few issues around proxy support in CLI:

* make proxy support work with recent Squid version which reply with HTTP/1.1 even if request is HTTP 1.0
* close the socket connected to the proxy if the connection failed
* output an error message when proxy connection failed
* don't do a reverse DNS lookup, instead use the host string provided in X-Jenkins-CLI-Host headers (we don't know if the DNS resolver on the
proxy will be able to resolve the name correctly, or like us).

* Use stdout to output CLI proxy connection error message

* Use the logger to output the error message, not System.out

* Add a 'verbose' option to the CLI to turn logging on

This should help people diagnosing connection issues with the CLI.

* [JENKINS-42191] Set log level to FINEST when -v is passed
 2017-03-17 14:09:16 +01:00
Jesse Glick 9ffb5d87f5 Hoping to fix an unreproducible test hang. 2017-03-13 19:14:15 -04:00
Jesse Glick 82cd1bdacf Deleteing apparently unused class SequenceOutputStream. 2017-03-13 17:06:50 -04:00
Jesse Glick b8ad3606e7 Marking various APIs, and a couple of commands, deprecated when they assume a Remoting-based CLI. 2017-03-13 17:06:18 -04:00
Jesse Glick 12ae48ebb4 Deprecating --username/--password and login/logout in favor of new -auth option passing BASIC authentication to /cli endpoint. 
Simpler, does not rely on Remoting, allows use of API tokens, and bypasses JENKINS-12543.
(You could actually do this before but only by embedding userinfo in the -s URL, especially awkward for usernames containing @.)
 2017-03-13 16:33:09 -04:00
Jesse Glick 7da0d39000 Argument processing mistake. 2017-03-13 11:53:20 -04:00
Jesse Glick 8302b85024 Draft of a new CLI transport that can operate over CLIAction with the regular HTTP(S) port. 2017-03-11 13:10:02 -05:00
Jesse Glick 2fe2487bab FindBugs, and more clearly stating which transport is in use. 2017-03-10 17:44:51 -05:00
Jesse Glick 492dbbed10 [JENKINS-41745] Make jenkins-cli.jar connect to the SSH port by default. 2017-03-10 16:05:55 -05:00
Daniel Beck 6351cf8c6c Jenkins! 2017-03-09 14:37:44 +01:00
Daniel Beck 2a03dda885 Reference redirectors and jenkins.io as much as possible (#2756) 
* Reference redirectors and jenkins.io as much as possible

* Something went wrong, so this is a troubleshooting URL

* More specific redirect URLs
 2017-02-25 19:56:01 +01:00
Oliver Gondža 59291a63c7 Do not report -noCertificateCheck warning on STDOUT 2016-12-15 16:22:24 +01:00
Jesse Glick c4ee05bcae Make sure Security218BlackBoxTest cleans up threads it starts (#2642) 
* Make sure Security218BlackBoxTest cleans up threads it starts.

* Some code simplifications, and possible leak fixes, based on CLI now being AutoCloseable.

* Obsolete comment.
 2016-12-09 11:05:49 +01:00