OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-14 04:22:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
19,741 Commits 58 Branches 1,942 Tags
2e87c36ca046d22fda07caccf9ab0988f70bdb40
Commit Graph
8801 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 2e87c36ca0 Making this class serializable 
The use case that led me here was to use this from workflow which relies primarily on Java serialization
 2014-11-11 11:52:26 -08:00
Nicolas De Loof e77f79e82b log error creating slave log directory 2014-11-11 10:58:10 +01:00
Jesse Glick 9cca9e05be Expanding Javadoc from #1454 as suggested by @oleg-nenashev. 2014-11-10 13:30:17 -05:00
Jesse Glick 50124db9d5 Merge branch 'Computer.currentComputer-JENKINS-2786' 2014-11-10 13:28:53 -05:00
Oleg Nenashev fef47e124f Merge pull request #1408 from howlger/master 
[FIXED JENKINS-22514] In ZIP archives file separator must be '/'
 2014-11-10 12:26:13 +03:00
Oliver Gondža e96f08d61a Merge pull request #1458 from olivergondza/aggregate-validations 
Aggregate multiple FormValidations into one
 2014-11-08 10:36:08 +01:00
Jesse Glick 78fde58c30 Merge branch 'master' of git://github.com/jenkinsci/jenkins 2014-11-07 14:13:09 -05:00
Oliver Gondža e451789ac7 Merge pull request #1456 from olivergondza/extract-label-validation 
Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins
 2014-11-07 19:42:03 +01:00
Jesse Glick ae053472a0 Merging #1268. 2014-11-07 13:08:53 -05:00
Jesse Glick bfa557b16a Merge branch 'JENKINS-23339' of github.com:synopsys-arc-oss/jenkins 2014-11-07 13:08:03 -05:00
Kohsuke Kawaguchi ada8432fc5 [JENKINS-25144] Merge pull request #1427 2014-11-07 09:43:25 -08:00
Kohsuke Kawaguchi 9e81b8e4fe [FIXED JENKINS-25144] Revisiting the attempted fix in the previous commit. 
IIUC, the issue here is that the request in question contains both a
valid session cookie AND basic authentication header, and that path
results in a failure because BasicHeaderProcessor expects one of
BasicHeaderAuthenticators to validate the basic authentication header
(without knowing that there's already a valid Authentication object that
came from the HTTP session, yet no BasicHeaderAuthenticator actually
processes this because BasicHeaderRealPasswordAuthenticator backs away
from doing that.

I think the corect fix is for BasicHeaderRealPasswordAuthenticator to
get rid of authenticationIsRequired check. This check instead belongs to
BasicHeaderProcessor, where it should be used to check if any
BasicHeaderAuthenticator should be consulted or not.

The problem with having this logic in
BasicHeaderRealPasswordAuthenticator is that this is just an
implementation of an extension point, and thus it needs to be removable.
As it stands right now in this fix, if this impl is removed,
JENKINS-25144 will be back again.
 2014-11-07 09:42:23 -08:00
Christof Schoell 0176b6d902 [JENKINS-25144] 
return authentication object instead of null if authentication is not
required - otherwise valid login fails with basic authentication
 2014-11-07 09:40:26 -08:00
Oleg Nenashev e6c2e16f7a [FIXED JENKINS-23339] - Introduce the validated Jenkins::getActiveInstance() method 
jenkins.model.Jenkins::getInstance() method is marked as @CheckForNull, but the most of Jenkins code does not actually check the return value. It leads to tons of static analysis errors, hence it is hard to analyze the code.

The change also adds annotations to old methods like Hudson::getInstance()

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-07 20:07:52 +03:00
Oliver Gondža 34850200b2 Introduce FormValidation#aggregate 2014-11-07 09:20:06 +01:00
Jesse Glick 24c5e5e440 Javadoc note pertaining to #1454. 2014-11-06 14:29:07 -05:00
Oliver Gondža e985ee69ff Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins 2014-11-06 13:29:08 +01:00
Jesse Glick 0b0b868805 [JENKINS-2786] Makes no sense for Computer.currentComputer to return MasterComputer when not on an executor thread. 2014-11-05 17:19:45 -05:00
Holger Voormann c56362aba3 [FIXED JENKINS-22514] In ZIP archives file separator must be '/' 2014-11-05 08:41:56 +01:00
Kohsuke Kawaguchi e7d75dc538 Make stdout swapping more reliable. 
This matches fb65a2c3c8584a9ac4daa49ecbce7a540dc7f5a5 in remoting.
 2014-11-04 19:46:49 -08:00
Jesse Glick 22d433deae So far unsuccessful attempt to make Jenkins startup more robust against bugs like JENKINS-25440. 
Even though SezpozModule.configure catches and ignores the faulty component, Guice still dies:
… hudson.ExtensionFinder$GuiceFinder <init>
SEVERE: Failed to create Guice container from all the plugins
com.google.inject.internal.guava.collect.$ComputationException: java.lang.NoClassDefFoundError: org/eclipse/jgit/storage/file/FileRepository
	at …
	at com.google.inject.Guice.createInjector(Guice.java:73)
	at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:279)
 2014-11-04 17:45:52 -05:00
Jesse Glick a6a3d5e166 [FIXED JENKINS-25400] Rework fix of JENKINS-22769 (c04cdcd) to put the burden on each listener to impersonate ACL.SYSTEM if it needs to. 2014-11-04 15:36:01 -05:00
Jesse Glick b486e46c4e Better Javadoc for new impersonate overload. 2014-11-04 15:32:33 -05:00
Oleg Nenashev 8f079fc434 [CID-1182126] - Resource leak in AsynchronousAdministrativeMonitor::run() 
Properly close listeners for asynchronous threads.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-04 15:54:13 +03:00
Oleg Nenashev c873722726 [CID-1182132] - Resource leak in BootFailure::loadAttempts() 
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-04 15:54:09 +03:00
Oleg Nenashev 5259996c44 [CID-1219446] - Resource leak in ClassicPluginStrategy 
Resource leak may happen during the search of manifest file.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-04 15:54:05 +03:00
Oleg Nenashev 2ea0276e7b [CID-1205053] - Resource leak on fingerprint calculation in DirectoryBrowserSupport 
The issue is related to JENKINS-18351.

Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-04 15:54:02 +03:00
Oleg Nenashev 21ba31af42 [CID-1182127] - Resource leak in HsErrPidList constructor. 
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-04 15:53:59 +03:00
Oleg Nenashev 3a8b81a0fc [CID-992725] - Resource leak in ClientAuthenticationCache 
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-04 15:53:55 +03:00
Oleg Nenashev 9e72099115 [CID-1182128] - Properly close InputStream in ConsoleCommand 
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2014-11-04 15:53:51 +03:00
Oliver Gondža 8b71d13233 Merge pull request #1447 from mattmoor/labels 
Adjust my prior change to better utilize structured form submission...
 2014-11-02 23:42:53 +01:00
Matt Moore c426fd2300 mark the legacy jelly endpoints as DoNotUse 2014-11-01 13:10:37 -07:00
Matt Moore 492b4902d8 Adjust my prior change to better utilize structured form submission to accomodate a plugins that are not using p:config-assignedLabel 2014-10-30 13:57:26 -07:00
Jesse Glick e22cb19feb Merge branch 'JENKINS-25358' of github.com:rodrigc/jenkins 2014-10-29 22:34:25 -04:00
Kohsuke Kawaguchi 47b8d961ae merged back the RC branch 2014-10-29 18:46:04 -07:00
Jesse Glick a6204318f8 Merge branch 'master' of github.com:n-nachiappan/jenkins 2014-10-29 18:35:45 -04:00
Jesse Glick 5976b3840a Merge branch 'custom-workspace' of github.com:mattmoor/jenkins 2014-10-29 18:07:48 -04:00
Matt Moore 207bf23884 Adjust my prior change to better utilize structured form submission to accomodate a few plugins that are improperly submitting data through this processing logic 2014-10-29 14:15:02 -07:00
Craig Rodrigues c577fffe43 Use a jna Union type for the DUMMYUNIONNAME union structure 
JNAerator ( https://code.google.com/p/jnaerator/ ) was helpful
for generating the Java code from the C struct.
 2014-10-29 12:34:47 -07:00
Stephen Connolly 86ea65ab6f Make it possible for sub-classes to have a sub-class specific trust anchor chain 2014-10-29 16:55:41 +00:00
Craig Rodrigues f3e9d5d681 [FIXED JENKINS-25358] Remove extra fields from getFieldOrder() 
Remove fields which are not part of struct _SHELLEXECUTEINFO.
 2014-10-29 09:52:59 -07:00
Jesse Glick 4cb7414e90 fromExternalizableId should just return null, not throw IAE, if the job has since been renamed/move/deleted. 
(It could already return null if the run has since been deleted; #1264 failed to mark this properly.)
Reserving IAE for inputs that getExternalizableId could not actually have produced,
and making sure to also throw this in case of non-numeric text after the hash.
Adding Javadoc for both methods.
 2014-10-28 11:23:03 -07:00
Jesse Glick c589392dca Merge branch 'SECURITY-144' into SECURITY-144-rc 2014-10-28 11:20:29 -04:00
Jesse Glick 8c10c75d85 Merge branch 'security-rc' into SECURITY-144-rc 2014-10-28 11:20:25 -04:00
Stephen Connolly 07fb00e05a If you are synchronizing on something to access a volatile, then you are doing something wrong 
- Yet more interrupting bad patterns, especially where we expect the node monitor to take up to 30 seconds to complete if an async variety
 2014-10-28 13:48:00 +00:00
Stephen Connolly 68f6222633 Prevent a storm of node monitor updates when there is a storm of nodes coming on line within 1 second 
- The old code would result in multiple triggered updates, with corresponding interrupts of in-progress updates
  when faced with lots of slaves coming on line within 1 second of each other.

- New code will ensure that one and only one of the scheduled tasks (i.e. the last one) will trigger the updates.
 2014-10-28 13:27:24 +00:00
Stephen Connolly 1587511c55 fix @since tags 2014-10-28 13:27:03 +00:00
Stephen Connolly bf2206d783 Merge pull request #1433 from stephenc/master 
Refactor NodeProvisioner to allow for extension of strategies
 2014-10-28 13:21:56 +00:00
Kohsuke Kawaguchi 9a108de405 These permissions should be RUN_SCRIPTS 
... as it grants access to the JVM internals of the master in the same
Groovy scripts do.
 2014-10-27 15:39:46 -07:00
Jesse Glick 0434a2ac4a readFromOffset needed to be adjusted too. 2014-10-26 15:47:47 -07:00