* [JENKINS-36720]: Fixed Spotbugs issues WMI_WRONG_MAP_ITERATOR and OS_OPEN_STREAM in core
* merged try with resources with try finally
* reverted auto format from IDE
* reverted auto format from IDE
* use Util.fileToPath() as suggested to remove catch block
* merged try statements
* merged try statements
* reverted some whitespace fixes
* reverted another whitespace fix
* Apply suggestions from code review
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
* reverted change
* reverted change
* reverted change
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
* JENKINS-60513: Added AtomicInteger to whitelist
* JENKINS-60513: Mark field as transient
* reverted whitelist change
* renamed field to support deserialization of ols values
* [JENKINS-60351] It should be possible to disable a retry of the
PathRemover
This does not address the issues that the comments and code in
hudons.Util are inconsistent if they are for retries or total number of
attempts (they are currently total number of attempts)
* [JENKINS-60351] Make the code conform to the documentation
maxRetries should control the number of retries not the number of
attempts.
* rename field from DELETION_MAX to DELETION_RETRIES
This fixes a regression introduced in SECURITY-901 where performing an authentication check on another user while logged in caused the user to get logged out.
Signed-off-by: Matt Sicker <boards@gmail.com>
* replaced integer with AtomicInteger to fix spotbugs issue
* added @Restricted to prevent further usage
* replaced volatile with final because of AtomicInteger usage
* implemented a getter and an increment method
* fixed typeo in javadoc
* [JENKINS-59656] when stopping a Run via the executors widget, make sure it's the intended one
* [JENKINS-59656] added Executor.stopBuild(String) instead of .stop(String)
* revert change to deprecated doStop(StaplerRequest,StaplerResponse), useless now that it's doStopBuild(String) which takes a runExtId parameter
* javadoc: "@since TODO" rather than "@since 2.???"
* [JENKINS-59656] added test case
* jelly cleanup with h.urlEncode(String)
* make Functions.urlEncode(null) return empty String
* Executor.doStopBuild(runExtId): ignore runExtId if executable is not a Run
* Executor.doStopBuild(runExtId) doesn't have to be a public API
* set HttpOnly flag to prevent cookie read by a malicious script in browser
* Update core/src/main/java/hudson/Functions.java
Co-Authored-By: Wadeck Follonier <Wadeck@users.noreply.github.com>
Add StandardOpenOption.CREATE flag to create FileChannelWriter to avoid full fs flush and 5sec log operation on creating empty file with CephFS as a storage
* Hide password form fields by default
* Trying to bypass enforced autocompletion by just having a test field at first
Something like onfocus didn't work, you'd tab through form elements
and unless you filled in the user name, changing the form field to
password would cause it to autocomplete.
It looks like, at least in Mac/Firefox, going from plain text to password
in the 'oninput' event handler works. The plain text is revealed neither
with typing nor pasting.
* Update core/src/main/resources/lib/form/password.jelly
Co-Authored-By: daniel-beck <daniel-beck@users.noreply.github.com>
* Use previously defined value
* Make new password form fields opt-out
* Add support for redacting form secrets in new password field
* Have a password value pre-set in Jelly
* Fix method
* Fix test by clicking on the button to change the password
* Forgot period separator between class and property name
This exception occurs while defining a view using job DSL:
SEVERE jenkins.InitReactorRunner$1#onTaskFailed: Failed ConfigurationAsCode.init
java.lang.ArrayIndexOutOfBoundsException: 0
at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:388)
at java.util.concurrent.CopyOnWriteArrayList.get(CopyOnWriteArrayList.java:397)
at hudson.model.ViewGroupMixIn.getPrimaryView(ViewGroupMixIn.java:172)
at hudson.model.ViewGroupMixIn.getView(ViewGroupMixIn.java:134)
at jenkins.model.Jenkins.getView(Jenkins.java:1834)
at javaposse.jobdsl.plugin.JenkinsJobManagement.createOrUpdateView(JenkinsJobManagement.java:175)
at javaposse.jobdsl.dsl.JobManagement$createOrUpdateView$2.call(Unknown Source)
at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:141)
at javaposse.jobdsl.dsl.AbstractDslScriptLoader$_extractGeneratedViews_closure5.doCall(AbstractDslScriptLoader.groovy:216)
* IntelliJ/Java: Duplicate code -- Refactored as DOSToUnixPathHelper.validate
* Change DOSToUnixPathHelper from validate() to iteratePath()
* Refactor DOSToUnixPathHelper checkPrefix
* mark DOSToUnixPathHelper as NoExternalUse
* Do not tempt fate
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
* [JENKINS-59886] Strengthen the queue to avoid canTake and canRun implementers hanging it
* [JENKINS-59886] Messages on iso-8859-1
* [JENKINS-59886] Messages on iso-8859-1
* [JENKINS-59886] lower case on properties
* [JENKINS-59886] trailing empty blanks
* [JENKINS-59886] Double single-quotes
* [JENKINS-59886] Don't sleep in the loop maintaining the queue
* [JENKINS-59886] Add class suffix, wait to just the start of the build
* [JENKINS-59886] Assert clearly there is only one job in the queue
* [JENKINS-59886] Uncomment fix
* [JENKINS-59886] Remove old comment
* [JENKINS-59886] Remove log messages from property files
* [JENKINS-59886] Remove UTF8 characters from es messages
Stefan Spieker