1) in onblur handler, simply restore old form.onsubmit rather than adding
another wrapper to call the old handler (which can result in a deep call
stack if several comboboxes are used prior to form submission).
2) in onsubmit handler when focused, only call the original onsubmit when
the dropdown is not showing (ie don't call it when we intercept the submit
to just select an item from the list and return false)
I didn't figure out exactly why, but the current code could result in the
original form.onsubmit handler not being called on form submission when
multiple comboboxes are used. This simplification seems to resolve the issue.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29149 71c3de6d-444a-0410-be80-ed276b4c234a
This is done by uniquifying groups of radiobutton names using Behavior rules,
then converting back to original names before form submission in buildFormTree.
Added some unit tests for f:repeatable, covering basic usage, minimum parameter,
simple radio buttons and f:radioBlock.
Fixed handling of minimum parameter in f:repeatable, since the new test failed :-)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29065 71c3de6d-444a-0410-be80-ed276b4c234a
takes more than 100ms. (mousedown on item makes text field lose focus, which
does a setTimeout to hide dropdown after 100ms.. it mouseup doesn't happen
before this, onclick is never triggered. Now using onmousedown to immediately
trigger select of item)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28703 71c3de6d-444a-0410-be80-ed276b4c234a
and initialize via hudson-behavior rules. Now f:editableComboBox works in
repeatable content such as a build step (or any f:hetero-list or f:repeatable).
createComboBox still accepts an ID parameter for compatibility, but this form
is now deprecated.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28338 71c3de6d-444a-0410-be80-ed276b4c234a
Merged revisions 27137,27564,27566-27567,27578,27586,27599,27603,27606-27609,27611,27616,27626-27632,27640,27654-27656,27687,27701,27801,27816,27819,27843-27845,28087,28158-28161 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/HUDSON-2137
........
r27137 | kohsuke | 2010-02-08 08:46:16 -0800 (Mon, 08 Feb 2010) | 1 line
experimenting with abstractions
........
r27564 | kohsuke | 2010-02-16 07:58:26 -0800 (Tue, 16 Feb 2010) | 1 line
bundling makes it easier for caller to handle ConsoleAnnotator
........
r27566 | kohsuke | 2010-02-16 08:49:48 -0800 (Tue, 16 Feb 2010) | 1 line
this should work with Runs, not AbstractBuilds
........
r27567 | kohsuke | 2010-02-16 08:54:06 -0800 (Tue, 16 Feb 2010) | 1 line
simplified
........
r27578 | kohsuke | 2010-02-16 12:26:11 -0800 (Tue, 16 Feb 2010) | 1 line
still a work in progress, but committing once to pull in trunk changes
........
r27586 | kohsuke | 2010-02-16 14:35:37 -0800 (Tue, 16 Feb 2010) | 1 line
making more progress
........
r27599 | kohsuke | 2010-02-16 19:22:01 -0800 (Tue, 16 Feb 2010) | 2 lines
hooking up the side that writes annotations.
still a work in progress.
........
r27603 | kohsuke | 2010-02-16 23:43:35 -0800 (Tue, 16 Feb 2010) | 3 lines
what appears to me as the first cut of hooking up the reader side of the annotations.
I haven't even run it yet --- this just passed the compilation, and I'm calling it a day.
........
r27606 | kohsuke | 2010-02-17 09:15:16 -0800 (Wed, 17 Feb 2010) | 1 line
demo instance hook up
........
r27607 | kohsuke | 2010-02-17 11:27:02 -0800 (Wed, 17 Feb 2010) | 3 lines
one more utility method.
I never understood what the point of letting the skip method skip less.
........
r27608 | kohsuke | 2010-02-17 11:56:23 -0800 (Wed, 17 Feb 2010) | 3 lines
- moved LargeText subtype to its own class
- skipping log output was done incorrectly --- it had to skip N bytes where it was skipping N chars.
- hooked up console annotations for completed builds.
........
r27609 | kohsuke | 2010-02-17 12:01:46 -0800 (Wed, 17 Feb 2010) | 1 line
copyright header
........
r27611 | kohsuke | 2010-02-17 13:18:10 -0800 (Wed, 17 Feb 2010) | 1 line
introduced a mechanism to register extension during an unit test.
........
r27616 | kohsuke | 2010-02-17 13:38:12 -0800 (Wed, 17 Feb 2010) | 1 line
test case for console annotations
........
r27626 | kohsuke | 2010-02-17 15:23:06 -0800 (Wed, 17 Feb 2010) | 1 line
removing test ConsoleAnnotator as I write tests as tests
........
r27627 | kohsuke | 2010-02-17 16:06:13 -0800 (Wed, 17 Feb 2010) | 1 line
added a multi-phase cooperative locking mechanism useful during the debugging
........
r27628 | kohsuke | 2010-02-17 16:06:41 -0800 (Wed, 17 Feb 2010) | 1 line
testing progressive log annotation
........
r27629 | kohsuke | 2010-02-17 16:20:32 -0800 (Wed, 17 Feb 2010) | 1 line
adding a test for ConsoleAnnotation that's explicitly placed.
........
r27630 | kohsuke | 2010-02-17 16:23:02 -0800 (Wed, 17 Feb 2010) | 1 line
removing test ConsoleAnnotation as I write tests as tests
........
r27631 | kohsuke | 2010-02-17 16:28:50 -0800 (Wed, 17 Feb 2010) | 1 line
tweaking the abstraction a bit.
........
r27632 | kohsuke | 2010-02-17 16:44:21 -0800 (Wed, 17 Feb 2010) | 1 line
parameterized the context type so that this can be used in places other than the build console output, such as polling logs, slave logs, and so on.
........
r27640 | kohsuke | 2010-02-17 17:27:52 -0800 (Wed, 17 Feb 2010) | 1 line
bug fix
........
r27654 | kohsuke | 2010-02-17 22:53:04 -0800 (Wed, 17 Feb 2010) | 1 line
doc improvement
........
r27655 | kohsuke | 2010-02-17 22:53:59 -0800 (Wed, 17 Feb 2010) | 1 line
doc improvement
........
r27656 | kohsuke | 2010-02-17 23:10:42 -0800 (Wed, 17 Feb 2010) | 1 line
test case for adjacent tags
........
r27687 | kohsuke | 2010-02-19 14:39:21 -0800 (Fri, 19 Feb 2010) | 1 line
introduced a facotry and descriptor. This allows them to define configuration pages, allow users to disable/enable them, plus define custom behaviors.
........
r27701 | kohsuke | 2010-02-19 18:23:52 -0800 (Fri, 19 Feb 2010) | 1 line
defining a mechanism for ConsoleAnnotatorFactory and ConsoleAnnotationDescriptor to define script.js and have them imported into the console output page
........
r27801 | kohsuke | 2010-02-22 11:59:16 -0800 (Mon, 22 Feb 2010) | 1 line
now embedding annotations inside the console output log file.
........
r27816 | kohsuke | 2010-02-22 15:45:04 -0800 (Mon, 22 Feb 2010) | 1 line
introduced a convenience method for unit tests
........
r27819 | kohsuke | 2010-02-22 17:37:05 -0800 (Mon, 22 Feb 2010) | 5 lines
As an example of using embedded console annotations, implementing Ant target invocation outlines.
It might be better to make the concept of outline more generally reusable, so that different kinds of outlines can be placed into the same container element for a single hierarchical representation.
Still a work in progress.
........
r27843 | kohsuke | 2010-02-23 16:12:13 -0800 (Tue, 23 Feb 2010) | 1 line
for now, disable this for production usage, until I work out a better UI.
........
r27844 | kohsuke | 2010-02-23 19:08:00 -0800 (Tue, 23 Feb 2010) | 1 line
started working on annotating exception.
........
r27845 | kohsuke | 2010-02-23 19:08:33 -0800 (Tue, 23 Feb 2010) | 1 line
more TODOs for myself
........
r28087 | kohsuke | 2010-03-01 10:03:55 -0800 (Mon, 01 Mar 2010) | 1 line
formatting changes
........
r28158 | kohsuke | 2010-03-02 17:00:00 -0800 (Tue, 02 Mar 2010) | 1 line
ConsoleAnnotation and ConsoleAnnotator are too confusing.
........
r28159 | kohsuke | 2010-03-02 17:02:02 -0800 (Tue, 02 Mar 2010) | 1 line
doc improvement
........
r28160 | kohsuke | 2010-03-02 17:05:14 -0800 (Tue, 02 Mar 2010) | 1 line
more doc improvements.
........
r28161 | kohsuke | 2010-03-02 17:11:59 -0800 (Tue, 02 Mar 2010) | 1 line
more doc improvement
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28173 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r27681 | kohsuke | 2010-02-19 11:14:43 -0800 (Fri, 19 Feb 2010) | 3 lines
Allow nearby elements to include itself, and don't let the failure in the check URL evaluation kill of the entire JavaScript processing.
This problem is noticed with the findbugs plugin, which uses a field name as a parameter instead of the 'value' parameter name.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27682 71c3de6d-444a-0410-be80-ed276b4c234a
https://svn.dev.java.net/svn/hudson/branches/rc
........
r27147 | kohsuke | 2010-02-08 11:10:47 -0800 (Mon, 08 Feb 2010) | 1 line
[FIXED HUDSON-5536] in 1.345 and added a test case.
........
r27149 | kohsuke | 2010-02-08 12:01:18 -0800 (Mon, 08 Feb 2010) | 1 line
added a backward compatibility measure to expose variables in both forms
........
r27150 | kohsuke | 2010-02-08 12:02:19 -0800 (Mon, 08 Feb 2010) | 1 line
forgot to commit this(?)
........
r27151 | kohsuke | 2010-02-08 12:24:51 -0800 (Mon, 08 Feb 2010) | 1 line
[maven-release-plugin] prepare release hudson-1_345
........
r27153 | kohsuke | 2010-02-08 12:25:04 -0800 (Mon, 08 Feb 2010) | 1 line
[maven-release-plugin] prepare for next development iteration
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27154 71c3de6d-444a-0410-be80-ed276b4c234a
https://www.dev.java.net/svn/hudson/branches/multiple-update-sources
........
r23183 | abayer | 2009-10-25 11:53:17 -0700 (Sun, 25 Oct 2009) | 1 line
First chunk of work towards supporting multiple update centers - infrastructure in place for it, and default update center treated as only one of multiple - have to use slightly modified update-center.json though
........
r23185 | abayer | 2009-10-25 12:25:49 -0700 (Sun, 25 Oct 2009) | 1 line
a number of tweaks - among other things, now works properly with additional update centers defined in hudson.model.UpdateCenter.xml - try using http://andrewbayer.com/images/hello-world/helloWorld-update-center.json as second update center
........
r23245 | abayer | 2009-10-27 13:45:25 -0700 (Tue, 27 Oct 2009) | 1 line
Modified to support existing default update-center.json
........
r23256 | kohsuke | 2009-10-27 18:30:15 -0700 (Tue, 27 Oct 2009) | 7 lines
- moved data binding of update-center.json to UpdateSource.
- moved some of the UpdateSource property into JSON, to improve the user experience when adding an update source.
the user should just type in one URL, and everything else should happen automatically.
- it doesn't make sense for UpdateSource to rely on UpdateCenterConfiguration, since behaviors cannot be
modified per UpdateSource basis. Instead, leaving it in UpdateCenter allows us to maintain backward compatible
behaviors with the existing custom UpdateCenterConfiguration implementation.
........
r23266 | kohsuke | 2009-10-27 19:29:24 -0700 (Tue, 27 Oct 2009) | 1 line
serve id inside JSON.
........
r23279 | kohsuke | 2009-10-28 10:44:00 -0700 (Wed, 28 Oct 2009) | 1 line
Do not special-case "default" ID. Receive hudson.war updates from wherever that provides one.
........
r23280 | kohsuke | 2009-10-28 10:50:57 -0700 (Wed, 28 Oct 2009) | 1 line
formatting change.
........
r23281 | kohsuke | 2009-10-28 11:30:40 -0700 (Wed, 28 Oct 2009) | 1 line
typo
........
r23282 | kohsuke | 2009-10-28 11:45:06 -0700 (Wed, 28 Oct 2009) | 2 lines
- added the UI to remove sites.
- persistence of UpdateSource happens more automatically now.
........
r23283 | kohsuke | 2009-10-28 11:50:04 -0700 (Wed, 28 Oct 2009) | 1 line
UpdateSource -> UpdateSite to align terminology with Eclipse.
........
r23284 | kohsuke | 2009-10-28 11:55:03 -0700 (Wed, 28 Oct 2009) | 5 lines
Actually, for now, just having a programmatic modification to UpdateSite would satisfy the primary use case.
And I'd like to upgrade YUI to a more recent version so that we can use its DataTable for UI. Plus the single update center model encourages the community to bring the code into the Hudson project, which is something we'd like to keep.
So all in all, I'm postponing the UI work.
........
r23286 | kohsuke | 2009-10-28 13:07:19 -0700 (Wed, 28 Oct 2009) | 1 line
Renaming and bug fixes.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23326 71c3de6d-444a-0410-be80-ed276b4c234a
to encodeURIComponent(this.value). Escape is not sufficient, as it does not
encode +. Function encode() in hudson-behavior.js is ok, but we can just use
a standard javascript function instead.
Marked encode() as deprecated.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21546 71c3de6d-444a-0410-be80-ed276b4c234a
Added support for multiple client-side validators (class="required number"),
and for checkMessage=".." attribute to override default error message.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21538 71c3de6d-444a-0410-be80-ed276b4c234a
hudson-behavior.js.
- Default crumb descriptor no longer presents any configuration UI. If a user
wants to change the crumb field name, that is now done through a system
property, hudson.security.csrf.requestfield.
- Default crumb issuer uses the Hudson secret key as the salt, so this no longer
needs to be a configuration option.
- layout.jelly initializes a crumb structure in hudson-behavior.js so that
Javascript functions can have access to this information without need it
passed in by the caller.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18856 71c3de6d-444a-0410-be80-ed276b4c234a
In function createComboBox, javascript errors will be thrown if the
id is not present on the page (which seems to happen sometimes when the
id in question is in an optionalBlock). This patch checks for the id
before trying to create the combo box.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18647 71c3de6d-444a-0410-be80-ed276b4c234a
Adding ToolInstaller.preferredLocation and using from existing installers.
Validating ToolInstallation.home if it is configured, but OK if blank.
Hacking JavaScript to display ToolInstallation.home field in UI
only if "Install automatically" unchecked (or field is not blank).
Simplifying parameters of DownloadFromUrlInstaller.isUpToDate.
chmod a+x after DownloadFromUrlInstaller unpacks (needed for Ant/Maven installations on Unix).
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18572 71c3de6d-444a-0410-be80-ed276b4c234a
https://www.dev.java.net/svn/hudson/branches/tool-autoinstallation
........
r17324 | jglick | 2009-04-20 18:24:32 -0700 (Mon, 20 Apr 2009) | 2 lines
Defensive cloning and Javadoc corrections.
(Though it seems no one is using the default impls of these methods yet anyway.)
........
r17325 | jglick | 2009-04-20 18:29:06 -0700 (Mon, 20 Apr 2009) | 1 line
Deprecation of delegate method is intentional.
........
r17428 | jglick | 2009-04-23 08:07:14 -0700 (Thu, 23 Apr 2009) | 1 line
Noting ToolLocationTranslator more prominently.
........
r17430 | jglick | 2009-04-23 09:16:40 -0700 (Thu, 23 Apr 2009) | 1 line
Unused imports.
........
r17473 | jglick | 2009-04-23 19:21:11 -0700 (Thu, 23 Apr 2009) | 1 line
Allow Plugin.configure to see the StaplerRequest, needed for some kinds of calls.
........
r17474 | jglick | 2009-04-23 19:25:54 -0700 (Thu, 23 Apr 2009) | 3 lines
Initial sketch of plugin to manage tool installations across slaves.
(Should really be under ../plugins/ but that was not branched, so putting here for the moment.)
........
r17475 | jglick | 2009-04-23 20:29:36 -0700 (Thu, 23 Apr 2009) | 1 line
Typo in Javadoc.
........
r17481 | jglick | 2009-04-23 22:46:26 -0700 (Thu, 23 Apr 2009) | 1 line
Unzip of an unbuffered stream is painfully slow.
........
r17482 | jglick | 2009-04-23 22:48:01 -0700 (Thu, 23 Apr 2009) | 1 line
ZIP-based tool installer now functional.
........
r17555 | jglick | 2009-04-27 17:50:38 -0700 (Mon, 27 Apr 2009) | 1 line
Build against newest trunk.
........
r17556 | jglick | 2009-04-27 18:38:28 -0700 (Mon, 27 Apr 2009) | 1 line
Adding help.
........
r17557 | jglick | 2009-04-27 18:57:46 -0700 (Mon, 27 Apr 2009) | 1 line
Moving toolName & label config GUI into generic files.
........
r17558 | jglick | 2009-04-27 19:37:30 -0700 (Mon, 27 Apr 2009) | 1 line
Typo.
........
r17559 | jglick | 2009-04-27 20:07:47 -0700 (Mon, 27 Apr 2009) | 1 line
Second tool installer type based on a freeform command.
........
r17560 | jglick | 2009-04-27 20:24:36 -0700 (Mon, 27 Apr 2009) | 1 line
installIfNecessaryFrom will now just return false in case the target dir exists but the URL cannot be opened.
........
r17561 | jglick | 2009-04-27 20:25:22 -0700 (Mon, 27 Apr 2009) | 2 lines
chmod only if something was actually installed.
Use a+x, not o+x.
........
r17562 | jglick | 2009-04-27 20:26:46 -0700 (Mon, 27 Apr 2009) | 1 line
Comment only.
........
r17563 | jglick | 2009-04-27 20:41:12 -0700 (Mon, 27 Apr 2009) | 1 line
I18N.
........
r17571 | jglick | 2009-04-28 08:15:31 -0700 (Tue, 28 Apr 2009) | 2 lines
Wiki link.
........
r17593 | jglick | 2009-04-28 15:38:33 -0700 (Tue, 28 Apr 2009) | 1 line
Turn off echo mode, it's just noise.
........
r17594 | jglick | 2009-04-28 15:39:29 -0700 (Tue, 28 Apr 2009) | 2 lines
Synchronizing access to installers for a given node/tool combo.
Sending log messages to Hudson log in real time.
........
r17595 | jglick | 2009-04-28 15:46:29 -0700 (Tue, 28 Apr 2009) | 1 line
Copyrights.
........
r17619 | jglick | 2009-04-29 06:25:23 -0700 (Wed, 29 Apr 2009) | 1 line
Improved Javadoc.
........
r17620 | jglick | 2009-04-29 06:51:11 -0700 (Wed, 29 Apr 2009) | 1 line
Demonstraing how to use DLJ to mechanically install official JDK releases on supported operating systems.
........
r17637 | kohsuke | 2009-04-30 16:15:24 -0700 (Thu, 30 Apr 2009) | 1 line
fixed what appears to be a C&P mistake
........
r17638 | kohsuke | 2009-04-30 16:16:21 -0700 (Thu, 30 Apr 2009) | 1 line
show YUI logger if YUI debugging mode is set.
........
r17639 | kohsuke | 2009-04-30 16:52:28 -0700 (Thu, 30 Apr 2009) | 7 lines
Fixed a UI script problem when <hetero-list> nests inside <repeatable>.
The cause of the problem was that the behavior for inner <hetero-list> kicks in first, altering HTML (by removing "prototypes"), before behavior for outer <repetable> kicks in and removes the master copy from DOM tree.
So <repeatable> ends up computing a master copy after some elements are removed, and hence when we try to reinsert them later by clicking "Add", it'll get incorrect copy, and re-execution of the <hetero-list> behavior bombs out.
I fixed this by skipping those HTML-altering behaviors if they show up in the part of DOM tree that's supposed to be snapshotted and removed.
........
r17640 | kohsuke | 2009-04-30 16:57:58 -0700 (Thu, 30 Apr 2009) | 7 lines
Added ToolProperty to ToolInstallation (which acts like NodeProperty to Node --- basically decorates the base object with additional properties.)
The original motivation is to implement ToolInstaller this way, if Jesse is OK. But decorating tools seem to have some other interesting use, such as a plugin for configuring $M2_HOME/conf/settings.xml, or a plugin to insert unlimited cryptography extension to JDK, or a plugin to add a few more jars into $ANT_HOME/lib.
For this to work, ToolInstallations that want properties needs to be modified to use a new constructor. For a starter, I modified the JDK class to do this.
I also took the opportunity to modernize JDK/config.jelly.
........
r17641 | kohsuke | 2009-04-30 17:02:04 -0700 (Thu, 30 Apr 2009) | 1 line
this appears to be a left-over from early days when we didn't have a means to do form validation
........
r17642 | kohsuke | 2009-04-30 17:02:35 -0700 (Thu, 30 Apr 2009) | 1 line
we don't need no.such.JDK but we need name. rebranching
........
r17643 | kohsuke | 2009-04-30 17:03:22 -0700 (Thu, 30 Apr 2009) | 1 line
rebranched from Hudson's configure.properties
........
r17644 | kohsuke | 2009-04-30 17:05:31 -0700 (Thu, 30 Apr 2009) | 1 line
removed unnecessary translations
........
r17656 | kohsuke | 2009-05-01 11:27:36 -0700 (Fri, 01 May 2009) | 1 line
Less hack for improved type safety. Asking people to write more code is not necessarily bad as long as what they need to do is obvious to them.
........
r17657 | kohsuke | 2009-05-01 12:07:20 -0700 (Fri, 01 May 2009) | 5 lines
The toolautoinst part of the change that corresponds to rev.17640.
ToolInstallers are now hooked under ToolInstallation through InstallSourceProperty as a ToolProperty.
This allows the relevant UIs to be shown in one place. Still pending Jesse's feedback. Making it a single commit to simplify a revert if necessary
........
r17663 | kohsuke | 2009-05-01 13:23:51 -0700 (Fri, 01 May 2009) | 1 line
doc improvement
........
r17664 | kohsuke | 2009-05-01 13:24:10 -0700 (Fri, 01 May 2009) | 1 line
needs this to allow Stapler to databind hetero-list automatically
........
r17665 | jglick | 2009-05-01 13:31:27 -0700 (Fri, 01 May 2009) | 1 line
Warnings.
........
r17667 | kohsuke | 2009-05-01 14:20:53 -0700 (Fri, 01 May 2009) | 1 line
added a method to do chmod
........
r17668 | kohsuke | 2009-05-01 14:30:35 -0700 (Fri, 01 May 2009) | 1 line
prefer JDK6 version to avoid unnecessary JNA loading
........
r17669 | kohsuke | 2009-05-01 14:33:09 -0700 (Fri, 01 May 2009) | 1 line
no, I must have confused this.
........
r17670 | kohsuke | 2009-05-01 15:57:11 -0700 (Fri, 01 May 2009) | 2 lines
- Automated JDK installer and its test.
- Minor update to the signature of ToolInstaller for supplying the expected default location.
........
r17730 | kohsuke | 2009-05-04 11:27:34 -0700 (Mon, 04 May 2009) | 1 line
avoid NPE as reported in HUDSON-3608
........
r17753 | jglick | 2009-05-04 19:34:08 -0700 (Mon, 04 May 2009) | 2 lines
Moved toolautoinst functionality into core.
........
r17755 | jglick | 2009-05-04 20:28:34 -0700 (Mon, 04 May 2009) | 8 lines
Added TaskListener parameter and IOException and InterruptedException to several methods:
Run.getEnvironment
NodeSpecific.forNode
ToolLocationTranslator.getToolHome
ToolLocationNodeProperty.getToolHome
ToolInstallation.translateFor
ProcessCache.Factory.getMavenInstallation
ProcessCache.Factory.getJava
........
r17756 | jglick | 2009-05-04 20:36:56 -0700 (Mon, 04 May 2009) | 1 line
expectedLocation was never strictly necessary, and will soon no longer be used even by JDKInstaller.
........
r17757 | jglick | 2009-05-04 20:40:41 -0700 (Mon, 04 May 2009) | 1 line
Not sure yet what @since should be.
........
r17758 | jglick | 2009-05-04 20:41:51 -0700 (Mon, 04 May 2009) | 1 line
getDefaultInstallers method added. Not yet in use.
........
r17763 | kohsuke | 2009-05-05 10:50:36 -0700 (Tue, 05 May 2009) | 1 line
deprecated redundant getJavaHome method
........
r17764 | kohsuke | 2009-05-05 12:10:45 -0700 (Tue, 05 May 2009) | 1 line
added general-purpose property defaulting mechanism, and added default tool installer for JDK
........
r17765 | jglick | 2009-05-05 12:35:56 -0700 (Tue, 05 May 2009) | 1 line
capitalize("") -> ""
........
r17766 | jglick | 2009-05-05 12:49:52 -0700 (Tue, 05 May 2009) | 1 line
Missing @since.
........
r17767 | jglick | 2009-05-05 13:01:41 -0700 (Tue, 05 May 2009) | 1 line
Unchecked warning.
........
r17768 | jglick | 2009-05-05 13:19:49 -0700 (Tue, 05 May 2009) | 2 lines
Two unsuccessful attempts at form validation.
........
r17770 | jglick | 2009-05-05 13:48:37 -0700 (Tue, 05 May 2009) | 1 line
Better class names.
........
r17771 | kohsuke | 2009-05-05 14:12:21 -0700 (Tue, 05 May 2009) | 5 lines
brought the form validation check back. The trick is to use the 'value' parameter.
In the end we'd expect this check to go away anyway, as we change input field to drop-down list, but in the mean time, this is why it didn't work.
Maybe we probably need more static code checkers? Like FindBugs rules?
........
r17901 | kohsuke | 2009-05-09 19:15:40 -0700 (Sat, 09 May 2009) | 1 line
having two toolHome is odd.
........
r17906 | kohsuke | 2009-05-10 11:09:13 -0700 (Sun, 10 May 2009) | 1 line
adding the generalization of UpdateCenter, but for compatibility reasons, we are leaving UpdateCenter as-is.
........
r17911 | kohsuke | 2009-05-10 17:02:53 -0700 (Sun, 10 May 2009) | 1 line
integrated json-lib with a bit of bug fix
........
r17912 | kohsuke | 2009-05-10 17:13:05 -0700 (Sun, 10 May 2009) | 1 line
JDK list is now fetched from hudson.dev.java.net
........
r17958 | kohsuke | 2009-05-11 13:44:25 -0700 (Mon, 11 May 2009) | 48 lines
Handle AbortException better to avoid error like this:
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Failed to delete directory: C:\files\hudson\workspace\hudson\hudson\main\remoting\target. Reason: Unable to delete file C:\files\hudson\workspace\hudson\hudson\main\remoting\target\remoting-1.304-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] For more information, run Maven with the -e switch
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31 seconds
[INFO] Finished at: Sun May 10 18:15:33 PDT 2009
[INFO] Final Memory: 25M/48M
[INFO] ------------------------------------------------------------------------
Recording fingerprints
Archiving artifacts
Recording test results
ERROR: Failed to archive JUnit reports
hudson.util.IOException2: remote file operation failed
at hudson.FilePath.act(FilePath.java:596)
at hudson.tasks.junit.JUnitResultArchiver.perform(JUnitResultArchiver.java:82)
at hudson.model.AbstractBuild$AbstractRunner.performAllBuildStep(AbstractBuild.java:372)
at hudson.model.AbstractBuild$AbstractRunner.performAllBuildStep(AbstractBuild.java:360)
at hudson.model.Build$RunnerImpl.post2(Build.java:183)
at hudson.model.AbstractBuild$AbstractRunner.post(AbstractBuild.java:345)
at hudson.model.Run.run(Run.java:943)
at hudson.model.Build.run(Build.java:112)
at hudson.model.ResourceController.execute(ResourceController.java:93)
at hudson.model.Executor.run(Executor.java:119)
Caused by: hudson.AbortException: Test reports were found but none of them are new. Did tests run?
For example, \files\hudson\workspace\hudson\hudson\main\core\target\surefire-reports\TEST-hudson.BulkChangeTest.xml is 2 days 23 hr old
at hudson.tasks.junit.TestResult.parse(TestResult.java:134)
at hudson.tasks.junit.TestResult.<init>(TestResult.java:95)
at hudson.tasks.junit.JUnitResultArchiver$1.invoke(JUnitResultArchiver.java:95)
at hudson.tasks.junit.JUnitResultArchiver$1.invoke(JUnitResultArchiver.java:82)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:1583)
at hudson.remoting.UserRequest.perform(UserRequest.java:92)
at hudson.remoting.UserRequest.perform(UserRequest.java:46)
at hudson.remoting.Request$2.run(Request.java:236)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
........
r17961 | kohsuke | 2009-05-11 15:16:39 -0700 (Mon, 11 May 2009) | 1 line
adding Windows JDK silent installation
........
r17962 | kohsuke | 2009-05-11 16:08:13 -0700 (Mon, 11 May 2009) | 1 line
Fixing JDK offline installatino for Windows
........
r17970 | kohsuke | 2009-05-11 19:37:59 -0700 (Mon, 11 May 2009) | 1 line
Fixing a problem that prevents the usage of this tag in <repeatable> block, which reinserts the same fragment over and over. So statically assigning IDs won't work
........
r17971 | kohsuke | 2009-05-11 22:17:09 -0700 (Mon, 11 May 2009) | 1 line
continuing to remove static ID generation, which breaks the tag when used inside <repetable> tag.
........
r17972 | kohsuke | 2009-05-11 22:19:11 -0700 (Mon, 11 May 2009) | 1 line
I don't know when this started, but even in the hudson-dev:run mode, the versionis no longer '?', so we need a different way to force reload
........
r17973 | kohsuke | 2009-05-11 22:26:34 -0700 (Mon, 11 May 2009) | 1 line
adjusted the text a bit since multiple "add" and "delete"s were rather confusing
........
r17974 | kohsuke | 2009-05-11 22:31:58 -0700 (Mon, 11 May 2009) | 1 line
added help screen
........
r17975 | kohsuke | 2009-05-11 22:41:39 -0700 (Mon, 11 May 2009) | 1 line
form validation now works against the checkbox, too
........
r17976 | kohsuke | 2009-05-11 22:43:00 -0700 (Mon, 11 May 2009) | 1 line
with auto installation, we expect users to specify a directory that doesn't exist yet, so don't report it as an error
........
r17977 | kohsuke | 2009-05-11 22:43:24 -0700 (Mon, 11 May 2009) | 1 line
improving the text
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17985 71c3de6d-444a-0410-be80-ed276b4c234a
https://www.dev.java.net/svn/hudson/branches/rc
........
r16638 | kohsuke | 2009-03-27 19:13:03 -0700 (Fri, 27 Mar 2009) | 1 line
[maven-release-plugin] prepare release hudson-1_294
........
r16644 | kohsuke | 2009-03-28 07:32:33 -0700 (Sat, 28 Mar 2009) | 1 line
[maven-release-plugin] prepare for next development iteration
........
r16652 | kohsuke | 2009-03-28 14:42:44 -0700 (Sat, 28 Mar 2009) | 1 line
updated changelog as a part of the release
........
r16719 | kohsuke | 2009-03-30 10:46:40 -0700 (Mon, 30 Mar 2009) | 3 lines
[HUDSON-3382] The race condition in the boolean flag prevents form validations from kicking in during unit tests, causing regressions to ship unnoticed.
Switched from a boolean to an integer so that the order of x=true / x=false won't matter.
........
r16720 | kohsuke | 2009-03-30 10:55:00 -0700 (Mon, 30 Mar 2009) | 1 line
[FIXED HUDSON-3382] NPE in .cvspass form validation. Will be in 1.295.
........
r16722 | kohsuke | 2009-03-30 13:31:17 -0700 (Mon, 30 Mar 2009) | 1 line
[HUDSON-3382] regression test. Make sure that the form validation failure gets detected.
........
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16725 71c3de6d-444a-0410-be80-ed276b4c234a
Quote:
A while back, I posted an AJAX-Style file upload demo. While using that technique in a current project, I discovered a bit of a bug. In FireFox, you can dynamically set the EncType of a form element to be "multipart/form-data" for file uploads; however, this does not work in Internet Explorer (IE). Apparently in IE, you have to set the "encoding" of the form rather than the "enctype". The good news is, you can set both values without concern and this will take care of the problem:
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15085 71c3de6d-444a-0410-be80-ed276b4c234a