Commit Graph
5413 Commits
Author SHA1 Message Date
mindless 34ccf95285 [HUDSON-4822] patch from lkishalmi to return after sending redirect in doLoginEntry
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23678 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 04:24:47 +00:00
mindless f73f51d2b4 Fix so disabled permissions are not shown in project-specific permission matrix
(EXTENDED_READ has been exposed there since 1.325 even w/o Extended-Read plugin
 to enable that permission)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23659 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 20:16:27 +00:00
kohsuke f055935603 Supported a relative path in the custom workspace directory, which resolves from FS root of the slave.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23656 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 19:20:15 +00:00
mindless 2fae128166 add missing checkPermission(CONFIGURE) to POST data to /job/{jobname}/config.xml
(was only checking EXTENDED_READ).  Added unit test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23652 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 04:25:05 +00:00
mindless 9d750356e1 [FIXED HUDSON-4588] catch NPE from TestResultAction constructor and report a nicer message
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23640 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 00:05:45 +00:00
mindless 65e9912c88 Mention the get/set job description api
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23638 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 23:12:20 +00:00
mindless ed5d70d191 [FIXED HUDSON-4573] Write log message and ignore unrecognized permissions when loading XML,
so these behave the same as other unknown fields (builders, publishers, etc).
Also changed context.convertAnother() calls to simpler reader.getValue()/writer.setValue()


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23637 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 22:43:38 +00:00
sogabe 90b1a5a3ac Updated japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23636 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 22:33:12 +00:00
mindless bc94c23868 Plugin manager now shows warning for upgrade/install of plugins
into a Hudson that is older than the plugin was built for.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23634 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 20:30:51 +00:00
mindless f3a13715a2 remove extra whitespace around Hudson version link
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23633 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 20:02:56 +00:00
mindless 4682a0e80d isUseProjectSecurity() was removed in 1.333 but was still referenced in jelly, so
"Enable project-based security" always comes up unchecked on configure pages and
project permissions are lost if not rechecked before clicking Save.
Now initialize checkbox with ${instance!=null} instead.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23630 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 17:35:10 +00:00
mindless 79f22cd661 Project read permission was not enforced via /jobCaseInsensitive/jobname path.
Added unit test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23629 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 07:08:14 +00:00
kohsuke 38da83339b [FIXED HUDSON-4802] in 1.334. The patch was slightly modified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23626 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:47:30 +00:00
kohsuke f8e2a28eb0 Seeing dead lock after the message:
Nov 9, 2009 1:46:11 PM hudson.remoting.Channel$ReaderThread run
SEVERE: I/O error in channel This side of the channel
java.io.IOException: Write end dead
	at java.io.PipedInputStream.read(PipedInputStream.java:294)
	at java.io.ObjectInputStream$PeekInputStream.peek(ObjectInputStream.java:2249)
	at java.io.ObjectInputStream$BlockDataInputStream.peek(ObjectInputStream.java:2542)
	at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2552)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1297)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:351)
	at hudson.remoting.Channel$ReaderThread.run(Channel.java:849)
Nov 9, 2009 1:46:11 PM hudson.remoting.Request$2 run
SEVERE: Failed to send back a reply
java.io.IOException: Read end dead
	at java.io.PipedInputStream.checkStateForReceive(PipedInputStream.java:246)
	at java.io.PipedInputStream.receive(PipedInputStream.java:210)
	at java.io.PipedOutputStream.write(PipedOutputStream.java:132)
	at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1838)
	at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1747)
	at java.io.ObjectOutputStream.writeNonProxyDesc(ObjectOutputStream.java:1249)
	at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:1203)
	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1387)
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150)
	at java.io.ObjectOutputStream.writeFatalException(ObjectOutputStream.java:1538)
	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329)
	at hudson.remoting.Channel.send(Channel.java:413)
	at hudson.remoting.Request$2.run(Request.java:282)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)



The thread dump indicates that the test thread is stuck at british.join(), because British channel reader thread is still alive. I remember PipedInput|OutputStream being not truly multi-thread aware, so changing it to our own version to see if that fixes the problem without my digging further.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23625 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:43:20 +00:00
kohsuke 80db087f64 added a bunch of CLI commands to Computer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23617 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 22:10:17 +00:00
kohsuke 846851344a doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23616 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 22:05:24 +00:00
mindless d4cb259440 [FIXED HUDSON-4784] translation from thosor
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23608 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 18:04:17 +00:00
mindless 14a37dba5b [FIXED HUDSON-4557] Moving consoleText handling from jelly to java in r20927
caused Content-Length header to no longer be written.  wget/curl seem ok with
this, but browsers display nothing for "view as plain text".
Stapler's DefaultScriptInvoker wraps the OutputStream in a filter to prevent
jelly from flushing the output; copied this into Run.doConsoleText and now
the Content-Length header gets written again, for both compressed/plain output.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23605 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 17:53:34 +00:00
mindless 36c1d4e0ac [HUDSON-4562] keep / in zip link if glob pattern is nonempty
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23603 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 17:35:42 +00:00
mindless 1e02c7c071 [FIXED HUDSON-4562] remove extra / in "all files in zip" links
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23571 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 18:40:01 +00:00
mindless 6ebcd2d97d [FIXED HUDSON-4765] Fix broken links for failed tests on MatrixBuild page.
Also removed extra slashes in links on MatrixTestResult page.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23569 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 17:44:44 +00:00
mindless 3963a49d2e add Manage Plugins link in sidepanel of UpdateCenter
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23568 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 15:37:13 +00:00
mindless 2b1a457f68 Deprecate util.StringConverter2 (extends deprecated XStream class,
but can't change it here to keep binary compatibility).
Add new HeapSpaceStringConverter to replace this.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23564 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 01:50:42 +00:00
kohsuke ebfa6a0e2d the test is still failing. adding more delay
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23556 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:51:39 +00:00
kohsuke 97711f3d3c it should be abstract since by itself it defines no test
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23555 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:50:19 +00:00
kohsuke d4f345f98e Maven picks up *Test, so renaming
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23554 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:49:57 +00:00
mindless 2be4e9691d Move ItemListener.onCreated notifiction from doCreateProject to createProject
and createProjectFromXML.  This add notification that was missing for project
creation from XML or CLI, and will catch anything else using Hudson.createProject
directly.  Added unit test for CLI case.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23553 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:12:48 +00:00
kohsuke bae8b35c8f refactored the commonality out
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23552 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 23:22:44 +00:00
kohsuke 8fcda35317 Future.cancel is asynchronous, so it can return before the process is actually killed
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23551 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 23:20:06 +00:00
kohsuke 461c315daa This is not the right place to do escaping, or else we see <h3> and <pre> looses the effect
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23549 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 22:47:00 +00:00
kohsuke 7816b82f10 Hudson on Hudson finds this test brittle, so changing the way the test works.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23547 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 22:27:05 +00:00
kohsuke b73f620e88 more test case
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23546 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 22:26:13 +00:00
kohsuke 61d341e21d assertNotSame would box them, so it won't achieve the intended test
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23545 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 22:14:43 +00:00
kohsuke 4c6319fe4f - CLI "build" command now supports passing parameters.
- introduced SimpleParameterDefinition to eliminate the common code

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23543 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 21:43:15 +00:00
kohsuke 51669e429d typo
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23530 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 19:25:13 +00:00
mindless 5f1c3fc878 after new job creation, remove view/{default-view} from redirect URL if created in default view
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23529 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:46:00 +00:00
jglick ebb5800937 Tweaking license text.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23528 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:39:49 +00:00
jglick 6ccad2bc32 [FIXED HUDSON-4611] hudson.proc.RemoteProc.kill() was a no-op.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23526 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:34:11 +00:00
jglick 01f8034b32 If a process sends data to stdout but no stdout is configured, an NPE can result.
Observed only inside a unit test, but makes sense to treat out symmetrically with err and in.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23525 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:32:49 +00:00
jglick 03842a08c9 If a process sends data to stdout but no stdout is configured, an NPE can result.
Observed only inside a unit test, but makes sense to treat out symmetrically with err and in.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23524 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:31:51 +00:00
sogabe b756b5a473 Japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23520 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 13:24:26 +00:00
mindless c9aa94fca9 [HUDSON-4784] move help about LDAP groups from global matrix help to a new
help button next to the Add user/group button.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23519 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 08:07:02 +00:00
mindless 373a33c3e2 [FIXED HUDSON-4580] Show "Latest Test Results" link even when a new build is running.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23510 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-05 23:28:32 +00:00
abayer 91bffe3b46 Adding SaveableListener, with calls to SaveableListener.fireOnChange in Saveable.save implementations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23502 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-05 16:11:47 +00:00
kohsuke c23e5ae206 List erases to List no matter what the type parameter is, so these two are unnecessary
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23490 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-05 00:41:54 +00:00
kohsuke 693734fe2d fixed a binary incompatibility introduced by rev.23326 due to the way generics/erasure works
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23489 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-05 00:39:46 +00:00
kohsuke b307fe14c2 Retry shouldn't kick in if the build is aborted during checkout.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23485 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-05 00:05:40 +00:00
mindless da4a8916ab tweak centering of first executor a bit (for mrooney)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23481 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-04 23:44:00 +00:00
kohsuke 6f4edfcbf5 this is more portable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23471 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-04 19:29:25 +00:00
mindless c825c2bbfd Check if jna-posix used a fallback java impl which does not support many operations.
If so, don't use posix in Util.createSymlink.
When posix IS used but fails, include errno in log.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23470 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-04 19:25:14 +00:00