Commit Graph
2295 Commits
Author SHA1 Message Date
kohsuke 3dab169a25 catch RuntimeException as well because onLoad fails unexpectedly some times. See HUDSON-1559
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9851 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 19:06:40 +00:00
kohsuke 6a7cbc8e2d typo
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9850 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 19:06:05 +00:00
kohsuke 23761ad689 [FIXED HUDSON-1782] Let Hudson try to auto-correct the error when the user assumes the wrong root for the relative path. This often happens because of the poor choice in the default location when multiple modules are checked out. In 1.222.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9840 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 18:42:21 +00:00
kohsuke cda73e9351 TAB -> WS in Hudson
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9832 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 18:33:01 +00:00
kohsuke 68c84ceeac permission check makes sense only in conjunction with a particular AccessControlled object.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9828 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 17:40:57 +00:00
kohsuke 9e62579d6c Removing the check permission.
For Hudson's system level configuration, form field validation is only used during the configuration, so it should be equal to ADMINISTER permission. IOW, there's no circumstance in Hudson where having the CHECK permission but not ADMINISTER permission is useful.

For project level configuration and things below, the permission needs to be checked against the lower-level object being configured (like Project), not Hudson. And in those cases, again the permission should equate to CONFIGURE.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9827 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 17:38:07 +00:00
kohsuke b2a1d808b0 [FIXED HUDSON-1773] needs to check Permission.impliedBy. In 1.222.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9826 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 17:27:52 +00:00
kohsuke 3143dcac44 clarifying the responsibility of the caller/callee
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9825 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 17:27:02 +00:00
kohsuke fe725b1316 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9824 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 17:25:31 +00:00
kohsuke cf7d70d465 applied a patch from Martin Ficker. See http://www.nabble.com/Patch-for-Buildorder-td17625563.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9821 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 15:59:35 +00:00
redsolo 7dbdd4729c [FIXED HUDSON-1793] JSONObject no longer is null in UserPropertyDecriptor.newInstance(StaplerRequest, JSONObject)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9819 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-04 14:40:58 +00:00
huybrechts 7618c62c06 fix single/multiple dispatch issue
getACL() should probably move from AbstractProject to Job

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9797 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-03 21:37:13 +00:00
huybrechts d6d7f24ee2 Allow project creation for logged in user with project based security
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9796 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-03 21:36:24 +00:00
kohsuke fe500bf9d8 permission check not required for all checks
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9795 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-03 21:14:10 +00:00
huybrechts 7a9cc3ea27 Issue #1778 - User implements AccessControlled, and requires app.ADMINISTER for now
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9794 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-03 20:50:11 +00:00
kohsuke 675050075b start building a debian package as a part of the release
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9773 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-03 03:31:38 +00:00
kohsuke 034250a109 [FIXED HUDSON-1773] for backward compatibility, the ADMINISTER right should imply the CHECK right. In 1.221.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9763 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-02 18:31:15 +00:00
kohsuke dc218a670d added buffering to the communication with Maven process.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9759 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-02 17:50:34 +00:00
kohsuke 0ba73fd97f too many plugins seem to depend on this. Resurrecting this.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9758 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-02 17:41:17 +00:00
kohsuke aef641827c [FIXED HUDSON-1767] no absolute URLs in HTML rendering. Fixed in1.221.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9755 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-02 16:50:59 +00:00
kohsuke b6ff565b0e doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9754 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-02 16:45:30 +00:00
kohsuke 8799016604 indentation fix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9753 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-02 16:41:31 +00:00
kohsuke 06131ad060 relaxing the rule further.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9725 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 23:25:15 +00:00
kohsuke 62a358f67d Look at the test suite name and timestamp to avoid recording the same test twice, but do so in a conservative way to avoid dropping the data. See
http://www.nabble.com/Problem-with-duplicate-build-execution-td17549182.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9723 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 22:58:39 +00:00
kohsuke a438aed630 [FIXED HUDSON-1750] The doConfigSubmit method already does the security check, and this is checking the wrong permission, too. In 1.220.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9718 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 21:21:41 +00:00
kohsuke 26d4e9c6df doc update
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9714 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 17:27:45 +00:00
kohsuke dcc34310ba "my projects" view is pointless if the user is not authenticated.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9713 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 17:27:20 +00:00
kohsuke 8a06e6a962 TAB -> WS
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9711 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 17:17:19 +00:00
kohsuke 442ee58775 documenting the new additions
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9710 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 17:16:41 +00:00
kohsuke 891f56e053 TAB -> WS in Hudson
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9709 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 17:15:41 +00:00
kohsuke 434c56af6b documenting this interface.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9708 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 17:14:59 +00:00
kohsuke f21fa55faf Merged revisions 8523-8525,8545-8556,8793,8803-8806,8858,9027-9028 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/tom

........
  r8523 | huybrechts | 2008-04-11 13:41:11 -0700 (Fri, 11 Apr 2008) | 1 line
  
  profile to build against current snapshot of hudson-core
........
  r8524 | huybrechts | 2008-04-11 14:42:58 -0700 (Fri, 11 Apr 2008) | 1 line
  
  [#710] project option to automatically delete the svn wc if it is locked
........
  r8525 | huybrechts | 2008-04-11 14:53:59 -0700 (Fri, 11 Apr 2008) | 1 line
  
  [#710] project option to automatically delete the svn wc if it is locked
........
  r8545 | huybrechts | 2008-04-12 04:17:46 -0700 (Sat, 12 Apr 2008) | 1 line
  
  profile to build against current snapshot of hudson-core
........
  r8546 | huybrechts | 2008-04-12 04:19:26 -0700 (Sat, 12 Apr 2008) | 1 line
  
  deleting IDE-specific files
........
  r8547 | huybrechts | 2008-04-12 06:31:32 -0700 (Sat, 12 Apr 2008) | 1 line
  
  added ignores
........
  r8548 | huybrechts | 2008-04-12 06:42:49 -0700 (Sat, 12 Apr 2008) | 4 lines
  
  Issue 1158
  - extended AuthorizationStrategy to provide ACLs for different types of objects
  - changed several object types to use these methods
  - changed jelly to check permissions (instead of using isAdmin check)
........
  r8549 | huybrechts | 2008-04-12 06:44:26 -0700 (Sat, 12 Apr 2008) | 1 line
  
  Issue 1110: use svn revision number in project-changes.jelly
........
  r8550 | huybrechts | 2008-04-12 06:46:18 -0700 (Sat, 12 Apr 2008) | 1 line
  
  Adding a 'My Projects' view which shows only projects the user has permission for
........
  r8551 | huybrechts | 2008-04-12 06:47:57 -0700 (Sat, 12 Apr 2008) | 1 line
  
  adding a user name resolver, like the MailAddressResolver
........
  r8552 | huybrechts | 2008-04-12 06:49:27 -0700 (Sat, 12 Apr 2008) | 1 line
  
  Adding jdom and cglib to the war, as a workaround for classloading issues
........
  r8553 | huybrechts | 2008-04-12 08:01:58 -0700 (Sat, 12 Apr 2008) | 1 line
  
  SFEE integration improvements, including links to project based security
........
  r8554 | huybrechts | 2008-04-12 08:27:17 -0700 (Sat, 12 Apr 2008) | 1 line
  
  wsdl for SFEE webservices
........
  r8555 | huybrechts | 2008-04-12 08:31:18 -0700 (Sat, 12 Apr 2008) | 1 line
  
  forgot some files...
........
  r8556 | huybrechts | 2008-04-12 08:34:31 -0700 (Sat, 12 Apr 2008) | 1 line
  
  an authorization strategy that provides project-based access control (not usable on its own)
........
  r8793 | huybrechts | 2008-04-22 14:39:57 -0700 (Tue, 22 Apr 2008) | 1 line
  
  [issue #1573] allow plugins to contribute ServletFilters
........
  r8803 | huybrechts | 2008-04-23 10:46:09 -0700 (Wed, 23 Apr 2008) | 1 line
  
  added ignores
........
  r8804 | huybrechts | 2008-04-23 10:52:11 -0700 (Wed, 23 Apr 2008) | 1 line
  
  added ignores
........
  r8805 | huybrechts | 2008-04-23 10:54:12 -0700 (Wed, 23 Apr 2008) | 1 line
  
  added ignores
........
  r8806 | huybrechts | 2008-04-23 10:59:13 -0700 (Wed, 23 Apr 2008) | 1 line
  
  Issue 1158
........
  r8858 | huybrechts | 2008-04-25 08:17:41 -0700 (Fri, 25 Apr 2008) | 1 line
  
  bugfixes
........
  r9027 | huybrechts | 2008-05-04 12:20:34 -0700 (Sun, 04 May 2008) | 1 line
  
  Issue 1158 - fixing permission checks in jelly
........
  r9028 | huybrechts | 2008-05-04 12:22:36 -0700 (Sun, 04 May 2008) | 1 line
  
  creating SFEE releases from Hudson
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9699 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-30 03:25:15 +00:00
kohsuke c3fa0f3964 report the stack trace, too
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9693 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-29 23:54:07 +00:00
kohsuke 7223cb3db2 noted when this was added
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9692 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-29 23:51:03 +00:00
kohsuke 80e78e1a08 adding the first cut of update center capability. UI needs to follow.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9691 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-29 23:50:36 +00:00
kohsuke 5b75f948b5 [FIXED HUDSON-984] Incorporated a patch from xlv@dev.java.net. Will be in 1.220.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9669 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-29 00:19:08 +00:00
kohsuke 013aa46039 more diagnostics
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9663 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-28 20:08:48 +00:00
kohsuke 1e668a1886 to trouble-shoot SVN credential issues, improving the logging.
See http://www.nabble.com/Problem-with-svn-credentials-td17501860.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9660 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-28 18:59:06 +00:00
kohsuke c2514895bd Switching to LargeText in stapler
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9657 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-28 17:30:25 +00:00
kohsuke a70958fdd2 noting the version in which this is deprecated.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9656 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-28 17:29:50 +00:00
kohsuke 2fa960b910 noting deprecated classes that are moved to Stapler to be reused with other webapps.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9655 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-28 17:26:23 +00:00
kohsuke 51b2e4bd17 Put URL in the error message as well
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9653 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-28 15:39:39 +00:00
frizbog f76fdaec10 Issue 1634. Changed failed authentication so try again link keeps track of where you were when you tried logging in, and the login link returns you to the top page if you click it while logging in.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9623 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-25 00:20:58 +00:00
kohsuke 32913046e2 [FIXED HUDSON-1672] Fixed NPE in fingerprinting. Will be in 1.219
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9617 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 21:34:57 +00:00
kohsuke f10090e2b8 [FIXED HDUSON-1648]
A debug code crept in. When Hudson's own user database is used, every user got the "admin" role.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9616 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 21:19:44 +00:00
kohsuke 704343f57e [FIXED HUDSON-1458] Fixed the mysterious JVM hang issue on Windows&Maven2.
I spent a good part of yesterday afternoon to track down this problem. I first attached Visual Studio to the hanging JVM. While I can see the JVM source code and Windows API symbols all right, I couldn't figure out how to relate back the code produced by JIT to its Java, so this made the debugging very hard.

What I observed was that Maven's main thread seems to be blocked in WaitForSingleObject kernel API, but I can't figure out what handle it's blocking on. This call appears to come directly from JIT-ed Java code.

The problem disappears if I enable Java debugger support, or if I attach jconsole. So this cannot be a plain Java-level deadlock.

So after that much work, I still coudldn't figure out the root cause.


But I took the advice from mriem@dev.ajva.net anyway, and modified the remoting to use a separate TCP socket, instead of stdin/stdout. This is useful anyway, because sometimes JVM writes out to stdout and that breaks the whole set up, which was one of the known issues.

This commit brings in this change, and in the limited testing so far, this appears to work. So let's hope that it fixes the problem once and for all.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9615 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 20:48:09 +00:00
kohsuke f70901a7c6 when the slave is offline, don't crap out.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9612 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 17:43:09 +00:00
kohsuke 38953b8869 [FIXED HUDSON-1589] Applied a patch from thepner.
My apologies for the delay in handling this.
This change will be in 1.219.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9609 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 15:18:57 +00:00
kohsuke 82a594f496 [FIXED HUDSON-1730] Tagged builds will get a badge, just like locked builds
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9605 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-23 06:22:01 +00:00
kohsuke d9840234a7 [FIXED HUDSON-1734] applied a patch from rfaber@dev.java.net. In 1.219
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9592 71c3de6d-444a-0410-be80-ed276b4c234a
2008-05-22 21:18:18 +00:00