Commit Graph
4366 Commits
Author SHA1 Message Date
mindless 48df625a44 [FIXED HUDSON-5769] Update to XStream 1.3.1-hudson-6 where I added
protected Converter createDefaultConverter().  This allows a subclass
to override the default converter (was hardcoded to ReflectionConverter)
which is also given to the constructor of a few other converters,
most notably ThrowableConverter.  Override this method in XStream2 to
provide a RobustReflectionConverter so missing fields in classes
extending Throwable are handled properly.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28141 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-02 18:55:42 +00:00
mindless c310b82692 use ImmutableTypesMapper that is already in the pipeline
instead of wrapping in a new one.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28102 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-02 01:12:30 +00:00
mindless f2a2b92a2f [FIXED HUDSON-5768] Avoid double decoding that broke deserialization of fields with
double underscore, by replacing XStream11XmlFriendlyMapper with a custom mapper that
only does "-" to "$" decoding that is needed for compatibility with old xml data
written by Hudson 1.105 or older.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28071 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-01 06:45:57 +00:00
sogabe 9615129098 i18n & l10n(ja) [LDAPSecurityRealm, PAMSecurityRealm]
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28051 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-28 14:15:28 +00:00
mindless b0fbd644c8 [FIXED HUDSON-5776] fix serialization problem with empty CopyOnWriteMap.Tree,
also add/update tests for CopyOnWriteMap and CopyOnWriteList.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28026 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-27 20:12:25 +00:00
wyukawa 33b63f8a06 Updated Japanese localization for slave
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28020 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-27 12:56:53 +00:00
kohsuke 0a6236c3f9 added a mechanism to fake a process execution.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27995 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-27 00:28:56 +00:00
kohsuke 787d843d3d perform path normalization to get rid of "." and ".." in the path.
Without it, FilePath.getParent() and File.getParent() doesn't work correctly.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27956 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-26 00:30:15 +00:00
mindless 439243f3ba Remove unused "labelSet" field (has always been private transient)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27955 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-26 00:21:31 +00:00
godin 0f98b4e4ce Minor comment
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27711 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-20 14:26:25 +00:00
kohsuke 80ab0acc8b Improved /etc/shadow permission checks.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27700 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-20 02:21:47 +00:00
kohsuke 54467adad8 Fixed a performance problem of the job/build top page when there are too many artifacts.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27686 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-19 21:32:22 +00:00
kohsuke a09979d6dc report unexpected problem during the polling to the polling log
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27665 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-18 23:45:40 +00:00
kohsuke d1382d5c1b Discussed a technique for better mail address resolution.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27624 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-17 23:06:48 +00:00
kohsuke 947c413190 [HUDSON-5403] adding more logging in MailAddressResolver to help us figure out what's going on.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27623 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-17 23:02:11 +00:00
mindless cb8fe5a683 For the first time, remove some old deprecated code.
All of these have been deprecated 2yr 4mo or more.
- Hudson.addListener(JobListener), Hudson.removeListener(JobListener)
- Entire listeners.JobListener class (replaced by ItemListener)
- One form of DirectoryBrowser constructor
- One form of Descriptor.configure() (with HttpServletRequest param)
- Descriptor.convert(Map) and 4 impls of this method,
  and code calling it in Descriptor.readResolve()
  (this code called save() whenever updating data, so there should be
   no remaining cases out there)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27597 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-17 02:19:08 +00:00
abayer 37183f4c86 [FIXED HUDSON-5651] Removing excess whitespace from MAVEN_OPTS
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27559 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-16 15:40:20 +00:00
kohsuke 1f055074b7 [FIXED HUDSON-5642] Under some circumstances, Hudson can incorrectly delete the temporary directory itself.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27539 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-16 01:53:10 +00:00
kohsuke 325d59e7cf doc wasn't complete
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27519 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-15 18:06:58 +00:00
kohsuke 36e1bd2e2a avoid confusion by using equals
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27518 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-15 18:06:05 +00:00
wyukawa 66b1d32dc1 i18n & l10n(ja) for Email Notification
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27472 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-14 09:00:12 +00:00
abayer fe7708e1f7 [FIXED HUDSON-5630]
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27457 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-13 15:00:30 +00:00
kohsuke 2676adca52 class initialization of Hudson is much more work than that of Util, so pushing these small utilities out to Util to reduce the overhead of remoting.
Plus it helps to keep Hudson.java smaller

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27448 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-13 01:30:56 +00:00
kohsuke cc2081f4a2 [FIXED HUDSON-5610] Improved the form validation mechanism to support multiple controls.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27436 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-12 22:05:44 +00:00
kohsuke 0f6dad0048 Use JSON to retrieve values to honor the scope
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27379 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-12 00:29:51 +00:00
kohsuke 2aeda6cc11 integrated a newer Jelly and Stapler that runs faster with less memory
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27308 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-11 02:35:09 +00:00
kohsuke f68ab9ca82 the poll method already handles necessary mutual exclusions
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27301 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-11 01:36:52 +00:00
mindless e605d071f1 [FIXED HUDSON-1375] Maven modules should not be buildable when the parent project is disabled
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27254 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-10 16:11:47 +00:00
mindless 4785ad36cb [FIXED HUDSON-2610] Escape username in URLs in case it contains special characters such as "#"
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27237 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-09 23:35:44 +00:00
mindless faffa3ad9f filter out some jelly internals from ${attrs} so they are not rendered in output
(f:textbox input tags have included attrs like nameAttr, valueAttr, ownerTag since r25876)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27233 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-09 22:43:14 +00:00
kohsuke 8bf35b2094 Merged revisions 27147,27149-27151,27153 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r27147 | kohsuke | 2010-02-08 11:10:47 -0800 (Mon, 08 Feb 2010) | 1 line
  
  [FIXED HUDSON-5536] in 1.345 and added a test case.
........
  r27149 | kohsuke | 2010-02-08 12:01:18 -0800 (Mon, 08 Feb 2010) | 1 line
  
  added a backward compatibility measure to expose variables in both forms
........
  r27150 | kohsuke | 2010-02-08 12:02:19 -0800 (Mon, 08 Feb 2010) | 1 line
  
  forgot to commit this(?)
........
  r27151 | kohsuke | 2010-02-08 12:24:51 -0800 (Mon, 08 Feb 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_345
........
  r27153 | kohsuke | 2010-02-08 12:25:04 -0800 (Mon, 08 Feb 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27154 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-08 20:28:39 +00:00
mindless 207f4c582e [HUDSON-5536] set text/plain content type in doPostBack response so browser won't
try to parse response (resulting in "no element found" in firefox error console).
Not the fix for 5536 itself, but nice to avoid js error after successful update.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27145 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-08 18:35:32 +00:00
kohsuke 3af3cc8e9b allow subtype to define visible Action out of SCMRevisionState
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27143 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-08 18:07:09 +00:00
mindless 043a67181a [FIXED HUDSON-5443] Fixes for sidepanel link for People.
Link to top level /people/ for AllView, otherwise to people for this view.
Hide link only for non-default, non-All view that would list no people.
Add heading on People page and a link to top level /people/ when appropriate.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27129 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-07 23:08:47 +00:00
kohsuke 04dcb87762 [FIXED HUDSON-2180] revised the design of polling to fix the problem.
See:

  - SCM.compareRemoteRevisionWith
  - SCM.calcRevisionsFromBuild
  - SCMRevisionState

for details. This feature was originally developed in a branch,
whose merge records are as follows:

------------------

Merged revisions 24271,27060,27065,27083-27084 via svnmerge from 
https://www.dev.java.net/svn/hudson/branches/HUDSON-2180/main

........
  r24271 | kohsuke | 2009-11-30 19:41:30 -0800 (Mon, 30 Nov 2009) | 1 line
  
  committing my work in progress
........
  r27060 | kohsuke | 2010-02-05 18:11:05 -0800 (Fri, 05 Feb 2010) | 7 lines
  
  Made SVNRevisionState non-comparable, since doing so and distinguishing
  significant/insignificant changes is rather involving work.
  
  So that's why I originally opted for the compareRemoteRevisionWith method approach
  of telling SCM upfront about what it's comparing the state with.
........
  r27065 | kohsuke | 2010-02-06 08:49:50 -0800 (Sat, 06 Feb 2010) | 1 line
  
  crucial bug fix
........
  r27083 | kohsuke | 2010-02-06 10:37:46 -0800 (Sat, 06 Feb 2010) | 1 line
  
  doc improvement
........
  r27084 | kohsuke | 2010-02-06 10:39:50 -0800 (Sat, 06 Feb 2010) | 1 line
  
  doc improvement
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27103 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-07 03:06:29 +00:00
mindless 1bd51f4b0f [FIXED HUDSON-5469] avoid NPE and show better error message if view type is missing
when creating a view (can be done by submitting form with enter key.. the OK button
is disabled)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27057 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-06 01:33:01 +00:00
kohsuke 819ab89dda Hudson wasn't properly streaming a large external build submission, which can result in OOME and unresponsiveness.
While investigating the sudden memory usage spike, I discovered that XMPP/MXParser doesn't have a capability of returning a long PCDATA as a series of events. Instead, it tries to buffer the whole thing and return it as a single string.
This obviously results in a horrible performance problem if the submission is large, as was the case.

Switching to StAX to prevent this problem. StAX API isn't a part of Java5, but we already bundle woodstox.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27042 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-05 18:45:28 +00:00
mindless 237b26daf3 Don't use raw request param in jelly path (allowing any jelly to be included)..
replace any / chars with _


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27004 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-04 20:52:33 +00:00
kohsuke fe1994a4ef [FIXED HUDSON-5210] fixed this problem in Hudson that doesn't require any configuration change in Jetty.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27002 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-04 03:12:15 +00:00
kohsuke 99ba5e7f59 call attention to config.jelly
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27001 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-04 02:30:40 +00:00
kohsuke a04320c09d exposed to the remote API
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26981 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-03 18:21:55 +00:00
kohsuke 19c57d03ac doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26980 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-03 18:17:38 +00:00
sogabe a25fda149b [FIXED HUDSON-5293] added equals() and hashcode() to Dependecy.class so that contains method can work correctly.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26798 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-31 09:32:00 +00:00
mindless aa79364f73 [FIXED HUDSON-3055] Show Hudson upgrade status on manage page instead of
offering same upgrade again.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26796 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-31 07:03:19 +00:00
kohsuke 6f3893c211 next release will be back to business as usual
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26766 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-30 02:58:00 +00:00
kohsuke 4fb6ad1f3f [FIXED HUDSON-5420] in 1.344 Password parameter on the disk should be encrypted.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26736 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-29 23:27:30 +00:00
kohsuke 7e1602415c Merged revisions 26724 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r26724 | kohsuke | 2010-01-29 12:03:11 -0800 (Fri, 29 Jan 2010) | 4 lines
  
  In tribute to Sun Microsystems and all my colleagues who had to go today.
  I hope the community would forgive me for doing this.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26728 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-29 20:21:41 +00:00
kohsuke 97c7060e98 Eliimnated a warning during a startup
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26718 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-29 19:30:52 +00:00
kohsuke 7c5453b63e making room for subtypes to tweak the behavior
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26669 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 22:41:31 +00:00
kohsuke 1b3c1f92fd [HUDSON-5391] Fixed the infamous Turkish bug.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26650 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 21:38:01 +00:00