Commit Graph
13375 Commits
Author SHA1 Message Date
Vincent Latombe 4ff3f04436 [JENKINS-63828] It is legal to have a CloudProvisioningListener not implementing canProvision
I got confused in
https://github.com/jenkinsci/jenkins/commit/3992a30efb1abf697cae8e02f9e81dd04b92b135
by Cloud#canProvision which was abstract vs.
CloudProvisioningListener#canProvision which wasn't and was returning
null.
2020-10-07 14:44:15 +02:00
Wadeck FollonierandJeff Thompson eb0876cdb9 [JENKINS-57484] Improving the scripting capacity for the API Tokens (#4027)
* [JENKINS-57484] Improving the scripting capacity for the API Tokens

* Modification after review

* Add `@Restricted` as proposed by Daniel

- Also remove some whitespace modifications that were not required

* Method already present, revert the annotation addition

* Adjustment after merge conflict + cleanup

- Nonnull to NonNull
- Immutable is illegal :(
- Mistake in WhoAmITest

* Adding revokeToken + unit test for scripting

* Adding comment for system property not set + recommendation about revocation

* Update core/src/main/java/jenkins/install/SetupWizard.java

Co-authored-by: Jeff Thompson <37345299+jeffret-b@users.noreply.github.com>

Co-authored-by: Jeff Thompson <37345299+jeffret-b@users.noreply.github.com>
2020-10-05 16:07:30 -06:00
Raihaan Shouhellandres0nance 5492c81800 Remove deadstore and use MessageDigest comparison (#4953)
Co-authored-by: res0nance <res0nance@users.noreply.github.com>
2020-10-05 12:29:57 +02:00
Raihaan Shouhellandres0nance c76d55a427 Improve performance of MyView (#4954)
Co-authored-by: res0nance <res0nance@users.noreply.github.com>
2020-10-05 12:29:39 +02:00
Vincent Latombe a75306f950 [JENKINS-63828] Fix expected signature for CloudProvisioningListener#canProvision (#4955)
* [JENKINS-63828] Fix expected signature for CloudProvisioningListener#canProvision

* Polish
2020-10-05 12:29:20 +02:00
A. JardandaHenryJard d7c230ce9a [JENKINS-63795] allow MANAGE to restart and safe-restart jenkins. (#4950)
* [JENKINS-63795] allow MANAGE to restart and safe-restart jenkins.

* Adding a Rule test to validate that only MANAGE and ADMIN can restart Jenkins.

Co-authored-by: aHenryJard <ajard@cloudbees.com>
2020-10-02 12:40:48 +02:00
Tasuku Nakagawa 8c6327f4c6 Refactoring CLIRegisterer (#4945)
* Refactoring CLIRegisterer

* Add printError method
2020-10-01 12:12:25 +02:00
Vincent LatombeandJesse Glick 3992a30efb Add CloudState to be passed to Cloud#provision and Cloud#canProvision methods. (#4922)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-09-25 21:34:05 +01:00
Andrei Neagu ded3192940 [JENKINS-50669] RingBufferLogHandler improvement (#4550) 2020-09-25 21:33:45 +01:00
Tim Van Holder 702bd3921c [JENKINS-46175] SimpleBuildStep/SimpleBuildWrapper without workspace (alternative approach) (#4829) 2020-09-22 09:52:07 +01:00
res0nance c431ccc9b4 Fix data migration and add a test 2020-09-21 17:22:42 +08:00
Tim Van Holder 35caaebd38 Fix JavaDoc error (#4941) 2020-09-21 07:56:40 +01:00
Pierre Beitz 28004e1501 [JENKINS-63682] The PluginServletFilter class should be final (#4934) 2020-09-19 13:07:05 +01:00
Tim Jacomb a0c9a06270 Merge pull request #4255 from jsoref/java-cleanup-ApiTokenProperty.checkPermission 2020-09-14 07:48:07 +01:00
Thomas de Grenier de LatourandRaihaan Shouhell 5b1dd72d9b [JENKINS-43889] Make sure Environments are always torn down (in AbstractBuild) (#4517)
Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2020-09-14 07:46:37 +01:00
Ramon Leon e3b17eff92 [JENKINS-63563] Avoid anonymous class warning for hudson.FilePath$2 (#4921) 2020-09-03 17:23:35 +02:00
Tim Jacomb 40916d7e26 JEP-224 GA system read permission (#4909) 2020-08-25 10:27:08 +01:00
Jesse Glick 49a0c54896 [JENKINS-63458] Abandoning attempt to preformat agent log records (#4912) 2020-08-25 10:26:38 +01:00
stellargo 9b0d18aba3 Expose fingerprint methods for plugins (#4888) 2020-08-12 16:09:21 +01:00
Daniel Beck 14398ae062 Merge remote-tracking branch 'jenkinsci-cert/security-master' into master 2020-08-12 15:39:36 +02:00
Jesse Glick 147e2efce7 [JENKINS-63082] SLAVE_LOG_HANDLER should avoid synch logging (#4886) 2020-08-11 21:17:23 +01:00
StefanSpieker c834ac74c4 Removed redundant suppressions (#4894) 2020-08-07 08:36:40 +01:00
StefanSpieker d611b6d10e Removed deprecated ProcessTreeKiller (#4874) 2020-08-07 08:35:06 +01:00
Zhenlei Huang 30e46ee8e0 [JENKINS-61687] Prevent concurrent build deletion (#4850) 2020-08-07 08:34:50 +01:00
Daniel Beck 6a3c6070bf Merge branch 'master' into security-master 2020-08-04 15:22:21 +02:00
Daniel BeckandDaniel Beck 9f3002d2bf Log expected and actual values for better UTF-8 decoding diagnosability (#4871)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-03 20:53:37 +02:00
stellargo 885c05cb43 [JENKINS-62757] Introduce fingerprint migration in External Storage API (#4825) 2020-08-01 08:34:44 +01:00
Daniel BeckandDaniel Beck 3ea9dc6b3a Do not block rendering of Manage Jenkins while waiting for UC data (#4881)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:34:18 +01:00
Daniel BeckandDaniel Beck c632f42f07 Update at-since Javadoc (#4877)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:33:48 +01:00
Daniel Beck 759fc31a8c Merge branch 'security-stable-2.235' into security-master 2020-07-29 11:11:18 +02:00
Daniel Beck 7343c039cd Merge branch 'security-stable-2.222' into security-stable-2.235 2020-07-29 11:10:29 +02:00
Daniel Beck 31a3e63760 Merge branch 'security-stable-2.204' into security-stable-2.222 2020-07-29 11:09:50 +02:00
Daniel Beck ef04fbddbd Merge branch 'security-stable-2.190' into security-stable-2.204 2020-07-29 11:09:09 +02:00
Daniel Beck 29c9a8fdea [SECURITY-1960] 2020-07-29 10:54:36 +02:00
Oleg Nenashev c8de5992b4 Merge pull request #4864 from daniel-beck/JENKINS-63168
[JENKINS-63168] Prevent NPE when calling CommandInterpreter#buildEnvVarsFilterRules
2020-07-23 21:57:53 +02:00
Daniel Beck 1c9b12bb19 [JENKINS-63168] Prevent NPE when calling CommandInterpreter#buildEnvVarsFilterRules 2020-07-22 20:53:56 +02:00
Jesse Glick 1ace38110e Use support-log-formatter from jetty:run 2020-07-21 10:56:53 -04:00
stellargo be28d586b5 [JENKINS-62755] Introduce Fingerprint Cleanup in External Storage API (#4817)
* Create new FingerprintCleanupThread

* Moved test to jenkins

* Add license

* Fix license

* Fix some tests

* Fix all tests

* Remove redundant imports

* Add documentation; add test

* Fix errors in fingerprintertest

* Remove default fingerprint cleanup implementation

* Remove override from execute

* Undo author deletion

* Remove redundant import

* Move fingerprint cleanup to storage

* Fix spacing

* Add new line

* Minor fixes

* Fix tests

* Add documentation

* Introduce fingerprint cleanup toggle

* Link cleanup config to thread

* Add file system cleanup

* Add test

* Introduce external fingerprint storage cleanup tests

* Remove redundant statements

* Fix test

* Improve docstring

* Introduce shouldNotCleanFingerprintsWhenDisabled test

* Fix default cleanup value

* Minor fixes

* Enabled->Disabled

* Fix tests

* get -> is
2020-07-21 06:20:47 +02:00
0134fb11a8 [JENKINS-62014] Add build step environment filters (#4683)
Co-authored-by: Wadeck Follonier <wadeck.follonier@gmail.com>
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-07-19 09:24:00 +01:00
Félix QueirugaandTim Jacomb fb7f8903c3 [JENKINS-63002] Revamp tabs and bigtables (#4835)
Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
2020-07-19 09:23:25 +01:00
StefanSpiekerandOleg Nenashev 463cd113ba Minor refactorings either for performance or readability (#4845)
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-07-17 15:14:46 +01:00
stellargo 859f01f5ad [JENKINS-63022] Make Fingerprint Storage Engine configurable from the config page (#4834) 2020-07-17 15:14:08 +01:00
Tim Jacomb f7ae11e630 Merge pull request #4833 from Zastai/JENKINS-62723 2020-07-15 20:51:15 +01:00
55a523e34c [JENKINS-59136] Enable labels/categories with deprecated to show a warning for plugins (#4073)
* Enable labels/categories with `deprecated` to show a warning for plugins

* fix doc

* Wording

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

* Add Restricted no external use

* add since todo

* spelling

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* use stream api to collect deprecated plugins

* link to plugin url

* add break lines to deprecation message

* fix regex

* wording and separation of description

* Hide deprecated plugins inside the available section on update center

* Add a warning inside the installed section on plugin manager

* Add support for top-level 'deprecations' element in update site

* Add test

* Make this a list to allow direct element access

* This isn't a critical problem so go with warning style, rephrase label

* Add an intermediate JSON object in the UC data for extensibility

* Make 'deprecated' a meta label (not shown in the regular label list)

* Make parsing this safer

* Null safety with labels array

* Link to the deprecation URL, not the plugin URL

* Add issue reference

* Add Javadoc

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-07-15 20:50:20 +01:00
Oleg Nenashev c145928091 Merge pull request #4830 from jglick/StandardOutputSwapper-logging
An UnsatisfiedLinkError from StandardOutputSwapper.ChannelSwapper.swap need not be reported
2020-07-15 10:54:50 +02:00
Tim Jacomb ef325a615e Merge pull request #4841 from jglick/doCheckTimeZoneName-JENKINS-61806
[JENKINS-61806] Form validation for TimeZoneProperty.timeZoneName
2020-07-14 08:00:55 +01:00
Oleg Nenashev 116d400356 Merge pull request #4823 from NextTurn/installer
Stop supporting .NET Framework 2.0 + Update Windows Service Wrapper from 2.3.0 to 2.9.0
2020-07-12 13:36:46 +02:00
Jesse Glick 6d6129d698 [JENKINS-61806] Form validation for TimeZoneProperty.timeZoneName 2020-07-10 11:28:15 -04:00
Daniel Beck 1610ba042e Add Javadoc 2020-07-10 15:35:22 +02:00
Tim Jacomb 4e5d74329d Merge pull request #4838 from jeffret-b/removeLoadBeans
Remove BeanBuilder.loadBeans(String)
2020-07-10 07:54:39 +01:00