Commit Graph
4522 Commits
Author SHA1 Message Date
jglick 554f1c0fa0 testLocate failed in continuous build; at least make it fail with a meaningful message.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30976 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-12 22:18:04 +00:00
mindless da236bad5e Support "optional=true" parameter for @Extension to logging exceptions at FINE
level (instead of WARNING) for any class loading problems reading the extension.
Also move up to sezpoz 1.7 and remove catch block for LinkageError in
ExtensionFinder.. sezpoz should now throw only InstantiationException.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30963 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-12 19:44:08 +00:00
kohsuke 9b2d10993c fail the build in case of an uncaught exception.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30956 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-12 00:23:44 +00:00
mindless ed81cd5f54 [FIXED HUDSON-6494] fix FilePath.getParent() so parent of /foo is /
(not "."), and handle edge case so path with no parent ("/" or "abc")
returns null instead of getting IndexOutOfBoundsException.
(returning null is consistent with File.getParentFile())


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30917 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-11 17:04:38 +00:00
mindless e41e9c7964 [FIXED HUDSON-6476] Fix to handle usernames with colon character on Windows.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30882 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-10 20:53:18 +00:00
kohsuke 33f26e439a Hudson shouldn't show a login error page unless the user really failed to login (think about when the user presses a back button.)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30828 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 22:36:13 +00:00
kohsuke eae388edff formatting changes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30811 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 18:52:32 +00:00
kohsuke 29ec8a8a1f clarified doc.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30808 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 18:46:06 +00:00
kohsuke 2e13eb03dd Added a convenience method to reduce the invocation of a deprecated method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30806 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 18:23:26 +00:00
mindless 44096c0d14 [FIXED HUDSON-6437] don't use LIBC outside catch block for LinkageError.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30794 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-06 23:47:32 +00:00
mindless 1ac357c2ea [FIXED HUDSON-6459] workaround for bug in Glassfish Enterprise
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30793 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-06 23:22:23 +00:00
mindless 1ee0988b06 update javadoc reference based on r30748 change
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30751 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-05 20:19:13 +00:00
jglick 7cff653800 Do not make DescriptorExtensionList attempt to override a static method from ExtensionList. Should fix CCE caused by last commit.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30748 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-05 18:48:48 +00:00
kohsuke b31b67cc5d also do chmod(2) in an attempt to make a file writable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30734 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-05 04:15:53 +00:00
kohsuke 617af7ded3 merged back the RC branch
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30703 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-04 17:14:24 +00:00
jglick 57a59c535e [FIXED HUDSON-5884] Making compilable with JDK 7 javac.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30701 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-04 15:40:41 +00:00
mindless f855c5ee22 [HUDSON-5951] yay for tests, fix error in new normalize() before it went in any release
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30579 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 21:57:24 +00:00
mindless a6e6c7946a add SubText.groupCount()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30578 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 21:09:41 +00:00
mindless cd8376e9b4 In editableDescription for test results, invalid variable reference for
permission attribute made the add/edit description link show up for all
users, even if they don't have permission to submit the description.
Fixed this so link is omitted when appropriate.
Also changed permission required to add/edit a description from "Build"
to "Update Run".


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30575 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 20:16:54 +00:00
mindless 5974981064 [FIXED HUDSON-6351] update DirectoryBrowserSupport to use long for contentLength,
and update stapler to 1.141 which supports long for contentLength.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30571 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 18:50:16 +00:00
kohsuke dadecc8180 Added a hidden system property to let people change the 'workspace' directory name, for those who are desparate to make the path fit to 256 chars (this is important for old ASCII-based Win32 apps, such as Cygwin 1.5 --- Unicode based later ones aren't affected.)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30523 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 22:00:36 +00:00
abayer 2eedba8679 [FIXED HUDSON-6394] Email recipient lists now support build parameters
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30485 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 18:38:39 +00:00
mindless ae837cecf4 [FIXED HUDSON-5951] improve normalization of ".." in FilePath
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30462 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 07:35:22 +00:00
mindless c0db657f22 [HUDSON-5844] set build duration to zero if it comes out negative
(clock was set during a short build?).
Also added i18n for getDurationString() result when build is in progress.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30455 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 18:58:12 +00:00
mindless 55aef4bb5c [FIXED HUDSON-5617] catch and report missing/invalid proxy port value
when submitting proxy settings.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30454 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 18:35:42 +00:00
mindless 95c1ba927a [FIXED HUDSON-5180] remove url binding for this property.. it just shows parameters
form and a Build button that results in error.  index.jelly should only be accessed
via /build (shows index.jelly via _doBuild in this class) where the Build button works.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30453 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 17:07:52 +00:00
mindless 71854d1b69 [FIXED HUDSON-6371] Fix getArtifactsUpTo so it doesn't count collapsed-directories
as artifacts, resulting in too few artifacts returned (since 1.348).
Also fix limit check so it returns "n" items, not n+1.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30451 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-28 16:13:37 +00:00
mindless 5ad11a0dbc [FIXED HUDSON-6332] for 1.357
Add setOverwrite(true) for local->local copy in FilePath.copyRecursiveTo().
This makes it consistent with master/slave copy (either direction),
and also avoids returning 0 if all files already have current/newer timestamp
which some code (javadoc publishing, copyartifact plugin) would interpret as
copy failure or no matching files found.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30450 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 23:53:41 +00:00
kohsuke 5c339d5040 @nameRef is a mechanism to designate a different parent, so it needs to be in the different branch of if/then/else from e=e.parentNode.
I realize that this is a risky change, so I need to pay attention to the regerssions caused by this.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30449 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 23:43:23 +00:00
kohsuke b988eb8b83 @fillUrl should take the public static fromStapler method into account.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30448 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 21:33:23 +00:00
kohsuke b0f664dfcf improved construction of query string.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30447 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 21:09:40 +00:00
kohsuke 38d8c36aa9 a convenience method to assist trouble-shooting.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30441 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 18:32:45 +00:00
kohsuke 77e5369157 fixed ArrayIndexOutOfBoundsException
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30421 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-26 21:15:34 +00:00
kohsuke f672a29cd5 adding a UI sample for dynamic combo box.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30360 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-23 20:05:12 +00:00
mindless 24bfe8eac5 r30283 introduced an NPE when tests do createSlave(), as there is no Stapler context
to get the rootUrl.  Add null check here.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30359 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-23 18:09:42 +00:00
kohsuke ee711d4e63 added a convenient base class.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30333 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:42:41 +00:00
kohsuke 23c7b05fc7 simplified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30332 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 21:31:39 +00:00
kohsuke ad7b504ced user report indicates that if someone puts a null value into a system proeprty we get a hard-to-diagnose NPE. Adding code to proactively watch out for that:
[workspace] $ /usr/lib/jvm/sun-jdk-1.6/bin/java -cp /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-agent-1.355.jar:/usr/share/maven-bin-2.1/boot/classworlds-1.1.jar hudson.maven.agent.Main /usr/share/maven-bin-2.1 /opt/glassfish/server/glassfish/domains/domain1/applications/hudson/WEB-INF/lib/remoting-1.355.jar /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-interceptor-1.355.jar 35855 /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven2.1-interceptor-1.2.jar
<===[HUDSON REMOTING CAPACITY]===>���channel started
channel stopped
ERROR: Processing failed due to a bug in the code. Please report this to users@hudson.dev.java.net
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)
project=hudson.maven.MavenModuleSet@19cc863[Meetspace]
project.getModules()=[hudson.maven.MavenModule@19fef64[Meetspace/com.steeplesoft:meetspace], hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent], hudson.maven.MavenModule@11d8f11[Meetspace/com.steeplesoft.meetspace:plugin-engine], hudson.maven.MavenModule@b6e204[Meetspace/com.steeplesoft.meetspace:webapp], hudson.maven.MavenModule@b097da[Meetspace/com.steeplesoft.meetspace.plugins:helloworld-plugin], hudson.maven.MavenModule@1c18b6a[Meetspace/com.steeplesoft.meetspace.plugins:plugin-api], hudson.maven.MavenModule@1a80928[Meetspace/com.steeplesoft.meetspace.plugins:plugin-engine]]
project.getRootModule()=hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent]
FATAL: null
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30326 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 17:14:06 +00:00
mindless 7694a68258 tiny simplification
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30302 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 17:48:32 +00:00
kohsuke d21407be4f [FIXED HUDSON-6311] (actually, this change went in as rev.30287, but I'm testing if the issue update is working again)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30290 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 07:07:55 +00:00
kohsuke 7e183a983b [FIXED HUDSON-6311] reverted the problematic change and instead introduced the ideal signature in a new name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30287 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:29:10 +00:00
kohsuke b06bf8461b expose a few variables to the script.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30283 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:17:52 +00:00
kohsuke 207f3112af Fixed UOE in the following exception. Maybe I shouldn't have relied on servlet filters and defined my own thing inside Stapler, so that this whole thing can happen after the request/response/stapler association was made.
But now it's too late. 

java.lang.UnsupportedOperationException
	at hudson.security.AccessDeniedHandlerImpl$1.getServletName(AccessDeniedHandlerImpl.java:58)
	at javax.servlet.GenericServlet.getServletName(GenericServlet.java:368)
	at javax.servlet.GenericServlet.log(GenericServlet.java:300)
	at javax.servlet.GenericServlet.init(GenericServlet.java:257)
	at org.kohsuke.stapler.Stapler.init(Stapler.java:67)
	at hudson.security.AccessDeniedHandlerImpl.handle(AccessDeniedHandlerImpl.java:56)
	at org.acegisecurity.ui.ExceptionTranslationFilter.handleException(ExceptionTranslationFilter.java:229)
	at org.acegisecurity.ui.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:176)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:112)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1088)
	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:729)
	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:324)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:829)
	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:513)
	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
	at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:488)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30282 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 01:12:40 +00:00
kohsuke 7a6c9d5b1a handle cases like [foo]http://bar/[/foo] or <foo>http://bar/</foo>.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30281 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 00:16:52 +00:00
kohsuke 5ae67f416b Added Secret.toString(Secret) that hides the handling against NPE.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30276 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-20 23:33:03 +00:00
sogabe 799492ba6b fixed garbled response of XML API if xpath is specified. http://n4.nabble.com/Hudson-API-XML-td1723766.html#a1723766
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30178 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-17 11:11:35 +00:00
mindless c2fd840846 [FIXED HUDSON-6252] fix bad index calculation in SubText.subText which
caused StringIndexOutOfBoundsException in UrlAnnotator.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30102 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-16 00:23:00 +00:00
kohsuke 86c0b80265 bug fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30095 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 23:08:54 +00:00
kohsuke e1e0237f65 work around for bug 6933067.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30091 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 21:30:47 +00:00
mindless 77da4bcba2 [FIXED HUDSON-6269] Add synchronized on Project.updateTransient actions to avoid
deadlock between saving project config and getting project page.. save locked
transientActions and then project itself; get locks project, then transientActions.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30087 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 18:04:47 +00:00