Commit Graph
5087 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 56501b4e33 Recording changes in af1a4a2036 2011-02-14 10:45:03 -08:00
Kohsuke Kawaguchi 28ac80fe8a doc improvement 2011-02-14 10:42:30 -08:00
Vojtech Juranek af1a4a2036 Added pre-checkout method.
This method is called after assinging the workspace to the build, but before SCM checkout. Can be implemented by BuildWrappers.
2011-02-14 10:37:10 -08:00
Jesse Farinacci 53f0274753 [FIXED JENKINS-8647] Many messages about RecordReaper IllegalArgumentException
I did a checkout for our internal fork of JmDNS [1] and the
upstream version [2] to compare what the differences were..
I found none. There do not appear to be any local edits to
our fork so I can not figure out why we did the fork to
begin with.

Perhaps some older version had locally patched bugs which
have since been resolved? Anyhow, given that JENKINS-8647
is causing lots of people lots of grief, and it is enabled
by default, I went ahead and bumped to jmdns-3.4.0 upstream.

I think reduction of forks for library projects is generally
good, and especially when we have no practical changes made
to our version.

[1] https://github.com/jenkinsci/jmdns
[2] https://jmdns.svn.sourceforge.net/svnroot/jmdns/tags/JmDNS_3_2_1/
2011-02-14 10:29:28 -08:00
Kohsuke Kawaguchi a95c3e687c fixed up some left over TODO comments 2011-02-14 10:23:08 -08:00
Stefan Wolf 18b92fe43a Fix killing processes on MacOs 64bit 2011-02-14 10:19:55 -08:00
Kohsuke Kawaguchi 709c55d5de Piece-meal merging pull request #42
* commit 'b7a6c5d5d18ac4a00781919788e5c57360f05529':
  Reverting the BUIlD_TAG change.
  Fixed BUILD_TAG env var to not say hudson and added JENKINS_* versions of more env vars.

Conflicts:
	changelog.html
2011-02-12 10:11:44 -08:00
Kohsuke Kawaguchi cc40af0cf3 While editing description, inline help should show the syntax guide based on the current markup formatter. 2011-02-12 09:56:37 -08:00
Kohsuke Kawaguchi 4093fcd4b9 Added a new extension point to expose unprotected root action. 2011-02-12 09:56:37 -08:00
André Twupack ec3821189b added some German translations 2011-02-11 20:54:29 +01:00
Andrew Bayer 354956f1f0 Reverting the BUIlD_TAG change. 2011-02-09 11:50:43 -08:00
Andrew Bayer fe103a6c3e Fixed BUILD_TAG env var to not say hudson and added JENKINS_* versions of more env vars. 2011-02-09 10:02:23 -08:00
Kohsuke Kawaguchi 7ef707390d Merge branch 'JENKINS-8054'
* JENKINS-8054:
  Set 'Aborted' result before invoking BuildWrapper's tearDown. Fixes JENKINS-7864 and JENKINS-8054.
2011-02-08 11:53:03 -08:00
Mikko Peltonen 9c965617b3 Set 'Aborted' result before invoking BuildWrapper's tearDown. Fixes JENKINS-7864 and JENKINS-8054. 2011-02-07 14:46:15 +02:00
Dave Brosius e7d0ba58d8 Classes that derive from FederatedIdentity are put into the session and should therefore be serializable 2011-02-05 19:31:24 -05:00
Dave Brosius 6bd3f83cb1 remove needless null check, subject isn't null (from above) 2011-02-05 19:21:57 -05:00
Dave Brosius 6201362a5f don't use reference comparisons with Booleans 2011-02-05 19:19:13 -05:00
Dave Brosius 5571e430d1 remove wasteful duplicate method calls 2011-02-05 19:16:24 -05:00
Dave Brosius 5abb484957 method parms should document the types of values they expect 2011-02-05 19:08:22 -05:00
Dave Brosius bf7cbca22b guard against npes 2011-02-05 18:59:54 -05:00
Dave Brosius 2cfd939358 don't use synchronized collections in a local-only context 2011-02-05 18:51:13 -05:00
Dave Brosius 9e32311e2f use %n for new lines in format strings 2011-02-05 18:39:54 -05:00
Dave Brosius 3c952fc7eb remove unused code 2011-02-05 18:30:46 -05:00
Jerome Lacoste 2e47359a6e JENKINS-8702 unit tests improvements
hudson.UDPBroadcastThread#testMulticast hangs when the network isn't enabled on my Linux box: joinGroup throws IOException and the ready lock isn't released.
This ready lock is only used in the tests.
2011-02-05 13:58:47 +01:00
Jerome Lacoste 58166dfb2b Merge remote branch 'upstream/master'
Reapplied 329a020188

Conflicts:
	core/src/main/java/hudson/widgets/HistoryWidget.java
2011-02-05 07:38:58 +01:00
Kohsuke Kawaguchi f88a2ba333 Merge branch 'JENKINS-4756'
* JENKINS-4756:
  minor touch up
  FIXED JENKINS-4756 the executor number was not always unique. Computer.executors.size() does not provide a unique number within one Computer.
2011-02-04 21:28:12 -08:00
Kohsuke Kawaguchi 36d9b56250 minor touch up 2011-02-04 21:28:01 -08:00
Kohsuke Kawaguchi 6c521259e2 [FIXED JENKINS-8660] recording the fix from Jerome Lacoste. 2011-02-04 21:15:03 -08:00
Kohsuke Kawaguchi 691f230519 Merge branch 'JENKINS-8660'
* JENKINS-8660:
  fail more gracefully if the header is not provided.
  JENKINS-8660: loading the build history cause an NPE on the History Widget
2011-02-04 21:12:49 -08:00
Kohsuke Kawaguchi 329a020188 fail more gracefully if the header is not provided. 2011-02-04 20:34:09 -08:00
Kohsuke Kawaguchi f8515e96fe Merge branch 'HUDSON-8656' of https://github.com/nairb774/jenkins 2011-02-04 20:18:23 -08:00
Brian Atkinson e7eac75978 This adds a test from HUDSON-8656, and is likely related to issues found in
HUDSON-8401.

This grouping of tests targets all Sunday to *another day of week* cron
tabs. There are likely other pairs that could be tested, but this seemed to
work out most of the bugs.
2011-02-04 18:45:12 -06:00
Richie Vos 9d7d0d753d Add the build's description to the build feed 2011-02-04 16:49:45 -06:00
Olivier Lamy 774f655398 Merge branch 'lacostej-pull5' of https://github.com/lacostej/jenkins 2011-02-04 23:41:00 +01:00
Jerome Lacoste 9005eb665f JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)
After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered.
And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.
2011-02-04 22:36:11 +01:00
Jerome Lacoste f40b4ffbc8 JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)
After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered.
And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.
2011-02-04 22:34:26 +01:00
Jerome Lacoste 3106a80bcf Merge remote branch 'upstream/master' 2011-02-04 21:37:39 +01:00
Nathan Parry a88920aab7 Fix JENKINS-8196
Persist a user-requested offline status for a slave across
restarts. Previously slaves would come back online if the server
was restarted while they were marked 'temporarily offline'.

I believe this also addresses JENKINS-7934 and JENKINS-7805
which look like duplicates.
2011-02-04 12:09:40 -08:00
Jerome Lacoste 4077b5da1c Merge remote branch 'upstream/master' 2011-02-04 20:33:22 +01:00
Jerome Lacoste 020a4ee92a JENKINS-8686 IO stream copies are not done properly.
Some more work:
* reviewed some callers
* took note that some classes have been moved into stapler
* used IOUtil.closeQuietly() in a few places
2011-02-04 15:34:26 +01:00
Jerome Lacoste bfbaf2c9d9 JENKINS-8686 IO stream copies are not done properly.
First pass at making sure we don't stop copying when the reader reads 0 characters.

I will now also review the callers for our internal code, and check if we can use IOUtils methods instead.
2011-02-04 15:34:07 +01:00
Janick Reynders 88a2860339 FIXED JENKINS-4756 the executor number was not always unique. Computer.executors.size() does not provide a unique number within one Computer. 2011-02-03 23:21:01 +01:00
Jerome Lacoste a8a931d8ec JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)
The ManagedWindowsServiceLauncher refers to hudson.exe and hudson-slave.exe while we renamed the artifact to jenkins.exe.

Tentative fix, completely untested (no windows box around).
Not sure about the service name (jenkinsslave). I added a second check for backward compatibility but I have no idea if it's useful.
2011-02-03 23:08:12 +01:00
Jerome Lacoste 9a13990be9 JENKINS-8660: loading the build history cause an NPE on the History Widget
loadAllBuildHistory() fails to set the headers field on the replacement buildHistory DOM element.

The patch fixes the problem by recreating a headers field.
It also:
* slightly refactor the loadAllBuildHistory() method for readability
* add a FIXME note that the server side history widget should fail if the n parameter is missing.
* add a pre-condition check to the buildHistory() update to catch potential bugs (note that the logging is disabled as Yahoo.log doesn't appear available)
2011-02-03 23:03:07 +01:00
Andrew Bayer 6424a80c98 Merge branch 'lacostej-pull' of https://github.com/lacostej/jenkins into lacostej-lacostej-pull 2011-02-03 13:51:39 -08:00
Jerome Lacoste 2332b114a3 JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)
The ManagedWindowsServiceLauncher refers to hudson.exe and hudson-slave.exe while we renamed the artifact to jenkins.exe.

Tentative fix, completely untested (no windows box around).
Not sure about the service name (jenkinsslave). I added a second check for backward compatibility but I have no idea if it's useful.
2011-02-03 22:20:25 +01:00
alanharder 3ba54b53ae hudson.war/jenkins.war changes.. made getBackupVersion use getHudsonWar()+".bak"
to match 2 other methods in this file (instead of hardcoded hudson.war.bak)
2011-02-03 09:47:50 -08:00
alanharder b3c661d59b some hudson.war/jenkins.war changes 2011-02-03 09:41:00 -08:00
Jerome Lacoste 3ddb68f038 JENKINS-8660: loading the build history cause an NPE on the History Widget
loadAllBuildHistory() fails to set the headers field on the replacement buildHistory DOM element.

The patch fixes the problem by recreating a headers field.
It also:
* slightly refactor the loadAllBuildHistory() method for readability
* add a FIXME note that the server side history widget should fail if the n parameter is missing.
* add a pre-condition check to the buildHistory() update to catch potential bugs (note that the logging is disabled as Yahoo.log doesn't appear available)
2011-02-03 13:06:57 +01:00
Jerome Lacoste 42c0bdb703 JENKINS-8658 cleanup. Inner class can be static 2011-02-03 05:38:50 +01:00