OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-10 02:26:18 +00:00
Code Issues Packages Projects Releases Wiki Activity
29,199 Commits 55 Branches 1,940 Tags
574ec6e5bdf2e4ac9394e290fefff5ac1c9a5c96
Commit Graph
12949 Commits
Author SHA1 Message Date
Wadeck Follonier 574ec6e5bd Merge branch 'master' into security-master 2020-01-20 14:55:10 +01:00
Jesse GlickandOleg Nenashev d02c756358 [JENKINS-60750] Skip CONFIGURE_INSTANCE panel when root URL is set during skipFirstUser (#4430) 
* [JENKINS-60750] Skip the CONFIGURE_INSTANCE panel when JenkinsLocationConfiguration.url is set, even when skipFirstUser is called.

* Add nullability annotation

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2020-01-17 06:46:57 +01:00
Francisco FernándezandOleg Nenashev 3ade716f41 [JENKINS-60577] - Prevent the RSS feed in Computer page from returning an error 404 (#4411) 
* [JENKINS-60577] Rss Latest Builds for Computer

* [JENKINS-60577] Missing javadoc

* [JENKINS-60577] Add builds from the computer

* Update core/src/main/java/hudson/model/Computer.java

* Apply suggestions from code review

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* [JENKINS-60577] Document limitation to AbstractProject

* [JENKINS-60577] Restrict the RSS methods in Computer

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2020-01-15 07:54:52 +01:00
Wadeck Follonier 8263b0ae48 Merge branch 'security-stable-2.204' into security-master 2020-01-14 14:56:56 +01:00
Wadeck Follonier a293a77a77 Merge branch 'security-stable-2.190' into security-stable-2.204 2020-01-14 14:51:25 +01:00
Wadeck Follonier b11f08686e Merge branch 'security-stable-2.176' into security-stable-2.190 2020-01-14 14:31:54 +01:00
Wadeck Follonier bb3d46d018 Merge branch 'security-stable-2.164' into security-stable-2.176 2020-01-14 13:58:13 +01:00
Wadeck Follonier 77f36f37f5 [SECURITY-1695][SECURITY-1697] 2020-01-14 12:21:45 +01:00
Jeff Thompson 5054bc6e12 [SECURITY-1682] 2020-01-14 12:16:59 +01:00
Jeff Thompson 6f35dbb939 [SECURITY-1660] 2020-01-14 12:15:51 +01:00
Daniel Beck 7d44836fad [SECURITY-1650] 2020-01-14 12:08:50 +01:00
Wadeck Follonier 639ade55ca [SECURITY-1704] 2020-01-14 12:08:10 +01:00
Wadeck Follonier cd28a6d934 [SECURITY-1641] 2020-01-14 12:06:40 +01:00
Daniel Beck c0d3c041b4 [SECURITY-1291] 2020-01-14 11:41:23 +01:00
StefanSpiekerandOleg Nenashev ec13ac9b67 Spotbugs issues (#4416) 
* Spotbugs: Fixed comparing strings with equals instead of ==

* Spotbugs: Do not return null in @Nonnull marked method, instead return empty string.

* Added Suppress for Spotbugs

* Apply suggestions from code review

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* fixed javadoc

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2020-01-14 11:16:48 +01:00
Oleg Nenashev 7be7ce0332 Merge pull request #4422 from jglick/LogRotator-JENKINS-60716 
[JENKINS-60716] Retain causes of a LogRotator failure for diagnosis
 2020-01-14 11:16:27 +01:00
Matt Sicker 47f9a94794 [JENKINS-59107] User is no longer logged out when authenticating another user 
This fixes a regression introduced in SECURITY-901 where performing an authentication check on another user while logged in caused the user to get logged out.

Signed-off-by: Matt Sicker <boards@gmail.com>
(cherry picked from commit d5b716625c)
 2020-01-13 19:45:54 +01:00
James Nord 5bc53da058 [JENKINS-60351] - Make it possible to disable multiple deletion attempts by setting hudson.Util.maxFileDeletionRetries to zero (#4382) 
* [JENKINS-60351] It should be possible to disable a retry of the
PathRemover

This does not address the issues that the comments and code in
hudons.Util are inconsistent if they are for retries or total number of
attempts (they are currently total number of attempts)

* [JENKINS-60351] Make the code conform to the documentation

maxRetries should control the number of retries not the number of
attempts.

* rename field from DELETION_MAX to DELETION_RETRIES

(cherry picked from commit 7228af5bb1)
 2020-01-13 19:42:45 +01:00
Baptiste Mathus cae20e7613 Merge pull request #4329 from lgoenner/executor 
[JENKINS-57304] - Add call to oneOffExecutors.remove in Computer.removeExecutor

(cherry picked from commit cb424f3ca0)
 2020-01-13 19:36:22 +01:00
Oleg Nenashev e29e3635c0 Merge pull request #4357 from bulanovk/JENKINS-60167 
[JENKINS-60167] - Fix AtomicFileWriter performance issue on CephFS in case of Empty File creation

(cherry picked from commit cce9587639)
 2020-01-13 19:34:13 +01:00
Oleg Nenashev 03214978a3 Merge pull request #4348 from pilou-/handle_empty_views 
[JENKINS-60092] getPrimaryView: return null if no view is defined

(cherry picked from commit 8bc435f32e)
 2020-01-13 19:08:52 +01:00
Oleg Nenashev 8ba98e9297 Merge pull request #4412 from jglick/changelog.url 
Simplify CoreUpdateMonitor/message.properties: changelog.url → jenkins-version.properties
 2020-01-11 13:56:23 +01:00
StefanSpieker bef9ded543 [JENKINS-36720] - Fix Spotbugs issues (SE_COMPARATOR_SHOULD_BE_SERIALIZABLE, ES_COMPARING_STRINGS_WITH_EQ) (#4379) 
* fixed Spotbugs issues (SE_COMPARATOR_SHOULD_BE_SERIALIZABLE, ES_COMPARING_STRINGS_WITH_EQ)

* replaced wildcard import with specific imports

* added missing import

* fixed spotbugs issues

* removed accidently added import
 2020-01-11 00:04:02 +01:00
Oleg Nenashev 5db5ef5131 Merge pull request #4271 from ilpianista/JENKINS-42658 
[JENKINS-42658] - Fix NPE in Agent API when the agent is offline (e.g. retrieving agent version or OS description)
 2020-01-10 14:38:17 +01:00
Karthick Prabu d3613f32ef [JENKINS-59220] - Updated EnvVars to add a method that extends putAll functionality (#4194) 
* Updated EnvVars to add a method that extends putAll functionality

* Updated method name

* Added test coverage
 2020-01-10 09:55:23 +01:00
Oleg Nenashev 58f8ac9b98 Merge pull request #4387 from jeffret-b/removeDeprecatedProtocols 
[JENKINS-60381] Remove old, deprecated agent protocols.
 2020-01-10 09:45:55 +01:00
A. Jard a00166bfd5 [JENKINS-60579] - Allow the usage of DescriptorVisibilityFilter to filter View properties on UI. (#4404) 
* [JENKINS-60579] Functionnal test on View that shows the issue for invisible properties.

* [JENKINS-60579] Apply the visibility filter on View for configuration.

* [JENKINS-60579] Better configuration for testing on invisible property on view.

* [JENKINS-60579] Move tests on ViewPropertyTest.

* [JENKINS-60579]adding the since on getVisiblePropertyDescriptors.
 2020-01-10 09:37:18 +01:00
Jesse Glick d051dc307c [JENKINS-60716] Retain causes of a LogRotator failure for diagnosis. 2020-01-09 15:06:04 -05:00
Oleg Nenashev ad1ca7101b Merge pull request #4414 from jglick/WORKSPACE_TMP-JENKINS-60634 
[JENKINS-60634] Define $WORKSPACE_TMP for (non-Pipeline) builds
 2020-01-08 11:47:56 +01:00
Oleg Nenashev c059ccb0d8 Merge pull request #4418 from darxriggs/fix-typos 
Fix typos & spelling in Javadoc and WebUI
 2020-01-08 11:43:57 +01:00
Jesse Glick 0bd5d671d2 Merge pull request #4415 from jglick/enable-security-JENKINS-40228 
[JENKINS-40228] Remove Enable Security checkbox in the Global Security configuration (follow-up)
 2020-01-07 09:22:04 -05:00
Jesse Glick f230462f15 #4254 incorrectly converted AntClassLoader.loadResource to a Java 5 for-loop. 2020-01-06 10:19:26 -05:00
René Scheibe f22d34675b Fix typos & spelling 2020-01-06 11:07:55 +01:00
Jesse Glick e6e8c387d5 Prevent endless recursion in SezpozModule.resolve. 2020-01-04 20:14:13 -05:00
Jesse Glick 5773970a64 Merge branch 'JENKINS-40228' of github.com:ksenia-nenasheva/jenkins into enable-security-JENKINS-40228 2020-01-04 11:27:26 -05:00
Oleg Nenashev 1f47ad6ea2 Merge pull request #4408 from StefanSpieker/spotbugs_switch 
Fixed Spotbugs Switch related issues and added Suppresses
 2020-01-04 14:16:19 +01:00
Oleg Nenashev 9640790fe1 Merge pull request #4413 from jglick/UpdateCenter.isSiteDataReady-JENKINS-60625 
[JENKINS-60625] Prevent Jenkins page rendering from being blocked when the update center data parsing is in progress
 2020-01-04 14:16:01 +01:00
StefanSpieker 0e6bb91864 Return error when invalid string is passed as a Run status CLI argument (#4212) 
* removed redundnat null checks of nonnull values

* integrated suggestions

* removed local jenkins variable as suggested

* replaced null check with check for error object
 2020-01-03 23:39:22 +01:00
Josh SorefandOleg Nenashev 9b8047acd1 IntelliJ/Java: Duplicate declaration -> AntClassLoader.getUrl (#4254) 
* IntelliJ/Java: Duplicate declaration

AntClassLoader.getUrl

* Add missing import for annotation

* Switch from Vector to ArrayList<File>

* Drop inferable File

* Use for (File pathComponent : pathComponents) sugar

* Accept generic container type for getUrl

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
 2020-01-03 23:35:38 +01:00
Vincent Latombe dd59e8c11c [JENKINS-60449] Attempt to fix an odd case of OptionalExtension blowing up Jenkins (#4393) 
* Add new module optional-depender and a new failing test

* Variant plugin is a dependency of optional-depender

Optional-depender contains the following class

@OptionalExtension(requirePlugins = {"dependee"})
public class OptionalDependerExtension {
      private static void foo(Dependee d) {

      }
}

* [JENKINS-60449] Move plugin initialization at the end, keep only one extension refresh

* Improve logic to detect classloading issues

Inspect all declared constructors/methods/fields recursively to exclude
failing classes from Guice rather than have Guice explode.

This also fix the failing test, but the previous commit is still better
because it avoids an extra Jenkins.get().refreshExtensions() call.

* Only test resolveClass method if the classloader is not the bootstrap one
 2020-01-03 23:26:35 +01:00
Jesse GlickandDaniel Beck e621b6e0cd Be explicit that UpdateSite.hasUnparsedData is not intended as an API. 
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
 2020-01-03 16:49:04 -05:00
Jesse Glick 84f66e3c4e [JENKINS-60634] Define $WORKSPACE_TMP for (non-Pipeline) builds. 2020-01-03 14:57:53 -05:00
Jeff Thompson 50921ccbec Reduce JnlpSlaveAgentProtocol to minimum. 
Remove anything unnecessary. Move SLAVE_SECRET to JnlpAgentReceiver
and alias it for existing usages.
 2020-01-03 12:08:24 -07:00
Jeff Thompson bd0d9560dc Update to Remoting without protocols. 2020-01-03 11:06:06 -07:00
Jesse Glick 29fbc9c451 Quiet down log message about parsing JSON. (Though it is kind of interesting just how slow it is.) 2020-01-02 21:29:35 -05:00
Jesse Glick af7c4bece2 [JENKINS-60625] Introduced UpdateCenter.isSiteDataReady for use from administrative monitors. 2020-01-02 17:23:01 -05:00
Jesse Glick 0ba0ea93d5 Normalized loading of UpdateCenter/CoreUpdateMonitor/message.properties by moving changelog.url to jenkins-version.properties. 2020-01-02 17:04:23 -05:00
Stefan Spieker dbaec7ec03 set spotbugs URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD to ignore because reads are not detectable by spotbugs 2019-12-31 11:37:20 +01:00
Stefan Spieker 492505fd5d fixed spotbugs switch case related findings 2019-12-31 11:13:22 +01:00
Stefan Spieker 2fbc94bb87 set spotbugs ICAST_IDIV_CAST_TO_DOUBLE to ignore, because precision loss is intended 2019-12-31 10:50:09 +01:00