* Revert DownloadService TimeUnit mix on lastAttempt
Downloadable.lastAttempt is set in milliseconds but the PR-3913 change
the test to toMillis(millis+seconds)<millis.
Thank you @pzygielo for this catch.
* Fix DownloadService time unit usage
Thank you @daniel-beck
Co-Authored-By: alecharp <adrien.lecharpentier@gmail.com>
* Fix DownloadService missing import
Context:
The "Manage Legacy API Token usage" page, used for migrating the legacy API Token.
Problem:
If you click on a line, the checkbox is checked and the line is highlighted. But if you click on the checkbox, the behavior should be the same. This is not the case for all the lines, except the last one.
Root cause:
In the code, I used a `var` inside a loop. Due to the JS behavior, the `var` are not scoped to their "block", but to their "function block". That results in the `onCheckChanged(checkBox)`, the checkBox change it's value, due to the closure, that keep the reference to a variable that is changed.
Solution:
Either using `let` instead of `var` or using the `this` that corresponds to the checkbox in this case.
* JENKINS-56398 Mobile friendly login / load / restart screens
* [JENKINS-56398] increase line-height of heading
* [JENKINS-56398] mobile friendly layout for signup form
* [JENKINS-56114] Correct behavior for Windows Server 2016 with Docker
- also adjust the symlink escape hatch
* Correct missing space + retrigger build
* Improve performance with a check on the logger level
* Run the specific code only under Windows
* Rename the method as it's used only for Windows
* spelling: dependent
Writers following British writing convention often confuse dependent and dependant. Those following US writing convention have an easier time with these words because Americans do not use dependant.
A dependant is a person who is dependent on someone else. (For example, a child is dependent on its parents. Therefore, a child is a dependant of its parents.)
Jenkins does not deal with people, thus the UK rule which is confusing does not apply.
* Add deprecated shims
Kohsuke Kawaguchi