Commit Graph
271 Commits
Author SHA1 Message Date
Josh Soref 8825451f67 spelling: dependent (#3821)
* spelling: dependent

Writers following British writing convention often confuse dependent and dependant. Those following US writing convention have an easier time with these words because Americans do not use dependant.

A dependant is a person who is dependent on someone else. (For example, a child is dependent on its parents. Therefore, a child is a dependant of its parents.)

Jenkins does not deal with people, thus the UK rule which is confusing does not apply.

* Add deprecated shims
2019-02-28 14:12:37 +01:00
Josh Soref bd8091cf57 Drop useless local variables 2019-02-20 19:18:09 -05:00
Baptiste Mathus a78312ea0f [JENKINS-55681] - Make JAXB a detached plugin only on Java 11 (#3865)
* Move detached plugins logic into a dedicated class

ClassicPluginStrategy is already long enough, so trying to make things a
bit more focused before adding Java 11 logic. (and even if not, the change
still splits a class that is almost 1k lines).

* Install jaxb as detached only on Java 11+

* Remove duplicate @Restricted

Given the enclosing class already has it.

* Use 1.5 release

* Add more test coverage

* getMinJavaVersion => getMinimumJavaVersion

* Rename DetachedPluginsManager as DetachedPluginsUtil

as requested by Oleg and Jesse. Mainly because of the misleading
relationship (there's no inheritance) with the existing `PluginManager`
class.

* 🤦 adjust to 1.5 release method renaming

* Clarify minimum Java version column

Co-Authored-By: batmat <bmathus@gmail.com>

* Update to 2.3.0 version of the jaxb plugin

* Bump minimum core version to next expected release version

* Add preventive cycle breaks for jaxb while waiting for JENKINS-28942

As requested by Oleg.

* Add test to fail fast on wrong format for split-plugins.txt
2019-02-03 10:56:26 +01:00
Baptiste Mathus 27c49bf0a1 Merge branch 'master' into JENKINS-20679-filter-out-plugins-compiled-with-more-recent-jdk 2019-01-07 11:11:38 +01:00
M Ramon Leon b1e8c6565c [JENKINS-54731] Fix checkUpdateAttempts system property
Rename hudson.PluginManager.CHECK_UPDATE_ATTEMPTS system property to
hudson.PluginManager.checkUpdateAttempts
2018-11-20 18:12:37 +01:00
Stephen Connolly 389c5a7e60 Merge pull request #3269 from stephenc/jenkins-45235
[FIXED JENKINS-45235] When multiple update sites publish different versions, allow those versions to be seen
2018-11-19 13:35:21 +00:00
Ramon Leon 7aef24d454 [JENKINS-54459] Avoid Angry Jenkins when check now on Plugin Manager (#3718)
* [JENKINS-54459] Avoid angry Jenkins in Plugin Manager. Check Now

* [JENKINS-54459] Avoid angry Jenkins in Plugin Manager. Check Now

* [JENKINS-54459] Fix updateSiteRightJsonTest in Windows

* [JENKINS-54459] Minor fixes

* Avoid deprecated getInstance

Co-Authored-By: MRamonLeon <manuelramonleonjimenez@gmail.com>

* [JENKINS-54459] Some fixes

- Better system properties initialization
- Rename properties
- Localized messages
- Add test for change log level message
- Restore signatureCheck field after test
- Other minor improvements

* [JENKINS-54459] Add Retrier generic class and use it in the checking

* [JENKINS-54459] Improving Spanish messages

* [JENKINS-54459] Fix two javadoc errors

* [JENKINS-54459] Rename constants and its visibility

Rename the constants to do the retries and change their visibilities.

Change the package of the test to be able to access the constants in
order to redefine their values in the tests.

* [JENKINS-54459] Avoid external use of Retrier and test the delay time
2018-11-17 11:56:21 +01:00
Stephen Connolly 4bf99bae6e Merge branch 'master' into jenkins-45235 2018-11-16 21:17:13 +00:00
Baptiste Mathus 131794b84d Merge pull request #3648 from MRamonLeon/JENKINS-27177
[JENKINS-27177] Add disable plugin command and tests
2018-11-08 13:04:13 +01:00
M Ramon Leon 8bc71b7181 [JENKINS-27177] Improve messages 2018-10-18 11:11:10 +02:00
M Ramon Leon 65faa1e6d8 [JENKINS-27177] Minor fixes.
Change the way of an array copy and ensure non null args
2018-10-17 18:31:45 +02:00
M Ramon Leon 8f239f6ee1 [JENKINS-27177] Add new status error_disabling and minor fixes
When there is some problem disabling a plugin (the disabling file cannot
be created) it should be indicated and also reflected in the dependee
plugin.
2018-10-16 11:47:23 +02:00
M Ramon Leon 1aa7dbb818 [JENKINS-27177] Minor fixes 2018-10-15 11:56:27 +02:00
M Ramon Leon fe8d0d5e7c [JENKINS-27177] Add strategies to disable plugins. Move process to core
Move the process to core to be reusable, not only for the cli command.
Add optionalDependants list to PluginWrapper to process them easily.

Replace (depreacate) the disable method without checks by this one with
strategies.

Improve messages and tests
2018-10-15 10:06:21 +02:00
Oleg Nenashev 150de1df6e Merge pull request #3640 from oleg-nenashev/build/jdk11-underscore-vars
JDK-11 support: refactor code to avoid underscore variable names
2018-09-27 18:08:51 +02:00
Oleg Nenashev ba08ebc97a Refactoring: Cleanup <tt> tags from the Jenkins core Javadoc 2018-09-21 17:47:11 -07:00
Oleg Nenashev a3cc7780aa JDK11 support: refactor code to avoid underscore variable names 2018-09-21 16:47:59 -07:00
Daniel Beck f55864fe49 Add Java version check to setup wizard and installNecessaryPlugins
I'm not sure what the log message is supposed to be for, but other
checks also log, so apply the same behavior for Java dependency.
2018-09-20 11:38:40 -07:00
Daniel Beck 725fb3026b Update Javadocs and comments 2018-09-20 11:38:40 -07:00
Daniel Beck 87c61f527d Merge branch 'security-stable-2.121' into security-master 2018-08-02 02:28:34 +02:00
Daniel Beck 7ac1c48ea6 Merge branch 'security-stable-2.107' into security-stable-2.121 2018-08-02 02:27:38 +02:00
Daniel Beck 909781ca14 Merge branch 'security-stable-2.89' into security-stable-2.107 2018-08-02 02:26:18 +02:00
Daniel Beck e56103203c Merge branch 'security-stable-2.73' into security-stable-2.89 2018-08-02 02:24:55 +02:00
Wadeck Follonier 6867e44695 [SECURITY-1071] 2018-08-02 01:34:28 +02:00
Vincent Latombe 8c1b8b8e14 [JENKINS-50336] Fix loading optional extensions after installing a missing dependency (#3370)
* [JENKINS-50336] Only keep extensions that could be loaded in memory

So that delta computations will re-attempt to load any extension that
previously failed or was skipped after a new plugin is installed.

After installing a plugin, need to refresh extensions in order to pick
up extensions that can be loaded thanks to this new plugin.

* [JENKINS-50336] @OptionalExtension annotated classes were not being picked up after dynamic load of variant

Recompute GuiceExtensionAnnotation list when refreshing extensions
2018-06-08 19:30:11 +02:00
Jesse Glick 7bd6d1e80c [JENKINS-51205] Improve performance of /pluginManager/available service.
(cherry picked from commit 3b61b96119)
2018-05-24 13:32:27 +02:00
Jesse Glick 3b61b96119 [JENKINS-51205] Improve performance of /pluginManager/available service. 2018-05-08 12:04:18 -04:00
Devin Nusbaum 7b6c86dc58 [JENKINS-48899] Do not downgrade detached plugins when upgrading Jenkins (#3229)
* Reproduce JENKINS-48899

* Do not downgrade installed detached plugins

(cherry picked from commit d629897958)
2018-01-31 11:41:51 +01:00
Stephen Connolly 884e95e0fa [FIXED JENKINS-45235] When multiple update sites publish different versions, allow those versions to be seen
- When automatically installing dependent plugins, the first update center with a version meeting the minimum required will win
- Also enhances the CLI command to allow specification of a minimum version
2018-01-26 11:32:36 +00:00
Devin Nusbaum d629897958 [JENKINS-48899] Do not downgrade detached plugins when upgrading Jenkins (#3229)
* Reproduce JENKINS-48899

* Do not downgrade installed detached plugins
2018-01-21 15:33:03 +01:00
Daniel Beck e9ecbb326c Merge pull request #3201 from dwnusbaum/JENKINS-48604
[JENKINS-48604] Do not downgrade plugins that are dependencies of detached plugins when upgrading Jenkins

(cherry picked from commit 1dc2c6d5ff)
2018-01-03 15:01:35 +01:00
Oleg Nenashev 0319362666 Merge pull request #3193 from dwnusbaum/JENKINS-48365
[JENKINS-48365] Install detached plugins when upgrading Jenkins past the version the plugins were detached

(cherry picked from commit 968b6adf00)
2018-01-03 15:01:11 +01:00
Jesse Glick dfc1940eee Merge branch 'master' into whitelist-JENKINS-47736 2017-12-19 14:34:57 -05:00
Devin Nusbaum 6632aef948 Revert "Upgrade installed optional dependencies if necessary"
This reverts commit eb77e5f20d.
2017-12-18 16:35:23 -05:00
Devin Nusbaum eb77e5f20d Upgrade installed optional dependencies if necessary 2017-12-18 13:16:20 -05:00
Devin Nusbaum 01f70d4290 Don't copy the bundled dependency if the current version is already installed 2017-12-18 13:14:24 -05:00
Devin Nusbaum 7fc4815e11 Do not downgrade installed plugins when loading detached plugins 2017-12-18 12:40:20 -05:00
Oleg Nenashev 968b6adf00 Merge pull request #3193 from dwnusbaum/JENKINS-48365
[JENKINS-48365] Install detached plugins when upgrading Jenkins past the version the plugins were detached
2017-12-17 14:26:51 +01:00
Devin Nusbaum 6bf700827a Do not use InstallState in PluginManager when loading detached plugins 2017-12-12 10:38:20 -05:00
Jesse Glick b6088dc456 Deprecating Service in favor of ServiceLoader. 2017-12-11 17:44:55 -05:00
Jesse Glick 5c749cfac3 Support dynamically-loaded plugins in CustomClassFilter.Contributed. 2017-12-04 23:11:31 -05:00
Daniel Beck 671a0ad4d0 Add ExtensionList#lookupFirst convenience method (#3021)
* Add ExtensionList#lookupFirst convenience method

* Fix Javadoc

* Convert to lookupSingleton, which throws unless there's only 1

* Address review comments
2017-10-28 12:58:48 +02:00
Akbashev Alexander 6e75f7349c [FIXED JENKINS-47713] - Do not copy list of plugins on every call (#3109)
[FIXED JENKINS-47713] - Do not copy list of plugins on every call
2017-10-28 12:52:44 +02:00
Jesse Glick d13b1361e1 Adding some interface default method implementations (#2879)
* Adding some interface default method implementations rather than catching AbstractMethodError or providing partial implementation classes.

* Show Javadoc warnings and errors, but not ‘Generating …/core/target/site/apidocs/jenkins/model/lazy/class-use/AbstractLazyLoadRunMap.html...’ and the like.

* Javadoc fixes.

* Review comments from @oleg-nenashev.

* Test fixes.

* Remove the unused import
2017-05-20 12:32:52 +02:00
Jesse Glick 8edf4a349d Update detached plugins to reflect security releases (#2817)
* [SECURITY-372] Update bundled mailer to 1.20.

* Updated to pick up other detached plugins mentioned in https://jenkins.io/security/advisory/2016-04-11/ or https://jenkins.io/security/advisory/2017-03-20/ while we are here.

* I18nTest.test_baseName_plugin caught that the detached version of credentials was too old to serve as a dependency.
Probably there should be some test case verifying that all detached plugins could be loaded at once,
though it would need to do a topological sort in dependency order.

* Must also include display-url-api as a detached plugin as it is a dependency, even though it was never actually detached from core.

* @oleg-nenashev insists on bundling display-url-api 2.0.
2017-05-13 13:01:10 +03:00
Jesse Glick 0993b7099b Do not load detached plugins during tests (#2829)
* Do not load detached plugins during tests.
Also warn about plugins which force us to create classes.jar.

* Porting POM fix from #2795: we must allow snapshots from repo.jenkins-ci.org so as to be able to test upstream component PRs.

* Fixed failures in tests which assumed detached plugins were being loaded.

* jenkins-test-harness 2.20

* Unreproducible test failure on CI, probably due to timing.
2017-05-01 16:44:55 +03:00
Jesse Glick f3304cb5cd Merge branch 'security-stable-2.46' into security-master 2017-04-13 14:15:04 -04:00
Jesse Glick c0c6a9798c Merge branch 'security-stable-2.32' into security-stable-2.46 2017-04-13 14:05:53 -04:00
Jesse Glick 4509ca7fa8 Merge branch 'security-stable-2.19' into security-stable-2.32 2017-04-13 14:03:59 -04:00
Jesse Glick 44c4c1cc0c Merge branch 'security-stable-2.7' into security-stable-2.19 2017-04-13 13:58:44 -04:00