Commit Graph
4154 Commits
Author SHA1 Message Date
jglick 5b7c857cfd [HUDSON-4941] Log which file had an XML parse error to assist in diagnosis & fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24022 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 16:36:07 +00:00
javadude bf8c9fba1e Added try/catch in AbtractBuild checkout handling to allow SCM plugins that throw exceptions to be retried.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24010 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 05:33:09 +00:00
mindless 34c15c775e [FIXED HUDSON-1867] Add ability to delete users from Hudson
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24009 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-24 03:59:43 +00:00
kohsuke fd13eee6d5 Merged revisions 23666-23667,23670,23711,23782-23785,23788,23809-23810,23817,23859,23870,23879,23899-23904,23906-23907,23909,23913 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/managed-startup

........
  r23666 | kohsuke | 2009-11-11 15:56:46 -0800 (Wed, 11 Nov 2009) | 1 line
  
  Reworked the initialization logic
........
  r23667 | kohsuke | 2009-11-11 16:01:56 -0800 (Wed, 11 Nov 2009) | 1 line
  
  fixed a failing test
........
  r23670 | kohsuke | 2009-11-11 16:42:32 -0800 (Wed, 11 Nov 2009) | 1 line
  
  use a non-snapshot
........
  r23711 | kohsuke | 2009-11-13 14:27:28 -0800 (Fri, 13 Nov 2009) | 1 line
  
  Session -> Reactor
........
  r23782 | kohsuke | 2009-11-17 10:35:14 -0800 (Tue, 17 Nov 2009) | 1 line
  
  Poorman's clone of JDK6 ServiceLoader.
........
  r23783 | kohsuke | 2009-11-17 10:56:25 -0800 (Tue, 17 Nov 2009) | 1 line
  
  Integrated the fatal support so that all errors are sent to the listener.
........
  r23784 | kohsuke | 2009-11-17 10:58:07 -0800 (Tue, 17 Nov 2009) | 1 line
  
  with the new reactor initialization, things are getting too verbose
........
  r23785 | kohsuke | 2009-11-17 11:18:45 -0800 (Tue, 17 Nov 2009) | 1 line
  
  failing to load jobs are non-fatal, too
........
  r23788 | kohsuke | 2009-11-17 13:18:59 -0800 (Tue, 17 Nov 2009) | 1 line
  
  logging the exception properly
........
  r23809 | kohsuke | 2009-11-17 18:45:47 -0800 (Tue, 17 Nov 2009) | 1 line
  
  releasing 1.1 as milestone
........
  r23810 | kohsuke | 2009-11-17 18:47:37 -0800 (Tue, 17 Nov 2009) | 2 lines
  
  - use a better idiom for building a sequence
  - use null display name to signify internal book-keeping tasks that's not worth displaying
........
  r23817 | kohsuke | 2009-11-18 07:54:17 -0800 (Wed, 18 Nov 2009) | 1 line
  
  removed accidental JDK6 dependency.
........
  r23859 | kohsuke | 2009-11-19 11:03:28 -0800 (Thu, 19 Nov 2009) | 1 line
  
  introducing the strategy pattern to hook into key decision making points during the start up
........
  r23870 | kohsuke | 2009-11-19 14:33:07 -0800 (Thu, 19 Nov 2009) | 1 line
  
  bug fix. These steps add additional tasks to the reactor, so they need to also prevent future milestones from getting attained.
........
  r23879 | kohsuke | 2009-11-19 16:54:59 -0800 (Thu, 19 Nov 2009) | 1 line
  
  moved the logic to the strategy.
........
  r23899 | kohsuke | 2009-11-20 09:32:13 -0800 (Fri, 20 Nov 2009) | 1 line
  
  handle duplicate plugins better
........
  r23900 | kohsuke | 2009-11-20 10:06:42 -0800 (Fri, 20 Nov 2009) | 1 line
  
  support pre-exploded plugin
........
  r23901 | kohsuke | 2009-11-20 10:49:04 -0800 (Fri, 20 Nov 2009) | 1 line
  
  making it a subtype
........
  r23902 | kohsuke | 2009-11-20 10:54:42 -0800 (Fri, 20 Nov 2009) | 1 line
  
  allow InitStrategy to skip some tasks
........
  r23903 | kohsuke | 2009-11-20 11:03:38 -0800 (Fri, 20 Nov 2009) | 1 line
  
  doc improvement.
........
  r23904 | kohsuke | 2009-11-20 11:03:49 -0800 (Fri, 20 Nov 2009) | 1 line
  
  no need to throw exceptions
........
  r23906 | kohsuke | 2009-11-20 11:17:34 -0800 (Fri, 20 Nov 2009) | 1 line
  
  debug switch to disable the automatic launch of slaves
........
  r23907 | kohsuke | 2009-11-20 11:25:15 -0800 (Fri, 20 Nov 2009) | 1 line
  
  added a magic object for cancelling all saves
........
  r23909 | kohsuke | 2009-11-20 11:29:53 -0800 (Fri, 20 Nov 2009) | 1 line
  
  moving initialization up
........
  r23913 | kohsuke | 2009-11-20 13:32:08 -0800 (Fri, 20 Nov 2009) | 1 line
  
  seeing heap space problem during tests
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23992 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 19:33:33 +00:00
kohsuke 7335533d68 [FIXED HUDSON-4873] in 1.336
Matrix configuration builds should continue even when Hudson is about to shut down.
    (<a href="https://hudson.dev.java.net/issues/show_bug.cgi?id=4873">issue 4873</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23980 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 16:55:03 +00:00
kohsuke 686d1b9283 [HUDSON-4876] Compatibility for the caller. This is more convenient for Jelly scripts, too.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23979 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 15:00:31 +00:00
kohsuke a9f3c9c1e9 [FIXED HUDSON-4876] If restart is not supported, explain why.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23978 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 14:53:06 +00:00
mindless 57f34037d2 [FIXED HUDSON-4924] avoid exception if a plugin implementing LabelFinder
extension provides a null label.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23975 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-23 06:57:25 +00:00
mindless 3be4551e3b [FIXED HUDSON-1986] Update or remove lastSuccessful/lastStable symlinks on filesystem
as appropriate when a build is deleted.  Based on patch from xlv.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23973 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-22 23:02:55 +00:00
mindless b4af8a5a2a Fix createSymlink so it overwrites existing link properly if the existing
link points to a non-existent file/dir (in this case File.exists() returns
false, so it was not removed before creating new symlink).
This change also avoids exec of "rm -rf" when simple File.delete() succeeds.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23972 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-22 22:54:13 +00:00
mindless b86b2d7226 set logger name in LogRecords sent from LogTaskListener,
but also check for null logger name in LogRecorder to avoid
NPE from any other such case.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23971 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-22 22:52:00 +00:00
mindless a96c6e02f8 [FIXED HUDSON-4894] match windows absolute path like C:/path as requested by torbent.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23889 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 16:14:51 +00:00
kohsuke 2e3365a070 Improved the error diagnostics on the failure to establish connection with JNLP slaves early on.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23883 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 02:52:49 +00:00
kohsuke 63e48ae865 improved the diagnosability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23882 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 01:49:03 +00:00
mindless b6600a3fbd User pages showed add/edit description link to users without permission to edit,
and guests were allowed to edit the user profile for anonymous user.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23881 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 01:33:09 +00:00
mindless 3a244cf8a0 Computer.CONFIGURE permission has existed for a long time, but it only shows the
configure link.. admin permission was needed to actually configure.
Fixed this so configuration can be done, and also hide the configure link for
master node unless you also have admin permission.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23880 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-20 00:55:07 +00:00
mindless c078a6c855 Improve display of cause of slaves being offline.
- Removed "failed to launch" message from ComputerLauncher/main.jelly
  This message was always shown, even if slave was offline for other reasons.
- Instead, added new OfflineCause.LaunchFailed which is set in SlaveComputer if channel
  is not set after calling launcher.  Now this shows the "failed to launch" message.
- Moved/copied existing translations for these strings to their new locations.
- Expanded message for in-demand strategy to say "will be relaunched when needed"
- Added text explanation and fixed display of exception for ChannelTermination cause
- Use class="warning" for default display of OfflineCause
- Added some @Override annotations


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23876 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 23:55:43 +00:00
mindless 991e7f8fdd [FIXED HUDSON-3890] Fix in-demand RetentionStrategy and more offline-slave fixes.
- Use isConnecting() instead of lastConnectActivity!=null in checking forceReconnect
  param.. var never resets to null, so this prevented forceReconnect==false from ever
  reconnecting (which broken in-demand strategy since 1.302 when it started using false)
- Only set ChannelTermination offline cause when the exception param is non-null.
  On orderly shutdown this was replacing the real cause of going offline.
- In setNode try to delegate to RetentionStrategy rather than calling connect directly.
  Reconfiguring a node was launching slave even if it wasn't needed per its strategy.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23875 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 23:37:45 +00:00
mindless 5f4d50dbfe Allow zero for inDemandDelay in RetentionStrategy.Demand.
Don't write "launching" in log if launch is not supported.
Don't need to call check() every minute for NOOP strategy.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23874 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 23:02:11 +00:00
mindless a8ffa18f8d fix a couple typos in comments
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23871 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 22:42:44 +00:00
kohsuke 5f7c8023a7 Gracefully detect the double loading of JNA instead of failing later with NoClassDefFoundError.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23864 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 22:24:43 +00:00
mindless e143c96f5c [FIXED HUDSON-4894] update DRIVE_PATTERN so a path like C:\ is recognized as absolute
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23832 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 23:38:20 +00:00
kohsuke b2dc60b246 reverting a typo introduced in r23543
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23831 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 23:22:00 +00:00
mindless 03bc0a168d [FIXED HUDSON-4877] Fixed handling of non-ASCII characters in external job submission
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23819 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 17:47:02 +00:00
mindless f71c79918a [FIXED HUDSON-4878] r22948 introduced a little bug in that a label with no nodes
generates an exception when trying to get the cause of blockage (calls next() on
empty iterator)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23811 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 06:37:09 +00:00
mindless 65b3e5102f [FIXED HUDSON-2360] Space in axis value for matrix project was lost on reconfiguration
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23757 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-16 18:41:05 +00:00
mindless 4039345b0e [HUDSON-4066] Add version# is slave.jar and report this in log when a node is launched.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23750 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-16 05:21:31 +00:00
mindless 0d39e761b3 [FIXED HUDSON-3057] configure RememberMeAuthenticationProvider with PAMSecurityRealm,
so "remember me" feature works.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23740 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-15 22:44:18 +00:00
mindless a93e851797 [HUDSON-4831] Record duplicate causes again, but now update display on the build page
to say (# times) for duplicates instead of listing them many times.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23731 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-14 22:27:31 +00:00
mindless 20688553cb [FIXED HUDSON-4831] prevent duplicate cause entries for a build
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23699 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 05:47:16 +00:00
kohsuke 36040b9a7a [FIXED HUDSON-4080] Node variables not passed through to Maven jobs. In 1.335.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23695 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 02:54:36 +00:00
kohsuke d4ad980691 Merged revisions 23689-23691 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23689 | kohsuke | 2009-11-12 15:35:27 -0800 (Thu, 12 Nov 2009) | 1 line
  
  improved diagnosability
........
  r23690 | kohsuke | 2009-11-12 18:03:42 -0800 (Thu, 12 Nov 2009) | 1 line
  
  adding a probe to diagnose a sporadic test failure
........
  r23691 | kohsuke | 2009-11-12 18:14:21 -0800 (Thu, 12 Nov 2009) | 1 line
  
  I think this is causing a test failure in ExtendedReadPermissionTest, as the existing alice/bob/charlie users prevent the data on the disk from loading.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23692 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 02:18:09 +00:00
mindless 8406095df3 change system property from .neverUpdate to .never to match what UpdateCenter had,
and is documented on wiki


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23683 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 18:01:01 +00:00
kohsuke d0555e8973 this isn't specific to Maven anymore
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23681 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 15:34:27 +00:00
kohsuke 121c258ff1 socket to channel needs to use a Socket(Input|Output)Stream
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23680 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 15:33:18 +00:00
kohsuke ca54609aa2 Hudson's UDP broadcast/discovery now supports IP multicast
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23679 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 15:08:48 +00:00
mindless 34ccf95285 [HUDSON-4822] patch from lkishalmi to return after sending redirect in doLoginEntry
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23678 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 04:24:47 +00:00
mindless f73f51d2b4 Fix so disabled permissions are not shown in project-specific permission matrix
(EXTENDED_READ has been exposed there since 1.325 even w/o Extended-Read plugin
 to enable that permission)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23659 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 20:16:27 +00:00
kohsuke f055935603 Supported a relative path in the custom workspace directory, which resolves from FS root of the slave.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23656 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 19:20:15 +00:00
mindless 2fae128166 add missing checkPermission(CONFIGURE) to POST data to /job/{jobname}/config.xml
(was only checking EXTENDED_READ).  Added unit test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23652 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 04:25:05 +00:00
mindless 9d750356e1 [FIXED HUDSON-4588] catch NPE from TestResultAction constructor and report a nicer message
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23640 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 00:05:45 +00:00
mindless ed5d70d191 [FIXED HUDSON-4573] Write log message and ignore unrecognized permissions when loading XML,
so these behave the same as other unknown fields (builders, publishers, etc).
Also changed context.convertAnother() calls to simpler reader.getValue()/writer.setValue()


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23637 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 22:43:38 +00:00
mindless bc94c23868 Plugin manager now shows warning for upgrade/install of plugins
into a Hudson that is older than the plugin was built for.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23634 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 20:30:51 +00:00
mindless 79f22cd661 Project read permission was not enforced via /jobCaseInsensitive/jobname path.
Added unit test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23629 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 07:08:14 +00:00
kohsuke 38da83339b [FIXED HUDSON-4802] in 1.334. The patch was slightly modified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23626 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:47:30 +00:00
kohsuke 80db087f64 added a bunch of CLI commands to Computer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23617 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 22:10:17 +00:00
kohsuke 846851344a doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23616 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 22:05:24 +00:00
mindless 14a37dba5b [FIXED HUDSON-4557] Moving consoleText handling from jelly to java in r20927
caused Content-Length header to no longer be written.  wget/curl seem ok with
this, but browsers display nothing for "view as plain text".
Stapler's DefaultScriptInvoker wraps the OutputStream in a filter to prevent
jelly from flushing the output; copied this into Run.doConsoleText and now
the Content-Length header gets written again, for both compressed/plain output.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23605 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 17:53:34 +00:00
mindless 6ebcd2d97d [FIXED HUDSON-4765] Fix broken links for failed tests on MatrixBuild page.
Also removed extra slashes in links on MatrixTestResult page.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23569 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 17:44:44 +00:00
mindless 2b1a457f68 Deprecate util.StringConverter2 (extends deprecated XStream class,
but can't change it here to keep binary compatibility).
Add new HeapSpaceStringConverter to replace this.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23564 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 01:50:42 +00:00