Commit Graph
13178 Commits
Author SHA1 Message Date
Jesse Glick 52c7ca45da Adding a warning to Javadoc. 2015-11-05 09:13:14 -05:00
Jesse Glick 054a329c59 [SECURITY-206] Need to call ChannelConfigurator on JNLP slave channels. 2015-11-04 17:40:20 -05:00
Kohsuke Kawaguchi abe561499b [SECURITY-214] OfflineCause.toString() is a string, not necessarily HTML 2015-11-03 19:46:28 -08:00
Jesse Glick 5192c9e3d6 Merge pull request #23 from varmenise/security-186
[SECURITY-186] check user permissions in Queue API
2015-10-28 13:10:56 -04:00
Jesse Glick 2e439dc70b Merge pull request #34 from varmenise/security-184
[SECURITY-184] fix test failures checking null value
2015-10-28 13:08:55 -04:00
Valentina Armenise d85bf66542 [SECURITY-184] fix test failures checking null value 2015-10-15 10:13:19 +02:00
Valentina Armenise 581eb9ceb3 [SECURITY-186] check user permissions when calling QUEUE API 2015-10-13 15:56:46 +02:00
Oleg Nenashev 0594c4cbcc [SECURITY-153] Hide references to inaccessible jobs in fingerprints. 2015-10-12 17:37:53 -04:00
Jesse Glick 234303da82 Merge pull request #33 from jenkinsci-cert/SECURITY-200-1.580
[FIXED SECURITY-200] - Do not expose Api tokens to other users by default
2015-10-12 16:32:37 -04:00
Jesse Glick e3ee63993b Merge pull request #29 from jenkinsci-cert/SECURITY-195-1.580
[SECURITY-195] - Prevent the folder escaping
2015-10-12 16:26:35 -04:00
Jesse Glick 25360f5451 Merge pull request #17 from varmenise/security-184
[SECURITY-184] check secret-key in handshake
2015-10-12 16:23:59 -04:00
varmenise ef64bb20dd [SECURITY-184] revised version of the orginal patch 2015-10-07 11:00:06 +02:00
akshayabd 91515d31ce [SECURITY-184]check secret-key in handshake 2015-10-07 10:43:48 +02:00
Oleg Nenashev b3f16489ad [FIXED SECURITY-200] - Do not expose Api tokens to other users by default
System property can be used to restore the original behavior
2015-09-29 23:44:21 +03:00
Oleg Nenashev 45d65c2fa0 Fix comments from @jglick 2015-09-29 23:18:25 +03:00
Jesse Glick d933964429 Merge pull request #31 from jenkinsci-cert/SECURITY-192-1.580
[FIXED SECURITY-192] - Require Jenkins.READ permissions to access CLI pages
2015-09-29 16:12:35 -04:00
valentina 553513a71c Merge pull request #25 from varmenise/security-173
[SECURITY-173] use XMLUtils safe transformation to create a job from xml
2015-09-25 13:52:42 +02:00
Valentina Armenise e78e9e8144 [SECURITY-173] use XMlUtils safe transformation to create a job from xml 2015-09-25 11:52:24 +02:00
Oleg Nenashev ed0bfe3014 Restrict everything excepting the predefined list of entries. 2015-09-25 10:52:53 +03:00
Oleg Nenashev 9e439d462c [FIXED SECURITY-192] - Require Jenkins.READ permissions to access CLI pages 2015-09-21 13:46:29 +03:00
Oleg Nenashev f22db8a7fa Update the implementation and tests according to comments from @stephenc 2015-09-10 16:47:08 +03:00
Oleg Nenashev 5431e39721 [SECURITY-195] - Throw the MalformedURLException if the request includes the relative addressing 2015-09-10 16:46:59 +03:00
Oleg Nenashev f53802bb82 [SECURITY-169] - Convert crumb issuer salt to the confidential key 2015-09-09 14:51:59 -04:00
Kohsuke Kawaguchi c545777bd2 Merge branch 'security' into security-stable-1.580 2015-03-16 15:27:37 -07:00
Kohsuke Kawaguchi 6990809360 Merge pull request #14 from jenkinsci-cert/SECURITY-177
[SECURITY-177] Reflected XSS in AdjunctManager.doDynamic
2015-03-16 22:24:04 +00:00
Jesse Glick 1780041009 Merge branch 'security' into security-stable-1.580
Conflicts:
	test/src/test/java/hudson/model/UserTest.java
2015-03-16 18:10:27 -04:00
Kohsuke Kawaguchi f58ba6e72f Merge pull request #15 from jenkinsci-cert/SECURITY-171
[SECURITY-171] XSS in FormValidation._error(..., Throwable, ...)
2015-03-16 22:03:51 +00:00
Oliver Gondža f880d8d2cd [SECURITY-171] test 2015-03-07 20:32:17 +01:00
Kohsuke Kawaguchi feb2703adb [FIXED SECURITY-171] 2015-03-07 10:28:40 -08:00
Kohsuke Kawaguchi 1699e2c1f3 [FIXED SECURITY-177]
Add nosniff header liberally to every request we serve.
2015-03-07 10:22:24 -08:00
Kohsuke Kawaguchi c826a1b827 [FIXED SECURITY-180] 2015-03-07 09:35:28 -08:00
Jesse Glick 664748283e Merge branch 'security' into security-stable-1.580 2015-02-27 13:44:12 -05:00
James Nord b8c9841c30 [SECURITY-167] Plugin manager was also vulnerable.
Although the plugiun manager was vulnerable getting information
out of Jenkins was harder - however it would still be possible to
do bad things such as reading from /dev/zero on Linux
2015-02-27 18:18:23 +00:00
Jesse Glick d6d127d637 Merge branch 'security' into security-stable-1.580
Conflicts:
	test/src/test/java/hudson/tasks/ArtifactArchiverTest.java
2015-02-07 11:28:06 -05:00
Jesse Glick be06d6c4b8 Merge pull request #11 from jenkinsci-cert/SECURITY-162
[SECURITY-162] Forbid symlink attacks from artifact archiving
2015-02-07 11:25:08 -05:00
Jesse Glick ade1d43664 Merge branch 'security' into security-stable-1.580
Conflicts:
	core/src/main/java/hudson/model/Api.java
2015-02-06 17:24:01 -05:00
Robert Sandell 1887656c11 Merge pull request #9 from jenkinsci-cert/SECURITY-165
[SECURITY-165] blacklist the document xpath function for use in Api
2015-02-06 18:18:30 +01:00
Jesse Glick 1bba1ac3c6 [SECURITY-162] Capture the root directory in VirtualFile.forFile and reject attempts to escape it. 2015-02-06 11:37:24 -05:00
Robert Sandell c03afbbd4f Moved new class to other package 2015-02-06 14:52:20 +01:00
Robert Sandell 1629a93fbc Tidy up
Review comments fixed:
 Added license header
 Reformat the issue comment
 Restricted NoExternalUse
 toLowerCase in English locale
 lesser resolution of declared exception from the test
2015-02-06 10:34:41 +01:00
Jesse Glick f3fe83803d Merge branch 'security' into security-stable-1.580
Conflicts:
	core/src/main/java/hudson/ClassicPluginStrategy.java
	core/src/main/java/hudson/cli/AddJobToViewCommand.java
	core/src/main/java/hudson/model/Run.java
	core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java
	core/src/main/java/jenkins/model/IdStrategyDescriptor.java
	core/src/main/resources/hudson/model/AbstractProject/configure-common_ru.properties
	core/src/main/resources/hudson/model/AbstractProject/configure-common_tr.properties
	core/src/main/resources/hudson/model/Job/index.jelly
	core/src/main/resources/jenkins/model/IdStrategy/config.jelly
	core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly
	core/src/main/resources/jenkins/security/s2m/AdminCallableMonitor/message.jelly
	core/src/main/resources/jenkins/security/s2m/MasterKillSwitchWarning/message.jelly
	core/src/main/resources/jenkins/slaves/systemInfo/EnvVarsSlaveInfo/systemInfo.jelly
	core/src/main/resources/jenkins/slaves/systemInfo/Messages.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_da.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_de.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_es.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_fr.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_ja.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_nl.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_pt_BR.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_sv_SE.properties
	core/src/main/resources/jenkins/slaves/systemInfo/Messages_zh_TW.properties
	core/src/main/resources/lib/form/link.jelly
	core/src/main/resources/lib/hudson/failed-test_pt_BR.properties
	core/src/main/resources/lib/hudson/project/configurable.properties
	core/src/main/resources/lib/hudson/project/configurable_bg.properties
	core/src/main/resources/lib/hudson/project/configurable_es_AR.properties
	core/src/main/resources/lib/hudson/project/configurable_eu.properties
	core/src/main/resources/lib/hudson/project/configurable_gl.properties
	core/src/main/resources/lib/hudson/project/configurable_hi_IN.properties
	core/src/main/resources/lib/hudson/project/configurable_it.properties
	core/src/main/resources/lib/hudson/project/configurable_nl.properties
	core/src/main/resources/lib/hudson/project/configurable_sl.properties
	core/src/main/resources/lib/hudson/project/configurable_tr.properties
	core/src/main/resources/lib/hudson/project/console-link.jelly
	core/src/main/resources/lib/hudson/project/console-link_pt_BR.properties
	core/src/main/resources/lib/layout/breadcrumbBar_pt.properties
	core/src/main/resources/lib/layout/layout_pt.properties
	core/src/main/resources/lib/layout/main-panel_pt.properties
	core/src/main/resources/lib/layout/pane_de.properties
	core/src/main/resources/lib/layout/pane_pt.properties
	core/src/main/resources/lib/layout/pane_pt_BR.properties
	core/src/main/resources/lib/layout/progressiveRendering_pt.properties
	core/src/main/resources/lib/layout/task_pt.properties
	pom.xml
	test/pom.xml
	test/src/test/resources/lib/layout/IconTest/03_testTask.jelly
	war/src/main/webapp/scripts/msie.js
2015-02-05 16:27:47 -05:00
Jesse Glick a001f71ded Merge pull request #6 from jenkinsci-cert/SECURITY-125
[SECURITY-125] Matrix project script security
2015-02-05 15:44:47 -05:00
Robert Sandell de4414cbf3 [SECURITY-165] blacklist the document xpath function for use in Api 2015-02-05 20:37:57 +01:00
James Nord 5564a62eb6 Merge pull request #7 from jenkinsci-cert/SECURITY-167_2
[SECURITY-167] Followup tweaks to address review comments.
2015-02-05 16:19:14 +00:00
James Nord fe5077e534 remove uneeded "@since TODO" 2015-02-05 14:45:35 +00:00
Ryan Campbell 1338e661aa Merge pull request #5 from jenkinsci-cert/SECURITY-166
Fixes for SECURITY-166
2015-02-05 08:44:51 -06:00
James Nord 1786daa514 [SECURITY-167] Followup tweaks to address review comments.
Addresses some comments received after the original fix was merged.
2015-02-05 14:36:29 +00:00
Jesse Glick 228e3d90b6 Merge branch 'security' into security-stable-1.580
Conflicts:
	core/src/main/java/hudson/model/AbstractItem.java
	core/src/main/resources/hudson/model/Messages.properties
2015-02-05 08:52:24 -05:00
James Nord 065c3b40d3 Merge pull request #4 from jenkinsci-cert/security-167
SECURITY-167

defend against XXE attacks in core https://issues.jenkins-ci.org/browse/SECURITY-167
2015-02-05 10:21:26 +00:00
Jesse Glick 41786ad019 Preventing cyclic dependencies among bundled plugins.
Reproducible for example via HelpLinkTest.testMatrixConfig.
Otherwise have: matrix-project → script-security → matrix-auth → windows-slaves → antisamy-markup-formatter → matrix-project
Tried to come up with a generic way of doing this automatically, but failed.
Just because we bundle a particular build of some plugin does not mean it was built against anything recent,
and for use on older cores it may well need some of those implicit dependencies.
2015-02-04 16:45:53 -05:00