Commit Graph
184 Commits
Author SHA1 Message Date
Basil Crow 632033d6ad Sort imports (#5732) 2021-09-18 09:39:42 +01:00
Basil Crow bd7c823c27 Remove unnecessary parentheses (#5576) 2021-06-25 09:23:37 +01:00
Basil CrowandDaniel Beck b8c20c6428 Fix violations of a handful of Error Prone checks (#5519)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2021-06-14 16:45:34 +01:00
Basil Crow 56216ba477 Ensure files end with a newline with Spotless rather than Checkstyle 2021-05-07 19:56:27 -07:00
Jesse Glick 82f3bfd74d [JENKINS-64294] Buffer stdin for jenkins-cli.jar 2021-04-30 14:53:27 -04:00
Basil Crow 95e85495ca Enable AvoidStarImport Checkstyle check (#5420) 2021-04-28 17:28:39 +08:00
Basil Crow f6378676b1 Add missing @Override annotations (#5430) 2021-04-28 17:28:25 +08:00
res0nance 9dc1c9aa12 Remove unused import 2021-03-12 19:25:01 +08:00
Oleg Nenashev 20c01e9005 Merge pull request #5206 from res0nance/bump-sshd-core
Bump sshd-core to 2.6.0 and update tests
2021-03-12 11:59:23 +01:00
Basil Crow 881365d30b Enable RedundantModifier Checkstyle check 2021-03-08 07:56:42 -08:00
Basil Crow 44c5342c58 Declare modifiers in JLS order (#5339) 2021-03-08 07:58:59 +00:00
Basil Crow bd1d5e09bd Add missing @Override annotations 2021-03-02 14:04:48 -08:00
res0nance 4d818c294f Bump sshd-core to 2.6.0 and update tests 2021-01-25 18:00:03 +08:00
dependabot[bot]andRaihaan Shouhell 7a5d49594c Bump tyrus-standalone-client-jdk from 1.12 to 2.0.0 (#5128)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2020-12-20 13:37:47 +00:00
StefanSpiekerandOleg Nenashev 463cd113ba Minor refactorings either for performance or readability (#4845)
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-07-17 15:14:46 +01:00
Søren A D 90f3047483 Support for bearer tokens in jenkins-cli (#4673)
* added -bearer argument to jenkins-cli

* updated message related to bearer/auth. added warning when both are used anyway.
2020-05-24 17:13:23 +02:00
Jeff Thompson ce4bc37a0d Remove suppression that were inadvertently merged back in. 2020-01-23 15:04:58 -07:00
Jeff Thompson 348a26f77e Narrow the suppression.
And add TODO connected with JENKINS tickets for relevant issues.
2020-01-23 14:59:51 -07:00
Jeff Thompson ced25e51fd Make sure everything has a justification.
And move a couple of items to the exclude file. If we ever get to a lower threshold, these will show up all over the place.
2020-01-23 14:55:59 -07:00
Jeff Thompson c76ee59810 Add findsecbugs plugin to spotbugs.
And suppress existing warnings. We should clean some of them up, but that's for different PRs.
2020-01-23 14:53:53 -07:00
Jesse Glick 5b5040298f [JEP-222] WebSocket support (#4369)
* Playing with WebSocket connections.

* Pluggable handlers.

* errorWithoutStack

* Server-side keepalive pings.

* Redesigned to work as an HttpResponse.

* Unused dep.

* Comment on JnlpSlaveRestarterInstaller.

* Sketch of WebSocket-based endpoint for JNLPLauncher.

* Comment.

* Test enhancement.

* Making it more obvious from JNLPLauncherTest where remoting.jar is being loaded from.

* Reworked protocol to negotiate remote capabilities.

* Unhelpful comment.

* Simplifying handshake to use HTTP headers.

* Moving code into top-level classes and otherwise prettifying.

* Linking to upstream PRs.

* Timestamped snapshot + incremental.

* Picking up incrementalified build of winstone.

* Working around https://github.com/kohsuke/access-modifier/pull/17.

* Finally have an incrementalified build of remoting.

* Use -webSocket option.

* Handling some close and error methods.

* Sending X-Remoting-Minimum-Version.

* If hudson.remoting.jnlp.Main._main fails, show the error.

* Comment.

* GUI analogue of https://github.com/jenkinsci/remoting/pull/357/commits/86cea5b83fd2fc93a9fc10896962eb42c95f80a0.

* Missing since tags.

* Capitalization.

* WebSockets.isSupported

* Rather than hiding JNLPLauncher.DescriptorImpl when the TCP port is disabled, always display it, but show form validation appropriate to WebSocket or TCP mode.

* Form validation fixes.

* Minor test improvements.

* Reworked WebSocketAgents to be compatible with JnlpAgentReceiver.

* Removing WebSocketSession.keepAlive in favor of a global setting applicable to all services.

* Add a -webSocket option to the Jenkins CLI.

* Using a snapshot deployment of Remoting, pending INFRA-2379.

* After #3838 there is no reason to recheck authentication after parsing CLICommand arguments.

* Advertise the -webSocket option.

* Adapt to newer HtmlUnit.

* https://github.com/HtmlUnit/htmlunit/pull/29 seems to have been incompatible.
WebClient.addRequestHeader will no longer override a header in a WebRequest,
such as when the same WebClient/WebRequest was previously used with different headers.

* Tracked down a behavioral change in passing through URL-encoded path characters.
https://github.com/HtmlUnit/htmlunit/commit/2c4956863420e4baef9d3d8c23ec0577ec64d2bf picks up
https://github.com/apache/httpcomponents-client/commit/8c04c6ae5e5ba1432e40684428338ce68431766b which is the actual change.

* Disabled TCP port does not matter in WebSocket mode.

* Shade dependencies needed for jenkins-cli.jar.

* Help text edit.

* https://github.com/jenkinsci/winstone/pull/79 was released as 5.5.

* https://github.com/jenkinsci/jenkins-test-harness/pull/183 released as 2.59.

* https://github.com/jenkinsci/jenkins/pull/4387#discussion_r362696234

* Bumping remoting to a new deployed snapshot.

* Need https://github.com/jenkinsci/winstone/pull/86.

* https://github.com/jenkinsci/winstone/pull/86 released as 5.6.

* Introduced constant for X-Remoting-Minimum-Version.

* s/slave/agent/ in GUI

* Removing in-JVM test, as it was no longer useful after introducing shading anyway.

* Bump.

* No need to check for anonymous CONNECT here.

* s/jenkins.slaves/jenkins.agents/g for new code.

* Restrict the diagnostic endpoint to administrators.

* Fixed Javadoc import after package move.

* https://github.com/jenkinsci/remoting/pull/357 released as 4.0.
2020-01-21 07:00:39 +01:00
Jesse Glick 642a4ff0f3 jenkins-cli.jar no longer needs to bundle remoting. 2019-11-08 17:28:37 -05:00
Basil Crow 20786f087b Fix dangling Javadocs 2019-10-19 14:02:59 -07:00
Oleg Nenashev abf4695421 Merge pull request #4263 from daniel-beck/JENKINS-59267
[JENKINS-59267] Increase ping frequency to prevent timeouts, and make it configurable
2019-10-06 11:31:31 +02:00
Daniel Beck 84b07be2b7 [JENKINS-59267] Increase ping frequency to prevent timeouts 2019-10-04 14:39:41 +02:00
a544a3b3b2 Extracted duplicate code (#4206)
* extracted duplicate code into helper method

* merged two identical switch statements

* Update cli/src/test/java/hudson/cli/PrivateKeyProviderTest.java

Co-Authored-By: Matt Sicker <boards@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* Update cli/src/test/java/hudson/cli/PrivateKeyProviderTest.java

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* renamed method as suggested by timja
2019-09-28 10:29:13 +02:00
StefanSpieker 69a524ab0b Fixed deprecated warnings without changing behaviour (#4177)
* fixed deprecated warnings without changing behaviour

* use Charset.defaultCharset() instead of null
2019-09-13 09:45:34 +02:00
Raihaan Shouhell a7e804399c Replace Apache Commons Codec Base64 implementations with standard java.util.Base64 (#4169)
* Replace apache base64 with java

* Swap to regular encoder
2019-09-04 00:08:15 +02:00
Ivan Fernandez Calvo 46cbaf51e8 [JENKINS-56167] Replace Trilead-ssh2 PEMParser class (#3902)
* [JENKINS-56167] Replace Trilead-ssh2 PEMParser class by Mina SSHD SecurityUtils.loadKeyPairIdentity implementation

* Update PrivateKeyProviderTest.java

* Update cli/src/test/java/hudson/cli/PrivateKeyProviderTest.java

Co-Authored-By: kuisathaverat <kuisathaverat@users.noreply.github.com>

* Update PrivateKeyProviderTest.java

* Update PrivateKeyProvider.java

* Update PrivateKeyProviderTest.java

* Update PrivateKeyProvider.java
2019-02-25 10:11:42 +01:00
Jesse Glick f150370166 Forgotten @Deprecated. 2019-02-14 14:45:52 -05:00
Jesse Glick f7ff281997 Removing code to support the Remoting-based CLI. 2019-01-08 22:39:07 -05:00
Francisco Fernández f6ef70a8d4 [JENKINS-54310] java.io.IOException: Stream is closed when the CLI has not read entirely the input (#3708)
* [JENKINS-54310] read the input at once

* [JENKINS-54310] reading as String

* [JENKINS-54310] Change the approach for those CLI that open a shell
2018-11-07 10:08:52 +03:00
Francisco Fernández e998a7808f [JENKINS-53792] Env vars to configure CLI -auth option (#3653)
* [JENKINS-53792] Add env vars for auth option

* [JENKINS-53792] Fix encoding after first commit

* [JENKINS-53792] Better readability

* [JENKINS-53792] Refactor and use the ApiToken

* [JENKINS-53792] Fix encoding
2018-10-06 16:05:38 +02:00
Oleg Nenashev d9d31f9914 Cleanup Javadoc errors in hudson.cli.PrivateKeyProvider (fails in Java 11) 2018-09-21 17:47:03 -07:00
Oleg Nenashev bb89137596 Merge pull request #3338 from oleg-nenashev/findbugs/JENKINS-50064
Cleanup FindBugs in CLI + some refactoring
2018-03-18 06:59:38 +01:00
Jesse Glick f9e4df59d5 Merge branch 'master' into anonymous-warning-JENKINS-49994 2018-03-12 12:24:31 -04:00
Oleg Nenashev 5e0e553353 [JENKINS-50064] - Suppress FindBugs warning in CLI, switch to the medium level 2018-03-10 21:54:43 +01:00
Jesse Glick d94049cc71 https://github.com/kohsuke/localizer/pull/11 actually works now. 2018-03-09 12:51:56 -05:00
Jesse Glick 73b16084f9 [JENKINS-49994] Warn about Remoting serialization of anonymous inner classes and their ilk. 2018-03-07 14:52:34 -05:00
Jesse Glick 5e84c5470f [JENKINS-18114] Fixing CLI crumbs (#3019)
* [JENKINS-18114] The CLI client already asks for a crumb; we just to actually serve it, from CrumbIssuer.RestrictedApi.

* serveCliActionToAnonymousUserWithoutPermissions() was checking some stuff better checked by authentication(), and was failing since this fake client was not passing a crumb.

* Bring back CliCrumbExclusion, needed for anonymous use with no read access, and just let the client stop asking for a crumb.

* Added FullDuplexHttpServiceTest; useful to have a simple, self-contained demonstration of the HTTP Duplex transport.
2017-09-22 11:55:52 +03:00
Jesse Glick dc06c3f03b [FIXED JENKINS-46659] Avoid Jetty timeouts by sending a ping-like packet every 10s while a CLI command is running. 2017-09-09 15:45:26 -04:00
Jesse Glick 00956ff9da [JENKINS-39738, JENKINS-43668] - Pick up SSHD module including sshd-core 1.6.0 (#2853)
* Pick up SSHD module including sshd-core 1.4.0.

* [FIXED JENKINS-39738] Picking up https://github.com/jenkinsci/sshd-module/commit/bb6963453086edef4e600abb2740182cd2f4ade0

* Picking up Apache SSHD 1.6.0 & Jenkins sshd module 2.0.
2017-07-08 01:01:01 +02:00
Oliver Gondža 662df37426 Resolving the redirect is OK to fail 2017-06-19 13:22:25 +02:00
Oliver Gondža d9cb39f95f Use authorization to resolve redirect 2017-06-19 12:52:18 +02:00
Oliver Gondža 552d2835cc Address review comment 2017-06-19 09:34:44 +02:00
Oliver Gondža 741be05517 [FIXED JENKINS-44361] Follow HTTP redirects while initiating CLI connection 2017-05-23 15:16:04 +02:00
Stephen Connolly 3871d7778e [JENKINS-43531] Plugins may not be expecting InvalidPathException
- Plugins should really be expecting it, but as historically they have not, may as well convert to IOE for them
2017-04-19 14:04:33 +01:00
Jesse Glick 7c16d8dc46 Fix Javadoc generation on JDK 8. 2017-04-11 09:26:45 -04:00
Jesse Glick 729016989e [FIXED JENKINS-41745] Merged #2795: non-Remoting-based CLI. 2017-04-07 20:08:05 -04:00
Jesse Glick 0f87e10a69 @oleg-nenashev requested this be decoupled from https://github.com/jenkinsci/sshd-module/pull/10. 2017-04-07 11:29:21 -04:00