Commit Graph
64 Commits
Author SHA1 Message Date
Basil Crow 632033d6ad Sort imports (#5732) 2021-09-18 09:39:42 +01:00
Stefan SpiekerandTim Jacomb f185e66ef7 Replaced own implementation with standard Java function (String.CASE_INSENSITIVE_ORDER) (#5569)
* replaced own implementation with standard Java function (String.CASE_INSENSITIVE_ORDER)

* mark class as Deprecated in favor of String.CASE_INSENSITIVE_ORDER

* Fix javadoc

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
2021-08-03 13:28:45 +01:00
Basil Crow bd7c823c27 Remove unnecessary parentheses (#5576) 2021-06-25 09:23:37 +01:00
Daniel Beck 239a6e635c Terminology cleanup: Internal and Javadoc changes 2021-06-20 16:24:43 +02:00
Basil Crow c904989067 Deprecate Util#join(Collection, String) in favor of String#join(CharSequence, Iterable) (#5467) 2021-05-09 08:08:59 +01:00
Basil Crow f6378676b1 Add missing @Override annotations (#5430) 2021-04-28 17:28:25 +08:00
Basil Crow 881365d30b Enable RedundantModifier Checkstyle check 2021-03-08 07:56:42 -08:00
James Nord 1f946961b9 s/javax.annotation.CheckForNull/edu.umd.cs.findbugs.annotations.CheckForNull/g 2020-03-26 16:12:35 +00:00
James Nord 819f80b12f s/javax.annotation.Nonnull/edu.umd.cs.findbugs.annotations.NonNull/g 2020-03-26 11:14:41 +00:00
Daniel Beck c4f90b7dbd Update at-since up to and including 2.226 2020-03-16 14:22:38 +01:00
Karthick Prabu d3613f32ef [JENKINS-59220] - Updated EnvVars to add a method that extends putAll functionality (#4194)
* Updated EnvVars to add a method that extends putAll functionality

* Updated method name

* Added test coverage
2020-01-10 09:55:23 +01:00
Daniel Beckandjsoref 0445bf2036 Note: Env.platform is not set by copy constructor
Co-Authored-By: jsoref <jsoref@users.noreply.github.com>
2019-04-11 16:49:19 -04:00
Josh Soref bf0f840c48 @SuppressWarnings("CopyConstructorMissesField") 2019-02-20 22:30:27 -05:00
Josh Soref 264980c707 Java 7: omit explit type in favor of <> 2019-02-20 21:51:03 -05:00
Josh Soref 004b23133f Dropping unnecessary semicolons 2019-02-20 18:59:46 -05:00
Mark Wynn-Mackenzie 3025c4308b Add a serialVersionUID to hudson.EnvVars to avoid deserialisation errors.
Following some changes to this class we've seen some deserialisation errors due to the
auto-generated serialVersionUID - adding one to avoid these.
2019-02-14 17:10:21 +00:00
Baptiste Mathus 835cd9c6bc Update '@since TODO' using the newly introduced tool 2019-01-08 22:56:31 +01:00
Jeff Pearce 45c837daa9 [JENKINS-53721] - Add getter/setter to EnvVars so the envinject plugin can set Platform safely (#3639)
[JENKINS-53721] - Add getter/setter to EnvVars so the envinject plugin can set Platform safely
2018-09-27 18:47:40 +02:00
Oleg Nenashev ba08ebc97a Refactoring: Cleanup <tt> tags from the Jenkins core Javadoc 2018-09-21 17:47:11 -07:00
Oleg Nenashev 095310afdd Annotate and document methods of hudson.Launcher (#2920)
* Annotate and document methods of hudson.Launcher

* Fix newly introduced FindBugs issues in hudson.Launcher

* Remove brackets from FilePath#createLauncher() to avoid the merge conflict
2017-06-24 19:17:11 +02:00
Oleg Nenashev 467cf9adcd Annotate Launcher and LauncherDecorator methods 2017-05-27 11:35:37 +02:00
Antonio Muñiz 320e6c0702 Slave to Agent renaming - Javadocs and logs 2016-01-29 17:40:26 +01:00
Jesse Glick c6deabb1b1 Forgotten @since. 2014-12-11 17:52:50 -05:00
Jesse Glick 89cbfc4639 Merge branch 'SECURITY-144' into SECURITY-144-rc
Conflicts:
	core/src/main/java/hudson/EnvVars.java
	core/src/main/java/hudson/FilePath.java
	core/src/main/java/hudson/cli/ClientAuthenticationCache.java
	core/src/main/java/hudson/markup/MyspacePolicy.java
	core/src/main/java/hudson/model/Computer.java
	core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
	core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java
	core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
	core/src/main/java/hudson/security/AbstractPasswordBasedSecurityRealm.java
	core/src/main/java/hudson/slaves/Channels.java
	core/src/main/java/hudson/slaves/SlaveComputer.java
	core/src/main/java/hudson/tasks/Fingerprinter.java
	core/src/main/java/hudson/tasks/Shell.java
	core/src/main/java/hudson/tasks/junit/JUnitParser.java
	core/src/main/java/hudson/tasks/test/DefaultTestResultParserImpl.java
	core/src/main/java/hudson/util/ProcessTree.java
	core/src/main/java/hudson/util/RemotingDiagnostics.java
	core/src/main/java/jenkins/model/Jenkins.java
	core/src/test/java/hudson/LauncherTest.java
	pom.xml
	test/src/test/java/hudson/tasks/junit/CaseResultTest.java
2014-09-26 15:56:48 -04:00
Kohsuke Kawaguchi ffb5b65093 Switched from annotation based scheme to a function based scheme. 2014-09-23 19:12:43 -07:00
Kohsuke Kawaguchi 101b4e7fd5 [SECURITY-144] Classify all the core callables one way or the other 2014-09-18 15:07:31 -07:00
Kohsuke Kawaguchi 5b81675c6d added a convenience method 2014-03-11 09:22:27 -07:00
ikedam 6d56de71cb [JENKINS-20280] Use topological sorting to decide the order to override variables. 2013-11-01 23:55:29 +09:00
ikedam 562c64bbdb [JENKINS-20280] Make it easy to change the implementation. Especially Map.Entry is not so convenient to handle. 2013-11-01 22:11:18 +09:00
ikedam 4204d22496 [FIX JENKINS-20280] Calculates the order to override variables. This is an improved fix for [JENKINS-19488] and [JENKINS-19926]. 2013-10-26 13:38:30 -07:00
cjo9900 3776891794 Document when EnvVars.get() function was added. 2012-11-09 18:54:29 +00:00
Kohsuke Kawaguchi ead639a1c0 added a convenience method 2012-09-30 14:45:44 -07:00
Kohsuke Kawaguchi 88de1669df Jenkins 2011-12-15 09:38:30 -08:00
Kohsuke Kawaguchi d41d9ff777 As Dean pointed out, this was an incompatible change.
This reverts commit 0cab76ae1f.
2011-06-06 12:38:43 -07:00
Kohsuke Kawaguchi 0cab76ae1f Jenkins 2011-03-28 21:32:58 -07:00
Brian Atkinson acfa7597bf Clean up a few javadoc typos 2011-02-16 19:48:44 -06:00
kohsuke 21ad12ffc0 defined a system property to remove MAVEN_OPTS from Maven builds forked inside.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@34044 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-23 19:05:03 +00:00
kohsuke ad7b504ced user report indicates that if someone puts a null value into a system proeprty we get a hard-to-diagnose NPE. Adding code to proactively watch out for that:
[workspace] $ /usr/lib/jvm/sun-jdk-1.6/bin/java -cp /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-agent-1.355.jar:/usr/share/maven-bin-2.1/boot/classworlds-1.1.jar hudson.maven.agent.Main /usr/share/maven-bin-2.1 /opt/glassfish/server/glassfish/domains/domain1/applications/hudson/WEB-INF/lib/remoting-1.355.jar /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven-interceptor-1.355.jar 35855 /opt/glassfish/.hudson/plugins/maven-plugin/WEB-INF/lib/maven2.1-interceptor-1.2.jar
<===[HUDSON REMOTING CAPACITY]===>���channel started
channel stopped
ERROR: Processing failed due to a bug in the code. Please report this to users@hudson.dev.java.net
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)
project=hudson.maven.MavenModuleSet@19cc863[Meetspace]
project.getModules()=[hudson.maven.MavenModule@19fef64[Meetspace/com.steeplesoft:meetspace], hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent], hudson.maven.MavenModule@11d8f11[Meetspace/com.steeplesoft.meetspace:plugin-engine], hudson.maven.MavenModule@b6e204[Meetspace/com.steeplesoft.meetspace:webapp], hudson.maven.MavenModule@b097da[Meetspace/com.steeplesoft.meetspace.plugins:helloworld-plugin], hudson.maven.MavenModule@1c18b6a[Meetspace/com.steeplesoft.meetspace.plugins:plugin-api], hudson.maven.MavenModule@1a80928[Meetspace/com.steeplesoft.meetspace.plugins:plugin-engine]]
project.getRootModule()=hudson.maven.MavenModule@bc2f14[Meetspace/com.steeplesoft.meetspace:meetspace-parent]
FATAL: null
java.lang.NullPointerException
	at java.util.Hashtable.put(Hashtable.java:394)
	at java.util.Hashtable.putAll(Hashtable.java:466)
	at hudson.maven.MavenBuilder.call(MavenBuilder.java:156)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:696)
	at hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:640)
	at hudson.remoting.UserRequest.perform(UserRequest.java:114)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30326 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-22 17:14:06 +00:00
kohsuke 68edd4f804 [FIXED HUDSON-5391] in 1.344. we should be case insensitive but case preserving.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26640 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 19:36:52 +00:00
mindless 22b729ff81 Add authentication support in hudson.Main (if username/password are included in
HUDSON_HOME URL, then include Authorization header in Hudson http requests).

Also moved Functions.isUnitTest to Main.isUnitTest, to remove dependency on
winstone.jar for running hudson.Main (Main uses EnvVars which checks isUnitTest
flag.. in Functions which uses servlet classes).

Updated http://wiki.hudson-ci.org/display/HUDSON/Monitoring+external+jobs
with info about required jars and authentication.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21479 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-05 04:49:03 +00:00
kohsuke af1d6538f4 generalized ProcessTreeKiller to expose more system information, so that the plugins and core can do more interesting things.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19434 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:31:29 +00:00
kohsuke fcb1e18fc1 forked Maven shouldn't see the Maven debug options.
This is only needed during debuggig Hudson and never in production, but this is the only place where we can put this code.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16510 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-25 04:22:50 +00:00
kohsuke a9c2567127 We might be handling environment variables for a slave that can have different path separator than the master, so this is an attempt to get it right. It's still more error prone that I'd like, but this should mostly work for our usage pattern.
The real problem is that AbstractBuild.getEnvVars() is designed to return overrides, not the whole thing. This was OK until recently, when we started using environment variables to eagerly perform variable expansions inside Builder/Publisher, which requires them to see the entire variables.
 


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16226 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-13 21:55:02 +00:00
kohsuke afb1240421 no need to double-wrap
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16224 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-13 21:14:41 +00:00
kohsuke 48db0a34e9 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16221 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-13 19:18:38 +00:00
huybrechts 3370ee3e31 support for environment variables in native Maven builds
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15927 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-01 20:43:52 +00:00
kohsuke c3ae1b7af9 prefer EnvVars over plain Map to signify the semantic difference between those two.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15712 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-25 01:52:42 +00:00
kohsuke 0c80771feb prefer better static typing
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15710 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-25 01:39:21 +00:00
huybrechts 87eb6367cd [HUDSON-2918] node properties and environment variables
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15502 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-20 22:12:06 +00:00
kohsuke 1a1d0d74d5 license header clean up
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15081 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-06 20:05:24 +00:00