Commit Graph
139 Commits
Author SHA1 Message Date
kohsuke 64db15c45c [FIXED HUDSON-4158]
JUnit report archiving now captures stdout of tests run in Surefire.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33862 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-15 16:28:53 +00:00
kohsuke 004c75c381 First stab at boolean expression over labels.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33617 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-07 23:03:06 +00:00
mindless 80f7a7ea61 [HUDSON-7108] add ArgumentListBuilder.toWindowsCommand() which wraps command
in CMD.EXE /C (as Ant.perform() already did), but also does escaping of special
characters to ensure argument as passed unaltered.  Use this in Ant.perform() so
build parameters with < or > characters don't cause I/O redirection, for example.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@33530 71c3de6d-444a-0410-be80-ed276b4c234a
2010-08-02 17:51:23 +00:00
kutzi 40ffa913f8 [FIXED HUDSON-6543] use last 3 builds to calculate estimated remaining build time
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32310 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-26 13:37:56 +00:00
jglick 33f7ed732f [FIXED HUDSON-6824] Statically held fields should be of type Localizable rather than String.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32240 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-22 20:10:59 +00:00
jglick 7ba6e1b134 [FIXED HUDSON-6516] Make stdio trimming optional.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31016 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-13 17:38:04 +00:00
jglick f4cc4245da [FIXED HUDSON-6516] Trim stdout/stderr of passing tests to around 1Kb. Otherwise Hudson easily gets OOME.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30978 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-12 23:12:57 +00:00
mindless ed81cd5f54 [FIXED HUDSON-6494] fix FilePath.getParent() so parent of /foo is /
(not "."), and handle edge case so path with no parent ("/" or "abc")
returns null instead of getting IndexOutOfBoundsException.
(returning null is consistent with File.getParentFile())


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30917 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-11 17:04:38 +00:00
kohsuke 2e13eb03dd Added a convenience method to reduce the invocation of a deprecated method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30806 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-07 18:23:26 +00:00
kohsuke 617af7ded3 merged back the RC branch
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30703 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-04 17:14:24 +00:00
mindless 0e37effa72 [HUDSON-6252] add test for UrlAnnotator
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30612 71c3de6d-444a-0410-be80-ed276b4c234a
2010-05-02 17:38:39 +00:00
mindless a6e6c7946a add SubText.groupCount()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30578 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-30 21:09:41 +00:00
mindless ae837cecf4 [FIXED HUDSON-5951] improve normalization of ".." in FilePath
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30462 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-29 07:35:22 +00:00
mindless 5ad11a0dbc [FIXED HUDSON-6332] for 1.357
Add setOverwrite(true) for local->local copy in FilePath.copyRecursiveTo().
This makes it consistent with master/slave copy (either direction),
and also avoids returning 0 if all files already have current/newer timestamp
which some code (javadoc publishing, copyartifact plugin) would interpret as
copy failure or no matching files found.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30450 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-27 23:53:41 +00:00
kohsuke 5ae67f416b Added Secret.toString(Secret) that hides the handling against NPE.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30276 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-20 23:33:03 +00:00
mindless c2fd840846 [FIXED HUDSON-6252] fix bad index calculation in SubText.subText which
caused StringIndexOutOfBoundsException in UrlAnnotator.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30102 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-16 00:23:00 +00:00
mindless da9acc9705 remove workaround to rerun testSymlink with shorter link for S10,
and instead add (char) cast so original test uses right length for name.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29990 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-12 19:45:13 +00:00
mindless f043975fc8 [HUDSON-5941] [HUDSON-5944] MarkupText.toString(boolean) was ignoring the
preEscape parameter when no markup tags were added.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28737 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-16 16:14:27 +00:00
mindless 007ce08a1c oops, typo in last commit
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28506 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-10 23:51:19 +00:00
mindless c79a4b0cea fix symlink test with long filename (got ENAMETOOLONG on Solaris 10)..
if "ln failed: 78" is logged, try again with shorter name.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28505 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-10 23:34:47 +00:00
kohsuke f7199479dd fixed regressions caused by my previous change to the toString() method.
We need two versions of escape, depending on whether the text is being injected into <PRE> or other normal HTML tags.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28422 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-08 21:55:40 +00:00
kohsuke 211f6b5605 [FIXED HUDSON-5852] '&lt;' and '&amp;' in the console output was not escaped since 1.349
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28418 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-08 20:51:34 +00:00
kohsuke c6acb5b8d5 [FIXED HUDSON-2137]
Merged revisions 27137,27564,27566-27567,27578,27586,27599,27603,27606-27609,27611,27616,27626-27632,27640,27654-27656,27687,27701,27801,27816,27819,27843-27845,28087,28158-28161 via svnmerge from 
https://www.dev.java.net/svn/hudson/branches/HUDSON-2137

........
  r27137 | kohsuke | 2010-02-08 08:46:16 -0800 (Mon, 08 Feb 2010) | 1 line
  
  experimenting with abstractions
........
  r27564 | kohsuke | 2010-02-16 07:58:26 -0800 (Tue, 16 Feb 2010) | 1 line
  
  bundling makes it easier for caller to handle ConsoleAnnotator
........
  r27566 | kohsuke | 2010-02-16 08:49:48 -0800 (Tue, 16 Feb 2010) | 1 line
  
  this should work with Runs, not AbstractBuilds
........
  r27567 | kohsuke | 2010-02-16 08:54:06 -0800 (Tue, 16 Feb 2010) | 1 line
  
  simplified
........
  r27578 | kohsuke | 2010-02-16 12:26:11 -0800 (Tue, 16 Feb 2010) | 1 line
  
  still a work in progress, but committing once to pull in trunk changes
........
  r27586 | kohsuke | 2010-02-16 14:35:37 -0800 (Tue, 16 Feb 2010) | 1 line
  
  making more progress
........
  r27599 | kohsuke | 2010-02-16 19:22:01 -0800 (Tue, 16 Feb 2010) | 2 lines
  
  hooking up the side that writes annotations.
  still a work in progress.
........
  r27603 | kohsuke | 2010-02-16 23:43:35 -0800 (Tue, 16 Feb 2010) | 3 lines
  
  what appears to me as the first cut of hooking up the reader side of the annotations.
  
  I haven't even run it yet --- this just passed the compilation, and I'm calling it a day.
........
  r27606 | kohsuke | 2010-02-17 09:15:16 -0800 (Wed, 17 Feb 2010) | 1 line
  
  demo instance hook up
........
  r27607 | kohsuke | 2010-02-17 11:27:02 -0800 (Wed, 17 Feb 2010) | 3 lines
  
  one more utility method.
  
  I never understood what the point of letting the skip method skip less.
........
  r27608 | kohsuke | 2010-02-17 11:56:23 -0800 (Wed, 17 Feb 2010) | 3 lines
  
  - moved LargeText subtype to its own class
  - skipping log output was done incorrectly --- it had to skip N bytes where it was skipping N chars.
  - hooked up console annotations for completed builds.
........
  r27609 | kohsuke | 2010-02-17 12:01:46 -0800 (Wed, 17 Feb 2010) | 1 line
  
  copyright header
........
  r27611 | kohsuke | 2010-02-17 13:18:10 -0800 (Wed, 17 Feb 2010) | 1 line
  
  introduced a mechanism to register extension during an unit test.
........
  r27616 | kohsuke | 2010-02-17 13:38:12 -0800 (Wed, 17 Feb 2010) | 1 line
  
  test case for console annotations
........
  r27626 | kohsuke | 2010-02-17 15:23:06 -0800 (Wed, 17 Feb 2010) | 1 line
  
  removing test ConsoleAnnotator as I write tests as tests
........
  r27627 | kohsuke | 2010-02-17 16:06:13 -0800 (Wed, 17 Feb 2010) | 1 line
  
  added a multi-phase cooperative locking mechanism useful during the debugging
........
  r27628 | kohsuke | 2010-02-17 16:06:41 -0800 (Wed, 17 Feb 2010) | 1 line
  
  testing progressive log annotation
........
  r27629 | kohsuke | 2010-02-17 16:20:32 -0800 (Wed, 17 Feb 2010) | 1 line
  
  adding a test for ConsoleAnnotation that's explicitly placed.
........
  r27630 | kohsuke | 2010-02-17 16:23:02 -0800 (Wed, 17 Feb 2010) | 1 line
  
  removing test ConsoleAnnotation as I write tests as tests
........
  r27631 | kohsuke | 2010-02-17 16:28:50 -0800 (Wed, 17 Feb 2010) | 1 line
  
  tweaking the abstraction a bit.
........
  r27632 | kohsuke | 2010-02-17 16:44:21 -0800 (Wed, 17 Feb 2010) | 1 line
  
  parameterized the context type so that this can be used in places other than the build console output, such as polling logs, slave logs, and so on.
........
  r27640 | kohsuke | 2010-02-17 17:27:52 -0800 (Wed, 17 Feb 2010) | 1 line
  
  bug fix
........
  r27654 | kohsuke | 2010-02-17 22:53:04 -0800 (Wed, 17 Feb 2010) | 1 line
  
  doc improvement
........
  r27655 | kohsuke | 2010-02-17 22:53:59 -0800 (Wed, 17 Feb 2010) | 1 line
  
  doc improvement
........
  r27656 | kohsuke | 2010-02-17 23:10:42 -0800 (Wed, 17 Feb 2010) | 1 line
  
  test case for adjacent tags
........
  r27687 | kohsuke | 2010-02-19 14:39:21 -0800 (Fri, 19 Feb 2010) | 1 line
  
  introduced a facotry and descriptor. This allows them to define configuration pages, allow users to disable/enable them, plus define custom behaviors.
........
  r27701 | kohsuke | 2010-02-19 18:23:52 -0800 (Fri, 19 Feb 2010) | 1 line
  
  defining a mechanism for ConsoleAnnotatorFactory and ConsoleAnnotationDescriptor to define script.js and have them imported into the console output page
........
  r27801 | kohsuke | 2010-02-22 11:59:16 -0800 (Mon, 22 Feb 2010) | 1 line
  
  now embedding annotations inside the console output log file.
........
  r27816 | kohsuke | 2010-02-22 15:45:04 -0800 (Mon, 22 Feb 2010) | 1 line
  
  introduced a convenience method for unit tests
........
  r27819 | kohsuke | 2010-02-22 17:37:05 -0800 (Mon, 22 Feb 2010) | 5 lines
  
  As an example of using embedded console annotations, implementing Ant target invocation outlines.
  
  It might be better to make the concept of outline more generally reusable, so that different kinds of outlines can be placed into the same container element for a single hierarchical representation.
  
  Still a work in progress.
........
  r27843 | kohsuke | 2010-02-23 16:12:13 -0800 (Tue, 23 Feb 2010) | 1 line
  
  for now, disable this for production usage, until I work out a better UI.
........
  r27844 | kohsuke | 2010-02-23 19:08:00 -0800 (Tue, 23 Feb 2010) | 1 line
  
  started working on annotating exception.
........
  r27845 | kohsuke | 2010-02-23 19:08:33 -0800 (Tue, 23 Feb 2010) | 1 line
  
  more TODOs for myself
........
  r28087 | kohsuke | 2010-03-01 10:03:55 -0800 (Mon, 01 Mar 2010) | 1 line
  
  formatting changes
........
  r28158 | kohsuke | 2010-03-02 17:00:00 -0800 (Tue, 02 Mar 2010) | 1 line
  
  ConsoleAnnotation and ConsoleAnnotator are too confusing.
........
  r28159 | kohsuke | 2010-03-02 17:02:02 -0800 (Tue, 02 Mar 2010) | 1 line
  
  doc improvement
........
  r28160 | kohsuke | 2010-03-02 17:05:14 -0800 (Tue, 02 Mar 2010) | 1 line
  
  more doc improvements.
........
  r28161 | kohsuke | 2010-03-02 17:11:59 -0800 (Tue, 02 Mar 2010) | 1 line
  
  more doc improvement
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28173 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-03 15:37:55 +00:00
kohsuke 9d63c0223f normalization needs to avoid producing empty string.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28142 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-02 19:18:28 +00:00
mindless 48df625a44 [FIXED HUDSON-5769] Update to XStream 1.3.1-hudson-6 where I added
protected Converter createDefaultConverter().  This allows a subclass
to override the default converter (was hardcoded to ReflectionConverter)
which is also given to the constructor of a few other converters,
most notably ThrowableConverter.  Override this method in XStream2 to
provide a RobustReflectionConverter so missing fields in classes
extending Throwable are handled properly.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28141 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-02 18:55:42 +00:00
mindless d07feb625e simplify tests
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28101 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-02 00:59:22 +00:00
mindless f2a2b92a2f [FIXED HUDSON-5768] Avoid double decoding that broke deserialization of fields with
double underscore, by replacing XStream11XmlFriendlyMapper with a custom mapper that
only does "-" to "$" decoding that is needed for compatibility with old xml data
written by Hudson 1.105 or older.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28071 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-01 06:45:57 +00:00
mindless b0fbd644c8 [FIXED HUDSON-5776] fix serialization problem with empty CopyOnWriteMap.Tree,
also add/update tests for CopyOnWriteMap and CopyOnWriteList.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28026 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-27 20:12:25 +00:00
kohsuke 787d843d3d perform path normalization to get rid of "." and ".." in the path.
Without it, FilePath.getParent() and File.getParent() doesn't work correctly.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27956 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-26 00:30:15 +00:00
kohsuke 2676adca52 class initialization of Hudson is much more work than that of Util, so pushing these small utilities out to Util to reduce the overhead of remoting.
Plus it helps to keep Hudson.java smaller

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27448 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-13 01:30:56 +00:00
kohsuke 92ca98c4d6 Merged revisions 24854,24862,24946,25411,25418-25419,25478,25699,25701,25770,25832,25834,26401-26404 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/test-result-refactor

........
  r24854 | bshine | 2009-12-22 12:52:32 -0800 (Tue, 22 Dec 2009) | 82 lines
  
  Generalize the junit-specific TestResult class into AbstractTestResult,
  and allow plugins to contribute test result parsers that generate
  AbstractTestResult subclasses.
  
  In order to support the increasing variety of test result file formats, we
  have added two extension points:
  
   * AbstractTestResult: a class that represents a general concept of a test
     result, without any language or implementation specifics.
  
   * AbstractTestResultParser: an API for parsing test result files and
     producing an instance of a concrete subclass of AbstractTestResult
  
   
   AbstractModelObject
      \
       TestObject 
          \
           AbstractTestResult is-a ExtensionPoint
                 \
                  |-- CaseResult 
                  |
                  |-- SimpleCaseResult
                  |
                  |-- TabulatedResult
                        \
                         |-- ClassResult
                         |
                         |-- MetaTabulatedResult
                               \
                                 |-- TestResult 
                                 |
                                 |-- PackageResult
  
  
   AbstractTestResultParser is-a ExtensionPoint
      \
       JUnitParser
  
  We have refactored the JUnit result publishing system so that it is "just"
  a subclass of AbstractTestResult. We have promoted functionality into
  AbstractTestResult from TestResult; we have also promoted jelly resources
  from TestResult up to AbstractTestResult. Together, these changes make it
  possible -- without much code -- to add a test result parser and a test
  result publisher that can participate in the test result ecosystem. See,
  for instance, TrivialTestResult, with its two supporting classes,
  TrivialTestResultAction and TrivialTestResultRecorder.
  
  We have moved the format-agnostic classes in the test result system into
  the hudson.tasks.test package, from hudson.tasks.junit:
     TestObject
     MetaTabulatedResult
     TabulatedResult
  
  We have attempted at every step to preserve backwards compatibility both
  with the existing APIs and with test results stored by earlier versions of
  Hudson. Numerous tests verify that the old APIs and historical data are
  still readable; all of the tests in hudson.tasks.junit operate on stored
  builds and test results created by Hudson around version 1.320. These
  tests have been created and expanded to exercise the HTML ui and the XML
  api of the test result publishing system, as well as the underlying java
  logic.
  
     hudson.tasks.junit.CaseResultTest
     hudson.tasks.junit.JUnitParserTest
     hudson.tasks.junit.JUnitResultArchiverTest 
     hudson.tasks.junit.TestResultLinksTest 
     hudson.tasks.junit.TestResultPublishingTest   
     
  This checkin also includes several smaller changes that were enacted in the course of this work: 
     Added convenience/utility methods
        - HudsonTestCase.java
     
     Added a read-only textbox.
        - core/src/main/resources/lib/form/readOnlyTextbox.jelly
  
     Added a standalone builder that touches all files in the workspace.
        - TouchBuilder.java
  
     Added a test: testUnwrappedLongString
        - src/test/java/hudson/model/ApiTest.java
........
  r24862 | bshine | 2009-12-22 17:30:04 -0800 (Tue, 22 Dec 2009) | 1 line
  
  Recreate the hudson.tasks.junit.TestObject class, and adapt the TestResultAction.Data class to be friendly to the refactoring. This makes the claim plugin and the junit-attachments plugin compile and pass tests against this branch.
........
  r24946 | bshine | 2009-12-24 21:59:14 -0800 (Thu, 24 Dec 2009) | 1 line
  
  Getting rid of some TODOs that don't apply anymore. The TODOs that remain are meaningful.
........
  r25411 | kohsuke | 2010-01-05 18:14:15 -0800 (Tue, 05 Jan 2010) | 3 lines
  
  Cosmetic change. It's not necessary to define our own constant for empty list when there's already one in JDK.
  
  I also think creating and wasting singleton list as needed is probably better use of memory than having a singleton list tied in memory for every CaseResult. It improves cognitive overhead for people reading the code, and modern GCs are very good at handling short-lived objects, and I don't see this method called in a busy loop.
........
  r25418 | kohsuke | 2010-01-05 18:37:17 -0800 (Tue, 05 Jan 2010) | 1 line
  
  pushed the get/setDescription implemention up to the AbstractTestResultAction. I believe the default implementation is sufficient for most purposes, and typical subtypes don't want to bother with the details that descriptions are actually persisted by the owning Action instead of in TestObjects.
........
  r25419 | kohsuke | 2010-01-05 18:59:29 -0800 (Tue, 05 Jan 2010) | 1 line
  
  we should allow the parse method to be called outside of the build, so this should be TaskListener.
........
  r25478 | kohsuke | 2010-01-07 11:44:34 -0800 (Thu, 07 Jan 2010) | 14 lines
  
  The ExtensionPoint interface primarily serves as a marker to call attention of the plugin developers as to where to hook into Hudson. Since the act of implementing AbstractTestResultParser naturally make them to implement AbstractTestResult, I'm removing the ExtensionPoint marker from this abstract class.
  
  The all() method is removed after the following discussion:
  
  >> - I propose we remove AbstractTestResult.all(). I don't think being  
  >> able
  >> to enumerate AbstractTestResult subtypes buy us anything, since those
  >> can only be instantiated by parsers that intimately know how to
  >> instantiate them properly. Or did I miss the purpose of this?
  > 
  > I put in the all method because it was suggested by the wiki:
  > "You also need to define the static "all" method..."
  > http://wiki.hudson-ci.org/display/HUDSON/Defining+a+new+extension+point
  > so I don't have a problem with removing it.
........
  r25699 | bshine | 2010-01-11 16:34:12 -0800 (Mon, 11 Jan 2010) | 1 line
  
  Removed a test that exercised AbstractTestResult.all(), because that API has been removed.
........
  r25701 | bshine | 2010-01-11 17:05:40 -0800 (Mon, 11 Jan 2010) | 1 line
  
  Don't test getDescription() on a TrivialTestResult because the TrivialTestResult doesn't actually implement a description.
........
  r25770 | bshine | 2010-01-13 11:52:27 -0800 (Wed, 13 Jan 2010) | 1 line
  
  Added a failing test to demonstrate bug HUDSON-5246, inter-build diffs for junit test results are wrong.
........
  r25832 | bshine | 2010-01-14 13:50:15 -0800 (Thu, 14 Jan 2010) | 1 line
  
  The id field was accidentally declared here; it was also declared in hudson.tasks.test.TestObject. This id field here is always hidden by the id field in the more-concrete TestObject. Therefore, I'm removing this field.
........
  r25834 | bshine | 2010-01-14 13:55:10 -0800 (Thu, 14 Jan 2010) | 5 lines
  
  Fixes bugs with getPreviousResult:
  HUDSON-5269 TestResult.getPreviousResult returns null when it shouldn't
  HUDSON-5246 test-result-refactor branch: inter-build diffs for junit test results are wrong 
........
  r26401 | kohsuke | 2010-01-25 17:24:51 -0800 (Mon, 25 Jan 2010) | 7 lines
  
  renamed:
   AbstractTestResultParser -> TestResultParser
   AbstractTestResult -> TestResult
  
  This discussion is in http://n4.nabble.com/Review-requested-Test-Result-Refactoring-td978100.html#a978100
  
  The conclusion of this renaming proposal isn't clear, but I'm assuming it's OK.
........
  r26402 | kohsuke | 2010-01-25 17:27:57 -0800 (Mon, 25 Jan 2010) | 1 line
  
  elsewhere in Hudson it's the "display name" that indicates a human readable name that programs don't try to interpret.
........
  r26403 | kohsuke | 2010-01-25 17:31:38 -0800 (Mon, 25 Jan 2010) | 1 line
  
  typo
........
  r26404 | kohsuke | 2010-01-25 17:35:41 -0800 (Mon, 25 Jan 2010) | 1 line
  
  doc improvement.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26406 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 01:49:47 +00:00
kohsuke b607079031 recording my failed experiment.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26400 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 01:08:45 +00:00
sogabe 951ccc5d8d fixed test failure. \u00E9 should encoded into %C3%A9, not %C3%A9%00
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26002 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-17 00:25:20 +00:00
kohsuke c3519f283f ProcessTree is now remoteable
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25705 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-12 01:18:22 +00:00
kohsuke c0d915b33d added code to check cycles in a directed graph
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25681 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-11 16:48:23 +00:00
kohsuke a61dc67178 Added a convenience method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25473 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-07 15:27:37 +00:00
kohsuke 8269a73476 clean up the tmp file after a test
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24667 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-17 01:01:54 +00:00
kohsuke 52066f6440 added symlink resolution code
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24373 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-03 14:15:46 +00:00
kohsuke 30cf7c698e Merged revisions 23698-23699 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23698 | kohsuke | 2009-11-12 19:24:53 -0800 (Thu, 12 Nov 2009) | 1 line
  
  testing if the root cause is a test failure and it's masked by the failure in tearDown
........
  r23699 | mindless | 2009-11-12 21:47:16 -0800 (Thu, 12 Nov 2009) | 2 lines
  
  [FIXED HUDSON-4831] prevent duplicate cause entries for a build
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23705 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 18:12:58 +00:00
kohsuke f8e2a28eb0 Seeing dead lock after the message:
Nov 9, 2009 1:46:11 PM hudson.remoting.Channel$ReaderThread run
SEVERE: I/O error in channel This side of the channel
java.io.IOException: Write end dead
	at java.io.PipedInputStream.read(PipedInputStream.java:294)
	at java.io.ObjectInputStream$PeekInputStream.peek(ObjectInputStream.java:2249)
	at java.io.ObjectInputStream$BlockDataInputStream.peek(ObjectInputStream.java:2542)
	at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2552)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1297)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:351)
	at hudson.remoting.Channel$ReaderThread.run(Channel.java:849)
Nov 9, 2009 1:46:11 PM hudson.remoting.Request$2 run
SEVERE: Failed to send back a reply
java.io.IOException: Read end dead
	at java.io.PipedInputStream.checkStateForReceive(PipedInputStream.java:246)
	at java.io.PipedInputStream.receive(PipedInputStream.java:210)
	at java.io.PipedOutputStream.write(PipedOutputStream.java:132)
	at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1838)
	at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1747)
	at java.io.ObjectOutputStream.writeNonProxyDesc(ObjectOutputStream.java:1249)
	at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:1203)
	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1387)
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150)
	at java.io.ObjectOutputStream.writeFatalException(ObjectOutputStream.java:1538)
	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329)
	at hudson.remoting.Channel.send(Channel.java:413)
	at hudson.remoting.Request$2.run(Request.java:282)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)



The thread dump indicates that the test thread is stuck at british.join(), because British channel reader thread is still alive. I remember PipedInput|OutputStream being not truly multi-thread aware, so changing it to our own version to see if that fixes the problem without my digging further.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23625 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:43:20 +00:00
kohsuke ebfa6a0e2d the test is still failing. adding more delay
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23556 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:51:39 +00:00
kohsuke 97711f3d3c it should be abstract since by itself it defines no test
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23555 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:50:19 +00:00
kohsuke d4f345f98e Maven picks up *Test, so renaming
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23554 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:49:57 +00:00
kohsuke bae8b35c8f refactored the commonality out
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23552 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 23:22:44 +00:00
kohsuke 8fcda35317 Future.cancel is asynchronous, so it can return before the process is actually killed
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23551 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 23:20:06 +00:00
kohsuke 7816b82f10 Hudson on Hudson finds this test brittle, so changing the way the test works.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23547 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 22:27:05 +00:00
kohsuke b73f620e88 more test case
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23546 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 22:26:13 +00:00
kohsuke 61d341e21d assertNotSame would box them, so it won't achieve the intended test
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23545 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 22:14:43 +00:00
jglick ebb5800937 Tweaking license text.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23528 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:39:49 +00:00
jglick 6ccad2bc32 [FIXED HUDSON-4611] hudson.proc.RemoteProc.kill() was a no-op.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23526 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:34:11 +00:00