Commit Graph
13470 Commits
Author SHA1 Message Date
Basil Crow 64dbdbc4f5 Remove unused imports 2020-12-19 13:10:38 -08:00
Basil Crow 4e12567881 Remove unnecessary return 2020-12-19 13:10:38 -08:00
Basil Crow f31107fac2 Consolidate duplicate branches in switch statement 2020-12-19 13:08:45 -08:00
Basil Crow d20533ef60 Remove duplicate @param tag 2020-12-19 12:19:22 -08:00
Basil Crow e83bde4ca2 Replace ThreadLocal#initialValue with ThreadLocal#withInitial 2020-12-19 12:17:39 -08:00
Basil Crow 406cefcd73 Replace anonymous types with method references 2020-12-19 12:17:39 -08:00
Basil Crow ee24685ca3 Replace explicit type with diamond operator 2020-12-19 12:17:35 -08:00
Oleg Nenashev 260c988d9d Merge pull request #5123 from oleg-nenashev/queue-cleanup
Remove support for queue.txt format (replaced by XML in 2009)
2020-12-19 20:55:38 +01:00
Jesse Glick d7c79eecb1 Removed admin monitor related to ZFS (#5047)
* Removed Solaris support

* Restore Solaris-specific functionality other than libzfs
2020-12-19 20:52:37 +01:00
Oleg Nenashev 152682c157 Merge pull request #5109 from basil/improvements
Code cleanup
2020-12-19 20:51:40 +01:00
Oleg NenashevandRamon Leon 9f50735a8b [JENKINS-64445] - Fix null safety for plugin categories (#5121)
* [JENKINS-64445] - Fix null safety for plugin categories

* Update core/src/main/java/hudson/model/UpdateSite.java

Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>

* Update core/src/main/java/hudson/model/UpdateSite.java

Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>
2020-12-19 20:50:14 +01:00
Oleg Nenashev a53d1ccf0b Remove support for queue.txt format (replaced by XML in 2009) 2020-12-15 22:07:20 +01:00
James NordandJesse Glick f7884d3513 [JENKINS-64390] make FieldUtils behave as it used to (#5105)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-12-13 20:35:21 +00:00
Esther Álvarez Feijoo bdb5dce566 JENKINS-64403 Declare the page variable "divBasedFormLayout" globally, not only inside forms (#5075) 2020-12-13 12:58:53 +00:00
Basil Crow 39c22138d7 Remove redundant type arguments 2020-12-11 21:34:22 -08:00
Basil Crow 86d59a1347 Replace manual min/max calculation with Math#min 2020-12-11 21:34:22 -08:00
Basil Crow df743d0c68 Replace loop with Arrays#fill method call 2020-12-11 21:34:22 -08:00
Basil Crow e6fb6cce38 Fix unresolvable symbol in Javadoc 2020-12-11 21:34:22 -08:00
Basil Crow 05d0dffd25 Replace dangling Javadoc comment with block comment 2020-12-11 21:34:22 -08:00
Basil Crow 3764940c2d Replace loop with Collection#removeIf where possible 2020-12-11 21:34:22 -08:00
Basil Crow 4284c3d2ab Replace lambda with method reference where possible 2020-12-11 21:34:22 -08:00
Basil Crow 2bae452ede Replace identical catch blocks with multi-catch 2020-12-11 21:34:22 -08:00
Basil Crow ba4c184daf Replace equals() expressions with Objects#equals() where possible 2020-12-11 21:34:22 -08:00
Basil Crow 88a5bafe16 Use Java 5 for-each loops where possible 2020-12-11 21:34:22 -08:00
Basil Crow 5d66c1a36e Remove unnecessary calls to Throwable#initCause() 2020-12-11 21:34:22 -08:00
Basil Crow 04f68995ce Remove unnecessary try/catch statement 2020-12-11 21:34:22 -08:00
Basil Crow 81bbfea719 Remove redundant close() statements 2020-12-11 21:34:22 -08:00
Basil Crow 2278d3ae27 Remove unnecessary interface modifiers 2020-12-11 20:50:51 -08:00
Basil Crow ddf216d3f7 Remove redundant "extends Object" 2020-12-11 20:50:24 -08:00
Basil Crow ef252ef956 Use Java-style arrays rather than C-style arrays 2020-12-11 20:49:47 -08:00
Raihaan Shouhellandres0nance 4db7028e2e Avoid calling task.getCauseOfBlockage() twice (#5103)
Co-authored-by: res0nance <res0nance@users.noreply.github.com>
2020-12-11 16:27:28 +00:00
Tim Jacomb 09307ea116 JENKINS-64196 Move PluginManager available page to client side (#5051)
* Move PluginManager available to client side

* Fix in IE

* Address feedback from ux-sig demo

* Add handlebars module

* Handlebars plugin manager

* Update core/src/main/java/hudson/model/UpdateCenter.java

* Remove import

* Fix input

* Remove debug

* Use rest client

* Fix bug

* Move properties to right location

* Cleanup

* Use lodash debounce

* Revert properties change

* Fmt

* Rank exact matches at the top

* Set locale

* Spotbugs

* ignore case in nicer way

* Sorting improvements
2020-12-08 07:29:21 +00:00
Rahul Reddy 1188566b66 Replace() optimization (#5095)
* Update MaskingClassLoader.java

Using the correct replace method
Modified the replace() with Character parameter for optimization

* Update LineEndingConversion.java

Using the correct replace method
Modified the replace(String, String) to replace(char, char) for optimization

* Update Icon.java

Using the correct replace method
Modified the replace() with Character parameter for optimization
2020-12-04 21:14:25 +08:00
Tim JacombandJesse Glick ec1fabc35f Inline icon-set lib (#5072)
* Inline icon-set lib

* Add @since 2.0

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

* Downgrade iconset to 1.0.5 version

* Fix javadoc

* Missed one javadoc error

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-12-01 07:24:42 +00:00
Daniel BeckandDaniel Beck c29640b16f Mark some more administrative monitors as security-related (#5079)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-11-29 09:19:35 +00:00
Jesse Glick 1577d66b08 Deprecate FileSystemProvisioner (#5048) 2020-11-29 09:19:16 +00:00
418fb5b565 Hacktoberfest - ParametersDefinition add equals and hashCode (#5014)
Co-authored-by: Zbynek Konecny <zbynek1729@gmail.com>
Co-authored-by: Ilya Gulyaev <ilya.gulyaev@nordigy.ru>
Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2020-11-26 09:01:11 +00:00
44c59a6f5c Load admin monitors popup content via ajax (#5063)
* Admin monitors popup is now loaded through an API

* Fixes form submission inside the popup

- Wraps it in an l:ajax template so that proper variables are set
- Applies the csrf crumbs to the forms after the popup is constructed

* Handle authorization and empty state

* Apply suggestions from code review

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>

* Fix JS error where there were monitors of only one kind

* Revert changes to indentation of inline JS

* Clarify ESC keyCode with a comment

* Update core/src/main/resources/jenkins/management/AdministrativeMonitorsDecorator/resources.js

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>

* Multiple small adjustments

- Remove unused imports
- Remove non-necessary call for the response that are set in the getView
- Keep the previous improvement about limiting the number of call to getMonitorList()

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Co-authored-by: Wadeck Follonier <wadeck.follonier@gmail.com>
2020-11-26 09:38:43 +01:00
15cfddf2a7 JENKINS-1877 Add ability to specify shut down reason (#4274)
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Ilya Zasimov <austry@yandex-team.ru>
2020-11-17 09:44:16 +00:00
Wadeck FollonierandFélix Queiruga bd59971eac [JENKINS-63977] Separate security / non-security admin monitors (#5015)
Co-authored-by: Félix Queiruga <felix.queiruga@gmail.com>
2020-11-17 09:43:37 +00:00
Josh Soref 6c6d787f26 [JENKINS-41891] Resource root url cleanup (#4294) 2020-11-09 22:15:01 +00:00
Oleg Nenashev 7657ae3f6e Merge pull request #5008 from aHenryJard/JENKINS-62446_casc
[JENKINS-62446] adding CasC compatibility to Global tool > Global Maven
2020-11-09 10:40:19 +01:00
Jesse GlickandBasil Crow 77f24bfb9a [JEP-228] Unforking XStream (#4944)
* Unforking XStream

* Some overrides missing from MapperDelegate

* [XSTR-762] writeReplace & readResolve must be accessible to be used from subclasses

* DomElement.click overloads changed incompatibly

* Giving up on ToolInstallation being Serializable.
Fixing MavenInstallation accordingly.
AntInstallation was already fixed: https://github.com/jenkinsci/ant-plugin/commit/c957dca4cd7789e3918e90ae020687aeaeea998e

* Relaxing message assertion in RobustReflectionConverter.randomExceptionsReported

* Picking up https://github.com/jenkinsci/matrix-auth-plugin/pull/89 caught via JobTest

* https://github.com/jenkinsci/jenkins-test-harness/pull/243 released

* Another case forgotten in 0e5aeec4cc

* XStream has SecurityMapper, but we have our own system already, so suppress warning

* GetMavenVersion was also serializing its outer class

* Trying to make ToolInstallation serializable compatible

* Avoid throwing IOException from PersistedList.inModified for common cases covered by https://github.com/jenkinsci/jenkins-test-harness/pull/243

* Found a way to avoid looking up XStream.converterRegistry by reflection

* XStream2Test.crashXstream now throwing ConversionException, not ForbiddenClassException

* Noting which version of the parent POM has https://github.com/jenkinsci/jenkins-test-harness/pull/243

* Refreshed Javadoc for XStream2

* The simplest solution to JENKINS-19561 seems to be to stop using autodetectAnnotations

* Fixing some deprecations in Robust*Converter

* Display OldDataMonitor errors from RobustReflectionConverter during functional tests

* Stray digit in test name

* Added XStream2AnnotationTest to clearly document incompatibility

* Picking up release of https://github.com/jenkinsci/matrix-auth-plugin/pull/89

Co-authored-by: Basil Crow <me@basilcrow.com>

Co-authored-by: Basil Crow <me@basilcrow.com>
2020-11-06 15:03:23 -06:00
a9ca5ef3d4 [JEP-227] Replace Acegi Security with Spring Security & upgrade Spring Framework (#4848)
Replacing Acegi Security with Spring Security

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
2020-11-06 11:30:25 -07:00
Oleg Nenashev 748e8b2b2d Merge pull request #5028 from Wadeck/JENKINS-60563_consistent_hash
[JENKINS-60563] Replace MD5 with SHA-256 in ConsistentHash
2020-11-06 12:00:07 +01:00
Jesse Glick 04c46dcfac Simplified IdentityRootAction.getFingerprint 2020-11-03 16:28:40 -05:00
Wadeck FollonierandJesse Glick 9c256ad830 Restriction mistake on TokenUuidAndPlainValue (#5041)
* Restriction mistake on TokenUuidAndPlainValue

* Update core/src/main/java/jenkins/security/apitoken/TokenUuidAndPlainValue.java

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-11-03 07:41:01 +01:00
Oleg Nenashev d03b8cfdff Merge pull request #5039 from jglick/UnbufferedBase64InputStream
Deprecating UnbufferedBase64InputStream
2020-11-02 12:03:25 +01:00
Raihaan Shouhellandres0nance 1a0a4809f1 [JENKINS-63899] Fix renaming items with non-latin characters and spaces (#5037)
* URLencode item names in url during rename

* Fix redirects with spaces

Co-authored-by: res0nance <res0nance@users.noreply.github.com>
2020-11-01 10:47:27 +08:00
Jesse Glick b40f70e3d8 XMLUtils should parse via InputStream not Reader (#5026) 2020-11-01 10:46:55 +08:00