Commit Graph
3982 Commits
Author SHA1 Message Date
kohsuke 66f157955a [FIXED HUDSON-4353] we should now be able to update bundled plugins.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21979 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 23:46:47 +00:00
kohsuke b8f2b7949d TAB->WS
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21978 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 23:31:32 +00:00
kohsuke 516866e06d adding the notion that a plugin can be pinned to avoid overwritten by a bundled plugin.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21977 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 23:29:38 +00:00
kohsuke 16a1ae58d1 [FIXED HDUSON-4514]
This is a problem in the core. The repositoryBrowser type shouldn't be persisted. Fixed toward 1.325.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21961 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 20:42:16 +00:00
mindless 92f54b4477 avoid repeated maxDescrLength-ending.length() calculations in getTruncatedDescription
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21951 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 17:37:46 +00:00
mindless b957f01246 add @Override annotations, tab->ws
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21902 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-19 20:19:07 +00:00
kohsuke 58e6059539 removed warning.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21890 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-19 02:02:59 +00:00
kohsuke 9882aba6a9 fixed NPE when Maven build is aborted.
MavenBuild (a Run for a module) does push(null), and its corresponding onEndBuilding() won't be invoked due to the abort. I guess the real root cause is to make sure the corresponding onEndBuilding() is always invoked, as not doing so can have other unintended side effect.

The stack trace of the problem was:

ERROR: Processing failed due to a bug in the code. Please report this to users@hudson.dev.java.net
java.lang.NullPointerException
	at hudson.model.Run$Runner.access$000(Run.java:1007)
	at hudson.model.Run.reportCheckpoint(Run.java:984)
	at hudson.model.CheckPoint.report(CheckPoint.java:113)
	at hudson.tasks.MailSender.execute(MailSender.java:107)
	at hudson.maven.reporters.MavenMailer.end(MavenMailer.java:54)
	at hudson.maven.MavenModuleSetBuild$Builder.end(MavenModuleSetBuild.java:677)
	at hudson.maven.MavenModuleSetBuild$RunnerImpl.doRun(MavenModuleSetBuild.java:480)
	at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:354)
	at hudson.model.Run.run(Run.java:1123)
	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:302)
	at hudson.model.ResourceController.execute(ResourceController.java:88)
	at hudson.model.Executor.run(Executor.java:123)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21883 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-19 00:30:25 +00:00
kohsuke 0755dd6fe4 TAB -> WS
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21875 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 23:12:00 +00:00
kohsuke 0bb6580426 added another CLI command.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21874 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 22:47:11 +00:00
kohsuke 0969b2213d Hudson itself needs to be resolvable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21873 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 22:46:58 +00:00
kohsuke f27973c6b3 adding more CLI commands.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21870 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 21:01:34 +00:00
kohsuke efbfd13483 useful convenience method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21869 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 20:34:22 +00:00
mindless 21e3b3ec60 Add "since .." on deprecated things
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21863 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 18:54:42 +00:00
kohsuke d3b5cde166 improved the error handling
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21858 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 18:09:11 +00:00
sogabe cfffeb86f4 fixed redundant redirection
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21822 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 05:22:16 +00:00
mindless 26cca1a973 [FIXED HUDSON-4475] handle null owner in View.getViewUrl()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21810 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 22:58:23 +00:00
kohsuke 97af019ca7 Merged revisions 21782-21783 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r21782 | kohsuke | 2009-09-17 10:22:50 -0700 (Thu, 17 Sep 2009) | 1 line
  
  [FIXED HUDSON-4039] Several classes need to be marked as serializable.
........
  r21783 | kohsuke | 2009-09-17 10:29:06 -0700 (Thu, 17 Sep 2009) | 1 line
  
  added a regression test for HUDSON-4039
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21797 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 21:31:48 +00:00
kohsuke a898587cde simplified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21796 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 21:29:05 +00:00
kohsuke 90f4af64e7 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21795 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 21:28:53 +00:00
kohsuke d54767aff8 Fixed the problem:
java.util.NoSuchElementException
	at java.util.StringTokenizer.nextToken(StringTokenizer.java:332)
	at hudson.model.Hudson.getItemByFullName(Hudson.java:1815)
	at hudson.model.Items.fromNameList(Items.java:92)
	at hudson.tasks.BuildTrigger.getChildProjects(BuildTrigger.java:125)
	at hudson.tasks.BuildTrigger.buildDependencyGraph(BuildTrigger.java:189)
	at hudson.util.DescribableList.buildDependencyGraph(DescribableList.java:276)
	at hudson.model.Project.buildDependencyGraph(Project.java:160)
	at hudson.model.DependencyGraph.(DependencyGraph.java:90)
	at hudson.model.Hudson.rebuildDependencyGraph(Hudson.java:3093)
	at hudson.model.Hudson.load(Hudson.java:2025)
	at hudson.model.Hudson.(Hudson.java:558)
	at hudson.WebAppMain$2.run(WebAppMain.java:190)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21794 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 21:16:52 +00:00
kohsuke ef5cffa71f using the build-in method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21793 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 21:04:34 +00:00
kohsuke bf5529567a adding error check.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21792 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 21:03:24 +00:00
kohsuke 8f00ea7df8 added a copy callback, separate from the create callback.
This is based on a discussion in http://www.nabble.com/How-do-I-make-a-BuildWrapper-be-on-by-default--td25285336.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21785 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 17:53:12 +00:00
kohsuke 484c3057b6 Merged revisions 21777 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r21777 | kohsuke | 2009-09-17 09:55:27 -0700 (Thu, 17 Sep 2009) | 1 line
  
  fixed a regression in the JDK installation
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21781 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 17:12:29 +00:00
mindless 5fde7f0f73 add TODO note to allow upgrade of bundled plugins
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21776 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 16:30:05 +00:00
mindless 0627cea06c Don't use @QueryParameter with doCheckURIEncoding, as then stapler reads
the parameter before the request.setCharacterEncoding() call in this method
(which results in a warning in the webserver log with SJSWS7).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21771 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 15:41:10 +00:00
jglick 8a304d59fe Incorrect code rejected by JDK 7's javac (and NB's editor).
http://www.netbeans.org/nonav/issues/show_bug.cgi?id=163763

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21750 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 22:50:48 +00:00
kohsuke 652a9a5c2f this needs to be public.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21747 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 20:40:56 +00:00
kohsuke f2aecc5551 more convenience methods.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21746 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 20:28:24 +00:00
kohsuke d2c8e6b8f8 more references.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21699 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 02:31:06 +00:00
kohsuke 235db08eb4 improved cross referencing.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21698 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 02:29:49 +00:00
kohsuke 200518006a refactoring the JDK installer to allow ssh-slaves to do this over SSH.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21687 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 18:53:31 +00:00
kohsuke 08c9928037 allow subtypes to be defined by plugins.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21686 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 18:12:52 +00:00
kohsuke 8a73c25000 Fixed the charset encoding handling when different encodings are involved between the master and slaves.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21664 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 23:52:25 +00:00
kohsuke 73f1b2ebac fixed a serialization form of Result so that it works like a value type.
See http://d.hatena.ne.jp/masanobuimai/20090911#1252684658

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21663 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 22:56:08 +00:00
mindless 82f0feb999 Updates to use non-deprecated APIs, and add some @Override annotations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21661 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:40:23 +00:00
mindless 2a67420162 fix indent
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21657 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:19:35 +00:00
mindless db93c57e03 Add @Override annotations, one copyright header and some tab->ws
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21655 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 19:10:57 +00:00
mindless 9fed9823f5 Add @Override annotations, remove unused imports,
add some copyright headers, some tab->ws


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21654 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 18:08:34 +00:00
pgweiss 7c2d1e9455 Don't fail the build when there is nothing to archive -- just warn -- provided system property hudson.tasks.ArtifactArchiver.warnOnEmpty=true
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21652 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 15:28:53 +00:00
dty 2a34cdafe6 [HUDSON-3677] First pass at providing read-only access to project configuration.
Defined a new permission, ExtendedRead, which can be enabled by specifying true
for the system property hudson.security.ExtendedReadPermission. Granting job
configuration permissions implies this permission.

	main/core/src/main/java/model/Item.java

Added plumbing for dynamic enabling and disabling of permissions at runtime.
This will be the basis for future UI based toggling of the availability of a
permission.

	main/core/src/main/java/hudson/security/Permission.java

Add the enabled state of a permission to the decision about whether a principal
has it or not. Only show a permission when it's enabled.

	main/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java

Allow access to config.xml when ExtendedRead is granted.

	main/core/src/main/java/hudson/model/Job.java

Don't show the save button if the user only has ExtendedRead.

	main/core/src/main/resources/hudson/model/Job/configure.jelly

Change the text of the Configure link in the side panel based on whether a user
has Configure or ExtendedRead permissions.

	main/core/src/main/resources/hudson/model/AbstractProject/sidepanel.jelly



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21626 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-12 08:13:00 +00:00
kohsuke dfacf6eab5 delete the config file first, so that even if the request doesn't fully complete, the job won't be resurrected.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21575 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 20:40:25 +00:00
mindless c3583afaff avoid a couple redundant save() calls in submit()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21571 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-10 16:35:26 +00:00
mindless bf9c475fe6 [FIXED HUDSON-4405] trim remoteFS value to avoid hard-to-notice error
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21557 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 19:04:17 +00:00
mindless bcd7e87b0d [FIXED HUDSON-4392] call Util.rawEncode on slaveName in jnlp url
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21556 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 18:51:33 +00:00
mindless d47993cfc6 [FIXED HUDSON-4333] rename constructor param from defaultvalue to defaultValue
so it works properly with @DataBoundConstructor


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21553 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 17:40:51 +00:00
abayer c13c7f94f0 [FIXED HUDSON-4423] Properly setting blockBuildWhenUpstreamBuilding now
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21550 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 16:03:12 +00:00
mindless f7e9b4fbd1 Replace uses of /fieldCheck validator with clazz="required" client-side validation.
Marked Hudson.doFieldCheck as deprecated.
Also a few more escape->encodeURIComponent.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21549 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-09 01:27:07 +00:00
mindless 5491cb256a [Util.rawEncode] Change complicated if expression to simpler array lookup
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21537 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-08 17:26:13 +00:00