Commit Graph
39 Commits
Author SHA1 Message Date
mindless 9fed9823f5 Add @Override annotations, remove unused imports,
add some copyright headers, some tab->ws


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21654 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 18:08:34 +00:00
kohsuke 1447affed5 fixed a compilation error
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19072 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-19 20:54:39 +00:00
kohsuke 6815e73ca7 introduced a new scheme to the form field validation, that makes the check feel more like a function.
Using it in a few places to begin with

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16459 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-22 18:56:36 +00:00
kohsuke 72242fcddf Merged revisions 16380-16381,16433,16435,16438 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r16380 | kohsuke | 2009-03-19 17:10:38 -0700 (Thu, 19 Mar 2009) | 1 line
  
  PeriodicWork change broke the tests, because the timer registration wasn't kicking in
........
  r16381 | kohsuke | 2009-03-19 17:33:14 -0700 (Thu, 19 Mar 2009) | 1 line
  
  fixed a test so that it's no longer timing sensitive
........
  r16433 | kohsuke | 2009-03-20 18:35:55 -0700 (Fri, 20 Mar 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_293
........
  r16435 | kohsuke | 2009-03-20 18:36:21 -0700 (Fri, 20 Mar 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r16438 | kohsuke | 2009-03-20 19:10:29 -0700 (Fri, 20 Mar 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16441 71c3de6d-444a-0410-be80-ed276b4c234a
2009-03-21 02:14:25 +00:00
kohsuke 5cf28bc2eb Proactively work around bug 6276483 by removing SunPKCS11-Solaris security provider.
See http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6276483
and http://hudson.gotdns.com/wiki/display/HUDSON/Solaris+Issue+6276483

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15292 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-13 17:25:14 +00:00
kohsuke 1a1d0d74d5 license header clean up
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15081 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-06 20:05:24 +00:00
kohsuke a06e8a05c1 - introduced adjuncts from stapler
- fixed the feature envy problem in the version computation

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14052 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-31 19:46:02 +00:00
kohsuke ce015a9c85 [FIXED HUDSON-2770] resurrected the awtProblem as boolean.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13837 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-24 18:11:44 +00:00
kohsuke bf096266b9 If AWT doesn't work, Hudson reports an error now.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13812 71c3de6d-444a-0410-be80-ed276b4c234a
2008-12-23 03:10:41 +00:00
kohsuke a9a6d17e55 unused imports
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@11598 71c3de6d-444a-0410-be80-ed276b4c234a
2008-08-18 21:04:29 +00:00
kohsuke 770a2badbd this class is not meant for sub-classing
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@11303 71c3de6d-444a-0410-be80-ed276b4c234a
2008-08-06 21:14:41 +00:00
kohsuke b355a8c741 no need to have the initialization code in a separate place.
This should fix the unit test failures in twitter4j I'm seeing at:

-------------------------------------------------------------------------------
Test set: hudson.plugins.twitter.ShouldIncludeURLTest
-------------------------------------------------------------------------------
Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 0.389 sec <<< FAILURE!
testTrueInDescriptor(hudson.plugins.twitter.ShouldIncludeURLTest)  Time elapsed: 0.358 sec  <<< ERROR!
java.lang.ExceptionInInitializerError
	at hudson.plugins.twitter.ShouldIncludeURLTest.setUp(ShouldIncludeURLTest.java:41)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.internal.runners.BeforeAndAfterRunner.invokeMethod(BeforeAndAfterRunner.java:74)
	at org.junit.internal.runners.BeforeAndAfterRunner.runBefores(BeforeAndAfterRunner.java:50)
	at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:33)
	at org.junit.internal.runners.TestMethodRunner.runMethod(TestMethodRunner.java:75)
	at org.junit.internal.runners.TestMethodRunner.run(TestMethodRunner.java:45)
	at org.junit.internal.runners.TestClassMethodsRunner.invokeTestMethod(TestClassMethodsRunner.java:66)
	at org.junit.internal.runners.TestClassMethodsRunner.run(TestClassMethodsRunner.java:35)
	at org.junit.internal.runners.TestClassRunner$1.runUnprotected(TestClassRunner.java:42)
	at org.junit.internal.runners.BeforeAndAfterRunner.runProtected(BeforeAndAfterRunner.java:34)
	at org.junit.internal.runners.TestClassRunner.run(TestClassRunner.java:52)
	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
	at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
Caused by: java.lang.NullPointerException
	at hudson.model.Queue$MaintainTask.<init>(Queue.java:928)
	at hudson.model.Queue.<init>(Queue.java:195)
	at hudson.model.Hudson.<init>(Hudson.java:144)
	at hudson.plugins.twitter.HudsonUtil.<clinit>(HudsonUtil.java:32)
	... 25 more


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@10993 71c3de6d-444a-0410-be80-ed276b4c234a
2008-07-24 15:59:29 +00:00
kohsuke 1b22943230 Merged revisions 9727,9739,9765-9766,9927,10332,10334-10338,10340,10416,10421,10553,10839-10845,10876 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/tom

........
  r9727 | huybrechts | 2008-05-31 12:49:18 -0700 (Sat, 31 May 2008) | 3 lines
  
  Issue 1659
  - cleaning up static Trigger, Hudson instances
  - resetting commons-logging
........
  r9739 | huybrechts | 2008-06-01 12:05:51 -0700 (Sun, 01 Jun 2008) | 1 line
  
  #1770 catching and logging InstantiationError
........
  r9765 | huybrechts | 2008-06-02 11:34:45 -0700 (Mon, 02 Jun 2008) | 1 line
  
  project-based security: fixed a new isAdmin call
........
  r9766 | huybrechts | 2008-06-02 11:35:27 -0700 (Mon, 02 Jun 2008) | 1 line
  
  "theInstance = null" caused some reloading problems
........
  r9927 | huybrechts | 2008-06-07 15:31:20 -0700 (Sat, 07 Jun 2008) | 8 lines
  
  Initial commit of parameterized builds. Provided functionality:
  - users can define parameters per project (only string paramters for now)
  - if a project has parameters, the 'build' button will redirect to an input page
  - parameter values can be used as ${variable} in Ant, Maven and CommandInterpreter builders
  - after the build, parameter values can be viewed in a separate page
  - tasks for parameterized builds are persisted in the queue over restarts
  - queue persistence is now in XML (with backwards compatibility for text format)
........
  r10332 | huybrechts | 2008-06-23 05:32:45 -0700 (Mon, 23 Jun 2008) | 1 line
  
  made EmbedderLoggerImpl public for use in plugins
........
  r10334 | huybrechts | 2008-06-23 05:48:10 -0700 (Mon, 23 Jun 2008) | 1 line
  
  [HUDSON-1914] additional parameter types (job, run), bugfixes
........
  r10335 | huybrechts | 2008-06-23 05:49:10 -0700 (Mon, 23 Jun 2008) | 1 line
  
  [HUDSON-1573] initialize servlet filters
........
  r10336 | huybrechts | 2008-06-23 05:52:14 -0700 (Mon, 23 Jun 2008) | 1 line
  
  [HUDSON-1915] onStarted onevent
........
  r10337 | huybrechts | 2008-06-23 06:07:32 -0700 (Mon, 23 Jun 2008) | 4 lines
  
  [HUDSON-1504] basic ui for job-based access control
  
  This allows assigning permissions per user and per job.
  It is still possible to provide defaults using a global matrix.
........
  r10338 | huybrechts | 2008-06-23 06:18:13 -0700 (Mon, 23 Jun 2008) | 3 lines
  
  [HUDSON-1504] basic ui for job-based access control
  
  adding it to the list...
........
  r10340 | huybrechts | 2008-06-23 07:23:12 -0700 (Mon, 23 Jun 2008) | 1 line
  
  [HUDSON-1504] fix compile error
........
  r10416 | huybrechts | 2008-06-25 01:13:11 -0700 (Wed, 25 Jun 2008) | 1 line
  
  initial commit staging plugin: supports doing a maven release to a staging repository, serving that repository for Hudson, and uploading it on demand
........
  r10421 | huybrechts | 2008-06-25 12:32:06 -0700 (Wed, 25 Jun 2008) | 1 line
  
  [HUDSON-1954] initial commit jbpm plugin and staging workflow example
........
  r10553 | huybrechts | 2008-07-01 14:13:57 -0700 (Tue, 01 Jul 2008) | 1 line
  
  moving registration for parameter definition out of registered class
........
  r10839 | kohsuke | 2008-07-15 13:48:05 -0700 (Tue, 15 Jul 2008) | 6 lines
  
  Making a few adjustments in preparation of merging back to the trunk.
  
  - doc updates
  - added QueueTaskFilter as a plain delegation implementation to simplify ParameterizedProjectTask.
  - renamed ParameterDefinition.newInstance(...) to createValue, to avoid having two newInstance methods
    in this part of the system that does different things
........
  r10840 | kohsuke | 2008-07-15 13:51:16 -0700 (Tue, 15 Jul 2008) | 1 line
  
  Hudson's coding convention is to use WS and no TAB.
........
  r10841 | kohsuke | 2008-07-15 14:34:37 -0700 (Tue, 15 Jul 2008) | 2 lines
  
  - making ParameterValue an abstract class to allow evolution without breaking plugins in the future
  - tweaked the UI a bit so that parameterization don't get too much visibility.
........
  r10842 | kohsuke | 2008-07-15 14:49:35 -0700 (Tue, 15 Jul 2008) | 2 lines
  
  improving the UI a bit.
  Added an icon
........
  r10843 | kohsuke | 2008-07-15 15:08:28 -0700 (Tue, 15 Jul 2008) | 1 line
  
  adding help
........
  r10844 | kohsuke | 2008-07-15 15:10:42 -0700 (Tue, 15 Jul 2008) | 1 line
  
  TAB->WS
........
  r10845 | kohsuke | 2008-07-15 15:44:47 -0700 (Tue, 15 Jul 2008) | 2 lines
  
  - Use HTTP status code to notify the automated clients that the build triggering failed.
  - Overload the "/build" URL to render the parameter entry form.
........
  r10876 | kohsuke | 2008-07-18 13:52:51 -0700 (Fri, 18 Jul 2008) | 10 lines
  
  Giving more hooks to ParameterValue to affect a build
  
   - abstracting the variable substitution process so that the actual syntax for marking
     variables (e.g., %VAR% vs ${var} vs #{xyz}) and the actual resolution process are
     orthogonal.
  
   - parameter values can now contribute BuildWrapper to a build.
  
   - parameter values can now contribute environment variables to a build.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@10950 71c3de6d-444a-0410-be80-ed276b4c234a
2008-07-22 00:48:13 +00:00
kohsuke a25326e6fc reuse the "unknown" user instead of creating a new one
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9970 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-09 23:11:47 +00:00
kohsuke a212202bbf improving the error handling. Error page shouldn't be 200.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@9871 71c3de6d-444a-0410-be80-ed276b4c234a
2008-06-05 18:29:38 +00:00
kohsuke 35362e9dab Looking at one more place (#1314)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7728 71c3de6d-444a-0410-be80-ed276b4c234a
2008-03-14 05:42:23 +00:00
kohsuke 032788d793 improving error detection for Ant 1.6.5
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7253 71c3de6d-444a-0410-be80-ed276b4c234a
2008-02-29 14:10:14 +00:00
kohsuke 66f9720fde improved error diagnostics. Make sure temporary directory is well-configured.
This would forestall problems like http://www.nabble.com/Image-links-broken-tt15316354.html


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7014 71c3de6d-444a-0410-be80-ed276b4c234a
2008-02-08 06:07:04 +00:00
kohsuke 49a3763b9e system property should take a higher priority than environment variable, as environment variables inherit from processes to processes, system properties don't.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@6904 71c3de6d-444a-0410-be80-ed276b4c234a
2008-01-29 16:35:56 +00:00
kohsuke 34ba554bd2 adding localizer <https://localizer.dev.java.net/> for a type-safe i18n support
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@6421 71c3de6d-444a-0410-be80-ed276b4c234a
2007-12-27 00:46:21 +00:00
kohsuke e551409a05 defined a scheme to put image/script/stylesheet files side-by-side with view scripts.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@6410 71c3de6d-444a-0410-be80-ed276b4c234a
2007-12-24 22:47:19 +00:00
kohsuke c94c95aca1 Acegi security exception within JEXL should propagate through the call stack for us to commence the authentication protocol.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@6355 71c3de6d-444a-0410-be80-ed276b4c234a
2007-12-20 06:35:28 +00:00
kohsuke b9873621d5 adding error diagnostics as to where servlet API is loaded from.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5706 71c3de6d-444a-0410-be80-ed276b4c234a
2007-11-05 18:59:23 +00:00
kohsuke 00c2282ab9 use a constant to avoid typo.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5661 71c3de6d-444a-0410-be80-ed276b4c234a
2007-11-01 22:14:22 +00:00
kohsuke fdf6eb5093 adding extra catch block to see diagnose "Error running hudson: no "app" attribute" problem.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5629 71c3de6d-444a-0410-be80-ed276b4c234a
2007-10-31 02:14:53 +00:00
jbq 0651632745 Compute version number before loading Hudson, so that the HudsonIsLoading page
displays a version number


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4802 71c3de6d-444a-0410-be80-ed276b4c234a
2007-09-18 10:51:47 +00:00
kohsuke 4b31585a8f initialization is now performed outside the main thread to provide better UI feedback during the initialization (#756)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4783 71c3de6d-444a-0410-be80-ed276b4c234a
2007-09-16 23:46:12 +00:00
kohsuke 170de3fd12 simplified a bit.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4191 71c3de6d-444a-0410-be80-ed276b4c234a
2007-08-10 16:00:06 +00:00
kohsuke 8c147d78f0 perform a quick check on whether we have sufficient security permissions to run. Otherwise report a nice friendly error message (#719)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4174 71c3de6d-444a-0410-be80-ed276b4c234a
2007-08-10 04:36:48 +00:00
kohsuke 7392db40e7 load static resources from the path dedicated to a specific version.
This "/static/VERSION/abc/def.ghi" path is interpreted by stapler to be
  the same thing as "/abc/def.ghi", but this avoids the stale cache
  problem when the user upgrades to new Hudson. Stapler also sets a long
  future expiration dates for such static resources.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4099 71c3de6d-444a-0410-be80-ed276b4c234a
2007-08-05 16:18:19 +00:00
kohsuke b202f373de added a base class so that an error in the timer won't kill timer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3969 71c3de6d-444a-0410-be80-ed276b4c234a
2007-08-01 17:05:31 +00:00
kohsuke e298fe3413 improved the error handling on failure to create hudson home (issue #558)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3352 71c3de6d-444a-0410-be80-ed276b4c234a
2007-05-25 23:08:00 +00:00
kohsuke 66fdd0d2e9 implemented #526 "Track the version of hudson used for each build"
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3314 71c3de6d-444a-0410-be80-ed276b4c234a
2007-05-13 17:59:23 +00:00
kohsuke 3bfa8af569 working around a memory leak in commons-logging. And they don't even acknowledge that it's a bug. Sigh.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2868 71c3de6d-444a-0410-be80-ed276b4c234a
2007-04-06 14:20:13 +00:00
kohsuke 19860fa070 merging remoting-integration branch
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1523 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-29 19:15:53 +00:00
kohsuke 4cabee9f18 typo fixes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1396 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-20 19:20:31 +00:00
kohsuke ef2c53d43a implemented 1.66.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1279 71c3de6d-444a-0410-be80-ed276b4c234a
2006-12-09 19:30:15 +00:00
kohsuke baff64ebac accept relative HUDSON_HOME.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1075 71c3de6d-444a-0410-be80-ed276b4c234a
2006-11-10 23:33:14 +00:00
kohsuke 8a0dc230f4 initial commit for a new layout.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@969 71c3de6d-444a-0410-be80-ed276b4c234a
2006-11-05 21:16:01 +00:00