Commit Graph
6204 Commits
Author SHA1 Message Date
mindless e143c96f5c [FIXED HUDSON-4894] update DRIVE_PATTERN so a path like C:\ is recognized as absolute
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23832 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 23:38:20 +00:00
kohsuke b2dc60b246 reverting a typo introduced in r23543
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23831 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 23:22:00 +00:00
mindless 56823f366f [FIXED HUDSON-4890] reconnect callback to show "Done" when update is done, and
add counter so if there are multiple update sites it shows Done when all are done.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23822 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 19:31:52 +00:00
mindless 03bc0a168d [FIXED HUDSON-4877] Fixed handling of non-ASCII characters in external job submission
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23819 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 17:47:02 +00:00
mindless f71c79918a [FIXED HUDSON-4878] r22948 introduced a little bug in that a label with no nodes
generates an exception when trying to get the cause of blockage (calls next() on
empty iterator)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23811 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-18 06:37:09 +00:00
sogabe 01486325cd fixed that core version in coreWarning is null. it should use requiredCore, not coreVersion.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23778 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-17 15:07:26 +00:00
kohsuke 5933042afe Merged revisions 23766,23768 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23766 | kohsuke | 2009-11-16 16:23:05 -0800 (Mon, 16 Nov 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_334
........
  r23768 | kohsuke | 2009-11-16 16:23:19 -0800 (Mon, 16 Nov 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23769 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-17 00:26:04 +00:00
mindless 65b3e5102f [FIXED HUDSON-2360] Space in axis value for matrix project was lost on reconfiguration
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23757 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-16 18:41:05 +00:00
mindless 4039345b0e [HUDSON-4066] Add version# is slave.jar and report this in log when a node is launched.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23750 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-16 05:21:31 +00:00
mindless 0d39e761b3 [FIXED HUDSON-3057] configure RememberMeAuthenticationProvider with PAMSecurityRealm,
so "remember me" feature works.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23740 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-15 22:44:18 +00:00
mindless 9ab15ecf9e [HUDSON-4831] don't wrap "(# times)" only separate line on build page
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23732 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-15 01:17:01 +00:00
mindless a93e851797 [HUDSON-4831] Record duplicate causes again, but now update display on the build page
to say (# times) for duplicates instead of listing them many times.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23731 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-14 22:27:31 +00:00
kohsuke 30cf7c698e Merged revisions 23698-23699 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23698 | kohsuke | 2009-11-12 19:24:53 -0800 (Thu, 12 Nov 2009) | 1 line
  
  testing if the root cause is a test failure and it's masked by the failure in tearDown
........
  r23699 | mindless | 2009-11-12 21:47:16 -0800 (Thu, 12 Nov 2009) | 2 lines
  
  [FIXED HUDSON-4831] prevent duplicate cause entries for a build
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23705 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 18:12:58 +00:00
mindless 20688553cb [FIXED HUDSON-4831] prevent duplicate cause entries for a build
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23699 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 05:47:16 +00:00
kohsuke 36040b9a7a [FIXED HUDSON-4080] Node variables not passed through to Maven jobs. In 1.335.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23695 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 02:54:36 +00:00
kohsuke d4ad980691 Merged revisions 23689-23691 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23689 | kohsuke | 2009-11-12 15:35:27 -0800 (Thu, 12 Nov 2009) | 1 line
  
  improved diagnosability
........
  r23690 | kohsuke | 2009-11-12 18:03:42 -0800 (Thu, 12 Nov 2009) | 1 line
  
  adding a probe to diagnose a sporadic test failure
........
  r23691 | kohsuke | 2009-11-12 18:14:21 -0800 (Thu, 12 Nov 2009) | 1 line
  
  I think this is causing a test failure in ExtendedReadPermissionTest, as the existing alice/bob/charlie users prevent the data on the disk from loading.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23692 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 02:18:09 +00:00
jglick 0ef598bd31 [FIXED HUDSON-4834] If an AccessDeniedException is thrown by ACEGI, do not print a full stack trace.
This could be a pretty normal occurrence; user might simply need to log in and retry the request.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23684 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 19:14:37 +00:00
mindless 8406095df3 change system property from .neverUpdate to .never to match what UpdateCenter had,
and is documented on wiki


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23683 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 18:01:01 +00:00
kohsuke d0555e8973 this isn't specific to Maven anymore
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23681 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 15:34:27 +00:00
kohsuke 121c258ff1 socket to channel needs to use a Socket(Input|Output)Stream
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23680 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 15:33:18 +00:00
kohsuke ca54609aa2 Hudson's UDP broadcast/discovery now supports IP multicast
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23679 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 15:08:48 +00:00
mindless 34ccf95285 [HUDSON-4822] patch from lkishalmi to return after sending redirect in doLoginEntry
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23678 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-12 04:24:47 +00:00
mindless f73f51d2b4 Fix so disabled permissions are not shown in project-specific permission matrix
(EXTENDED_READ has been exposed there since 1.325 even w/o Extended-Read plugin
 to enable that permission)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23659 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 20:16:27 +00:00
mindless e119e9598f [FIXED HUDSON-4787] use latest stapler with fix so we don't redirect to "." (stapler r1241)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23658 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 19:45:47 +00:00
kohsuke f055935603 Supported a relative path in the custom workspace directory, which resolves from FS root of the slave.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23656 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 19:20:15 +00:00
mindless 2fae128166 add missing checkPermission(CONFIGURE) to POST data to /job/{jobname}/config.xml
(was only checking EXTENDED_READ).  Added unit test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23652 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 04:25:05 +00:00
mindless 9d750356e1 [FIXED HUDSON-4588] catch NPE from TestResultAction constructor and report a nicer message
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23640 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-11 00:05:45 +00:00
mindless 65e9912c88 Mention the get/set job description api
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23638 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 23:12:20 +00:00
mindless ed5d70d191 [FIXED HUDSON-4573] Write log message and ignore unrecognized permissions when loading XML,
so these behave the same as other unknown fields (builders, publishers, etc).
Also changed context.convertAnother() calls to simpler reader.getValue()/writer.setValue()


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23637 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 22:43:38 +00:00
sogabe 90b1a5a3ac Updated japanese localization
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23636 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 22:33:12 +00:00
mindless bc94c23868 Plugin manager now shows warning for upgrade/install of plugins
into a Hudson that is older than the plugin was built for.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23634 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 20:30:51 +00:00
mindless f3a13715a2 remove extra whitespace around Hudson version link
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23633 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 20:02:56 +00:00
kohsuke 9757c4b68a [FIXED HUDSON-4058] Integrating a newer version of Winp that fixes memory leak problems.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23632 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 19:53:46 +00:00
kohsuke 91a4b86a0e Integrated new version of Stapler to improve the caching of Jelly scripts.
This should result in a dramatic performance improvement in the rendering of configuration pages

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23631 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 18:50:17 +00:00
mindless 4682a0e80d isUseProjectSecurity() was removed in 1.333 but was still referenced in jelly, so
"Enable project-based security" always comes up unchecked on configure pages and
project permissions are lost if not rechecked before clicking Save.
Now initialize checkbox with ${instance!=null} instead.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23630 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 17:35:10 +00:00
mindless 79f22cd661 Project read permission was not enforced via /jobCaseInsensitive/jobname path.
Added unit test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23629 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-10 07:08:14 +00:00
kohsuke 38da83339b [FIXED HUDSON-4802] in 1.334. The patch was slightly modified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23626 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:47:30 +00:00
kohsuke f8e2a28eb0 Seeing dead lock after the message:
Nov 9, 2009 1:46:11 PM hudson.remoting.Channel$ReaderThread run
SEVERE: I/O error in channel This side of the channel
java.io.IOException: Write end dead
	at java.io.PipedInputStream.read(PipedInputStream.java:294)
	at java.io.ObjectInputStream$PeekInputStream.peek(ObjectInputStream.java:2249)
	at java.io.ObjectInputStream$BlockDataInputStream.peek(ObjectInputStream.java:2542)
	at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2552)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1297)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:351)
	at hudson.remoting.Channel$ReaderThread.run(Channel.java:849)
Nov 9, 2009 1:46:11 PM hudson.remoting.Request$2 run
SEVERE: Failed to send back a reply
java.io.IOException: Read end dead
	at java.io.PipedInputStream.checkStateForReceive(PipedInputStream.java:246)
	at java.io.PipedInputStream.receive(PipedInputStream.java:210)
	at java.io.PipedOutputStream.write(PipedOutputStream.java:132)
	at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1838)
	at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1747)
	at java.io.ObjectOutputStream.writeNonProxyDesc(ObjectOutputStream.java:1249)
	at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:1203)
	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1387)
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150)
	at java.io.ObjectOutputStream.writeFatalException(ObjectOutputStream.java:1538)
	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329)
	at hudson.remoting.Channel.send(Channel.java:413)
	at hudson.remoting.Request$2.run(Request.java:282)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)



The thread dump indicates that the test thread is stuck at british.join(), because British channel reader thread is still alive. I remember PipedInput|OutputStream being not truly multi-thread aware, so changing it to our own version to see if that fixes the problem without my digging further.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23625 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:43:20 +00:00
kohsuke 80db087f64 added a bunch of CLI commands to Computer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23617 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 22:10:17 +00:00
kohsuke 846851344a doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23616 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 22:05:24 +00:00
mindless d4cb259440 [FIXED HUDSON-4784] translation from thosor
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23608 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 18:04:17 +00:00
mindless 14a37dba5b [FIXED HUDSON-4557] Moving consoleText handling from jelly to java in r20927
caused Content-Length header to no longer be written.  wget/curl seem ok with
this, but browsers display nothing for "view as plain text".
Stapler's DefaultScriptInvoker wraps the OutputStream in a filter to prevent
jelly from flushing the output; copied this into Run.doConsoleText and now
the Content-Length header gets written again, for both compressed/plain output.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23605 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 17:53:34 +00:00
mindless 36c1d4e0ac [HUDSON-4562] keep / in zip link if glob pattern is nonempty
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23603 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 17:35:42 +00:00
kohsuke 51052d3c46 Merged revisions 23599,23601 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23599 | kohsuke | 2009-11-09 08:51:27 -0800 (Mon, 09 Nov 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_333
........
  r23601 | kohsuke | 2009-11-09 08:51:57 -0800 (Mon, 09 Nov 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23602 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 16:56:34 +00:00
mindless 1e02c7c071 [FIXED HUDSON-4562] remove extra / in "all files in zip" links
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23571 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 18:40:01 +00:00
mindless 6ebcd2d97d [FIXED HUDSON-4765] Fix broken links for failed tests on MatrixBuild page.
Also removed extra slashes in links on MatrixTestResult page.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23569 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 17:44:44 +00:00
mindless 3963a49d2e add Manage Plugins link in sidepanel of UpdateCenter
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23568 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 15:37:13 +00:00
mindless 2b1a457f68 Deprecate util.StringConverter2 (extends deprecated XStream class,
but can't change it here to keep binary compatibility).
Add new HeapSpaceStringConverter to replace this.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23564 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-08 01:50:42 +00:00
kohsuke ebfa6a0e2d the test is still failing. adding more delay
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23556 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:51:39 +00:00
kohsuke 97711f3d3c it should be abstract since by itself it defines no test
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23555 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-07 00:50:19 +00:00