Commit Graph
13348 Commits
Author SHA1 Message Date
Daniel Beck 6a3c6070bf Merge branch 'master' into security-master 2020-08-04 15:22:21 +02:00
Daniel BeckandDaniel Beck 9f3002d2bf Log expected and actual values for better UTF-8 decoding diagnosability (#4871)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-03 20:53:37 +02:00
stellargo 885c05cb43 [JENKINS-62757] Introduce fingerprint migration in External Storage API (#4825) 2020-08-01 08:34:44 +01:00
Daniel BeckandDaniel Beck 3ea9dc6b3a Do not block rendering of Manage Jenkins while waiting for UC data (#4881)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:34:18 +01:00
Daniel BeckandDaniel Beck c632f42f07 Update at-since Javadoc (#4877)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:33:48 +01:00
Daniel Beck 759fc31a8c Merge branch 'security-stable-2.235' into security-master 2020-07-29 11:11:18 +02:00
Daniel Beck 7343c039cd Merge branch 'security-stable-2.222' into security-stable-2.235 2020-07-29 11:10:29 +02:00
Daniel Beck 31a3e63760 Merge branch 'security-stable-2.204' into security-stable-2.222 2020-07-29 11:09:50 +02:00
Daniel Beck ef04fbddbd Merge branch 'security-stable-2.190' into security-stable-2.204 2020-07-29 11:09:09 +02:00
Daniel Beck 29c9a8fdea [SECURITY-1960] 2020-07-29 10:54:36 +02:00
Oleg Nenashev c8de5992b4 Merge pull request #4864 from daniel-beck/JENKINS-63168
[JENKINS-63168] Prevent NPE when calling CommandInterpreter#buildEnvVarsFilterRules
2020-07-23 21:57:53 +02:00
Daniel Beck 1c9b12bb19 [JENKINS-63168] Prevent NPE when calling CommandInterpreter#buildEnvVarsFilterRules 2020-07-22 20:53:56 +02:00
Jesse Glick 1ace38110e Use support-log-formatter from jetty:run 2020-07-21 10:56:53 -04:00
stellargo be28d586b5 [JENKINS-62755] Introduce Fingerprint Cleanup in External Storage API (#4817)
* Create new FingerprintCleanupThread

* Moved test to jenkins

* Add license

* Fix license

* Fix some tests

* Fix all tests

* Remove redundant imports

* Add documentation; add test

* Fix errors in fingerprintertest

* Remove default fingerprint cleanup implementation

* Remove override from execute

* Undo author deletion

* Remove redundant import

* Move fingerprint cleanup to storage

* Fix spacing

* Add new line

* Minor fixes

* Fix tests

* Add documentation

* Introduce fingerprint cleanup toggle

* Link cleanup config to thread

* Add file system cleanup

* Add test

* Introduce external fingerprint storage cleanup tests

* Remove redundant statements

* Fix test

* Improve docstring

* Introduce shouldNotCleanFingerprintsWhenDisabled test

* Fix default cleanup value

* Minor fixes

* Enabled->Disabled

* Fix tests

* get -> is
2020-07-21 06:20:47 +02:00
0134fb11a8 [JENKINS-62014] Add build step environment filters (#4683)
Co-authored-by: Wadeck Follonier <wadeck.follonier@gmail.com>
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-07-19 09:24:00 +01:00
Félix QueirugaandTim Jacomb fb7f8903c3 [JENKINS-63002] Revamp tabs and bigtables (#4835)
Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
2020-07-19 09:23:25 +01:00
StefanSpiekerandOleg Nenashev 463cd113ba Minor refactorings either for performance or readability (#4845)
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-07-17 15:14:46 +01:00
stellargo 859f01f5ad [JENKINS-63022] Make Fingerprint Storage Engine configurable from the config page (#4834) 2020-07-17 15:14:08 +01:00
Tim Jacomb f7ae11e630 Merge pull request #4833 from Zastai/JENKINS-62723 2020-07-15 20:51:15 +01:00
55a523e34c [JENKINS-59136] Enable labels/categories with deprecated to show a warning for plugins (#4073)
* Enable labels/categories with `deprecated` to show a warning for plugins

* fix doc

* Wording

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

* Add Restricted no external use

* add since todo

* spelling

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

* use stream api to collect deprecated plugins

* link to plugin url

* add break lines to deprecation message

* fix regex

* wording and separation of description

* Hide deprecated plugins inside the available section on update center

* Add a warning inside the installed section on plugin manager

* Add support for top-level 'deprecations' element in update site

* Add test

* Make this a list to allow direct element access

* This isn't a critical problem so go with warning style, rephrase label

* Add an intermediate JSON object in the UC data for extensibility

* Make 'deprecated' a meta label (not shown in the regular label list)

* Make parsing this safer

* Null safety with labels array

* Link to the deprecation URL, not the plugin URL

* Add issue reference

* Add Javadoc

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-07-15 20:50:20 +01:00
Oleg Nenashev c145928091 Merge pull request #4830 from jglick/StandardOutputSwapper-logging
An UnsatisfiedLinkError from StandardOutputSwapper.ChannelSwapper.swap need not be reported
2020-07-15 10:54:50 +02:00
Tim Jacomb ef325a615e Merge pull request #4841 from jglick/doCheckTimeZoneName-JENKINS-61806
[JENKINS-61806] Form validation for TimeZoneProperty.timeZoneName
2020-07-14 08:00:55 +01:00
Oleg Nenashev 116d400356 Merge pull request #4823 from NextTurn/installer
Stop supporting .NET Framework 2.0 + Update Windows Service Wrapper from 2.3.0 to 2.9.0
2020-07-12 13:36:46 +02:00
Jesse Glick 6d6129d698 [JENKINS-61806] Form validation for TimeZoneProperty.timeZoneName 2020-07-10 11:28:15 -04:00
Daniel Beck 1610ba042e Add Javadoc 2020-07-10 15:35:22 +02:00
Tim Jacomb 4e5d74329d Merge pull request #4838 from jeffret-b/removeLoadBeans
Remove BeanBuilder.loadBeans(String)
2020-07-10 07:54:39 +01:00
b20b760a29 [JENKINS-62949] - Escape special characters from href attrib (#4758)
* escape special characters from href attrib

* escape special character | adding test case

* escape special character | adding test case

* escape special character | adding test case

* escape special character | adding test case

* escape special character | adding test case

* escape special character | adding test case

* escape special character | adding test case

* escape special character | adding test case

* escape special character | adding test case

* Update test/src/test/java/hudson/console/HyperlinkNoteTest.java

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

Co-authored-by: Singh, Abhinav Kumar <abhinavkumar.singh@kronos.com>
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-07-08 19:03:27 +02:00
Jeff Thompson cc1d4afed4 Remove BeanBuilder.loadBeans(String).
This method is unused in the Jenkins ecosystem.
It is potentially problematic and dangerous.
2020-07-08 11:03:21 -06:00
Tim Van Holder 7c2abcfa94 [JENKINS-62723] Extend JavaDoc with @throws 2020-07-08 00:09:21 +02:00
Tim Van Holder 9c088c27f2 [JENKINS-62723] Further fix for Util.isOverridden
This handles the remaining case (override provided by default implementation of an interface).
2020-07-07 22:23:40 +02:00
Tim Van Holder ccc0e34724 [JENKINS-62723] Improve Util.isOverridden
It will now deal with final/abstract methods appropriately.
It will also clearly report bad arguments (base not base of derived, or base does not declare the method).
Added a unit test for interface cases.

Small gap to be looked into: overrides provided via default implementation of a (derived) interface.
2020-07-07 22:09:59 +02:00
Oleg Nenashev ed71254abc Merge branch 'master' into installer 2020-07-07 10:54:00 +02:00
Tim Jacomb e9dc2694db JENKINS-41805 Cleanup workspace suffixes (#4824) 2020-07-06 19:37:30 +01:00
Jesse Glick 0eb0b904db An UnsatisfiedLinkError from StandardOutputSwapper.ChannelSwapper.swap need not be reported 2020-07-06 11:20:30 -04:00
Wadeck Follonier 96a7c68af3 Merge branch 'security-stable-2.222' into security-stable-2.235 2020-07-06 17:01:27 +02:00
Wadeck Follonier 89ec29018a Merge branch 'security-stable-2.204' into security-stable-2.222 2020-07-06 17:00:35 +02:00
Wadeck Follonier 56f715612c Merge branch 'security-stable-2.190' into security-stable-2.204 2020-07-06 16:59:31 +02:00
Singh, Abhinav Kumar 11f4a35122 [SECURITY-1945] 2020-07-06 16:34:02 +02:00
Jeff Thompson 55d1b9e387 [JENKINS-62889] ParameterDefinition check for validity (#4826) 2020-07-06 07:55:52 +01:00
Tim Van Holder a1b5ec1532 JENKINS-62572: Extend Downloadable API slightly (#4773) 2020-07-06 07:52:53 +01:00
Tim Van Holder a49f58057c [JENKINS-26097] Adjust label expression auto-completion and validation (#4774) 2020-06-29 07:40:51 +01:00
NextTurn f13e514c7f Update WindowsInstallerLink from WindowsSlaveInstaller 2020-06-26 23:37:57 +08:00
Oleg Nenashev 339f9b930e Merge pull request #4803 from jtnord/JENKINS-62688
[JENKINS-62688] use id in User.toString()
2020-06-24 18:56:26 +02:00
Johno Crawford c732bb3693 [JENKINS-62695] - Use daemon threads for SCMTrigger so Jenkins shuts down gracefully. (#4805) 2020-06-24 10:25:41 +01:00
Sumit Sarin a5310b10d6 [JENKINS-62345] Introduce FingerprintStorage API in core (#4731)
* [JENKINS-62345] Introduce FingerprintStorage API

* Fix FingerprintTest by adding JenkinsRule

* Add licenses

* Undo Adding JTH to core

* Move roundTrip test to JTH

* Move toByteArray method to Fingerprint class

* Decrease extension ordinal value for FileFingerprintStorage

* abstract logging and bulkchange into fingerprint class

* Move loading logs into Fingerprint

* Expose setPersistedFacets in Fingerprint class

* Annotate FingerprintStorage as Beta

* Add docstring for FingerprintStorage and FileFingerprintStorage

* Remove nonnull annotation from getPersistedFacets

* Add System property to choose FingerprintStorage engine

* Introduce initFacets method for abstraction

* Remove setPersistedFacets method

* Change scope of getPersistedFacets to default

* Single line return statement

* Add check for null

* Remove checkForNull annotation from initFacets

* change access scope from package to public for load

* Remove No external use from FingerprintStorageEngine

* fingerprintStorageEngine moved inside constructor

* Make get function static

* Remove ordinal value

* Make get method public

* make getPersistedFacets public

* Remove brackets from Extension

* Mark FileFingerprintStorage Beta

* Add fingerprint's hash to logging

* Spelling fix

* Remove toByteArray method

* Move getConfigFile and getFingerprintFile to FileFingerprintStorage

* Annotate and make final: getPersistedFacets

* getBytes -> fromHex

* Deprecate Fingerprint.save(File file)

* add version since deprecated

* Deprecate Fingerprint.load(file) method

* Move FingerprintStorage,FileFingerprintStorage -> jenkins.fingerprints package

* Deprecate Fingerprint load(@NonNull byte[] md5sum) and move to String id

* Delete private deprecated method

* CheckForNull added

* Add comments about implementing Saveable Listener

* Add TODO for Saveable Listener

* Add TODO for renaming md5 in xml

* Move serialize to FileFingerprintStorage

* Make serialize method private

* Add docstrings

* Revert serialize to static

* Introduce deletion in the API

* Make messageOfParseException private

* Remove Redundant imports

* Add test for fingerprint deletion

* Make methods private

* Move deletion test to FingerprintTest

* Improve code style

* Improve code style

* Add deletion errors in FileFingerprintStorage#delete

* Add spaces

* Remove extra empty line

* Variable renaming

* Add documentation

* Add spacing

* Remove spacing

* Beta -> NoExternalUse

* Refactoring

* Add CheckForNull annotation in save method

* Add documentation

* Refactor FingerprintMap#isReady to FingerprintStorage

* Suppress fingerprint cleanup thread when external storage is configured

* Add TODO

* Fix negation bug

* Move FingerprintCleanupThreadTest from core to test (needs JTH)

* Revert to using ordinal for extension

* Remove redundant import

* Add note on ID

* spacing changes

* Add spacing

* Add ordinal to extension

* Add curlies

* remove curlies

* j -> jenkinsRule

* Remove note on | delimeter

* Improve docstring

* null -> {@code null}

* Improve docstring

* Improve documentation

* Fix typos

* Minor changes to variable names and docstrings

* Update docstring
2020-06-22 09:42:08 +02:00
Daniel Beck e639c64e19 Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-06-20 20:53:34 +02:00
James Nord eb1c156065 [JENKINS-62688] use id in User.toString()
Change toString() to use the id rather than fullName.

This is because a full name may not be unique and as such when used in log
messages we get something that is less than helpful.

as such we should print the user's Id so we can actually identify the
user.
2020-06-15 15:00:29 +01:00
Daniel Beck ca00f7a11a [JENKINS-62622] Do not throw exception with nonpublic plugins 2020-06-15 09:44:46 +02:00
Tim Van HolderandJesse Glick 302159c0e8 JENKINS-29144: Enable proper environment access for build steps (#4766)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
2020-06-13 13:00:37 +01:00
Daniel BeckandDaniel Beck a53ef93cca Use the 'agent' term more often (#4777)
* Use the 'agent' term more often

* More cleanup

* Another occurrence

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-06-09 18:00:37 +02:00