Commit Graph
370 Commits
Author SHA1 Message Date
Jesse Glick 2187f804f5 Help text was misleading when an alternate MarkupFormatter was in use. 2013-05-17 03:36:34 -04:00
Kohsuke Kawaguchi 76b455184a expose the submitted file name 2013-05-08 12:13:44 -07:00
Kohsuke Kawaguchi 9b75fe5c9e Hopefully this helps us reduce the screen glitch 2013-05-01 13:00:18 -07:00
Kohsuke Kawaguchi 937315a29a Delete button will highlight what it is going to delete 2013-04-19 13:36:51 -07:00
Kohsuke Kawaguchi d74ef2783e This aligns the middle of the text and the icon.
For multiple line warning messages, this makes them little bit spaced, but I think it's OK.
2013-04-19 12:09:10 -07:00
Kohsuke Kawaguchi ac7e27756f Avoid using now deprecated names 2013-04-19 12:07:52 -07:00
Kohsuke Kawaguchi 9b072294af Added 'sorttop' class to make rows stick to the top.
Plus more simplifications
2013-04-19 12:03:49 -07:00
Kohsuke Kawaguchi d5d4b45ef7 refactored to eliminate duplication.
Using prototype.js to simplify the code
2013-04-19 11:55:28 -07:00
Kohsuke Kawaguchi 8bcc07326d avoid global names 2013-04-19 10:22:37 -07:00
Kohsuke Kawaguchi 368d8c7394 Don't let the error icon get clipped when the text is short.
On Chrome (and possibly others), an inline element like span doesn't enlarge
its size to cover its content, so the 1px place holder wasn't taking effect.

To ensure the minimum height of 16px, make it an inline-block element. I'm
not entirely sure how an inline-block element with no fixed width would behave,
but with a bit of casual testing, the text inside seems to wrap OK.
2013-04-19 10:11:28 -07:00
Kohsuke Kawaguchi 63b3c935ef Use transparent background in the title logo.
This prevents one pixel height difference between the logo and the title
bar background.
2013-04-16 19:27:36 -07:00
Kohsuke Kawaguchi 11bc7ce933 [JENKINS-13995]
Now that the context menu is open only when clicking 'v', the tooltip on model link should
be displayed as soon as the mouse hovers over it.
2013-04-16 16:00:46 -07:00
Seiji Sogabe 26b15e139c [FIXED JENKINS-17039] sort order of plugin list is not working by default 2013-04-07 10:11:48 +09:00
Jesse Glick c6f988a120 Normalized help file locations. 2013-03-18 14:41:24 -04:00
Pei-Tang Huang 1e62491558 Merge branch 'master' of https://github.com/jenkinsci/jenkins 2013-03-06 15:53:40 +08:00
Pei-Tang Huang 14fc6de7a1 Align to src/main/resources/hudson/model/Messages_zh_TW.properties.
Refine sentences.
2013-03-06 09:23:35 +08:00
Pei-Tang Huang 6a6af02f48 Fix typo. 2013-03-06 09:13:05 +08:00
Jesse Glick 470051c2a6 Comments. 2013-03-05 16:59:26 -05:00
Pei-Tang Huang 717d19a1e8 Fix typo.
Update translation.
2013-03-04 16:59:11 +08:00
Pei-Tang Huang 94ae0fe63b Align Traditional Chinese translation with commit
d62e95a976.
2013-02-28 00:45:39 +08:00
vjuranek ec1b6b31bb Merge pull request #720 from petehayes/master
Add run display name as an environment variable when RunParameter is used as a parameter.
2013-02-27 06:50:16 -08:00
Peter Hayes d62e95a976 Run Parameter's will now contribute an environment variable for the
target run's display name.

The environment variable will be named <PARAM_NAME>_NAME and will
contain the display name of the target build.
2013-02-25 13:40:01 -05:00
Pei-Tang Huang 427726b85f Add/update Chinese (traditional) translation. 2013-02-20 12:57:44 +08:00
beta ba04edcc8c Merge branch 'master' of https://github.com/jenkinsci/jenkins
Conflicts:
	core/src/main/resources/jenkins/model/Jenkins/help-rawBuildsDir.html
	core/src/main/resources/jenkins/model/Jenkins/help-rawWorkspaceDir.html
2013-02-18 20:22:06 +08:00
Kohsuke Kawaguchi acd9f2c040 Merge branch 'master' of github.com:jenkinsci/jenkins 2013-02-16 11:40:51 -08:00
Kohsuke Kawaguchi 9e68fed9fe merged back the RC branch
Conflicts:
	core/src/main/java/jenkins/model/Jenkins.java
	test/src/test/java/hudson/bugs/JnlpAccessWithSecuredHudsonTest.java
2013-02-16 11:40:16 -08:00
Kohsuke Kawaguchi 5e4b7bcc36 [FIXED JENKINS-15918] follow-up changes
- Environment variables are by convention upper case, so I'm switching to upper case. This was what the original ticket requested anyway.
- Since the ".jobName" was never documented to begin with, let's not promote that and stick to "_JOBNAME" as the official version.
2013-02-16 10:21:23 -08:00
gcummings 7338dcc01a [JENKINS-15918] Adding some detail of the Environment variables created 2013-02-16 10:21:15 -08:00
Kohsuke Kawaguchi 4c52ddfe14 [FIXED SECURITY-46]
(cherry picked from commit f8d2a0ba6c)
2013-02-13 15:30:31 -08:00
Jesse Glick 0271fdb8a2 [SECURITY-13]
(cherry picked from commit 1fb2acfd7b)

Conflicts:

	core/src/main/java/hudson/model/AbstractProject.java
	core/src/main/java/hudson/model/ParametersDefinitionProperty.java
2013-02-13 15:29:20 -08:00
Kohsuke Kawaguchi 3f48eff1ee [FIXED JENKINS-16561]
eval("") is no-op in IE but window.execScript("") isn't.
So bring the uniformity outside
2013-02-12 17:44:41 -08:00
beta 246227e875 Fix paragraphing. 2013-01-29 11:39:16 +08:00
Harald Albers f18fa7ebe1 clarified English help
The help message was uninformative about the impact of this setting on
job execution.
2012-12-29 19:42:46 +01:00
Harald Albers 08c574a4b1 German translation for GlobalProjectNamingStrategyConfiguration 2012-12-29 19:42:46 +01:00
Jesse Glick 1f94f6efd4 Reworked UnprotectedRootAction display to be in configure page for better discoverability and possibility of support from reverse-proxy-auth-plugin. 2012-12-10 13:29:37 -05:00
Kohsuke Kawaguchi 148ed0d480 Merge branch 'pull-628' 2012-12-09 06:07:12 -08:00
Kohsuke Kawaguchi 215e22576f Minor tweaks
- All our other icons do not have bounding boxes, so let's follow that
  scheme as well.
- Changed the name to "Configure Global Security" to make it clear that
  this is a part of the configuration.
2012-12-08 16:41:26 -08:00
Jesse Glick 18e4e97e86 LegacySecurityRealm.getUnprotectedRootActions 2012-12-07 13:30:21 -05:00
Jesse Glick 25cc5a87e8 Minor edits. 2012-12-07 13:07:51 -05:00
Kohsuke Kawaguchi a2a398ed0c merge the tooltip to the context menu 2012-12-06 08:54:29 -08:00
imod 1b8048cefa cleanup text and images 2012-11-25 15:48:27 +01:00
Kohsuke Kawaguchi d7b59bfc7d Fixed a regression introduced by pull request #606 2012-11-13 12:26:38 -08:00
Nicolas De loof 4e8dcbe6d7 Merge pull request #606 from ndeloof/maven-settings2
inverse maven-plugin -> config-file-provider dependency
2012-11-08 23:52:54 -08:00
imod edd6841644 minor changes from pull feedback 2012-11-05 18:34:02 +01:00
imod 2c977c79ea add help 2012-11-04 11:26:30 +01:00
Cliffano Subagio feba7ddd9e Add note on multiple patterns.
As recommended on this old mailing list thread http://jenkins.361315.n4.nabble.com/Multiple-test-reports-td380558.html . Which I found after Googling for a hint on specifying multiple Jenkins JUnit reports.
2012-11-01 18:44:34 +11:00
Kohsuke Kawaguchi 1c578ab554 [FIXED JENKINS-15617]
execScript cannot return value [1], so I'm restricting its use to where
we don't care about the return value. See ticket for more discussions

[1] http://msdn.microsoft.com/en-us/library/ie/ms536420(v=vs.85).aspx
2012-10-26 19:20:34 -07:00
Jesse Glick 52274032e3 addLoadEvent failed to pass on the Event object.
Does not matter for any handlers used in Jenkins, but can break third-party frameworks.
In particular mixpanel-2.1.min.js seems to detect when this mistake is made and somehow disables some Jenkins handlers,
causing e.g. “LOADING” to stay on job config pages and breaking behavior.js (but only on Firefox).

Using addEventListener/attachEvent where available also works, but this fix is a bit simpler and more general.
https://gist.github.com/1930440 would also work but again seems like overkill here.

To reproduce:
diff --git a/core/src/main/resources/lib/layout/layout.jelly b/core/src/main/resources/lib/layout/layout.jelly
index 1fb3fec..c1337c4 100644
--- a/core/src/main/resources/lib/layout/layout.jelly
+++ b/core/src/main/resources/lib/layout/layout.jelly
@@ -88,6 +88,19 @@ ${h.initPageVariables(context)}
 <x:doctype name="html" />
 <html>
   <head>
+<script type="text/javascript"><![CDATA[
+(function(c,a){window.mixpanel=a;var b,d,h,e;b=c.createElement("script");
+    b.type="text/javascript";b.async=!0;b.src=("https:"===c.location.protocol?"https:":"http:")+
+    '//cdn.mxpnl.com/libs/mixpanel-2.1.min.js';d=c.getElementsByTagName("script")[0];
+    d.parentNode.insertBefore(b,d);a._i=[];a.init=function(b,c,f){function d(a,b){
+    var c=b.split(".");2==c.length&&(a=a[c[0]],b=c[1]);a[b]=function(){a.push([b].concat(
+    Array.prototype.slice.call(arguments,0)))}}var g=a;"undefined"!==typeof f?g=a[f]=[]:
+    f="mixpanel";g.people=g.people||[];h=['disable','track','track_pageview','track_links',
+    'track_forms','register','register_once','unregister','identify','name_tag',
+    'set_config','people.identify','people.set','people.increment'];for(e=0;e<h.length;e++)d(g,h[e]);
+    a._i.push([b,c,f])};a.__SV=1.1;})(document,window.mixpanel||[]);
+    mixpanel.init("…something valid here…");
+]]></script>
     ${h.checkPermission(it,permission)}

     <title>${h.appendIfNotNull(title, ' [Jenkins]', 'Jenkins')}</title>
2012-10-26 20:03:03 -04:00
Kohsuke Kawaguchi 5aca73f183 [JENKINS-15617]
This needs to be eval, not geval.
Plus I forgot to return the value.
2012-10-24 18:49:00 -07:00
Kohsuke Kawaguchi 51f508ba37 [FIXED JENKINS-15617]
Evaluate script in global context.
See http://perfectionkills.com/global-eval-what-are-the-options/ for how
to evaluate JavaScript in global context.
2012-10-24 17:41:20 -07:00