Commit Graph
4048 Commits
Author SHA1 Message Date
kohsuke 73130a3853 [FIXED HUDSON-1816] in 1.331. Applied a patch from ybubnov, and made him a committer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23071 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-22 23:03:44 +00:00
kohsuke 2bc598ecdd Merged revisions 23066 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23066 | kohsuke | 2009-10-22 15:03:52 -0700 (Thu, 22 Oct 2009) | 1 line
  
  fixed a compilation problem.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23067 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-22 22:06:08 +00:00
dty 75b43ed5f8 Fix terminology, get rid of redundant String creation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23007 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 22:47:18 +00:00
dty bd27be08fc Older versions of bash improperly decide that a script is a binary file if there
is non-ASCII on the first line of the file, preventing the step from executing
properly. This was discovered by the DirectoryBrowserSupport unit test failing.
This can be worked around by inserting a leading carriage return so that bash
won't find the non-ASCII on the first line.

   - Modify the Shell task to insert a carriage return for shell scripts that
     don't start with #! or already contain a leading carriage return.

     main/core/src/main/java/hudson/tasks/Shell.java

   - This test failed after the change because the inserted carriage return
     is returned from getContent(). Trim the result before comparing it to
     the expected data.

     main/test/src/test/java/hudson/model/FreeStyleProjectTest.java


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23006 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 22:01:32 +00:00
abayer 34387b2fef Added meetsMavenReqVersion method to Maven.MavenInstallation - generalization of logic from isMaven2_1 - tests modified to check whether default MavenInstallation meets required Maven version before using bundled Maven install instead
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23000 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 19:48:11 +00:00
kohsuke f2402ec6d8 fixed a compilation problem.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22996 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 18:17:47 +00:00
kohsuke 4ca37cfd46 FoldableAction isn't used by any plugin yet, so changing the signature and moving it to a new home.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22992 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 16:56:49 +00:00
kohsuke b1b384d243 removed a compiler warning.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22990 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:49:12 +00:00
kohsuke 7d159d19e2 simplified.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22989 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:43:24 +00:00
kohsuke 2e8f055592 unused field.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22988 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:39:09 +00:00
kohsuke f52873cc30 unused private method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22987 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:38:12 +00:00
kohsuke 531ce7179f simplifiedi
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22986 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:37:59 +00:00
kohsuke 773fdeeb9a avoid instanceof.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22985 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:28:58 +00:00
kohsuke 3fc44fdfdd removed pointless empty check that doesn't affect the execution.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22984 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:27:56 +00:00
kohsuke fd4039aff4 cosmetic changes
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22983 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:23:08 +00:00
kohsuke 30a45d4364 Avoid instanceof
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22982 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 15:18:47 +00:00
kohsuke fa3a50b96f Queue has too many inner classes to make it hard to read.
Moving some of the pieces into its own package.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22948 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-20 00:25:54 +00:00
kohsuke 5c5274bc24 doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22947 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-19 23:40:24 +00:00
kohsuke bc66388f85 support mark up in the text that explains why a build is pending
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22946 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-19 23:37:27 +00:00
kohsuke 26713adab2 [FIXED HUDSON-3997] Custom workspace is now subject to to the variable expansion. This will be in 1.330.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22922 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-19 18:02:39 +00:00
mindless 39be7ffd87 Use yui treeview to show 17-40 build artifacts on build/project pages.
Added system properties for LIST_CUTOFF/TREE_CUTOFF values.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22920 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-19 17:17:48 +00:00
kohsuke d3c2d48518 Merged revisions 22846,22861-22862,22864,22868 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r22846 | kohsuke | 2009-10-16 12:20:23 -0700 (Fri, 16 Oct 2009) | 1 line
  
  [FIXED HUDSON-4456] This problem is fixed toward 1.329.
........
  r22861 | kohsuke | 2009-10-16 16:45:02 -0700 (Fri, 16 Oct 2009) | 1 line
  
  this is now done asynchronously by Hudson
........
  r22862 | kohsuke | 2009-10-16 17:41:53 -0700 (Fri, 16 Oct 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_329
........
  r22864 | kohsuke | 2009-10-16 17:42:13 -0700 (Fri, 16 Oct 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r22868 | kohsuke | 2009-10-16 18:20:51 -0700 (Fri, 16 Oct 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22919 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-19 17:10:29 +00:00
kohsuke 35e6c076dd Update center switched over from <tt>https://hudson.dev.java.net/</tt> to <tt>http://hudson-ci.org/</tt>
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22855 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-16 22:19:08 +00:00
kohsuke f092e9f0a5 Merge commit 'rtyler/master'
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22771 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-14 21:46:49 +00:00
R. Tyler Ballance c59e4c5896 [FIXED HUDSON-4654] Properly return "true" when calling isDarwin on a Mac.
Patch submitted by Benjamin Shine <bshine@yahoo-inc.com>
2009-10-13 22:07:05 -07:00
dty 5c65527ceb The visibility rules for top level test results and test suite results were not
consistent with the recent changes to test case results. Added visibility
attributes to @Exported annotations so that stdout and stderr can be filtered
out of the remote API.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22735 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-14 04:21:38 +00:00
kohsuke fdf857c7fd reload-config -> reload-configuration.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22667 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-12 17:08:38 +00:00
kohsuke e283405c10 added the reload-config command.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22666 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-12 17:07:11 +00:00
kohsuke 91a43c52f8 Added the "build" CLI command that can not only schedule a new build, but also wait until its completion.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22663 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-12 16:26:26 +00:00
kohsuke 189676b377 direct the browser to download the data in a certain file name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22558 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-09 00:55:42 +00:00
dty ee0f1d5bdc Synchronize access to the build number.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22542 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-08 21:06:50 +00:00
kohsuke 126f04cd50 improved error diagnosis to point out which site we are trying to access.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22519 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-08 14:45:26 +00:00
jglick 263d587cc3 [FIXED HUDSON-4609] Overview of polling activity was never showing anything, due to confusion between two kinds of Runnable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22459 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-06 16:00:21 +00:00
jglick f74eaaffbf Correcting import in Javadoc.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22454 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-06 15:30:09 +00:00
kohsuke 6b1e9c2510 Fixed a bug in the form submission logic of the SMTP authentation configuration.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22396 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-05 01:46:13 +00:00
kohsuke 0acbe7478c Hudson shouldn't store SMTP auth password in a clear text.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22382 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 14:55:20 +00:00
kohsuke 8dd9f1bf42 Secret class should be serialization forward compatible with Strnig.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22381 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 14:52:21 +00:00
kohsuke 704899683c [FIXED HUDSON-4592] Generally speaking, security manager restricts too many things away that you'll unlikely to get Hudson function properly. Hudson has a graceful error check for this in its ServletContextInitializer, but it looks like the filters are initialized before that, and causing the hard failure that you saw.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22379 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 01:41:38 +00:00
kohsuke 397d45193d Added a form validation check to detect typical errors like http://www.nabble.com/cannot-setup-email-account-td25727896.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22378 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 01:22:07 +00:00
pgweiss 6f0c7ec9a8 Use -Dhudson.upstreamCulprits=true to implement passing culprit information to downstream jobs
in core.  I prefer this to a plugin as I want to use the existing email infrastructure.

I assume that when taksan does his plugin it will work as long as this property is _not_ set.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22362 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-02 20:33:07 +00:00
kohsuke b3166a03c7 [HUDSON-4590] only send a request up to every once in 10 seconds in order to avoid hitting java.net too hard when it's about to recover from an outage.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22348 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-02 18:38:15 +00:00
kohsuke 967531a1e3 [FIXED HUDSON-4590] Defer injection of the script until the page load event fires, so that inability to load scripts from java.net wouldn't block other things that's wating for the firing of the onload event.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22347 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-02 18:09:47 +00:00
kohsuke 596e2b9de1 without a message, it's as if the validate button didn't do anything
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22330 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-01 21:27:30 +00:00
dty 572039518a Added visibility attribute to fields that are exported through the remote API.
The default behavior doesn't change, but fields that don't contain output are
now more visible (they will stay visible through depth=-10, where they before
they went away at depth=-1). Field with test out, i.e., stderr, stdout,
errorDetails, errorStackTrace can now be excluded seperately from other fields.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22276 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-29 00:06:28 +00:00
kohsuke 6fb51882fc doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22266 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 20:45:37 +00:00
kohsuke dc11d862ec Added an extension point for inserting actions across all projects without configuration.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22262 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 20:36:04 +00:00
kohsuke d69c7f678e Merged revisions 22140,22200,22202,22205,22237,22240,22242,22245 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r22140 | kohsuke | 2009-09-24 16:41:50 -0700 (Thu, 24 Sep 2009) | 1 line
  
  updating to a new version
........
  r22200 | kohsuke | 2009-09-25 16:33:50 -0700 (Fri, 25 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_325
........
  r22202 | kohsuke | 2009-09-25 16:34:05 -0700 (Fri, 25 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r22205 | kohsuke | 2009-09-25 17:09:38 -0700 (Fri, 25 Sep 2009) | 1 line
  
  updated changelog as a part of the release
........
  r22237 | kohsuke | 2009-09-28 09:51:38 -0700 (Mon, 28 Sep 2009) | 1 line
  
  [HUDSON-4353] My fix had a crucial bug that prevents plugin updates from failing.
........
  r22240 | kohsuke | 2009-09-28 10:37:51 -0700 (Mon, 28 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_326
........
  r22242 | kohsuke | 2009-09-28 10:39:05 -0700 (Mon, 28 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r22245 | kohsuke | 2009-09-28 11:24:40 -0700 (Mon, 28 Sep 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22250 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 19:58:53 +00:00
jglick 39cf92377e dos2unix for text files in repo (minus plugins/). SVN client on Windows should convert where needed.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22234 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 15:47:43 +00:00
kohsuke bb984e4dd6 [FIXED HUDSON-3721] Job-enabling API should reject GET requests.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22207 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-26 00:13:35 +00:00
mindless a119c26b9c javadoc update
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22187 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-25 19:15:40 +00:00