Commit Graph
16132 Commits
Author SHA1 Message Date
Oliver Gondža a655611f76 Remove polish trnaslation that sneaked into english one 2016-12-19 13:34:08 +01:00
Kohsuke Kawaguchi 3a3f32da9d [maven-release-plugin] prepare for next development iteration 2016-12-18 17:49:48 -08:00
Kohsuke Kawaguchi e67560843f [maven-release-plugin] prepare release jenkins-2.37 2016-12-18 17:49:48 -08:00
Stephen Connolly 673cc13ffb Merge pull request #2665 from stephenc/jenkins-40252
[FIXED JENKINS-40252] Add an Iterable<T> that returns all items unsorted
2016-12-16 23:54:25 +00:00
bpedersen2 8634965a4f [JENKINS-39971] Always display the recheck button in the Plugin Manager (#2668)
The re-check updatecenter button should be visible even if there are
currently no pending updates.
2016-12-16 22:53:20 +01:00
Oleg Nenashev a0262d2fec [JENKINS-40435] - Use BulkChange when processing config changes in Job#doConfigSubmit. (#2664)
When an empty Freestyle job config gets submitted in the default configuration of Jenkins 2.35, the data is being saved to the disk *8 times*. All of them happen in this code: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Job.java#L1227-L1246

* setDisplayName
* Project#getBuildWrappersList().rebuild (onModified handler)
* Project#getBuilderList().rebuild (onModified handler)
* Project#getPublisherList().rebuild (onModified handler)
* AbstractProject#makeDisabled
* AbstractProject#setScm
* AbstractProject#triggers.replaceBy
* final save()

There is not so much sense to save partial configurations to the disk due to the risk of data inconsistency there. This change just wraps the config submission section of the job into the BulkChange clause.
2016-12-16 22:52:31 +01:00
Markus Winter a1258c0009 [JENKINS-40365] add Node#getNodeProperty methods (#2663)
* [JENKINS-40365] add getNodeProperty methods

* implement getNodeProperty in DummySlave

* implement getNodeProperty in Node

avoid binary imcompatible change
dded javadoc

* revert Slave.jar to original

* fix formatting

* more formatting
2016-12-16 22:52:09 +01:00
Daniel Beck 7bb4a592d4 [FIX JENKINS-39433] Make URI encoding check into admin monitor (#2661) 2016-12-16 22:50:37 +01:00
Stephen Connolly 6ce8cafcdd Oleg wanted Javadoc commend 2016-12-15 23:13:50 +00:00
Oleg Nenashev 9c23a30e67 [FIXED JENKINS-40489] - Fix Jenkins initialization stage names 2016-12-16 00:03:06 +01:00
Bryson Gibbons 0060335b8c [JENKINS-32797] Break the catch clause contents of Jenkins.getTarget(… (#2652)
* [JENKINS-32797] Break the catch clause contents of Jenkins.getTarget() out into a separate, publicly accessible function.

This will allow plugins (particularly authentication plugins that override the normal authentication process) to determine if authentication is not required for a particular path by calling isPathUnprotected(restOfPath).

* Add @since TODO to comment

* Change name of function to something that is accurate and clear

isPathUnprotected is misleading, and the Javadoc was worse. isSubjectToMandatoryReadPermissionCheck is a much better name, and the return value is reversed to match the name,
2016-12-15 23:49:13 +01:00
Damian Szczepanik bd6a7d6751 Polish translations (added new, removed outdated) (#2643) 2016-12-15 23:43:55 +01:00
Stephen Connolly 16254cb8ba [JENKINS-40252] Switch to allItems where traversal order is not important
- Also switch in cases where we have a subset that is likely significantly smaller and hence quicker to sort
2016-12-15 10:35:00 +00:00
Pavel Janousek 15e6987419 [JENKINS-38903] Split Exception handling for node provision and adding to Jenkins (#2591)
* [JENKINS-38903] Split Exception handling for node provision and adding to Jenkins

* Defined new static helper methods that ensure exceptions are not propagated

* Added onCommit and onRollback signals to CloudProvisioningListener

Added the new signals to be able to notify the state after Jenkins.addNode(Node)
All Listener's calls moved to an exception-tolerant static helpers

* Added @Nonnull annotation
Changed the method signature CloudProvisioningListener.onRollback()

* Re-throw Error in the fireOnXXX()
Removed re-thrown Throwable in the main try/catch block
	(an instance of the Error is handled separately)

* Handling of Error changed

* Fixed Error instance handling in NodeProvisioner.fireOnFailure()
2016-12-15 11:34:12 +01:00
Stephen Connolly ab849a3054 [JENKINS-40252] Expose utility comparator singletons 2016-12-15 10:33:04 +00:00
kbrowder 37806a53c8 [FIXED JENKINS-40286] - Delegate JnlpMac computation to SlaveComputers if possible (#2658)
[FIXED JENKINS-40286] - Delegate JnlpMac computation to SlaveComputers if possible
2016-12-15 11:31:29 +01:00
Stephen Connolly 52ea389a5e [JENKINS-40252] Address code review comments 2016-12-15 10:25:04 +00:00
andrealaura f042bf2215 [FIX JENKINS-40053]: Use english as default-locale ResourceBundleUtilTest#test_unknown_locale (#2650)
* [FIX JENKINS-40053]: Use english as default-locale, so the ResourceBundleUtilTest runs also on systems with other default os locales.

* [FIX JENKINS-40053]: Cleanup Locale after test to avoid impact on other tests.

*  [FIX JENKINS-40053]: Use english as default-locale only in the required test method.

* [FIX JENKINS-40053]: Cleanup unused imports.
2016-12-15 08:25:23 +01:00
Stephen Connolly cf0fea0c1f [FIXED JENKINS-40252] Add an Iterable<T> that returns all items unsorted 2016-12-14 20:23:51 +00:00
Oleg Nenashev 1868c8486b Merge pull request #2645 from alvarolobato/JENKINS-28245
[FIX JENKINS-28245] - Allow defining agent ping interval and ping timeout in seconds
2016-12-14 10:38:53 +01:00
Daniel Beck e7e51eeb62 Merge pull request #2660 from daniel-beck/JENKINS-39700
[FIX JENKINS-39700] Don't fail when no parameters property for job
2016-12-12 18:04:31 +01:00
Stephen Connolly e2e17da128 since FIXME -> 2.37 2016-12-12 15:22:19 +00:00
Stephen Connolly e18b34caaf Merge pull request #2603 from stephenc/jenkins-39300
[JENKINS-39300] View.getDisplayName() is ignored when rendering tabs
2016-12-12 15:13:46 +00:00
Kohsuke Kawaguchi 49653d1a6d [maven-release-plugin] prepare for next development iteration 2016-12-11 20:50:44 -08:00
Kohsuke Kawaguchi 44133ea90c [maven-release-plugin] prepare release jenkins-2.36 2016-12-11 20:50:44 -08:00
Daniel Beck fdba189158 Fix 'since TODO' from #2630 2016-12-10 17:46:25 +01:00
Daniel Beck 8d465c6aa0 Merge pull request #2659 from jglick/Run.getBadgeActions-JENKINS-40281
[JENKINS-40281] Do not try to mutate the result of getActions(Class)
2016-12-10 01:53:39 +01:00
Daniel Beck e43222dde8 [FIX JENKINS-39700] Don't fail when no parameters property for job 2016-12-09 12:02:32 +01:00
andrealaura ba2900b27d [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it … (#2649)
* [FIX JENKINS-36044]: Added default locale to XMLUtilsTest so that it runs independent from the host OS locale.

* [FIX JENKINS-36044]: Cleanup default-locale after test, to avoid impact to other tests.

*  [FIX JENKINS-36044]: Make test language indepedent.

* [FIX JENKINS-36044]: Cleanup unused imports.
2016-12-09 11:23:58 +01:00
Daniel Beck 7292c91ea0 Merge pull request #2656 from daniel-beck/localizer-1.24-access-modifier
Annotate localizer generated Messages classes with NoExternalUse
2016-12-09 11:19:56 +01:00
Oleg Nenashev 006c6264b6 Merge pull request #2647 from olivergondza/testPluginWrapper
Test plugin wrapper
2016-12-09 11:07:17 +01:00
Jesse Glick 8d23041d4b [JENKINS-38514] Retain CauseOfBlockage from JobOffer (#2651)
* Converted to JenkinsRule.

* Improved messages from Node.canTake.

* [FIXED JENKINS-38514] BuildableItem needs to retain information from JobOffer about why it is neither blocked nor building.

* Converted to JenkinsRule.

* Found an existing usage of BecauseNodeIsNotAcceptingTasks.

* Original JENKINS-6598 test was checking behavior we want amended by JENKINS-38514.

* Ensure that a BuildableItem which is simply waiting for a free executor reports that as its CauseOfBlockage.

* Review comments from @oleg-nenashev.
2016-12-09 11:04:22 +01:00
Jesse Glick 5c79beb3ef [FIXED JENKINS-40281] Do not try to mutate the result of getActions(Class). 2016-12-08 18:03:45 -05:00
Stephen Connolly fd2009a971 [JENKINS-38606] Allow legacy localized links to continue working after migration
- This means we can default the migration to enabled
2016-12-07 09:54:04 +00:00
Kanstantsin Shautsou 9172bca30f [FIX JENKINS-40266] Allow override UserProperty.setUser(User) (#2655)
UserProperty may contain nested objects that depend on User. 
On User reconfiguration setUser(User) is called so it should be non-final to have ability override it and update references in nested objects.

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
2016-12-07 00:52:35 +01:00
Daniel Beck eac59f3b5e Annotate localizer generated Messages classes with NoExternalUse
Also update to localizer 1.24 which adds support for this.
2016-12-06 17:17:42 +01:00
Kohsuke Kawaguchi f106e249b6 [maven-release-plugin] prepare for next development iteration 2016-12-04 12:36:17 -08:00
Kohsuke Kawaguchi 37df0e3a46 [maven-release-plugin] prepare release jenkins-2.35 2016-12-04 12:36:17 -08:00
Oleg Nenashev 29893354a5 [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods (#2653)
* [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods

* [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
2016-12-03 16:55:35 +01:00
Baptiste Mathus b6eb255b22 Clarify hudson.Extension#ordinal documentation
I have to read it many times each time I need it. Hopefully
it's a bit clearer with this addition.
2016-11-30 15:42:29 +01:00
Jesse Glick 9ecc77b9ba [JENKINS-38867] Since tag for #2582. 2016-11-29 10:06:42 -05:00
Alvaro Lobato 6dea3c3f70 [JENKINS-28245] - Finish deadmoose's work to allow defining agent ping interval and ping timeout in seconds 2016-11-29 11:15:16 +01:00
David Hoover d563062747 [FIXED JENKINS-28245] Allow finer-grained tuning of ChannelPinger.
* Allows customization in seconds, not minutes
 * Allows customization of the ping timeout (before, you could set a
   custom interval, but the timeout would always be PingThread's 4
   minute default)

This also drops the serialVersionUID from ChannelPinger.SetUpRemotePing;
without one provided, the JVM will generate one on demand which is
sufficient for the purposes here since these are never persisted and
master & slave run the same compiled code. (And it demonstrably works
since countless other MasterToSlaveCallables fail to specify their own
custom IDs)
2016-11-29 10:28:01 +01:00
Baptiste Mathus a05d9422ef Merge pull request #2646 from batmat/add-level-to-SystemProperties
Be able to specify the log Level when system property is not found
2016-11-28 12:40:30 +01:00
mawinter69 5cc21bc3b9 [JENKINS-39972] export fullName and fullDisplayName (#2644) 2016-11-28 05:44:33 +04:00
Kohsuke Kawaguchi 36ba8e590d [maven-release-plugin] prepare for next development iteration 2016-11-27 12:55:26 -08:00
Kohsuke Kawaguchi 5346c8b6f2 [maven-release-plugin] prepare release jenkins-2.34 2016-11-27 12:55:26 -08:00
Oleg Nenashev 63c2f6c5d7 Update winp to 1.24. In particular, it addresses issues like [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) (#2619)
### Changes to be picked

### 1.24

Release date: Nov 2, 2016

* [Issue #22](https://github.com/kohsuke/winp/issues/22) - Winp sometimes kills random processes when using killRecursive. ([PR #23](https://github.com/kohsuke/winp/pull/23))
* [WINP-10](https://java.net/jira/browse/WINP-10) - Fix for `getCmdLineAndEnvVars()` which fails on x64 versions of Windows. ([PR #20](https://github.com/kohsuke/winp/pull/20))
* [Issue #24](https://github.com/kohsuke/winp/issues/24) - Wrong folder when using the `winp.folder.preferred` system property (parent instead of the actual folder). ([PR #25](https://github.com/kohsuke/winp/pull/25))
* [Issue #26](https://github.com/kohsuke/winp/issues/26), [JENKINS-20913](https://issues.jenkins-ci.org/browse/JENKINS-20913) - Native class now tries loading DLLs via the temp location. ([PR #27](https://github.com/kohsuke/winp/pull/27))

### 1.23

Release date: Fev 16, 2015

* Migrate native components to Visual Studio Community 2013. ([PR #14](https://github.com/kohsuke/winp/pull/14))
* Provide a `winp.unpack.dll.to.parent.dir` property, which disables DLL unpacking to the parent dir. ([PR #14](https://github.com/kohsuke/winp/pull/12))
2016-11-27 07:41:36 +01:00
Jesse Glick 6360b96464 [JENKINS-38867] Optimize performance of Actionable.getAllActions (#2582)
* Optimize Actionable.getAllActions.

* Also need to invalidate the cache when new plugins are installed.

* Various improvements to TransientActionFactory caching.
· Move the cache code to TransientActionFactory itself, for better encapsulation.
· Optimize getAction(Class) to not need to call getAllActions; avoids copying lists, and can avoid calling TransientActionFactory at all.
· Ensure that we maintain a separate cache per ExtensionList instance, so that static state is not leaked across Jenkins restarts.

* Updated TransientActionFactory to specify what kinds of actions it could produce.

* It turns out that changing type parameters for an extension, while generally binary-compatible, breaks reflective code in Jenkins and so this is not an option.
… hudson.ExtensionFinder$GuiceFinder$SezpozModule configure
WARNING: Failed to load com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl
java.lang.LinkageError: Failed to resolve class com.cloudbees.hudson.plugins.folder.relocate.RelocationAction$TransientActionFactoryImpl
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:489)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.configure(ExtensionFinder.java:506)
	at …
	at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:280)
	at …
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:472)
	at hudson.ExtensionList.load(ExtensionList.java:349)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:287)
	at hudson.ExtensionList.getComponents(ExtensionList.java:167)
	at jenkins.model.Jenkins$8.onInitMilestoneAttained(Jenkins.java:1082)
	at jenkins.InitReactorRunner$1.onAttained(InitReactorRunner.java:82)
	at org.jvnet.hudson.reactor.ReactorListener$Aggregator.onAttained(ReactorListener.java:104)
	at org.jvnet.hudson.reactor.Reactor$1.run(Reactor.java:176)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:117)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.reflect.MalformedParameterizedTypeException
	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.validateConstructorArguments(ParameterizedTypeImpl.java:58)
	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.<init>(ParameterizedTypeImpl.java:51)
	at sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl.make(ParameterizedTypeImpl.java:92)
	at sun.reflect.generics.factory.CoreReflectionFactory.makeParameterizedType(CoreReflectionFactory.java:105)
	at sun.reflect.generics.visitor.Reifier.visitClassTypeSignature(Reifier.java:140)
	at sun.reflect.generics.tree.ClassTypeSignature.accept(ClassTypeSignature.java:49)
	at sun.reflect.generics.repository.ClassRepository.getSuperclass(ClassRepository.java:90)
	at java.lang.Class.getGenericSuperclass(Class.java:777)
	at hudson.ExtensionFinder$GuiceFinder$SezpozModule.resolve(ExtensionFinder.java:470)
	... 29 more

* Remove actionType override to make for a simpler diff.

* Strengthened test to cover accesses to unrelated context types.

* Strengthening tests in a couple of ways.

* Javadoc improvements suggested by @oleg-nenashev.
2016-11-27 07:38:38 +01:00
Oliver Gondža a077b6ec9c Report dependency version we failed to load, not the one we require 2016-11-25 15:22:25 +01:00