Commit Graph
4484 Commits
Author SHA1 Message Date
mindless 7694a68258 tiny simplification
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30302 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 17:48:32 +00:00
kohsuke d21407be4f [FIXED HUDSON-6311] (actually, this change went in as rev.30287, but I'm testing if the issue update is working again)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30290 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 07:07:55 +00:00
kohsuke 7e183a983b [FIXED HUDSON-6311] reverted the problematic change and instead introduced the ideal signature in a new name.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30287 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:29:10 +00:00
kohsuke b06bf8461b expose a few variables to the script.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30283 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 05:17:52 +00:00
kohsuke 207f3112af Fixed UOE in the following exception. Maybe I shouldn't have relied on servlet filters and defined my own thing inside Stapler, so that this whole thing can happen after the request/response/stapler association was made.
But now it's too late. 

java.lang.UnsupportedOperationException
	at hudson.security.AccessDeniedHandlerImpl$1.getServletName(AccessDeniedHandlerImpl.java:58)
	at javax.servlet.GenericServlet.getServletName(GenericServlet.java:368)
	at javax.servlet.GenericServlet.log(GenericServlet.java:300)
	at javax.servlet.GenericServlet.init(GenericServlet.java:257)
	at org.kohsuke.stapler.Stapler.init(Stapler.java:67)
	at hudson.security.AccessDeniedHandlerImpl.handle(AccessDeniedHandlerImpl.java:56)
	at org.acegisecurity.ui.ExceptionTranslationFilter.handleException(ExceptionTranslationFilter.java:229)
	at org.acegisecurity.ui.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:176)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.BasicAuthenticationFilter.doFilter(BasicAuthenticationFilter.java:112)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1088)
	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:360)
	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:729)
	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:405)
	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
	at org.mortbay.jetty.Server.handle(Server.java:324)
	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:505)
	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:829)
	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:513)
	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:211)
	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:380)
	at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector.java:228)
	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:488)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30282 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 01:12:40 +00:00
kohsuke 7a6c9d5b1a handle cases like [foo]http://bar/[/foo] or <foo>http://bar/</foo>.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30281 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-21 00:16:52 +00:00
kohsuke 5ae67f416b Added Secret.toString(Secret) that hides the handling against NPE.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30276 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-20 23:33:03 +00:00
sogabe 799492ba6b fixed garbled response of XML API if xpath is specified. http://n4.nabble.com/Hudson-API-XML-td1723766.html#a1723766
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30178 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-17 11:11:35 +00:00
mindless c2fd840846 [FIXED HUDSON-6252] fix bad index calculation in SubText.subText which
caused StringIndexOutOfBoundsException in UrlAnnotator.  Added test.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30102 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-16 00:23:00 +00:00
kohsuke 86c0b80265 bug fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30095 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 23:08:54 +00:00
kohsuke e1e0237f65 work around for bug 6933067.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30091 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 21:30:47 +00:00
mindless 77da4bcba2 [FIXED HUDSON-6269] Add synchronized on Project.updateTransient actions to avoid
deadlock between saving project config and getting project page.. save locked
transientActions and then project itself; get locks project, then transientActions.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30087 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 18:04:47 +00:00
kohsuke 277d995bb1 [HUDSON-6259] report the error messaeg in addition to error code.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30074 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 01:34:14 +00:00
kohsuke 000a7c33b1 Extension points can be now sorted.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30071 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-15 00:24:55 +00:00
kohsuke 6253fb1b24 Test performance improvement by allowing multiple Hudsons to reuse classloaders.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30070 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-14 22:55:18 +00:00
mindless b3eb862daa report any missing class errors to OldDataMonitor
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30025 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-13 14:52:45 +00:00
kohsuke a559b1635a Fixed http://n4.nabble.com/Password-masking-when-running-commands-on-a-slave-tp1753033p1753033.html
Mask wasn't sent properly to slaves.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29920 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-10 01:17:04 +00:00
kohsuke 06d4cf11a1 integrated custom annotation checker
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29918 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-09 23:16:15 +00:00
dty e48188122d Hook to allow Build subclasses to provide their own Runner implementations.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29913 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-09 22:40:11 +00:00
cactusman 8809f3def6 Fixed don't set charset.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29877 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-08 07:18:02 +00:00
kohsuke 9dbd212039 fixed NPE if stdout isn't given:
Exception: 
Stacktrace:
java.lang.NullPointerException: out is null
	at hudson.util.StreamCopyThread.(StreamCopyThread.java:44)
	at hudson.util.StreamCopyThread.(StreamCopyThread.java:51)
	at hudson.Proc$LocalProc.(Proc.java:150)
	at hudson.Proc$LocalProc.(Proc.java:121)
	at hudson.Launcher$LocalLauncher.launch(Launcher.java:633)
	at hudson.Launcher$ProcStarter.start(Launcher.java:268)
	at hudson.Launcher$ProcStarter.join(Launcher.java:275)
	at hudson.plugins.script_realm.ScriptSecurityRealm.authenticate(ScriptSecurityRealm.java:62)
	at hudson.security.AbstractPasswordBasedSecurityRealm$Authenticator.retrieveUser(AbstractPasswordBasedSecurityRealm.java:137)
	at org.acegisecurity.providers.dao.AbstractUserDetailsAuthenticationProvider.authenticate(AbstractUserDetailsAuthenticationProvider.java:119)
	at org.acegisecurity.providers.ProviderManager.doAuthentication(ProviderManager.java:195)
	at org.acegisecurity.AbstractAuthenticationManager.authenticate(AbstractAuthenticationManager.java:45)
	at org.acegisecurity.ui.webapp.AuthenticationProcessingFilter.attemptAuthentication(AuthenticationProcessingFilter.java:71)
	at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:252)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.ui.basicauth.BasicProcessingFilter.doFilter(BasicProcessingFilter.java:173)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249)
	at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:66)
	at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87)
	at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
	at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
	at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
	at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
	at winstone.RequestDispatcher.forward(RequestDispatcher.java:333)
	at winstone.RequestHandlerThread.processRequest(RequestHandlerThread.java:244)
	at winstone.RequestHandlerThread.run(RequestHandlerThread.java:150)
	at java.lang.Thread.run(Thread.java:637)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29867 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-08 05:29:38 +00:00
cactusman 4572e7738c refactering
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29858 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-07 23:51:31 +00:00
mindless 46d604dd42 [FIXED HUDSON-2341] Colored ball image at top of build pages was broken
for Hudson in some web containers. Fixed by removing workaround (r323)
for a Firefox bug (https://bugzilla.mozilla.org/show_bug.cgi?id=89419),
fixed since 3.0.5 (Dec, 2008).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29855 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-07 22:15:34 +00:00
kohsuke 7573c9bed4 return value from Recorder.perform shouldn't be ignored. See http://n4.nabble.com/how-can-a-Recorder-mark-build-as-failure-tp1746654p1746654.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29836 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-06 23:55:17 +00:00
kohsuke 5e342c7e7c rolling back the LDAP change based on the discussion: http://n4.nabble.com/LDAP-change-tp1749752p1749752.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29831 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-06 23:18:41 +00:00
cactusman b2bd8ceae2 Added to configure charset option of Mailer.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29822 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-06 14:58:59 +00:00
kohsuke 3ba89b5b88 Fixed a bug where a job created via XML didn't properly receive upstream/downstream computation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29798 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-06 05:09:22 +00:00
kohsuke b09c5098e4 Added the slave retention strategy based on a schedule.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29797 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-06 04:54:40 +00:00
sogabe fd054f70c1 Status of build history doesn't indicate test fafilure.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29716 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-02 12:44:41 +00:00
kohsuke 3ff23b5d16 adding a convenience base class for various Cloud implementations.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29689 71c3de6d-444a-0410-be80-ed276b4c234a
2010-04-01 22:46:27 +00:00
kohsuke 05cf2ddc68 Quiet period wasn't taking effect properly when doing parameterized builds.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29665 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 22:27:36 +00:00
kohsuke a52565547c strange place to check for buildability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29664 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 22:21:28 +00:00
kohsuke c5d891b1b9 [FIXED HUDSON-6137] in 1.354. Thanks for the patch!
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29663 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 22:15:45 +00:00
kohsuke c78ae310bf [FIXED HUDSON-6034] in 1.354.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29653 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 16:47:51 +00:00
sogabe 03198ecc7f l18n & l10n of navigation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29641 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 13:05:32 +00:00
sogabe 49e6ed2040 fixed compilation failure.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29635 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 10:56:31 +00:00
kohsuke 79b0db483f do not require the READ permission for channel connections. The connected session will be authenticated later
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29623 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 01:25:10 +00:00
kohsuke cfe3f7315e doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29622 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-31 01:01:10 +00:00
kohsuke ef39c053f7 Relaxed the LDAP search a bit so that it also matches the 'cn' and 'mail' attributes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29615 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-30 23:10:15 +00:00
kohsuke a168fc472a - Improved the error reporting mechanism in LDAP setting.
- improved FormValidation.error(...) so that one can easily send the full stack trace.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29612 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-30 22:41:24 +00:00
kohsuke 918a06d270 committed to the serializability.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29600 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-30 18:16:55 +00:00
kohsuke 9e22361309 Merged revisions 29309-29311,29421,29449,29451,29459 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r29309 | kohsuke | 2010-03-26 14:44:45 -0700 (Fri, 26 Mar 2010) | 1 line
  
  Work around for http://n4.nabble.com/hudson-logging-LogRecorderManagerTest-failing-tp1589811p1589811.html
........
  r29310 | kohsuke | 2010-03-26 14:45:29 -0700 (Fri, 26 Mar 2010) | 1 line
  
  unnecessary boxing
........
  r29311 | kohsuke | 2010-03-26 16:00:41 -0700 (Fri, 26 Mar 2010) | 1 line
  
  fixed a stability in the test.
........
  r29421 | kohsuke | 2010-03-29 11:40:37 -0700 (Mon, 29 Mar 2010) | 1 line
  
  improving the test stability
........
  r29449 | kohsuke | 2010-03-29 18:08:26 -0700 (Mon, 29 Mar 2010) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_353
........
  r29451 | kohsuke | 2010-03-29 18:08:46 -0700 (Mon, 29 Mar 2010) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r29459 | kohsuke | 2010-03-29 19:20:42 -0700 (Mon, 29 Mar 2010) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29490 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-30 09:47:41 +00:00
kohsuke cc4c17b927 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29447 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-30 01:00:14 +00:00
swiest 76121e2cae Fixed typo in documentation (trivial).
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29370 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-28 13:06:02 +00:00
kohsuke 411e9d8a16 stop reloading automatically from disk.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29312 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-26 23:37:31 +00:00
kohsuke 987ff580e2 one more optimization.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29308 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-26 21:27:01 +00:00
kohsuke f3ad3ab4be improved the handling of URL enclosed in "..." or <...> (or others like that)
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29261 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-26 01:24:42 +00:00
kohsuke b4e4167f6e this class actually serves a purpose, which is to introduce a tree structure induced by the getChildren() method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29244 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-25 19:42:22 +00:00
kohsuke f744501078 LogTaskListener needs to be remoteable, and clarified the remotable semantics of TaskListener.
See http://n4.nabble.com/Hudson-dev-f387835.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29210 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-25 00:29:03 +00:00
kohsuke 330c6304dc recognize "... 12 more" lines
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@29203 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-24 23:50:40 +00:00