Commit Graph
5063 Commits
Author SHA1 Message Date
Daniel Beck 7777d8f28b Do not show disabled permissions in permission errors (#4482) 2020-02-13 09:40:58 +01:00
Raihaan ShouhellandEvaristo Gutiérrez 9c4dac702e Add preauth filtering overload of getAllItems(), getItems() and allItems() (#4469)
* Add preauth filtering overload of getAllItems()

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>

* Add allItems filtering

* Apply suggestions from code review

Co-Authored-By: Evaristo Gutiérrez <egutierrez@cloudbees.com>

* Use streams

* Add stream functions

Signed-off-by: Raihaan Shouhell <raihaan.shouhell@autodesk.com>

* Missed simplification

Co-authored-by: Evaristo Gutiérrez <egutierrez@cloudbees.com>
2020-02-13 09:40:35 +01:00
Raihaan Shouhell 99767d6882 Increase timeout on test to stop flaking 2020-02-10 11:39:43 +08:00
Kohsuke Kawaguchi e489dc20e5 [maven-release-plugin] prepare for next development iteration 2020-02-09 13:18:36 -08:00
Kohsuke Kawaguchi e97efd05df [maven-release-plugin] prepare release jenkins-2.220 2020-02-09 13:18:30 -08:00
Wadeck Follonier 2f51583c8b [JENKINS-60867] Prevent creation of duplicated SetupWizard singleton instances on Jenkins startup (#4456)
* [JENKINS-60867] Blank page after SetupWizard: root cause

* Correct a test that was a bit too greedy
2020-02-07 08:40:08 -05:00
f10d9f95fc [JENKINS-60913] Remove network discovery services (#4460)
* Remove multicast discovery services.

* Refine clean up with DNSMultiCast.

Doesn't need to be referenced in the other pom any more.
We need to keep the class and the property around for a while.
Jenkins Test Harness sets the property. Until we can get all
versions aligned so it isn't needed, it's best to keep the property
doing nothing.

* Deprecate remaining class fragment.

* Remove unneeded dependency.

* Improve code comments for external usages.

Co-Authored-By: Jesse Glick <jglick@cloudbees.com>

* Remove multicast discovery services.

* Refine clean up with DNSMultiCast.

Doesn't need to be referenced in the other pom any more.
We need to keep the class and the property around for a while.
Jenkins Test Harness sets the property. Until we can get all
versions aligned so it isn't needed, it's best to keep the property
doing nothing.

* Deprecate remaining class fragment.

* Remove unneeded dependency.

* Add log warning messages.

* Don't need to implement the interface anymore.

* Fix initializer.

Change capitalization for logger.

* Add URLs to log messages.

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-07 03:53:54 -05:00
Oleg Nenashev 820b64a6a6 Merge pull request #4473 from daniel-beck/JENKINS-21837
[JENKINS-21837] Do not record user creating an agent
2020-02-06 07:44:29 -05:00
efe2b876a9 [JENKINS-51856] Add new milestones (#4450)
* [JENKINS-51856] Add new milestones

* Apply suggestions from code review

* [JENKINS-51856] Improve description of JOB_CONFIG_ADAPTED

* [JENKINS-51856] Add test for milestones

* [JENKINS-51856] Fix test error

* Apply suggestions from code review

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* Update core/src/main/java/hudson/init/impl/GroovyInitScript.java

Co-Authored-By: Tim Jacomb <t.jacomb@kainos.com>

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
2020-02-06 07:39:46 -05:00
Jeff ThompsonandWadeck Follonier b0eee6d655 [JENKINS-60848] Improve RSS title wording + Add more RSS tests (#4442)
* Add more tests.

Also a little cleanup of RSS.
Fix the broken "All all ..." title and description.
Remove a long unused bit for never implemented trackback.

* Increase date time checks.

* Copy and paste error.

Co-Authored-By: Wadeck Follonier <Wadeck@users.noreply.github.com>

* Assert not empty.

Co-Authored-By: Wadeck Follonier <Wadeck@users.noreply.github.com>

* Add a bunch more tests and clarify title.

Add a number of more tests. Test the various places that RSS is used.
Improve title wording to something consistent and somewhat sensible.

Co-authored-by: Wadeck Follonier <Wadeck@users.noreply.github.com>
2020-02-06 07:38:31 -05:00
Daniel Beck 9e39d578c2 [JENKINS-21837] Do not record user creating an agent 2020-02-05 19:29:47 +01:00
Wadeck Follonier d6db99df8d Disable failing test in UDP broadcast 2020-02-02 09:59:24 +01:00
Kohsuke Kawaguchi c376ffe0a4 [maven-release-plugin] prepare for next development iteration 2020-01-28 11:03:06 -08:00
Kohsuke Kawaguchi 789b74b00d [maven-release-plugin] prepare release jenkins-2.219 2020-01-28 11:03:02 -08:00
Kohsuke Kawaguchi 569e0acce2 Excluding this test that keeps failing and blocking my release. 2020-01-28 09:48:05 -08:00
Daniel Beck ff48c04fdc Remove obsolete test 2020-01-27 22:29:05 +01:00
Jeff Thompson c365300f99 Merge branch 'master' into security-master 2020-01-27 13:36:19 -07:00
Kohsuke Kawaguchi f2861f2b68 [maven-release-plugin] prepare for next development iteration 2020-01-27 11:25:53 -08:00
Kohsuke Kawaguchi e09bdd3116 [maven-release-plugin] prepare release jenkins-2.218 2020-01-27 11:25:48 -08:00
Kohsuke Kawaguchi 30dbf728ec [maven-release-plugin] prepare for next development iteration 2020-01-23 07:14:52 -08:00
Kohsuke Kawaguchi 3d8a846a75 [maven-release-plugin] prepare release jenkins-2.217 2020-01-23 07:14:46 -08:00
Kohsuke Kawaguchi 7e3382acba [maven-release-plugin] prepare for next development iteration 2020-01-22 15:34:51 -08:00
Kohsuke Kawaguchi 6b6fece88c [maven-release-plugin] prepare release jenkins-2.216 2020-01-22 15:34:37 -08:00
Jesse Glick 17c4c35813 [JENKINS-60816] Missing null check when traversing type hierarchy of interfaces 2020-01-21 15:53:19 -05:00
Oleg Nenashev 5a7af03c5b Merge pull request #4438 from StefanSpieker/clean_up
Removed unnecessary semicolons and unused imports
2020-01-21 08:16:44 +01:00
Jesse Glick 5b5040298f [JEP-222] WebSocket support (#4369)
* Playing with WebSocket connections.

* Pluggable handlers.

* errorWithoutStack

* Server-side keepalive pings.

* Redesigned to work as an HttpResponse.

* Unused dep.

* Comment on JnlpSlaveRestarterInstaller.

* Sketch of WebSocket-based endpoint for JNLPLauncher.

* Comment.

* Test enhancement.

* Making it more obvious from JNLPLauncherTest where remoting.jar is being loaded from.

* Reworked protocol to negotiate remote capabilities.

* Unhelpful comment.

* Simplifying handshake to use HTTP headers.

* Moving code into top-level classes and otherwise prettifying.

* Linking to upstream PRs.

* Timestamped snapshot + incremental.

* Picking up incrementalified build of winstone.

* Working around https://github.com/kohsuke/access-modifier/pull/17.

* Finally have an incrementalified build of remoting.

* Use -webSocket option.

* Handling some close and error methods.

* Sending X-Remoting-Minimum-Version.

* If hudson.remoting.jnlp.Main._main fails, show the error.

* Comment.

* GUI analogue of https://github.com/jenkinsci/remoting/pull/357/commits/86cea5b83fd2fc93a9fc10896962eb42c95f80a0.

* Missing since tags.

* Capitalization.

* WebSockets.isSupported

* Rather than hiding JNLPLauncher.DescriptorImpl when the TCP port is disabled, always display it, but show form validation appropriate to WebSocket or TCP mode.

* Form validation fixes.

* Minor test improvements.

* Reworked WebSocketAgents to be compatible with JnlpAgentReceiver.

* Removing WebSocketSession.keepAlive in favor of a global setting applicable to all services.

* Add a -webSocket option to the Jenkins CLI.

* Using a snapshot deployment of Remoting, pending INFRA-2379.

* After #3838 there is no reason to recheck authentication after parsing CLICommand arguments.

* Advertise the -webSocket option.

* Adapt to newer HtmlUnit.

* https://github.com/HtmlUnit/htmlunit/pull/29 seems to have been incompatible.
WebClient.addRequestHeader will no longer override a header in a WebRequest,
such as when the same WebClient/WebRequest was previously used with different headers.

* Tracked down a behavioral change in passing through URL-encoded path characters.
https://github.com/HtmlUnit/htmlunit/commit/2c4956863420e4baef9d3d8c23ec0577ec64d2bf picks up
https://github.com/apache/httpcomponents-client/commit/8c04c6ae5e5ba1432e40684428338ce68431766b which is the actual change.

* Disabled TCP port does not matter in WebSocket mode.

* Shade dependencies needed for jenkins-cli.jar.

* Help text edit.

* https://github.com/jenkinsci/winstone/pull/79 was released as 5.5.

* https://github.com/jenkinsci/jenkins-test-harness/pull/183 released as 2.59.

* https://github.com/jenkinsci/jenkins/pull/4387#discussion_r362696234

* Bumping remoting to a new deployed snapshot.

* Need https://github.com/jenkinsci/winstone/pull/86.

* https://github.com/jenkinsci/winstone/pull/86 released as 5.6.

* Introduced constant for X-Remoting-Minimum-Version.

* s/slave/agent/ in GUI

* Removing in-JVM test, as it was no longer useful after introducing shading anyway.

* Bump.

* No need to check for anonymous CONNECT here.

* s/jenkins.slaves/jenkins.agents/g for new code.

* Restrict the diagnostic endpoint to administrators.

* Fixed Javadoc import after package move.

* https://github.com/jenkinsci/remoting/pull/357 released as 4.0.
2020-01-21 07:00:39 +01:00
Wadeck Follonier 574ec6e5bd Merge branch 'master' into security-master 2020-01-20 14:55:10 +01:00
Kohsuke Kawaguchi 1568f328cd [maven-release-plugin] prepare for next development iteration 2020-01-19 13:00:48 -08:00
Kohsuke Kawaguchi c4b2894202 [maven-release-plugin] prepare release jenkins-2.215 2020-01-19 13:00:43 -08:00
Stefan Spieker c8ff153cdf removed unused imports 2020-01-19 14:49:21 +01:00
Stefan Spieker 126e3f577d removed unnecessary semicolons 2020-01-19 14:38:39 +01:00
Tim Jacomb 954e64b0fb Disable native maven based tests (#4435)
* Fix maven tests - https only

* More test fixes

* Copy settings.xml to home directory

Due to the maven central change to require only https, this ensures that
tests pickup the settings as well and not just the main process

* Revert "Copy settings.xml to home directory"

This reverts commit 37ccab7c55.

* Ignore tests that fail on CI due to https required on maven central

* Comment out HudsonTestCase based test

* Rerun CI
2020-01-19 10:55:58 +01:00
Francisco FernándezandOleg Nenashev 3ade716f41 [JENKINS-60577] - Prevent the RSS feed in Computer page from returning an error 404 (#4411)
* [JENKINS-60577] Rss Latest Builds for Computer

* [JENKINS-60577] Missing javadoc

* [JENKINS-60577] Add builds from the computer

* Update core/src/main/java/hudson/model/Computer.java

* Apply suggestions from code review

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* [JENKINS-60577] Document limitation to AbstractProject

* [JENKINS-60577] Restrict the RSS methods in Computer

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-01-15 07:54:52 +01:00
Wadeck Follonier 8263b0ae48 Merge branch 'security-stable-2.204' into security-master 2020-01-14 14:56:56 +01:00
Wadeck Follonier a293a77a77 Merge branch 'security-stable-2.190' into security-stable-2.204 2020-01-14 14:51:25 +01:00
Wadeck Follonier b11f08686e Merge branch 'security-stable-2.176' into security-stable-2.190 2020-01-14 14:31:54 +01:00
Wadeck Follonier bb3d46d018 Merge branch 'security-stable-2.164' into security-stable-2.176 2020-01-14 13:58:13 +01:00
Wadeck Follonier 77f36f37f5 [SECURITY-1695][SECURITY-1697] 2020-01-14 12:21:45 +01:00
Jeff Thompson 5054bc6e12 [SECURITY-1682] 2020-01-14 12:16:59 +01:00
Wadeck Follonier 639ade55ca [SECURITY-1704] 2020-01-14 12:08:10 +01:00
Wadeck Follonier cd28a6d934 [SECURITY-1641] 2020-01-14 12:06:40 +01:00
Matt Sicker 47f9a94794 [JENKINS-59107] User is no longer logged out when authenticating another user
This fixes a regression introduced in SECURITY-901 where performing an authentication check on another user while logged in caused the user to get logged out.

Signed-off-by: Matt Sicker <boards@gmail.com>
(cherry picked from commit d5b716625c)
2020-01-13 19:45:54 +01:00
Kohsuke Kawaguchi 3cf031965c [maven-release-plugin] prepare for next development iteration 2020-01-12 10:54:01 -08:00
Kohsuke Kawaguchi 9a1740192a [maven-release-plugin] prepare release jenkins-2.214 2020-01-12 10:53:56 -08:00
Oleg Nenashev 073122f13b Merge pull request #4421 from jglick/test-pom
Inlining test-pom into test and removing test-jdk8
2020-01-11 00:01:08 +01:00
Oleg Nenashev 58f8ac9b98 Merge pull request #4387 from jeffret-b/removeDeprecatedProtocols
[JENKINS-60381] Remove old, deprecated agent protocols.
2020-01-10 09:45:55 +01:00
A. Jard a00166bfd5 [JENKINS-60579] - Allow the usage of DescriptorVisibilityFilter to filter View properties on UI. (#4404)
* [JENKINS-60579] Functionnal test on View that shows the issue for invisible properties.

* [JENKINS-60579] Apply the visibility filter on View for configuration.

* [JENKINS-60579] Better configuration for testing on invisible property on view.

* [JENKINS-60579] Move tests on ViewPropertyTest.

* [JENKINS-60579]adding the since on getVisiblePropertyDescriptors.
2020-01-10 09:37:18 +01:00
Oleg Nenashev ad1ca7101b Merge pull request #4414 from jglick/WORKSPACE_TMP-JENKINS-60634
[JENKINS-60634] Define $WORKSPACE_TMP for (non-Pipeline) builds
2020-01-08 11:47:56 +01:00
Oleg Nenashev c059ccb0d8 Merge pull request #4418 from darxriggs/fix-typos
Fix typos & spelling in Javadoc and WebUI
2020-01-08 11:43:57 +01:00
Jesse Glick 629df6da7a Inlining test-pom into test and removing test-jdk8 2020-01-07 11:53:04 -05:00