Commit Graph
18248 Commits
Author SHA1 Message Date
Mark Waite 7dd28afd03 Merge pull request #5393 from jglick/isSafeToRedirectTo
Fixing deprecation link in Util.isAbsoluteUri
2021-04-08 19:14:55 -06:00
Wadeck Follonier 7296ac7034 [JENKINS-65288] Bring back support for stapler.jelly.trace (#5391)
* [JENKINS-65288] Bring back support for stapler.jelly.trace

* Remove two unused imports, thanks Daniel for catching them
2021-04-08 19:13:49 -06:00
Mark Waite 30cbbaa4e1 Merge pull request #5387 from mustafau/tr/login-form
Add Turkish translations for new login form
2021-04-08 19:12:15 -06:00
Daniel Beck 677fbb2a81 Merge remote-tracking branch 'jenkinsci/master' into master 2021-04-07 09:52:51 +02:00
Jesse Glick f6098a1df4 Fixing deprecation link in Util.isAbsoluteUri 2021-04-05 18:05:39 -04:00
Mustafa Ulu fd9d897174 Correct wording of “hoş geldiniz” 2021-04-04 21:43:02 +03:00
James Nord c4e0291c50 [JENKINS-56934] fix the 'new view' link to correctly work with folders (#5377)
* [JENKINS-56934] fix the 'new view' link to correctly work with folders

* [JENKINS-56934] check permission on the correct item

* [JENKINS-56934] update and simplify the test

* [JENKINS-56934] check the owner is modifiable and refactor

* [JENKINS-56934] correct unit test, and add new test for non modifiable owner
2021-04-03 21:21:42 +02:00
Mustafa Ulu ca69e398e8 Add Turkish translations for new login form 2021-04-03 19:04:14 +03:00
Matt Sicker 42e2c74049 [SECURITY-1871] 2021-03-30 23:41:15 +02:00
Matt Sicker 84210baed0 [SECURITY-1721] 2021-03-30 23:41:15 +02:00
Oleg Nenashev e4faa17ef7 Merge pull request #5365 from daniel-beck/JENKINS-65172
[JENKINS-65172] Better support for remote platform-plugins.json
2021-03-30 10:07:00 +02:00
Oleg Nenashev 4395d50f27 Merge pull request #5370 from usmonster/JENKINS-36707-add-ci-env-var
[JENKINS-36707] Add `CI` environment variable
2021-03-30 10:06:40 +02:00
EBIBOandOleg Nenashev 8ffad147e5 [JENKINS-63855] Support 'min' and 'max' values in the <f:number> tag (#5192)
* [JENKINS-63855] Support 'min' and 'max' values in the <f:number> tag

Add the validator for <f:number> whose clazz is 'number', 'number-required', 'non-negative-number-required', 'positive-number', 'positive-number-required'

* Document of min and max value of <f:input>

* Test for min / max support of <f:input>

In hudson-behaviour.js:
1. Convert the min and max to integer when they are comparing.
2. Since the HtmlUnit can't recognize the string literals, I changed it to string concat.

* Fix for "/minAndMaxValidation" 404 not found

Besides, remove unnecessary exception

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2021-03-29 15:33:56 +08:00
43359ca59b Add a couple of admin monitors for executors on the controller (#5337)
* Add a couple of admin monitors.

Warn against leaving executors configured on the controller, under two different scenarios.

* Add line endings.

* Update extension name and doc targets.

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>

* Make them security monitors.

* Improve UI / presentation.

* Remove permission checks.

Unnecessary.

* Make localizable.

* Add restricted annotations.

* Fix checkstyle error

* Use same message.

Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2021-03-29 15:32:30 +08:00
James Nord 16aa06a6e6 fix non compilable code on eclipse compiler (#5375)
legacyDescriptors has no idea what type of Descriptor it has and is
using a raw Descrriptor.
legacyDescriptors.computeIfAbsent can then only return keys of the type
that are in the map - and this is a raw type - so no generic is possible
in the return of getLegacyDescriptors()

fixes the eclipse error ->
Type mismatch: cannot convert from
CopyOnWriteArrayList<ExtensionComponent<Descriptor>> to
CopyOnWriteArrayList<ExtensionComponent<Descriptor<T>>>
2021-03-28 08:43:12 +01:00
Oleg Nenashev 6a95b01ba7 Merge pull request #5368 from daniel-beck/user-agent-decorator
Add a Jenkins User-Agent header to outgoing HTTP requests
2021-03-26 00:07:19 +01:00
usmonster 4f1139764c [JENKINS-36707] Add CI environment variable
Introduces a standard `CI` env var that is always set to "true" in order
to allow pipelines and tools to know they're executing in a continuous
integration context. This has emerged as a best practice used by most
other popular CI solutions, and a number of tools look for this variable
in order to make CI-appropriate optimizations (cf. the ticket).

Closes JENKINS-36707.
2021-03-23 16:17:47 +01:00
Oleg Nenashev e723ebc91b Merge pull request #5364 from daniel-beck/at-since-2.284
Update at-since annotations up to 2.284
2021-03-23 09:21:26 +01:00
Tim Jacomb e2837f8a57 JENKINS-62006 Fix a classloading issue while executing ProcessTree.get() (#5367)
* JENKINS-62006 Check if agent before master, fix remoting classloading
error

* Use JenkinsJVM API
2021-03-22 12:50:12 +00:00
Daniel BeckandDaniel Beck 43dbc8f9b4 Default to POST form validation (#4623)
* Default to POST form validation

* Add documentation to f:combobox

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2021-03-21 20:21:58 +00:00
Raihaan Shouhellandres0nance 93a27128f6 Ensure that plugins are sorted by name (#5359)
* Ensure that plugins are sorted by name

* Remove incorrect comment

* Remove unused import

Co-authored-by: res0nance <res0nance@users.noreply.github.com>
2021-03-21 20:20:32 +00:00
Daniel Beck a088584573 Add a Jenkins User-Agent header to outgoing HTTP requests 2021-03-21 16:24:11 +01:00
Daniel Beck e1beed0396 [JENKINS-65172] Better support for remote platform-plugins.json 2021-03-19 10:53:28 +01:00
Daniel Beck 15299a7111 Update at-since annotations up to 2.284 2021-03-17 18:57:53 +01:00
Basil Crow 3f53051b0b Test cleanup (#5357) 2021-03-16 08:14:11 +00:00
Daniel BeckandDaniel Beck 0548d59508 Fix sort order (#5356)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2021-03-14 17:07:52 +00:00
Oleg Nenashev ec2e7aca07 Merge pull request #5354 from timja/transparent-image-fixes
Icon typo fixes (used non transparent gif by accident)
2021-03-13 21:08:55 +01:00
Oleg Nenashev 7c0d4df8cb Merge pull request #5346 from basil/checkstyle
Bump Checkstyle from 8.29 to 8.41 and enable additional checks
2021-03-12 11:52:10 +01:00
Oleg Nenashev 0dc82bfd4e Merge pull request #5350 from takashiharano/dashboard-view-rename-ja
Add Japanese translations for Dashboard, Views, Rename
2021-03-12 10:05:20 +01:00
Tim Jacomb 0eee6f1859 Icon typo fixes (used non transparent gif by accident) 2021-03-11 08:06:31 +00:00
Tim Jacomb 4f66846de6 Merge branch 'master' into checkstyle 2021-03-10 20:35:03 +00:00
Takashi Harano f1ef8ec7b4 Add Japanese translations for Dashboard, Views, Rename 2021-03-11 00:26:49 +09:00
Basil Crow b252819947 Remove deprecated and unused jenkins.widgets.HistoryPageFilter.add(java.util.List) (#5258) 2021-03-10 13:43:03 +00:00
037e1379ab Initial new icons (#5065)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Félix Queiruga <felix.queiruga@gmail.com>
Co-authored-by: Félix Queiruga <fqueiruga@cloudbees.com>
2021-03-09 08:09:04 +00:00
Basil Crow ce8b93f712 Enable OneStatementPerLine Checkstyle check 2021-03-08 08:03:29 -08:00
Basil Crow 1e9e0a49e3 Enable UnusedImports Checkstyle check 2021-03-08 08:03:27 -08:00
Basil Crow 670d5e4823 Enable RedundantImport Checkstyle check 2021-03-08 07:56:42 -08:00
Basil Crow 881365d30b Enable RedundantModifier Checkstyle check 2021-03-08 07:56:42 -08:00
Basil Crow 6f012029b8 Enable ModifierOrder Checkstyle check 2021-03-08 07:56:42 -08:00
Basil Crow 4ada7324a2 Enable NewlineAtEndOfFile Checkstyle check 2021-03-08 07:56:42 -08:00
Basil Crow 44c5342c58 Declare modifiers in JLS order (#5339) 2021-03-08 07:58:59 +00:00
StefanSpieker 58499905f8 replaced MS_SHOULD_BE_FINAL general spotbugs exclude with individual excludes (#5235) 2021-03-08 07:58:49 +00:00
Olivier Lamy 8a6defe963 [JENKINS-64931] no need to synchronize on Queue as queue is using a Lock and this under certain conditions can generate a deadlock. look at the dump attached to the issue JENKINS-64931 (#5305)
Signed-off-by: olivier lamy <olamy@apache.org>
2021-03-08 07:58:04 +00:00
Jesse Glick a43cd9c33c Be quiet if Queue.save gets ClosedByInterruptException (#5326) 2021-03-08 07:57:25 +00:00
Takashi Harano e3d5073f71 Add Japanese translations for New Job screen (#5334) 2021-03-08 07:57:16 +00:00
899a55e770 Indicate in configuration which admin monitors are security-related (#5078)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Felix Queiruga <fqueiruga@cloudbees.com>
2021-03-08 07:57:01 +00:00
Basil Crow 810e908f8f Migrate from com.google.common.base.Function to java.util.function.Consumer in hudson.model.listeners.ItemListener 2021-03-05 19:16:27 -08:00
benebsiny 7be7079419 [JENKINS-64972] Help-buttons are not working when they are at the top of draggable div (#5316)
* [JENKINS-64972] Help-buttons are not working when they are at the top of draggable div

The 'dd-handle' div will make all events in that div (e.g. click event of a button) not triggered, so I move the help-button out of the 'dd-handle' div.
In order to make the button still at the right of the same line, I use flex to realize.

* [JENKINS-64972] Move style to CSS file
2021-03-04 13:33:52 +01:00
Oleg Nenashev 62fdb42c1e Merge pull request #5323 from basil/override
Add missing @Override annotations
2021-03-04 13:33:20 +01:00
Basil Crow bd1d5e09bd Add missing @Override annotations 2021-03-02 14:04:48 -08:00