OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-15 04:52:20 +00:00
Code Issues Packages Projects Releases Wiki Activity
27,720 Commits 56 Branches 1,942 Tags
7eae00a5a5c82bfc34c066ff8bc2db24d0aa2e52
Commit Graph
18622 Commits
Author SHA1 Message Date
Ivan Fernandez Calvo 1ab11ea121 [JENKINS-47458][JENKINS-55133] update trilead-ssh2 version 2018-12-28 14:47:09 +01:00
Baptiste Mathus ac34c927f6 Merge pull request #3822 from jsoref/eta-space 
Add space after ETA:
 2018-12-27 23:28:23 +01:00
Jeff Thompson 65ecd43ece Merge pull request #3812 from jvz/flaky-util-test 
[JENKINS-55016] Fix flakiness in UtilTest
 2018-12-27 14:06:05 -07:00
Josh Soref a60f37ec13 Add space after ETA: 
n.b. The French Localizer already did this

Old:
 (pending—Build #3,585 is already in progress (ETA:N/A))
New:
 (pending—Build #3,585 is already in progress (ETA: N/A))
 2018-12-21 15:00:13 -05:00
Matt Sicker c453b9228f Update Util.isSymlink commentary 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-21 09:18:35 -06:00
Matt Sicker 1e82509bcc Use mutable list in mutable context 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-21 09:15:24 -06:00
Matt Sicker 15be8b0c1e Make test platform independent via Mockito 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-20 15:54:16 -06:00
Matt Sicker baba953258 Add missing exception 
Without this, no exception would be thrown when a file cannot be deleted, but an exception would be thrown when a directory cannot be deleted.

Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-20 15:52:00 -06:00
Gavin Mogan 9e77fde2be remove incorrect comment that was copy and pasted 2018-12-20 10:47:03 -08:00
Gavin Mogan 89fcbb623d JENKINS-55062 - set resURL and rootURL for restarting template to load from the right places 2018-12-20 10:47:03 -08:00
Matt Sicker e4937bbb78 Revert test logic back to original 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-18 14:33:16 -06:00
Matt Sicker 24da0712cc Simplify test 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-18 11:43:47 -06:00
Matt Sicker 323b106ffe Revert "Improve test robustness" 
This reverts commit dfb6d1d4

Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-18 11:40:42 -06:00
Matt Sicker dfb6d1d41c Improve test robustness 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-18 11:35:07 -06:00
Matt Sicker d5c9340041 Improve assertions 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-18 11:13:25 -06:00
Matt Sicker 55b8911c5d Use CountDownLatch instead of Object 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-18 10:57:59 -06:00
Matt Sicker f71bf07993 Refactor FileLocker into JUnit rule 
Also fixes a bug where locked files are not cleaned up in the cleanup.

Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-18 10:46:09 -06:00
Matt Sicker 41fbaeeb8e Break up testForceRemoveRecursive_LockedFiles into logical tests 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-17 16:06:54 -06:00
Matt Sicker cc809df4c2 Use Files.isSymbolicLink on non-Windows platforms 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-17 15:47:18 -06:00
Matt Sicker 1b23a9e119 Fix symlink check logic to support junctions again 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-17 15:18:17 -06:00
Matt Sicker 592af986dc Clarify what this test is for 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-17 15:17:48 -06:00
Matt Sicker c05829c780 Add explicit test timeout 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-17 11:57:04 -06:00
Matt Sicker 27949aab5a Merge branch 'master' into flaky-util-test 2018-12-17 10:22:55 -06:00
Matt Sicker 685fb49c4f Ensure test thread is killed eventually 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-17 09:53:11 -06:00
Kohsuke Kawaguchi bcc4e4fe9c [maven-release-plugin] prepare for next development iteration 2018-12-16 21:07:20 -08:00
Kohsuke Kawaguchi 0f477dc3be [maven-release-plugin] prepare release jenkins-2.156 2018-12-16 21:07:07 -08:00
Matt Sicker b42d0fcb7d Fix typo in method name 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-14 14:30:15 -06:00
Matt Sicker c020186130 Revert behavior of making writable 
Instead of attempting to make every file or directory writable before deleting, this reverts behavior back to trying to delete before setting writable file options and retrying.

Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-14 14:25:44 -06:00
Matt Sicker e892a0bb6e Add convenience constructor 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-14 14:24:47 -06:00
Matt Sicker 97f539d003 Fix off by one error in error message 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-14 14:05:44 -06:00
Jesse Glick 13db805dee [JENKINS-26677] Avoid using ServletException from SlaveComputer since it can break calls to SlaveComputer.getChannelToMaster. (#3778) 
java.lang.NoClassDefFoundError: javax/servlet/ServletException
	at hudson.util.ProcessTree.get(ProcessTree.java:399)
 2018-12-14 18:59:04 +01:00
Nicolae Pascu b4a884e5bd [JENKINS-54933] Replace ZeroClipboard (Flash) with native JavaScript implementation (#3780) 
* [CORE-626] remove ZeroClipboard and replace with pure js replacement

* remove css rule used for testing

* Poke the build
 2018-12-14 18:34:44 +01:00
Matt Sicker e67d24c2ef Fix off by one math logic 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-14 11:21:04 -06:00
Matt Sicker da96361c9b Merge branch 'master' into flaky-util-test 2018-12-14 11:06:51 -06:00
Matt Sicker 2e8197a2c7 Complete refactoring of Util.delete methods 
This removes duplicated tests from UtilTest that were added in PathRemoverTest. This also ports the sleep/gc strategy for use by default to preserve backward compatibility.

Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-14 10:33:18 -06:00
Oleg Nenashev f0dadba464 Merge pull request #3791 from jsoref/patch-3 
Miscellaneous minor fixes
 2018-12-14 10:08:56 +01:00
Wadeck Follonier 0c6a314297 [JENKINS-55197] Correction of the InstallUncaught NPE (#3806) 
[JENKINS-55197] Correction of the InstallUncaught exception
 2018-12-14 10:02:56 +01:00
Matt Sicker 3ee6a38484 Add PathRemover refactoring of Util 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-13 17:16:58 -06:00
Matt Sicker aa0d346700 Simplify assume expressions 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-12 14:31:34 -06:00
Matt Sicker c58164a25d Use ExpectedException in test 
Signed-off-by: Matt Sicker <boards@gmail.com>
 2018-12-12 14:29:26 -06:00
Jesse Glick 08d273f3c6 Fixing a SIOOBE encountered during Windows-jdk11 tests (but not reproducible locally). 
Amends code added in https://github.com/jenkinsci/jenkins/pull/2082.
java.lang.RuntimeException: Unexpected issues encountered during cleanUp: offset 0, count -1, length 5
	at jenkins.model.Jenkins.cleanUp(Jenkins.java:3319)
	at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:495)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:565)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.StringIndexOutOfBoundsException: offset 0, count -1, length 5
	at java.base/java.lang.String.checkBoundsOffCount(String.java:3304)
	at java.base/java.lang.String.<init>(String.java:465)
	at hudson.TcpSlaveAgentListener$PingAgentProtocol.connect(TcpSlaveAgentListener.java:416)
	at hudson.TcpSlaveAgentListener.shutdown(TcpSlaveAgentListener.java:196)
	at jenkins.model.Jenkins._cleanUpShutdownTcpSlaveAgent(Jenkins.java:3548)
	at jenkins.model.Jenkins.cleanUp(Jenkins.java:3294)
	... 6 more
 2018-12-12 14:47:48 -05:00
Jesse Glick 208b42a3ca Blocking Lifecycle.restart from within JenkinsRule. 2018-12-12 11:36:04 -05:00
Baptiste Mathus 563945f11d Remove duplicate @Ignore failing the compilation 2018-12-12 11:31:57 +01:00
Baptiste Mathus 404ca8d0c7 Merge pull request #3721 from jvz/simple-footer-decorators 
[JENKINS-54325] Add support for multiple footers in SimplePageDecorator
 2018-12-12 09:38:30 +01:00
Wadeck Follonier 99835d6247 Revert the whitespace addition as well 2018-12-11 10:48:08 +01:00
Baptiste Mathus 0ee685eeec Un-ignore test that was fixed 
Fixed in https://github.com/jenkinsci/jenkins/pull/3795
 2018-12-11 09:57:12 +01:00
Jesse Glick 50df56352c Suppressing some tests which fail in CI. 2018-12-10 17:16:15 -05:00
Baptiste Mathus c18bb84df1 Merge pull request #3795 from Wadeck/JENKINS-55081_xxx904Test_failing 
[JENKINS-55081] SEC-904 related test failing on java 11
 2018-12-10 17:21:56 +01:00
Wadeck Follonier 4ad8019c3f One Ignore was already added by Baptiste in master 2018-12-10 13:52:53 +01:00
Daniel Beck 3b8258fd0c [JENKINS-52869] Show error messages on user creation (#3727) 
* [JENKINS-52869] Show error messages on user creation

* Restore support for general signup error
 2018-12-10 13:09:20 +01:00