Jesse Glick
7f82ab94a4
[FIXED JENKINS-26519] Build record migration failed on Windows using Java 6.
...
In this environment, Util.createSymlink and .isSymlink are implemented, but resolveSymlink is not.
(cherry picked from commit 388c4b5e6b )
Conflicts:
changelog.html
2015-01-30 10:10:11 -05:00
Jesse Glick
4a75e058ba
[JENKINS-26519] Attempting to improve diagnostics in case rename fails.
...
(cherry picked from commit 0633beef08 )
2015-01-30 10:08:42 -05:00
Jesse Glick
b2cc36377e
Merge branch 'rc'
2015-01-21 13:18:57 -05:00
Jesse Glick
056b446480
[FIXED JENKINS-26519] Accept Windows text file quasi-symlinks for build numbers.
2015-01-21 13:17:31 -05:00
Jesse Glick
c997ac0c86
[JENKINS-26519] Confirming that it is safe to rerun migration by just deleting legacyId files.
2015-01-21 13:01:05 -05:00
René Scheibe
665c4985d7
don't extend a test class from org.junit.Assert to use its static methods
...
* to simplify the static import and test use Hamcrest to compare arrays
* no need to box boolean[] to Boolean[] when using Hamcrest
2015-01-09 12:30:00 +01:00
René Scheibe
13ab787d5f
don't extend a test class from org.junit.Assert to use its static methods
2015-01-09 12:25:37 +01:00
René Scheibe
2d3dbad35a
statically import methods used from org.junit.Assert
...
* that's a common practice so do it consistently in all tests
2015-01-08 20:25:18 +01:00
René Scheibe
bd1d6251e0
replace all deprecated @Bug annotations with @Issue
2015-01-07 17:12:21 +01:00
Jesse Glick
42fede3248
Merge pull request #1505 from darxriggs/junit3-to-junit4
...
convert tests from JUnit3 to JUnit4
2015-01-02 12:33:41 -05:00
Jesse Glick
1fcee97d2f
[FIXED JENKINS-26196] More robust handling of server errors in FilePath.installIfNecessaryFrom.
2014-12-29 14:49:27 -05:00
Jesse Glick
babfb832a3
JUnit 4.
2014-12-29 14:00:48 -05:00
René Scheibe
73efe6825a
convert tests from JUnit3 to JUnit4
...
* life goes on :-)
* touching all tests that directly inherit from junit.framework.TestCase
2014-12-27 22:41:09 +01:00
Kohsuke Kawaguchi
b47d450ddb
Fixed RunIdMigratorTest failures in non-EST time zone
...
RunIdMigrator.LEGACY_ID_FORMATTER was static, which gets instantiated before the time zone is overriden during the test. Changing this to an instance field so that it gets created later on.
2014-12-23 11:33:23 -08:00
CloudBees DEV@Cloud
4c474cea6f
Merge commit '711b3325adf629585d60aa5a2bcac1d49b8324ae'
2014-12-23 16:59:01 +00:00
Daniel Beck
b090751c16
[JENKINS-25897] Add tests
2014-12-23 11:22:01 +01:00
Kohsuke Kawaguchi
296849edf9
Merge pull request 1379
2014-12-22 14:33:48 -08:00
Jesse Glick
b415b467fb
Replacing Util.createTempDir with the standard TemporaryFolder rule in some tests.
2014-12-17 15:04:45 -05:00
Jesse Glick
589d74a55e
Making reverse migration tool handle more kinds of item groups.
2014-12-15 15:51:45 -05:00
Jesse Glick
0a9b638280
Added a tool to reverse the build directory migration if required.
2014-12-15 14:26:36 -05:00
Jesse Glick
0cd13e9670
Compilability fix.
2014-12-12 14:59:03 -05:00
Jesse Glick
7c988de3cd
Merge branch 'master' into build-number-is-id-JENKINS-24380
2014-12-12 13:27:31 -05:00
Stephen Connolly
8e5a92d8e6
remove trailing whitespace and tabs
2014-12-03 17:02:18 +00:00
Jesse Glick
534328b264
[FIXED JENKINS-25759] Avoid consuming too much memory while running validateAntFileMask.
...
Not fully solved, since the scannedDirs field can still grow to be large, but at least clearing files/dirsNotIncluded.
Also imposing a 5s timeout on the scan regardless of file count, and defining a user-customizable bound.
2014-11-24 10:37:58 -05:00
Jesse Glick
b76e7bf998
[FIXED JENKINS-25655] Incorrect caching from entrySet sometimes caused incorrect results.
...
Caused a failure in hudson.plugins.promoted_builds.conditions.ManualConditionTest.testManualPromotionProcessViaWebClient when run against 1.580.1.
2014-11-17 17:48:48 -05:00
Oliver Gondža
34850200b2
Introduce FormValidation#aggregate
2014-11-07 09:20:06 +01:00
Oliver Gondža
12ff0b249a
Junit 4
2014-11-06 12:30:33 +01:00
Jesse Glick
f0658e233d
Merge branch 'security-rc' into SECURITY-144-rc
...
Conflicts:
core/src/main/java/hudson/FilePath.java
2014-10-26 13:55:39 -07:00
Oleg Nenashev
e80fa118aa
Merge pull request #1411 from synopsys-arc-oss/JENKINS-19017
...
[FIXED JENKINS-19017] - FileParameter - Handle non-null file parameters as different values
2014-10-19 23:28:14 +04:00
Oleg Nenashev
cc06ae78e3
[JENKINS-19017] - Unit tests
...
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-10-18 22:03:28 +04:00
Jesse Glick
ccbe96227f
Merge branch 'security-rc' into SECURITY-144-rc
...
Conflicts:
core/src/main/java/hudson/FilePath.java
pom.xml
2014-10-16 13:18:08 -04:00
Daniel Beck
daacb02057
[JENKINS-16184] Also escape greater-than character
2014-10-09 00:38:22 +02:00
Jesse Glick
89cbfc4639
Merge branch 'SECURITY-144' into SECURITY-144-rc
...
Conflicts:
core/src/main/java/hudson/EnvVars.java
core/src/main/java/hudson/FilePath.java
core/src/main/java/hudson/cli/ClientAuthenticationCache.java
core/src/main/java/hudson/markup/MyspacePolicy.java
core/src/main/java/hudson/model/Computer.java
core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java
core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
core/src/main/java/hudson/security/AbstractPasswordBasedSecurityRealm.java
core/src/main/java/hudson/slaves/Channels.java
core/src/main/java/hudson/slaves/SlaveComputer.java
core/src/main/java/hudson/tasks/Fingerprinter.java
core/src/main/java/hudson/tasks/Shell.java
core/src/main/java/hudson/tasks/junit/JUnitParser.java
core/src/main/java/hudson/tasks/test/DefaultTestResultParserImpl.java
core/src/main/java/hudson/util/ProcessTree.java
core/src/main/java/hudson/util/RemotingDiagnostics.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/test/java/hudson/LauncherTest.java
pom.xml
test/src/test/java/hudson/tasks/junit/CaseResultTest.java
2014-09-26 15:56:48 -04:00
Kohsuke Kawaguchi
ffb5b65093
Switched from annotation based scheme to a function based scheme.
2014-09-23 19:12:43 -07:00
Kohsuke Kawaguchi
c0260056e5
in pre-cursor for the next change, make all remoting call go through FileCallable
2014-09-23 14:53:31 -07:00
Kohsuke Kawaguchi
6a2b879262
Revisiting 9b7b1364c0 a bit.
...
Since ConsistentHash is written as a mutable class, I think a better way to fit the existing design is to provide a bulk add operation.
It already has several methods to that end, so I just added one more that's needed for our purpose.
2014-09-05 10:45:42 -07:00
Jesse Glick
cb6e568815
[FIXED JENKINS-23522] Defend against stack overflows when a listener (unnecessarily) called super from a deprecated method.
...
Fixes #1295 a little differently.
2014-08-29 18:16:19 -04:00
Jesse Glick
843d238723
Added RunIdMigrator.
2014-08-27 15:04:45 -04:00
Jesse Glick
1ede3e9833
Defend against out-of-order builds even if nextBuildNumber is wrong.
2014-08-27 11:00:39 -04:00
Jesse Glick
6d2e3ae5cb
Initial sketch of replacement of Run.id by number.
...
Does not yet deal with migrating historical records.
2014-08-21 18:18:25 -04:00
Jesse Glick
df4ba0d82c
Trying to make testRemoteKill less prone to random failure (presumably on a heavily loaded machine).
2014-08-21 10:25:58 -04:00
Jesse Glick
16197ea502
[FIXED JENKINS-23263] JUnit reporter moved to a plugin.
2014-08-11 13:45:23 -04:00
Jesse Glick
1239ed3bd9
Merge commit '16f2c7af0122a4f3cfd709bd44d9b5402a6ec8bf' into security
...
Updating branch base to 1.532.
2014-07-30 17:39:01 -07:00
tfennelly
42190ed977
<l:icon> tag
2014-07-30 15:52:15 +01:00
Daniel Beck
5751560fc1
Merge pull request #1251 from daniel-beck/JENKINS-14583
...
[FIX JENKINS-14538] Improve builds dir input validation
2014-07-26 13:32:27 +02:00
Jesse Glick
b25e8e54dc
Introduced Run.StatusSummarizer extension point so that Run need not refer directly to AbstractTestResultAction.
2014-07-22 17:47:35 -04:00
Jesse Glick
37c5bc2fd8
Deprecating getTestResultAction as an unwanted link from the model package to hudson.tasks.test package.
2014-07-22 10:22:17 -04:00
Jesse Glick
2f58ceb1a6
[JENKINS-18065] Uncommenting original test.
...
The actual implementation does not behave as nicely as one would hope, for a few reasons:
1. isEmpty actually tries to load the newestBuild, rather than simply checking whether there is some idOnDisk.
Arguably this is necessary, since there could be an unloadable build record, in which case it would be technically correct for the map to be considered empty.
2. Loading AbstractLazyLoadRunMap.newestBuild calls search(MAX_VALUE, DESC), which behaves oddly, by doing a binary search, and thus perhaps loading lg(|map|) entries.
You would think that it would suffice to check for the last member of idOnDisk in index.byId.
3. The iterator eagerly loads the next value before hasNext has even been called.
Looks bad in a test, though it probably has little practical impact since most callers would be calling hasNext soon afterward anyway.
Might cause one extra build record to be loaded unnecessarily from a limited RunList.
2014-07-11 17:17:45 -04:00
Kohsuke Kawaguchi
54c084613f
[FIXED JENKINS-18065] made ALLRM.entrySet() smarter
2014-07-11 12:03:11 -07:00
Daniel Beck
50cbded7f8
[JENKINS-14583] Fix tests
2014-06-30 03:16:48 +02:00