Commit Graph
340 Commits
Author SHA1 Message Date
Stefan Spieker 7fd6191ed2 use try with resources 2021-06-11 22:34:07 +02:00
Basil CrowandTim Jacomb 2760e3ebfb Remove Bytecode Compatibility Transformer (#5526)
* Remove Bytecode Compatibility Transformer

* AntClassLoader2 is now redundant

Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
2021-06-01 13:06:30 +08:00
Basil Crow c904989067 Deprecate Util#join(Collection, String) in favor of String#join(CharSequence, Iterable) (#5467) 2021-05-09 08:08:59 +01:00
Basil Crow 95e85495ca Enable AvoidStarImport Checkstyle check (#5420) 2021-04-28 17:28:39 +08:00
Basil Crow f6378676b1 Add missing @Override annotations (#5430) 2021-04-28 17:28:25 +08:00
Basil Crow 881365d30b Enable RedundantModifier Checkstyle check 2021-03-08 07:56:42 -08:00
StefanSpieker 58499905f8 replaced MS_SHOULD_BE_FINAL general spotbugs exclude with individual excludes (#5235) 2021-03-08 07:58:49 +00:00
Tim Jacomb 26adaf1fc6 Remove broken upgrade wizard (#5283) 2021-02-16 08:05:08 +00:00
Robert Sandell f47257bdf1 [JENKINS-64840] Fix searching multiple update sites (#5281) 2021-02-12 18:51:53 +00:00
Oleg Nenashev b49610e29f Cleanup warnings for missing getPlugin() null checks (#5222) 2021-02-10 19:52:44 +00:00
Basil Crowanddependabot[bot] 887296fcd0 JENKINS-64650: Upgrade Commons FileUpload from 1.3.1-jenkins-2 to 1.4 (#5174)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 08:20:19 +00:00
Basil Crow 64dbdbc4f5 Remove unused imports 2020-12-19 13:10:38 -08:00
Basil Crow 4e12567881 Remove unnecessary return 2020-12-19 13:10:38 -08:00
Oleg Nenashev 152682c157 Merge pull request #5109 from basil/improvements
Code cleanup
2020-12-19 20:51:40 +01:00
Oleg NenashevandRamon Leon 9f50735a8b [JENKINS-64445] - Fix null safety for plugin categories (#5121)
* [JENKINS-64445] - Fix null safety for plugin categories

* Update core/src/main/java/hudson/model/UpdateSite.java

Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>

* Update core/src/main/java/hudson/model/UpdateSite.java

Co-authored-by: Ramon Leon <manuelramonleonjimenez@gmail.com>
2020-12-19 20:50:14 +01:00
Basil Crow 3764940c2d Replace loop with Collection#removeIf where possible 2020-12-11 21:34:22 -08:00
Basil Crow 4284c3d2ab Replace lambda with method reference where possible 2020-12-11 21:34:22 -08:00
Tim Jacomb 09307ea116 JENKINS-64196 Move PluginManager available page to client side (#5051)
* Move PluginManager available to client side

* Fix in IE

* Address feedback from ux-sig demo

* Add handlebars module

* Handlebars plugin manager

* Update core/src/main/java/hudson/model/UpdateCenter.java

* Remove import

* Fix input

* Remove debug

* Use rest client

* Fix bug

* Move properties to right location

* Cleanup

* Use lodash debounce

* Revert properties change

* Fmt

* Rank exact matches at the top

* Set locale

* Spotbugs

* ignore case in nicer way

* Sorting improvements
2020-12-08 07:29:21 +00:00
a9ca5ef3d4 [JEP-227] Replace Acegi Security with Spring Security & upgrade Spring Framework (#4848)
Replacing Acegi Security with Spring Security

Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>
Co-authored-by: James Nord <jtnord@users.noreply.github.com>
2020-11-06 11:30:25 -07:00
Oleg Nenashev b8b2c47586 Revert "Omit stacktraces on ClassNotFoundException in PluginStrategy classloading (#4957)"
This reverts commit b62b6dd830.
2020-10-14 21:09:26 +02:00
Oleg Nenashev b62b6dd830 Omit stacktraces on ClassNotFoundException in PluginStrategy classloading (#4957)
* Omit stacktraces on ClassNotFoundException in PluginStrategy classloading

* Modify implementation to not fill in stacktraces by default

* Apply suggestions from code review

* Restrict withFillInStackTracesOnClassNotFoundException() at Beta API
2020-10-12 11:21:38 +02:00
Daniel BeckandDaniel Beck c632f42f07 Update at-since Javadoc (#4877)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-08-01 08:33:48 +01:00
Daniel Beck e639c64e19 Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-06-20 20:53:34 +02:00
Daniel BeckandDaniel Beck 2776f4dc77 [JENKINS-62332] Show when a plugin version newer than offered exists (#4742)
* [JENKINS-62332] Show when a plugin version newer than offered exists

* Add more obvious label/tag to entries that cannot be installed

Also link to plugin documentation from the detail message

* Also show the list if there are any unavailable updates

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2020-06-07 10:51:16 +02:00
Daniel Beck 9ae93b67a0 Link to the deprecation URL, not the plugin URL 2020-05-26 21:40:24 +02:00
Daniel Beck 56c11a3f79 Make 'deprecated' a meta label (not shown in the regular label list) 2020-05-04 10:20:22 +02:00
Daniel Beck d213ef962c Add support for top-level 'deprecations' element in update site 2020-05-03 22:09:47 +02:00
Daniel Beck 0dc475a1df Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-05-03 18:29:48 +02:00
Tim Jacomb aa3ad0664a Fix available tab sort order and support popularity outside 0..1 range (#4675) 2020-04-25 14:25:20 +01:00
Daniel Beck a54823769a Fix Available tab sort order and support popularity outside 0..1 range 2020-04-21 23:46:45 +02:00
Stefan Spieker c7564f8596 removed unused imports 2020-04-19 20:53:35 +02:00
Daniel Beck a6ebf3b4bf Merge branch 'master' into popularity 2020-04-16 16:41:36 +02:00
Tim JacombandDaniel Beck 9b4a62c716 JENKINS-61203 System read - Plugin Manager (#4518)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-04-09 22:36:46 +01:00
James Nord 1f946961b9 s/javax.annotation.CheckForNull/edu.umd.cs.findbugs.annotations.CheckForNull/g 2020-03-26 16:12:35 +00:00
James Nord 819f80b12f s/javax.annotation.Nonnull/edu.umd.cs.findbugs.annotations.NonNull/g 2020-03-26 11:14:41 +00:00
Daniel Beck ebc46de632 Sort available plugins by popularity 2020-03-16 22:49:52 +01:00
Daniel Beck 02d57f1dc4 Highlight when plugins have the adopt-this-plugin label 2020-03-15 15:45:59 +01:00
9ead76e210 [JEP-223] Deprecate permissions RUN_SCRIPTS, UPLOAD_PLUGINS, an… (#4365)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2020-02-22 15:28:42 +00:00
Joseph Petersen d19fdb4c91 use stream api to collect deprecated plugins 2020-02-19 19:25:01 +01:00
Joseph Petersen ed9baefc56 Merge branch 'master' into feature/add-deprecated-plugin-monitor 2020-02-19 18:37:04 +01:00
James NordandRaihaan Shouhell b39ff9938a [JENKINS-61046] - Allow plugins to force an update of the UpdateCenter (#4488)
* Allow plugins to force an update of the UpdateCenter

* Add javadoc to updateDirectlyNow

* [JENKINS-61046] introduce updateDirectlyNow() and updateDirectly()

@oleg-nenashev notes that the public API should not expose the security
option that is for testing.  Introduced updateDirectlyNow() as the new
API and updateDirectly() to have a mirror and deprecated
updateDirectly(boolean) as a consequence.

* fix javadoc grammar

fixes the grammar of the UpdateSite#updateDirectlyNow javadoc

Co-Authored-By: Raihaan Shouhell <raihaanhimself@gmail.com>

Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2020-02-18 11:36:38 +01:00
Vincent Latombe dd59e8c11c [JENKINS-60449] Attempt to fix an odd case of OptionalExtension blowing up Jenkins (#4393)
* Add new module optional-depender and a new failing test

* Variant plugin is a dependency of optional-depender

Optional-depender contains the following class

@OptionalExtension(requirePlugins = {"dependee"})
public class OptionalDependerExtension {
      private static void foo(Dependee d) {

      }
}

* [JENKINS-60449] Move plugin initialization at the end, keep only one extension refresh

* Improve logic to detect classloading issues

Inspect all declared constructors/methods/fields recursively to exclude
failing classes from Guice rather than have Guice explode.

This also fix the failing test, but the previous commit is still better
because it avoids an extra Jenkins.get().refreshExtensions() call.

* Only test resolveClass method if the classloader is not the bootstrap one
2020-01-03 23:26:35 +01:00
StefanSpiekerandOleg Nenashev 8b893a1cbe [JENKINS-36720]: Fixed some Spotbugs issues (#4180)
* [JENKINS-36720]: Fixed Spotbugs issues WMI_WRONG_MAP_ITERATOR and OS_OPEN_STREAM in core

* merged try with resources with try finally

* reverted auto format from IDE

* reverted auto format from IDE

* use Util.fileToPath() as suggested to remove catch block

* merged try statements

* merged try statements

* reverted some whitespace fixes

* reverted another whitespace fix

* Apply suggestions from code review

Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>

* reverted change

* reverted change

* reverted change

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2019-12-29 12:50:10 +01:00
Oleg Nenashev eedf2a4e2a Merge pull request #4262 from StefanSpieker/replace_getActiveInstance
Replaced deprecated getActiveInstance() with get()
2019-11-22 10:25:21 +01:00
Allan BurdajewiczandJesse Glick e99c183566 [JENKINS-59775] Ensure that PluginManager.start runs as SYSTEM (#4320)
* [JENKINS-59775] Ensure that PluginManager.start runs as SYSTEM

* Use User#getById

Co-Authored-By: Jesse Glick <jglick@cloudbees.com>

* [JENKINS-59383] Undo indent

* [JENKINS-59383] Undo indent
2019-11-02 16:45:28 +03:00
Basil Crow 861855953b Replace <code>…</code> with {@code …} 2019-10-19 14:02:59 -07:00
Joseph Petersen aa863548bc Add Restricted no external use 2019-10-12 11:13:52 +02:00
Stefan Spieker 35dedaf917 merged master and use suggested type for tests 2019-10-08 23:35:34 +02:00
Stefan Spieker 76057897be replaced deprecated getActiveInstance() with get() 2019-10-03 21:13:14 +02:00
Raihaan Shouhell e5d578b617 Use type inference instead of specifying it 2019-10-01 13:30:39 +08:00