Commit Graph
14775 Commits
Author SHA1 Message Date
Daniel Beck 98ad8e4d73 Merge pull request #2824 from daniel-beck/JENKINS-43228
[FIX JENKINS-43228] Consider time zone for cron validation
2017-04-08 12:24:01 +02:00
Jesse Glick 729016989e [FIXED JENKINS-41745] Merged #2795: non-Remoting-based CLI. 2017-04-07 20:08:05 -04:00
Jesse Glick 23cb13aad0 Clean up usages of IOUtils.closeQuietly and related calls (#2830)
* Clean up usages of IOUtils.closeQuietly and related calls predating Java 7.

* Review comments from @oleg-nenashev.

* Noticed another place where try-with-resources would protect against a potential leak.
2017-04-08 00:41:27 +02:00
Oleg Nenashev 77804c1451 Merge pull request #2828 from sathiya-mit/master
[JENKINS-42852] - Jenkins Configuration Save Option
2017-04-08 00:40:05 +02:00
Jesse Glick 45092f06a8 checkChannel() provides a better error message in case you are not using Remoting mode. 2017-04-07 12:04:58 -04:00
Jesse Glick 98f227c20a Showing general help message rather than suggesting obsolete authentication options. 2017-04-07 11:47:59 -04:00
Jesse Glick f3da0e498f Minor review comments from @oleg-nenashev. 2017-04-07 10:22:06 -04:00
Jesse Glick 2e7fe04d7c Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-07 09:56:31 -04:00
Oliver Gondža 1ca9c880fd [FIXED JENKINS-40848] Introduce status indicator for skipped download job (#2705)
* [FIXED JENKINS-40848] Introduce status indicator for skipped download job

* [JENKINS-40848] Stick to existing code-flow as that is proved to work
2017-04-07 10:50:15 +02:00
Marcin Zajączkowski b831acd985 [JENKINS-42645] Case insensitive search by default for new and anonymous users (#2801)
* [JENKINS-42645] Case insensitive search by default

* [JENKINS-42960] Search in FixedSet more locale friendly

String.equalsIgnoreCase is safer than toLowerCase when non English
locales are used.

* [JENKINS-42645] Review remarks
2017-04-07 10:40:12 +02:00
Jesse Glick 9fc59bf251 Finally figured out how to suppress the ReadPendingException from Jetty.
Something¹ seems to interrupt the HTTP duplex service thread,
and Jetty apparently deals poorly with interruptions.
So introduce an extra sleep to soak up the interrupt.

¹Who? http://stackoverflow.com/questions/2126997/who-is-calling-the-java-thread-interrupt-method-if-im-not#comment40865453_2127397
2017-04-04 19:15:03 -04:00
Jesse Glick f7006b4674 Jetty 9.4.3.v20170317 refuses to set an empty HTTP header, leading to cryptic client errors since Hudson-Duplex is missing. 2017-04-04 14:46:20 -04:00
Jesse Glick caf3e8e843 Removing comment corresponding to something I can no longer reproduce. 2017-04-04 14:02:30 -04:00
Jesse Glick 4069e67392 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-04 13:26:16 -04:00
Baptiste Mathus 09cfe3bda6 Merge pull request #2802 from batmat/JENKINS-42709
[JENKINS-27624][JENKINS-42709] Bump Jenkins baseline to Java 8 minimum
2017-04-04 19:01:48 +02:00
Jesse Glick c74999f00c Found a race condition which could explain random CI hangs of CLIActionTest.authenticate. 2017-04-04 11:26:57 -04:00
Jesse Glick 71d7562db6 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-04 11:03:59 -04:00
Sathiya Narayanan a7bcf1fd0f Fixed - Jenkins Global Configuration Save Option 2017-04-04 19:42:53 +05:30
Evaristo Gutiérrez de75be131b [JENKINS-43320] Improve Spanish translations for JNLP configuration. 2017-04-04 09:07:38 +02:00
Jesse Glick 9812db70d3 Improved handling of stream closure.
Making interrupt of `build -s` work in `-http` mode.
Does not solve `ReadPendingException`s.
2017-04-03 18:52:59 -04:00
Oleg Nenashev 33f458d358 Merge pull request #2519 from oleg-nenashev/findbugs/JENKINS-36720-medium-level-fb
[JENKINS-36720] - Cleanup of SOME medium FindBugs issues
2017-04-03 22:45:34 +02:00
Jesse Glick 466d74d15e Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-03 12:54:04 -04:00
Baptiste Mathus 067ba0ebe8 Remove MaxPermSize usage
Obsolete with Java 8. Permanent generation was removed.
2017-04-03 15:43:42 +02:00
Manuel Recena f3f29c0e45 Merge branch 'master' of https://github.com/jenkinsci/jenkins into JENKINS-34670 2017-04-01 20:40:30 +02:00
recena bb1ff6a4b3 Merge branch 'JENKINS-34670' of https://github.com/recena/jenkins into JENKINS-34670 2017-03-31 17:21:39 +02:00
recena c8970db709 [JENKINS-34670] Reverting html.jelly and noting as deprecated 2017-03-31 17:21:08 +02:00
Daniel Beck a34479c418 [JENKINS-43228] Add test 2017-03-30 18:11:52 +02:00
Daniel Beck 43d612f984 [FIX JENKINS-43228] Consider time zone for cron validation 2017-03-30 15:26:08 +02:00
Daniel Beck bde09f70af Merge pull request #2816 from stephenc/jenkins-42934
[JENKINS-42934] Avoid using new FileInputStream / new FileOutputStream
2017-03-30 12:46:10 +02:00
Daniel Beck 0ddf2d5be7 Merge pull request #2822 from daniel-beck/borderless-admin-monitor-popup
Remove invalid CSS rule
2017-03-30 12:45:07 +02:00
Oleg Nenashev 0ae38f553a Merge pull request #2785 from TristanFAURE/JENKINS-42590
[JENKINS-42590] : remove text mentioning getDisplayName==null
2017-03-29 11:50:30 +02:00
Daniel Beck c83894e325 Remove invalid CSS rule 2017-03-25 01:51:37 +01:00
Jesse Glick e69ba0f024 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-03-24 15:26:59 -04:00
Jesse Glick 1101b323c1 Merge pull request #2819 from jglick/Computer.addAction-JENKINS-42969
[JENKINS-42969] UnsupportedOperationException from Computer.addAction
2017-03-24 10:17:42 -04:00
Daniel Beck a00a6993ec Merge branch 'master' of github.com:jenkinsci/jenkins into update-german-translation 2017-03-24 01:58:19 +01:00
Daniel Beck de9b3d3561 Address more review comments 2017-03-23 22:35:07 +01:00
Daniel Beck c3b06ad985 Address further review comments 2017-03-23 22:32:27 +01:00
Daniel Beck a1955c8c37 Merge branch 'master' of github.com:jenkinsci/jenkins into remove-partial-translations 2017-03-22 15:31:54 +01:00
Daniel Beck b5914bb634 Merge pull request #2812 from daniel-beck/localizations-cleanup
Clean up localizations
2017-03-22 15:14:58 +01:00
Stephen Connolly 568772cddc [JENKINS-42934] Some unit tests need side-effects of FileInputStream 2017-03-22 09:04:20 +00:00
Jesse Glick 838357700d [FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction. 2017-03-21 13:02:17 -04:00
Stephen Connolly e603b10088 [JENKINS-42934] A couple of places where FileNotFoundException may be replaced by NoSuchFileException by JVM shenanigans 2017-03-21 13:55:06 +00:00
Stephen Connolly 218d0a5516 [JENKINS-42934] Actually use Java's file locking API to lock the file on windows 2017-03-21 11:08:50 +00:00
Stephen Connolly 211bb29338 [JENKINS-42934] When you specify options you need to include CREATE or the file will not be created 2017-03-20 16:02:59 +00:00
Stephen Connolly a7fc570158 [JENKINS-42934] Need to catch a different exception 2017-03-20 15:51:57 +00:00
Stephen Connolly f0cd7ae8ff [JENKINS-42934] Avoid using new FileInputStream / new FileOutputStream 2017-03-20 12:50:46 +00:00
Daniel Beck 45a3280c43 Remove partial (5% or less) translations 2017-03-19 19:01:12 +01:00
Oleg Nenashev 4ac7c0850b [JENKINS-42724] - Restore the windows-service/jenkins.xml resource to restore compatibility with windows-slaves 1.2 (#2803)
* [JENKINS-42724] - Restore the jenkins-slave.xml file

Windows Slaves plugin performs a direct access to the resources bundled into the core.
Hence the file removal was a bad idea though I have not seen the issue in automatic tests and ATH.

This change also was a last-minute change in https://github.com/jenkinsci/jenkins/pull/2765/ in order to address suggestions from @daniel-beck, hence I didn't test it properly

* [JENKINS-42724] - Update the Windows Agents plugin dependency to 1.3.1

* [JENKINS-42724]  -Revert the war/pom.xml upgrade
2017-03-19 18:42:59 +01:00
Daniel Beck ba46c681c3 Clean up localizations 2017-03-19 17:59:17 +01:00
Akbashev Alexander e8efc96f3d [JENKINS-42319] - Fix broken compareTo method of Run (#2762)
* JENKINS-42319: Fix broken compareTo method of Run

Previous implementation relied on fact that users always compare run
objects with same parent. But this is not always the case.
So, it was not safe to put runs from different parents to TreeSet, i.e.

* Make comparasion more performance friendly
2017-03-19 00:10:37 +01:00