Basil Crow
881365d30b
Enable RedundantModifier Checkstyle check
2021-03-08 07:56:42 -08:00
Basil Crow
6f012029b8
Enable ModifierOrder Checkstyle check
2021-03-08 07:56:42 -08:00
Basil Crow
4ada7324a2
Enable NewlineAtEndOfFile Checkstyle check
2021-03-08 07:56:42 -08:00
Basil Crow
44c5342c58
Declare modifiers in JLS order ( #5339 )
2021-03-08 07:58:59 +00:00
StefanSpieker
58499905f8
replaced MS_SHOULD_BE_FINAL general spotbugs exclude with individual excludes ( #5235 )
2021-03-08 07:58:49 +00:00
Olivier Lamy
8a6defe963
[JENKINS-64931] no need to synchronize on Queue as queue is using a Lock and this under certain conditions can generate a deadlock. look at the dump attached to the issue JENKINS-64931 ( #5305 )
...
Signed-off-by: olivier lamy <olamy@apache.org >
2021-03-08 07:58:04 +00:00
Jesse Glick
a43cd9c33c
Be quiet if Queue.save gets ClosedByInterruptException ( #5326 )
2021-03-08 07:57:25 +00:00
Basil Crow
810e908f8f
Migrate from com.google.common.base.Function to java.util.function.Consumer in hudson.model.listeners.ItemListener
2021-03-05 19:16:27 -08:00
Oleg Nenashev
62fdb42c1e
Merge pull request #5323 from basil/override
...
Add missing @Override annotations
2021-03-04 13:33:20 +01:00
Basil Crow
bd1d5e09bd
Add missing @Override annotations
2021-03-02 14:04:48 -08:00
Basil Crow
f19e33f893
Migrate from com.google.common.util.concurrent.SettableFuture to Java 8 java.util.concurrent.CompletableFuture
2021-03-02 12:37:39 -08:00
Jeff Thompson
e4bbb27b9e
Log a message about the interrupted exception at this level ( #5054 )
2021-03-02 08:17:15 +00:00
Jeff Thompson and Tim Jacomb
8e0ba4c668
[JENKINS-64510] Necessary pieces to get TCP agent reconnect working. ( #5138 )
...
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com >
2021-03-02 08:07:08 +00:00
Basil Crow
7fb2511ee8
Use native Java functionality rather than Guava's Lists#newArrayList, Maps#newHashMap, and Sets#newHashSet where possible
2021-02-25 17:02:24 -08:00
Matt Sicker
f6a0b56d59
Small code cleanups ( #5301 )
2021-02-24 20:11:46 +00:00
gulyaev13
f81f81082d
Remove hardcode of JKS for use other key stores ( #5266 )
2021-02-24 20:07:00 +00:00
2f3b59b363
replaced deprecated jenkins.getInstance() calls with .get() ( #5269 )
...
* replaced deprecated jenkins.getInstance() calls with .get()
* Apply suggestions from code review
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com >
* Apply suggestions from code review
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com >
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com >
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com >
2021-02-23 10:37:09 +01:00
Daniel Beck and Daniel Beck
9b8e3ca937
Update RestrictedSince annotations with version numbers ( #5277 )
...
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com >
2021-02-23 08:13:46 +00:00
Daniel Beck and Daniel Beck
90f2d5e3dd
Add at-since annotations up to 2.279 ( #5276 )
...
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com >
2021-02-23 08:13:23 +00:00
Jesse Glick and Tim Jacomb
8152129c73
Better @DataBoundConstructor hygiene for ParameterDefinition’s ( #5275 )
...
* Better @DataBoundConstructor hygiene for ParameterDefinition’s
* @since TODO not @since XXX
* Fix JavaDoc generation
* Treat empty ParameterDefinition.description & StringParameterDefinition.defaultValue like null, for better /directive-generator/ behavior
* ChoiceParameterDefinitionTest reminds me to ensure that choices contains no null elements
Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com >
2021-02-21 20:31:08 +00:00
Jesse Glick
d5c8c41b5e
Use FINE not FINEST for log messages that used to be INFO ( #5294 )
2021-02-21 20:30:39 +00:00
Daniel Beck and Daniel Beck
b6a7251809
Revert "Clean up VirtualFile after adding base implementation ( #5212 )" ( #5298 )
...
This reverts commit 792efa7c24daniel-beck@users.noreply.github.com >
2021-02-21 20:30:27 +00:00
Tim Jacomb
60b7a7c3a4
Fix merge conflict resoluton for upgrade Jenkins ( #5290 )
2021-02-16 09:53:42 +00:00
Tim Jacomb and Jesse Glick
e13e30c262
[JENKINS-41727] Reload update center data on upgrade/downgrade ( #5282 )
...
Co-authored-by: Jesse Glick <jglick@cloudbees.com >
2021-02-16 09:31:56 +00:00
Tim Jacomb
26adaf1fc6
Remove broken upgrade wizard ( #5283 )
2021-02-16 08:05:08 +00:00
Robert Sandell
f47257bdf1
[JENKINS-64840] Fix searching multiple update sites ( #5281 )
2021-02-12 18:51:53 +00:00
Oleg Nenashev
b49610e29f
Cleanup warnings for missing getPlugin() null checks ( #5222 )
2021-02-10 19:52:44 +00:00
Daniel Beck and Daniel Beck
792efa7c24
Clean up VirtualFile after adding base implementation ( #5212 )
...
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com >
2021-02-06 15:39:47 +00:00
eeac80127b
Clean up some Deprecation warnings ( #4407 )
...
Co-authored-by: Jesse Glick <jglick@cloudbees.com >
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2021-02-06 09:04:27 +00:00
Basil Crow
44e11f66bc
Deprecate hudson.util.RunList#filter(com.google.common.base.Predicate) ( #5220 )
2021-02-06 09:03:45 +00:00
Mark Waite
9e0d511a0c
Merge pull request #5223 from StefanSpieker/string_format
...
Removed redundant String.format
2021-02-01 13:32:52 -07:00
Mark Waite
9f570159ed
Merge pull request #5221 from basil/PeepholePermalink
...
Remove Guava reference in PeepholePermalink public API
2021-02-01 13:32:34 -07:00
Emilio Escobar and Jesse Glick
2c1e8399ca
[JENKINS-64746] public API hudson.model.UpdateCenter.HudsonUpgradeJob constructor signature change ( #5216 )
...
Co-authored-by: Jesse Glick <jglick@cloudbees.com >
2021-02-01 08:21:22 +00:00
Basil Crow and dependabot[bot]
887296fcd0
JENKINS-64650: Upgrade Commons FileUpload from 1.3.1-jenkins-2 to 1.4 ( #5174 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-02-01 08:20:19 +00:00
StefanSpieker and Mark Waite
4525d8fe57
Update core/src/main/java/hudson/cli/ListPluginsCommand.java
...
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com >
2021-01-31 19:34:12 +01:00
Stefan Spieker
122782c7fc
removed redundant string.format
2021-01-31 14:06:41 +01:00
Basil Crow
69faf7e905
Remove Guava reference in PeepholePermalink public API
2021-01-30 23:26:00 -08:00
Raihaan Shouhell
022a09cec0
Merge pull request #5205 from res0nance/minor-cleanup
...
Minor cleanups to Fingerprint writing codepaths
2021-01-28 19:02:54 +08:00
Félix Queiruga
1ce40eb67c
Rename API endpoint to avoid URL collisions ( #5207 )
2021-01-27 14:00:32 +00:00
Raihaan Shouhell and res0nance
8130b13e82
Improve performance when saving Fingerprints to disk ( #5198 )
...
Co-authored-by: res0nance <res0nance@users.noreply.github.com >
2021-01-25 21:10:10 +00:00
res0nance
15549a6720
Minor cleanups to Fingerprint writing codepaths
2021-01-25 17:21:26 +08:00
203ec707b7
[JENKINS-64670] Improve performance in file fingerprint creation ( #5190 )
...
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com >
Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com >
Co-authored-by: Baptiste Mathus <bmathus@gmail.com >
2021-01-23 08:43:31 +00:00
Jeff Thompson and Wadeck Follonier
5562c53d6b
[JENKINS-64655] Provide default implementation for external storage
...
Co-authored-by: Wadeck Follonier <wadeck.follonier@gmail.com >
2021-01-20 12:43:30 +01:00
Wadeck Follonier
f2d289c001
[JENKINS-64632] File handle leak correction
2021-01-19 11:29:09 +01:00
Wadeck Follonier
ecf3095362
[JENKINS-64621] Fix zip regression ( #5187 )
2021-01-19 09:11:30 +00:00
Jon and Jon Sten
f0fc1b8389
Log if no class paths was found for plugin ( #5154 )
...
Co-authored-by: Jon Sten <jons@axis.com >
2021-01-18 16:06:18 +00:00
Daniel Beck
82688811fa
Merge branch 'security-master' into master
2021-01-13 15:41:47 +01:00
Jeff Thompson
71d2ecf1a4
[SECURITY-1452]
2021-01-11 16:53:00 +00:00
Jeff Thompson
f576b2eb43
[SECURITY-2023]
2021-01-11 16:52:50 +00:00
Daniel Beck
b1ca284966
[SECURITY-2147]
2021-01-11 16:52:29 +00:00
Basil Crow