Commit Graph
16831 Commits
Author SHA1 Message Date
Josh Soref f3cb12ebe1 [JENKINS-55787] remove accidentally resurrected localization file 2019-05-25 22:35:34 -04:00
Daniel Beck c03c6b0e1c Merge pull request #4043 from ljader/patch-2
Switch translations for 2 labels in iconSize_pl.properties
2019-05-25 22:58:08 +02:00
Oleg Nenashev 82a569869a Merge pull request #4031 from daniel-beck/agent-secret-file
Add an example how to launch agent with secret not on command line
2019-05-25 18:49:36 +02:00
Oleg Nenashev 0a3f618bfb Merge pull request #4039 from jglick/nonstandardFilenames-JENKINS-55582
[JENKINS-55582] Handle nonstandard $JENKINS_HOME/plugins/$shortName.hpi and warn about $shortName-$version.hpi
2019-05-25 18:19:40 +02:00
Łukasz Jąder e4c928ceb9 Switch translations for 2 labels in iconSize_pl.properties
Initial translation mixed small (S) and medium (M) translations
2019-05-25 17:30:09 +02:00
Josh Soref 01a3c5741a [JENKINS-55787] Switch labels from entry to checkbox (#3921)
* [JENKINS-55787] Switch labels from entry to checkbox

* trim

* help-boolean-default
2019-05-24 14:38:34 +02:00
Jesse Glick 3bcdefcae4 [JENKINS-55582] Refinement to at least handle nonstandard $JENKINS_HOME/plugins/$shortName.hpi and warn about $shortName-$version.hpi. 2019-05-23 13:26:15 -04:00
Wadeck FollonierandDaniel Beck 1f290ff1d0 Un-restrict the XMLUtils class after SECURITY-521 release (#4032)
* Un-restrict the XMLUtils class after SECURITY-521 release
- It was forgotten since that actually

* Update core/src/main/java/jenkins/util/xml/XMLUtils.java

Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2019-05-22 07:31:14 +02:00
Francisco Javier Fernandez Gonzalez 655beb988e [JENKINS-25369] Add Javadoc to new class 2019-05-20 09:53:52 +02:00
Francisco Fernández 12769e53d1 [JENKINS-25369] DNS multicast error messages (#4021)
* [JENKINS-25369] Update jmdns library

* [JENKINS-25369] Enable again and add commented out code again
2019-05-18 20:05:27 +02:00
Jesse Glick 855ea2eea2 [JENKINS-57528] - Load detached plugins which are implicit deps of other plugins at startup even w/o UC (#4000)
* Do not warn repeatedly of the same missing update site dependency.
This happens when locally testing split plugins (despite their presence in WEB-INF/detached-plugins/*.hpi).

(cherry picked from commit 918a0fd221)

* Detached plugins must be kept up to date with security advisories.

(cherry picked from commit e08d28a698)

* Load detached plugins which are implicit dependencies of other plugins at startup, even if the update center was not used.

(cherry picked from commit ad7a36001d)

* Adjusted expected version after e08d28a698.

(cherry picked from commit 84f939cebd)

* e08d28a698 exposed tests which had been incorrectly storing plugins as *.hpi rather than *.jpi.

(cherry picked from commit a0abad7ec4)

* Test failure after ad7a36001d.

(cherry picked from commit 0084e8dbdd)

* Another test failure after ad7a36001d30a6174b25e616fc3c215dd24919d1; fewer installDetachedPlugin calls are now required.

(cherry picked from commit b65bb54e99)
2019-05-17 16:22:22 +02:00
Daniel Beck fe6e297fac Add an example how to launch agent with secret not on command line 2019-05-16 16:52:28 +02:00
Zhao Xiaojie 52ac8f7178 [JENKINS-57412] Should always keep install wizard localization files in the core (#4014) 2019-05-11 18:34:21 +02:00
Oleg Nenashev 5ebea39af9 Merge pull request #4017 from jsoref/abandon-manag_
Remove manag_.groovy
2019-05-11 16:28:43 +02:00
Oleg Nenashev a2819d8dec Merge pull request #4015 from bitwiseman/JENKINS-57111
[JENKINS-57111] Do not put agent offline for exceptions in onOnline
2019-05-11 16:28:26 +02:00
Oleg Nenashev b264a329bd Merge pull request #4019 from ljader/patch-1
Update one message in Polish translation (typo fix)
2019-05-11 16:26:37 +02:00
Liam Newman a78f9461ef [JENKINS-57111] Do not put agent offline for exceptions in onOnline
Agent implementers use onOnline to perform actions after an agent
put online.  The API specifies that execeptions thrown by this
method will not put an agent offline.  However, the default
implementation does exactly that.

This change clarifies the API to say all exceptions will be logged
and hardens setChannel against exceptions during onOnline.

NOTE: Errors will still cause an agent to go offline as they are
generally fatal conditions.

Also added tests to verify the behavior.
2019-05-10 19:28:18 -07:00
Oleg Nenashev eeb1ebe25d Merge pull request #3975 from jsoref/java-cleanup
Java cleanup
2019-05-10 16:58:25 +02:00
Łukasz Jąder 6f6d5749d0 Update one message in Polish translation
Previous translation suggested the files will be saved in external tool (Artifactory)
2019-05-10 00:07:40 +02:00
amuniz d74b31bad8 [SECURITY-901] Remove restriction
This is a follow up on SECURITY-901 changes to remove the @Restricted
annotation after the security release is done.
2019-05-09 14:35:06 +02:00
Mit Naria 82aca6421d [FIX JENKINS-41696] Fix recording fingerprints (#3915)
* [FIX JENKINS-41696] Fix recording fingerprints

1. Fix bug which records fingerprints while
   ignoring the excludes when archiving artifacts.

* [JENKINS-41696] Fix recording fingerprints

1. Fix bug which records fingerprints while
   ignoring the excludes when archiving artifacts.
2. Fingerprinter now supports excluding patterns for targets,
   caseSensitivity and defaultExcludes.

* [FIX JENKINS-41696] Fix recording fingerprints

1. Fix bug which records fingerprints while
   ignoring the excludes when archiving artifacts.
2. Fingerprinter now supports excludes,
   defaultExcludes and caseSensitivity.

Signed-off-by: Mit Naria <mit4dev@gmail.com>

* [FIX JENKINS-41696] Fix recording fingerprints

    1. Fix bug which records fingerprints while
       ignoring the excludes when archiving artifacts.
    2. Fingerprinter now supports excludes,
       defaultExcludes and caseSensitivity.

* removing unused annotation and triggering a build.

* Apply suggestions from code review by jvz

Co-Authored-By: foxtrot9 <mit4dev@gmail.com>

* [JENKINS-41696] Fix deserialization bug using readResolve.

Signed-off-by: Mit Naria <mit4dev@gmail.com>

* Update Fingerprinter.java

1. Getters and setters for defaultExcludes and caseSensitive use boolean instead of Boolean.

* Minor bug fixs.

Signed-off-by: Mit Naria <mit4dev@gmail.com>

* Fix stupid mistake in last commit

Signed-off-by: Mit Naria <mit4dev@gmail.com>
2019-05-08 18:25:47 +02:00
Oleg Nenashev 002cf09dc5 Merge pull request #3922 from jsoref/JENKINS-56379
[JENKINS-56379] Absorb pipeline-model-definition symbol-hetero-list.jelly into hetero-list.jelly
2019-05-08 18:25:15 +02:00
Josh Soref 5bee355671 Remove manag_.groovy
This was an experiment that was not adopted.

Retaining just creates confusion.

For reference, these are the commits related to the file:

o    68d4d22fcf kk [JENKINS-8446] it's better to let those directories setting be a part of JENKINS_HOME rather than being independent configuration properties, since they aren't orthogonal.
:\
: o  8291720005 kk making it more type-safe
: |
: o  8c7c1c62b1 kk this file is now auto-generated
:/
o  61768cc0f8 kk not specifying the file extension so that different pieces can be implemented by different view technologies
|
o  12ad3b0272 kk replaced i18n by '_' since it shows up a lot.
:
o  00bc32985f kk experimental re-write of the "manage Jenkins" view by Groovy
|
~
2019-05-08 10:33:15 -04:00
Oleg Nenashev f115ae07cd Merge pull request #3997 from daniel-beck/distinguish-grey
Distinguish between new/aborted/disabled by ball color
2019-05-07 12:17:51 +02:00
Jesse Glick 7054610887 [JENKINS-57244] FilePath (de)serialization via XStream is unsupported but should not be fatal (#4011)
* [JENKINS-57244] FilePath (de)serialization via XStream is unsupported but should not be fatal.

* Factoring out a _getChannelForSerialization with a friendlier message and a redirect.
2019-05-05 16:25:01 +02:00
Oleg Nenashev 9ad3967d7b Merge pull request #4012 from jglick/Run.keepLog
Run.keepLog-related names were misleading
2019-05-04 21:22:11 +02:00
austry 63b953d409 [JENKINS-11888] - Add stop-job CLI command (#3686)
* JENKINS-11888 Add stop-job CLI command

* JENKINS-11888 Add license headers

* JENKINS-11888 Review fix

* JENKINS-11888 Fix review

* JENKINS-11888 Remove moved files from cli package

* JENKINS-11888 Fix logging

* JENKINS-11888 Collect jobs list before stopping any builds

* JENKINS-11888 Refactor isBuilding check

* JENKINS-11888 Add Restricted annotation for StopBuildsCommand

* JENKINS-11888 Make cli output more responsive

* JENKINS-11888 Remove single quote for job name

* JENKINS-11888 Add semicolon

* JENKINS-11888 Handle exception for executor.doStop

* JENKINS-11888 Rework test to use JenkinsRule

* JENKINS-11888 Remove semicolons from CLI output

* JENKINS-11888 Fix tests for windows platform

* JENKINS-11888 Write message about exception in one line

* JENKINS-11888 Fix output on not founded job

* JENKINS-11888 Improve tests

* JENKINS-11888 Use fullDisplayName for job name

* JENKINS-11888 Use single quotes for build and job names

* JENKINS-11888 Cleanup exceptions throwing

* JENKINS-11888 Add test checking second job will be stopped if first stop failed
2019-05-04 21:21:20 +02:00
liucc52 f6cd994bdd [JENKINS-56499] Remove synchronized on method updateUsageForId for API token usage stat (#3936)
* Update ApiTokenStats.java

remove the synchronized on method updateUsageForId if token usage stats diabled

* Update ApiTokenPropertyConfiguration.java

change the default value for api token usage stats to false

* Update ApiTokenPropertyConfiguration.java

change default value to true
2019-05-04 09:42:02 +02:00
Oleg Nenashev 4ea5d14639 Merge pull request #4008 from LinuxSuRen/remove-all-zh-files
Remove All localized files of Chinese
2019-05-04 09:41:36 +02:00
Jesse Glick 744c4d5e35 Run.keepLog-related Javadoc failed to note that what is being kept is the build, not just the log as the name would suggest. 2019-05-03 18:29:12 -04:00
Jesse Glick 45573ce6a3 [JENKINS-57273] Jenkins/Nodes.addNode could replace an existing node, but always fired onCreated. (#4004) 2019-05-03 13:19:24 +02:00
suren a205a20bd1 Remove All localized files of Chinese 2019-05-02 19:18:04 +08:00
Zbynek Konecny 511a533d15 [JENKINS-16750] Update build status icon (#3952)
* [JENKINS-16750] update status icon when build is finished

* JENKINS-16750 use Event.fire / Event.observe instead of global function
2019-04-28 10:39:13 +02:00
Oleg Nenashev 25f4e71977 Merge pull request #3995 from daniel-beck/agent-to-master-section
Add section for agent to master configuration
2019-04-27 07:42:19 +02:00
Romén Rodríguez-Gil a21402b5f8 [JENKINS-56477] Fix to allow selecting compatible-only updates for plugins (#3985)
* [JENKINS-56477] New "isCompatible" method avoiding all plugins w/ warns

Previous version was only checking "isCompatibleWithInstalledVersion", but there were several other cases that had to be checked

* [JENKINS-56477] Added issue annotation to isPluginUpdateCompatible test

* [JENKINS-56477] Factored out getUpdateSite, init method used by 2 tests

Also removed the "sites" list from the init, since it seemed it was not being used, only using the specific site created from the external json

* [JENKINS-56477] Added a new option for plugin selection: "compatible"

Now users can select "All", "Compatible" or "None"

* [JENKINS-56477] checkPluginsWithoutWarnings also unchecks now

Useful if the user first clicks "Select All" and now wants to "Select Compatible" only.

* [JENKINS-56477] Added unit test for "UpdateSite.Plugin.isCompatible"

The UpdateSite class and its internal classes (e.g. Plugin) are a bit tricky to unit-test. Using some stubs to set the necessary context for the test to run

* [JENKINS-56477] "mock-maker-inline" incompatible w/ other tests

Had to remove the unit test checking "pluginUpdateNotCompatible. It needed "mock-maker-inline" config to mock/spy the Plugin class (which is final), but that mockito config caused conflicts with pre-existing tests.

* [JENKINS-56477] Simplifying condition to check the candidate checkbox

* [JENKINS-56477] Method overload with param should not be exported

* [JENKINS-56477] Javadoc for isCompatible(). Overloaded ver. restricted

Also switched the call in table.jelly to the overloaded version of isCompatible, since a "cache" var was available in the context (and was being already used by calls to the internal methods to show the warnings)

* Removed empty line.

Trivial change to force re-execution of pipeline.

* [JENKINS-56477] "isCompatible" set to @Restricted for now

This method is currently only being used by the Jenkins UI, so we are not being exposing it to plugins nor exporting it. If in the future that need emerges, this can be changed
2019-04-26 17:22:21 +02:00
Nisarg Shah f4046fb3d4 [JENKINS-55829] New getter method in AbstractCIBase (#3873)
* Created new getter method in AbstractCIBase and marked it as
`Restricted`

* Added suggested changes

* Added changes

* Suggested Changes Added

* Added new getter method with appropriate changes.
2019-04-26 15:00:08 +02:00
Oleg Nenashev 6414d0718f Merge pull request #3987 from jglick/slave-installer
[JENKINS-57071] Fixing problems affecting Linux agent installer modules
2019-04-26 10:17:37 +02:00
Oleg Nenashev 43d7874310 Merge pull request #3986 from jglick/ConfidentialKey
Making ConfidentialKey instances safe to keep in static fields even across JenkinsRule starts
2019-04-26 10:15:40 +02:00
Oleg Nenashev e2da5e41c7 Merge pull request #3980 from jglick/SerializableOnlyOverRemoting-JENKINS-47896
[JENKINS-47896] SerializableOnlyOverRemoting
2019-04-25 17:00:50 +02:00
Daniel Beck a5a92af4be Merge pull request #3998 from jglick/jnlp-to-inbound
Remove JNLP terminology from GUI when referring to inbound agents
2019-04-24 14:34:49 +02:00
Daniel Beck 8ea548828a Enable Stapler telemetry 2019-04-23 22:17:16 +02:00
Jesse Glick c5c8037113 Remove JNLP terminology from GUI when referring to inbound agents. 2019-04-22 10:51:05 -04:00
Daniel Beck c036654f8c Distinguish between new/aborted/disabled by ball color 2019-04-21 22:08:32 +02:00
Baptiste Mathus 0f03ce2f27 Merge pull request #2831 from szpak/feature/searchableNestedViews3
[JENKINS-43322] Nested views should be also searchable by name
2019-04-20 21:22:33 +02:00
Daniel Beck 9227240d5e Add section for agent to master configuration 2019-04-20 00:51:25 +02:00
Baptiste Mathus 67e86ed1b0 🤦 now it's just noop code that should be removed 2019-04-18 16:31:37 +02:00
Baptiste Mathus 9ecafa86c1 Document that return must not be null 2019-04-18 16:08:46 +02:00
Baptiste Mathus 596fd963b6 Remove unnecessary new @Export 2019-04-18 16:05:07 +02:00
Baptiste Mathus 2767b00146 Merge pull request #3925 from ad22/JENKINS-56403
[JENKINS-56403]: Renaming an agent retains old agent configuration
2019-04-18 12:41:09 +02:00
Jesse Glick 16ece5c66e Fixing problems affecting Linux agent installer modules. 2019-04-16 14:08:17 -04:00